Re: [PATCH 04/13] ARM: shmobile: r8a7792: basic SoC support

2016-06-06 Thread Sergei Shtylyov

Hello.

On 06/01/2016 01:18 AM, Sergei Shtylyov wrote:


Add minimal support for the R-Car V2H (R8A7792) SoC.

Signed-off-by: Sergei Shtylyov 


[...]


Index: renesas/arch/arm/mach-shmobile/setup-r8a7792.c
===
--- /dev/null
+++ renesas/arch/arm/mach-shmobile/setup-r8a7792.c
@@ -0,0 +1,34 @@
+/*
+ * r8a7792 processor support
+ *
+ * Copyright (C) 2014  Renesas Electronics Corporation


   Hm, I thought I'd stamped Cogent's copyright here... Please hold on with 
merging this patch.


[...]

MBR, Sergei



Re: [PATCH 04/13] ARM: shmobile: r8a7792: basic SoC support

2016-06-01 Thread Sergei Shtylyov

On 06/01/2016 10:47 AM, Geert Uytterhoeven wrote:


--- renesas.orig/arch/arm/mach-shmobile/Kconfig
+++ renesas/arch/arm/mach-shmobile/Kconfig
@@ -86,6 +86,11 @@ config ARCH_R8A7791
select ARCH_RCAR_GEN2
select I2C

+config ARCH_R8A7792
+   bool "R-Car V2H (R8A77920)"
+   select ARCH_RCAR_GEN2
+   select I2C


I2c is selected for the other SoCs because of regulator-quirk-rcar-gen2.
I do not have schematics for Blanche, so I don't know if it has DA9063 and
DA9210 regulators sharing the same interrupt.


   No, it only has DA9063.


If yes, you should make sure regulator-quirk-rcar-gen2 is updated for Blanche,
and built.
If no, you should drop the select.


   Thanks for noticing!


If the above is clarified:



Reviewed-by: Geert Uytterhoeven 


   Thank you, adding...


Gr{oetje,eeting}s,

Geert


MBR, Sergei



Re: [PATCH 04/13] ARM: shmobile: r8a7792: basic SoC support

2016-06-01 Thread Geert Uytterhoeven
Hi Sergei,

On Wed, Jun 1, 2016 at 12:18 AM, Sergei Shtylyov
 wrote:
> --- renesas.orig/arch/arm/mach-shmobile/Kconfig
> +++ renesas/arch/arm/mach-shmobile/Kconfig
> @@ -86,6 +86,11 @@ config ARCH_R8A7791
> select ARCH_RCAR_GEN2
> select I2C
>
> +config ARCH_R8A7792
> +   bool "R-Car V2H (R8A77920)"
> +   select ARCH_RCAR_GEN2
> +   select I2C

I2c is selected for the other SoCs because of regulator-quirk-rcar-gen2.
I do not have schematics for Blanche, so I don't know if it has DA9063 and
DA9210 regulators sharing the same interrupt.
If yes, you should make sure regulator-quirk-rcar-gen2 is updated for Blanche,
and built.
If no, you should drop the select.

If the above is clarified:

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


Re: [PATCH 04/13] ARM: shmobile: r8a7792: basic SoC support

2016-05-31 Thread Simon Horman
On Wed, Jun 01, 2016 at 01:18:22AM +0300, Sergei Shtylyov wrote:
> Add minimal support for the R-Car V2H (R8A7792) SoC.
> 
> Signed-off-by: Sergei Shtylyov 

Acked-by: Simon Horman