Re: [PATCH v2 03/19] soc: renesas: Identify R-Car M3-N

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:40:34PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
> 
> On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi  
> wrote:
> > Add support for indentifying R-Car M3-N (R8A77965) SoC.
> >
> > Signed-off-by: Jacopo Mondi 
> 
> Reviewed-by: Geert Uytterhoeven 
> 
> > --- a/drivers/soc/renesas/renesas-soc.c
> > +++ b/drivers/soc/renesas/renesas-soc.c
> > @@ -149,6 +149,11 @@ static const struct renesas_soc soc_rcar_v3m 
> > __initconst __maybe_unused = {
> > .id = 0x54,
> >  };
> >
> > +static const struct renesas_soc soc_rcar_m3_n __initconst __maybe_unused = 
> > {
> > +   .family = _rcar_gen3,
> > +   .id = 0x55,
> > +};
> 
> Note that the list was sorted by SoC part number.

Thanks, I have moved the above structure to between
the similar structure for m3_w and v3m. The result is below.

> > +
> >  static const struct renesas_soc soc_rcar_v3h __initconst __maybe_unused = {
> > .family = _rcar_gen3,
> > .id = 0x56,
> > @@ -214,6 +219,9 @@ static const struct of_device_id renesas_socs[] 
> > __initconst = {
> >  #ifdef CONFIG_ARCH_R8A7796
> > { .compatible = "renesas,r8a7796",  .data = _rcar_m3_w },
> >  #endif
> > +#ifdef CONFIG_ARCH_R8A77965
> > +   { .compatible = "renesas,r8a77965", .data = _rcar_m3_n },
> > +#endif
> >  #ifdef CONFIG_ARCH_R8A77970
> > { .compatible = "renesas,r8a77970", .data = _rcar_v3m },
> >  #endif

From: Jacopo Mondi 
Subject: [PATCH] soc: renesas: Identify R-Car M3-N

Add support for indentifying R-Car M3-N (R8A77965) SoC.

Signed-off-by: Jacopo Mondi 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Simon Horman 
---
 drivers/soc/renesas/renesas-soc.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/soc/renesas/renesas-soc.c 
b/drivers/soc/renesas/renesas-soc.c
index 000834321774..ea71c413c926 100644
--- a/drivers/soc/renesas/renesas-soc.c
+++ b/drivers/soc/renesas/renesas-soc.c
@@ -144,6 +144,11 @@ static const struct renesas_soc soc_rcar_m3_w __initconst 
__maybe_unused = {
.id = 0x52,
 };
 
+static const struct renesas_soc soc_rcar_m3_n __initconst __maybe_unused = {
+   .family = _rcar_gen3,
+   .id = 0x55,
+};
+
 static const struct renesas_soc soc_rcar_v3m __initconst __maybe_unused = {
.family = _rcar_gen3,
.id = 0x54,
@@ -214,6 +219,9 @@ static const struct of_device_id renesas_socs[] __initconst 
= {
 #ifdef CONFIG_ARCH_R8A7796
{ .compatible = "renesas,r8a7796",  .data = _rcar_m3_w },
 #endif
+#ifdef CONFIG_ARCH_R8A77965
+   { .compatible = "renesas,r8a77965", .data = _rcar_m3_n },
+#endif
 #ifdef CONFIG_ARCH_R8A77970
{ .compatible = "renesas,r8a77970", .data = _rcar_v3m },
 #endif
-- 
2.11.0



Re: [PATCH v2 03/19] soc: renesas: Identify R-Car M3-N

2018-02-20 Thread Geert Uytterhoeven
Hi Jacopo,

On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi  wrote:
> Add support for indentifying R-Car M3-N (R8A77965) SoC.
>
> Signed-off-by: Jacopo Mondi 

Reviewed-by: Geert Uytterhoeven 

> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -149,6 +149,11 @@ static const struct renesas_soc soc_rcar_v3m __initconst 
> __maybe_unused = {
> .id = 0x54,
>  };
>
> +static const struct renesas_soc soc_rcar_m3_n __initconst __maybe_unused = {
> +   .family = _rcar_gen3,
> +   .id = 0x55,
> +};

Note that the list was sorted by SoC part number.

> +
>  static const struct renesas_soc soc_rcar_v3h __initconst __maybe_unused = {
> .family = _rcar_gen3,
> .id = 0x56,
> @@ -214,6 +219,9 @@ static const struct of_device_id renesas_socs[] 
> __initconst = {
>  #ifdef CONFIG_ARCH_R8A7796
> { .compatible = "renesas,r8a7796",  .data = _rcar_m3_w },
>  #endif
> +#ifdef CONFIG_ARCH_R8A77965
> +   { .compatible = "renesas,r8a77965", .data = _rcar_m3_n },
> +#endif
>  #ifdef CONFIG_ARCH_R8A77970
> { .compatible = "renesas,r8a77970", .data = _rcar_v3m },
>  #endif

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds