Re: [PATCH v2 2/7] arm64: dts: renesas: r8a7796: Add FCPF and FCPV instances

[Simon Horman]

On Wed, Jul 12, 2017 at 11:45:41AM +0300, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Wednesday 12 Jul 2017 09:22:50 Geert Uytterhoeven wrote:
> > On Wed, Jun 21, 2017 at 11:31 AM, Laurent Pinchart wrote:
> > > The FCPs handle the interface between various IP cores and memory. Add
> > > the instances related to the FDPs and VSP2s.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > 
> > > Reviewed-by: Geert Uytterhoeven 
> > 
> > Ah, the pitfalls of reposting patches 8 months later...
> > 
> > >  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 42
> > >   1 file changed, 42 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> > > 1f6710912045..28b0e2127021 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > > @@ -1440,6 +1440,48 @@
> > > /* placeholder */
> > > };
> > > 
> > > +   fcpf0: fcp@fe95 {
> > > +   compatible = "renesas,fcpf";
> > > +   reg = <0 0xfe95 0 0x200>;
> > > +   clocks = < CPG_MOD 615>;
> > > +   power-domains = < R8A7796_PD_A3VC>;
> > 
> > ... missing resets properties.
> 
> Oops :-/
> 
> Simon, can I send an incremental patch ?

Yes, please do.

Re: [PATCH v2 2/7] arm64: dts: renesas: r8a7796: Add FCPF and FCPV instances

[Laurent Pinchart]

Hi Geert,

On Wednesday 12 Jul 2017 09:22:50 Geert Uytterhoeven wrote:
> On Wed, Jun 21, 2017 at 11:31 AM, Laurent Pinchart wrote:
> > The FCPs handle the interface between various IP cores and memory. Add
> > the instances related to the FDPs and VSP2s.
> > 
> > Signed-off-by: Laurent Pinchart
> > 
> > Reviewed-by: Geert Uytterhoeven 
> 
> Ah, the pitfalls of reposting patches 8 months later...
> 
> >  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 42
> >   1 file changed, 42 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> > 1f6710912045..28b0e2127021 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -1440,6 +1440,48 @@
> > /* placeholder */
> > };
> > 
> > +   fcpf0: fcp@fe95 {
> > +   compatible = "renesas,fcpf";
> > +   reg = <0 0xfe95 0 0x200>;
> > +   clocks = < CPG_MOD 615>;
> > +   power-domains = < R8A7796_PD_A3VC>;
> 
> ... missing resets properties.

Oops :-/

Simon, can I send an incremental patch ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/7] arm64: dts: renesas: r8a7796: Add FCPF and FCPV instances

[Geert Uytterhoeven]

Hi Laurent, Simon,

On Wed, Jun 21, 2017 at 11:31 AM, Laurent Pinchart
 wrote:
> The FCPs handle the interface between various IP cores and memory. Add
> the instances related to the FDPs and VSP2s.
>
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 

Ah, the pitfalls of reposting patches 8 months later...

>  arch/arm64/boot/dts/renesas/r8a7796.dtsi | 42 
> 
>  1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 1f6710912045..28b0e2127021 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -1440,6 +1440,48 @@
> /* placeholder */
> };
>
> +   fcpf0: fcp@fe95 {
> +   compatible = "renesas,fcpf";
> +   reg = <0 0xfe95 0 0x200>;
> +   clocks = < CPG_MOD 615>;
> +   power-domains = < R8A7796_PD_A3VC>;

... missing resets properties.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds