Hi Laurent,
Thanks for your reworking and improvements here.
The documentation additions look good.
Only one grammar fixup found inline in the struct fdp1_ctx which isn't
critical (and could have been from my original submission), so don't
worry about it unless there ends up being another respin.
--
Regards
Kieran
On 24/10/16 10:03, Laurent Pinchart wrote:
> From: Kieran Bingham
>
> The FDP1 driver performs advanced de-interlacing on a memory 2 memory
> based video stream, and supports conversion from YCbCr/YUV
> to RGB pixel formats
>
> Signed-off-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Laurent Pinchart
> ---
> Changes since v3:
>
> - Squashed all driver changes together
> - Documented deinterlacing modes
> - Capitalized the 2D and 3D abbreviations
> ---
> Documentation/media/v4l-drivers/index.rst |1 +
> Documentation/media/v4l-drivers/rcar-fdp1.rst | 37 +
> MAINTAINERS |9 +
> drivers/media/platform/Kconfig| 13 +
> drivers/media/platform/Makefile |1 +
> drivers/media/platform/rcar_fdp1.c| 2446
> +
> 6 files changed, 2507 insertions(+)
> create mode 100644 Documentation/media/v4l-drivers/rcar-fdp1.rst
> create mode 100644 drivers/media/platform/rcar_fdp1.c
>
> diff --git a/Documentation/media/v4l-drivers/index.rst
> b/Documentation/media/v4l-drivers/index.rst
> index acde3ed7860f..a606d1cdac13 100644
> --- a/Documentation/media/v4l-drivers/index.rst
> +++ b/Documentation/media/v4l-drivers/index.rst
> @@ -48,6 +48,7 @@ For more details see the file COPYING in the source
> distribution of Linux.
> pvrusb2
> pxa_camera
> radiotrack
> + rcar-fdp1
> saa7134
> sh_mobile_ceu_camera
> si470x
> diff --git a/Documentation/media/v4l-drivers/rcar-fdp1.rst
> b/Documentation/media/v4l-drivers/rcar-fdp1.rst
> new file mode 100644
> index ..a59b1e8e3e9c
> --- /dev/null
> +++ b/Documentation/media/v4l-drivers/rcar-fdp1.rst
> @@ -0,0 +1,37 @@
> +Renesas R-Car Fine Display Processor (FDP1) Driver
> +==
> +
> +The R-Car FDP1 driver implements driver-specific controls as follows.
> +
> +``V4L2_CID_DEINTERLACING_MODE (menu)``
> +The video deinterlacing mode (such as Bob, Weave, ...). The R-Car FDP1
> +driver implements the following modes.
> +
> +.. flat-table::
> +:header-rows: 0
> +:stub-columns: 0
> +:widths: 1 4
> +
> +* - ``"Progressive" (0)``
> + - The input image video stream is progressive (not interlaced). No
> +deinterlacing is performed. Apart from (optional) format and encoding
> +conversion output frames are identical to the input frames.
> +* - ``"Adaptive 2D/3D" (1)``
> + - Motion adaptive version of 2D and 3D deinterlacing. Use 3D
> deinterlacing
> +in the presence of fast motion and 2D deinterlacing with diagonal
> +interpolation otherwise.
> +* - ``"Fixed 2D" (2)``
> + - The current field is scaled vertically by averaging adjacent lines to
> +recover missing lines. This method is also known as blending or Line
> +Averaging (LAV).
> +* - ``"Fixed 3D" (3)``
> + - The previous and next fields are averaged to recover lines missing
> from
> +the current field. This method is also known as Field Averaging
> (FAV).
> +* - ``"Previous field" (4)``
> + - The current field is weaved with the previous field, i.e. the
> previous
> +field is used to fill missing lines from the current field. This
> method
> +is also known as weave deinterlacing.
> +* - ``"Next field" (5)``
> + - The current field is weaved with the next field, i.e. the next field
> is
> +used to fill missing lines from the current field. This method is
> also
> +known as weave deinterlacing.
Doc's look good.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1cd38a7e0064..a61bebacee45 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7712,6 +7712,15 @@ F:
> Documentation/devicetree/bindings/media/renesas,fcp.txt
> F: drivers/media/platform/rcar-fcp.c
> F: include/media/rcar-fcp.h
>
> +MEDIA DRIVERS FOR RENESAS - FDP1
> +M: Kieran Bingham
> +L: linux-me...@vger.kernel.org
> +L: linux-renesas-soc@vger.kernel.org
> +T: git git://linuxtv.org/media_tree.git
> +S: Supported
> +F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +F: drivers/media/platform/rcar_fdp1.c
> +
> MEDIA DRIVERS FOR RENESAS - VIN
> M: Niklas Söderlund
> L: linux-me...@vger.kernel.org
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index ce4a96fccc43..414b69e5333c 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -290,6 +290,19 @@ config VIDEO_SH_VEU
> Support for the Video Engine Unit (VEU) on SuperH and
> S
