Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Geert Uytterhoeven
On Tue, Jun 27, 2017 at 5:03 PM, Kieran Bingham  wrote:
> From: Kieran Bingham 
>
> Create device tree bindings documentation for the ADV748x.
> The ADV748x supports both the ADV7481 and ADV7482 chips which
> provide analogue decoding and HDMI receiving capabilities

The subject says adv7*1*81, adv7*1*82.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Kieran Bingham


On 29/06/17 10:37, Geert Uytterhoeven wrote:
> On Tue, Jun 27, 2017 at 5:03 PM, Kieran Bingham  wrote:
>> From: Kieran Bingham 
>>
>> Create device tree bindings documentation for the ADV748x.
>> The ADV748x supports both the ADV7481 and ADV7482 chips which
>> provide analogue decoding and HDMI receiving capabilities
> 
> The subject says adv7*1*81, adv7*1*82.

Indeed it does. I'm not sure how I managed to typo that...
My usual typo is adv749x instead :)


Thanks for the spot!

--
Kieran

> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
> 

-- 
--
Kieran


Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Laurent Pinchart
Hi Kieran,

Thank you for the patch.

On Tuesday 27 Jun 2017 16:03:32 Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> Create device tree bindings documentation for the ADV748x.
> The ADV748x supports both the ADV7481 and ADV7482 chips which
> provide analogue decoding and HDMI receiving capabilities
> 
> Signed-off-by: Kieran Bingham 

With the subject fixed,

Reviewed-by: Laurent Pinchart 

> ---
> v6:
>  - Clean up description and remove redundant text regarding optional
>nodes
> 
>  Documentation/devicetree/bindings/media/i2c/adv748x.txt | 95 ++-
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/adv748x.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> b/Documentation/devicetree/bindings/media/i2c/adv748x.txt new file mode
> 100644
> index ..21ffb5ed8183
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt
> @@ -0,0 +1,95 @@
> +* Analog Devices ADV748X video decoder with HDMI receiver
> +
> +The ADV7481 and ADV7482 are multi format video decoders with an integrated
> +HDMI receiver. They can output CSI-2 on two independent outputs TXA and TXB
> +from three input sources HDMI, analog and TTL.
> +
> +Required Properties:
> +
> +  - compatible: Must contain one of the following
> +- "adi,adv7481" for the ADV7481
> +- "adi,adv7482" for the ADV7482
> +
> +  - reg: I2C slave address
> +
> +Optional Properties:
> +
> +  - interrupt-names: Should specify the interrupts as "intrq1", "intrq2"
> and/or +   "intrq3". All interrupts are optional. The 
"intrq3"
> interrupt +is only available on the adv7481
> +  - interrupts: Specify the interrupt lines for the ADV748x
> +
> +The device node must contain one 'port' child node per device input and
> output +port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt. The port
> nodes +are numbered as follows.
> +
> +   Name  TypePort
> + ---
> +   AIN0  sink0
> +   AIN1  sink1
> +   AIN2  sink2
> +   AIN3  sink3
> +   AIN4  sink4
> +   AIN5  sink5
> +   AIN6  sink6
> +   AIN7  sink7
> +   HDMI  sink8
> +   TTL   sink9
> +   TXA   source  10
> +   TXB   source  11
> +
> +The digital output port nodes must contain at least one endpoint.
> +
> +Ports are optional if they are not connected to anything at the hardware
> level. +
> +Example:
> +
> + video-receiver@70 {
> + compatible = "adi,adv7482";
> + reg = <0x70>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + interrupt-parent = <&gpio6>;
> + interrupt-names = "intrq1", "intrq2";
> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> +  <31 IRQ_TYPE_LEVEL_LOW>;
> +
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_in>;
> + };
> + };
> +
> + port@8 {
> + reg = <8>;
> +
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in>;
> + };
> + };
> +
> + port@10 {
> + reg = <10>;
> +
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi40_in>;
> + };
> + };
> +
> + port@11 {
> + reg = <11>;
> +
> + adv7482_txb: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + remote-endpoint = <&csi20_in>;
> + };
> + };
> + };

-- 
Regards,

Laurent Pinchart