Re: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h for MFC 5.1
On Friday, March 04, 2011 19:56:35 Kamil Debski wrote:
> Hi,
>
> > -Original Message-
> > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
> > Sent: 04 March 2011 17:39
> > To: Kamil Debski
> > Cc: linux-me...@vger.kernel.org; linux-samsung-soc@vger.kernel.org;
> > m.szyprow...@samsung.com; kyungmin.p...@samsung.com;
> > jaeryul...@samsung.com; kgene@samsung.com
> > Subject: Re: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h
> > for MFC 5.1
> >
> > On Friday 04 March 2011 12:26:18 Kamil Debski wrote:
> > > This patch adds fourcc values for compressed video stream formats and
> > > V4L2_CTRL_CLASS_CODEC. Also adds controls used by MFC 5.1 driver.
> > >
> > > Signed-off-by: Kamil Debski
> > > Signed-off-by: Kyungmin Park
> > > ---
> > > include/linux/videodev2.h | 39
> > +++
> > > 1 files changed, 39 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> > > index a94c4d5..a48a42e 100644
> > > --- a/include/linux/videodev2.h
> > > +++ b/include/linux/videodev2.h
> > > @@ -369,6 +369,19 @@ struct v4l2_pix_format {
> > > #define V4L2_PIX_FMT_DV v4l2_fourcc('d', 'v', 's', 'd') /*
> > 1394 */
> > > #define V4L2_PIX_FMT_MPEG v4l2_fourcc('M', 'P', 'E', 'G') /*
> > MPEG-1/2/4 */
> > >
> > > +#define V4L2_PIX_FMT_H264 v4l2_fourcc('H', '2', '6', '4') /*
> > H264 */
> > > +#define V4L2_PIX_FMT_H263 v4l2_fourcc('H', '2', '6', '3') /*
> > H263 */
> > > +#define V4L2_PIX_FMT_MPEG12 v4l2_fourcc('M', 'P', '1', '2') /*
> > MPEG-1/2 */
> > > +#define V4L2_PIX_FMT_MPEG4v4l2_fourcc('M', 'P', 'G', '4') /*
> > MPEG-4 */
> > > +#define V4L2_PIX_FMT_DIVX v4l2_fourcc('D', 'I', 'V', 'X') /*
> > DivX */
> > > +#define V4L2_PIX_FMT_DIVX3v4l2_fourcc('D', 'I', 'V', '3') /*
> > DivX 3.11 */
> > > +#define V4L2_PIX_FMT_DIVX4v4l2_fourcc('D', 'I', 'V', '4') /*
> > DivX 4.12 */
> > > +#define V4L2_PIX_FMT_DIVX500 v4l2_fourcc('D', 'X', '5', '2') /*
> > DivX 5.00 - 5.02 */
> > > +#define V4L2_PIX_FMT_DIVX503 v4l2_fourcc('D', 'X', '5', '3') /*
> > DivX 5.03 - x */
> > > +#define V4L2_PIX_FMT_XVID v4l2_fourcc('X', 'V', 'I', 'D') /*
> > Xvid */
> > > +#define V4L2_PIX_FMT_VC1 v4l2_fourcc('V', 'C', '1', 'A') /* VC-
> > 1 */
> > > +#define V4L2_PIX_FMT_VC1_RCV v4l2_fourcc('V', 'C', '1', 'R') /* VC-
> > 1 RCV */
> > > +
> >
> > Hans, you mentioned some time ago that you were against ading H.264 or
> > MPEG4
> > fourccs, and that drivers should use the MPEG controls instead. Could
> > you
> > clarify your current position on this ?
>
> If I remember correct there was no clear conclusion on this. I hope we can
> discuss this
> during the upcoming meeting.
Yes, we need to discuss this.
> Have you got an alternative suggestion to using fourccs?
>
> The existing MPEG controls won't cover all the functions and parameters that
> are
> used by video codecs. The controls that are in this patch are the ones
> related to
> decoding, there is even more for encoding.
>
> Yesterday I have been talking with Hans on the IRC channel about the control
> for
> quantization parameters and he has suggested to use different for MPEG4,
> H263 and H264.
> Personally I'd like to have a common one, as the QP meaning is the same in
> those 3
> cases, the difference is the range of the value.
> So I think that this still is a subject that could use more discussion as
> there are
> a few ideas.
When I made the MPEG API originally I did design it to be usable for other
compression schemes as well. But we need to review that API in light of the
current developments and see if it can be used unchanged, needs tweaking or
perhaps should be abandoned altogether.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h for MFC 5.1
Hi, I commented as below.
> -Original Message-
> From: Kamil Debski [mailto:k.deb...@samsung.com]
> Sent: Saturday, March 05, 2011 3:57 AM
> To: 'Laurent Pinchart'
> Cc: linux-me...@vger.kernel.org; linux-samsung-soc@vger.kernel.org; Marek
> Szyprowski; kyungmin.p...@samsung.com; jaeryul...@samsung.com;
> kgene@samsung.com
> Subject: RE: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h for
> MFC 5.1
>
> Hi,
>
> > -Original Message-
> > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
> > Sent: 04 March 2011 17:39
> > To: Kamil Debski
> > Cc: linux-me...@vger.kernel.org; linux-samsung-soc@vger.kernel.org;
> > m.szyprow...@samsung.com; kyungmin.p...@samsung.com;
> > jaeryul...@samsung.com; kgene@samsung.com
> > Subject: Re: [RFC/PATCH v7 1/5] Changes in include/linux/videodev2.h
> > for MFC 5.1
> >
> > On Friday 04 March 2011 12:26:18 Kamil Debski wrote:
> > > This patch adds fourcc values for compressed video stream formats and
> > > V4L2_CTRL_CLASS_CODEC. Also adds controls used by MFC 5.1 driver.
> > >
> > > Signed-off-by: Kamil Debski
> > > Signed-off-by: Kyungmin Park
> > > ---
> > > include/linux/videodev2.h | 39
> > +++
> > > 1 files changed, 39 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> > > index a94c4d5..a48a42e 100644
> > > --- a/include/linux/videodev2.h
> > > +++ b/include/linux/videodev2.h
> > > @@ -369,6 +369,19 @@ struct v4l2_pix_format {
> > > #define V4L2_PIX_FMT_DV v4l2_fourcc('d', 'v', 's', 'd') /*
> > 1394 */
> > > #define V4L2_PIX_FMT_MPEG v4l2_fourcc('M', 'P', 'E', 'G') /*
> > MPEG-1/2/4 */
> > >
> > > +#define V4L2_PIX_FMT_H264 v4l2_fourcc('H', '2', '6', '4') /*
> > H264 */
> > > +#define V4L2_PIX_FMT_H263 v4l2_fourcc('H', '2', '6', '3') /*
> > H263 */
> > > +#define V4L2_PIX_FMT_MPEG12 v4l2_fourcc('M', 'P', '1', '2') /*
> > MPEG-1/2 */
> > > +#define V4L2_PIX_FMT_MPEG4v4l2_fourcc('M', 'P', 'G', '4') /*
> > MPEG-4 */
> > > +#define V4L2_PIX_FMT_DIVX v4l2_fourcc('D', 'I', 'V', 'X') /*
> > DivX */
> > > +#define V4L2_PIX_FMT_DIVX3v4l2_fourcc('D', 'I', 'V', '3') /*
> > DivX 3.11 */
> > > +#define V4L2_PIX_FMT_DIVX4v4l2_fourcc('D', 'I', 'V', '4') /*
> > DivX 4.12 */
> > > +#define V4L2_PIX_FMT_DIVX500 v4l2_fourcc('D', 'X', '5', '2') /*
> > DivX 5.00 - 5.02 */
> > > +#define V4L2_PIX_FMT_DIVX503 v4l2_fourcc('D', 'X', '5', '3') /*
> > DivX 5.03 - x */
> > > +#define V4L2_PIX_FMT_XVID v4l2_fourcc('X', 'V', 'I', 'D') /*
> > Xvid */
> > > +#define V4L2_PIX_FMT_VC1 v4l2_fourcc('V', 'C', '1', 'A') /* VC-
> > 1 */
> > > +#define V4L2_PIX_FMT_VC1_RCV v4l2_fourcc('V', 'C', '1', 'R') /* VC-
> > 1 RCV */
> > > +
> >
> > Hans, you mentioned some time ago that you were against ading H.264 or
> > MPEG4
> > fourccs, and that drivers should use the MPEG controls instead. Could
> > you
> > clarify your current position on this ?
>
> If I remember correct there was no clear conclusion on this. I hope we can
> discuss this
> during the upcoming meeting.
>
> Have you got an alternative suggestion to using fourccs?
>
> The existing MPEG controls won't cover all the functions and parameters
> that
> are
> used by video codecs. The controls that are in this patch are the ones
> related to
> decoding, there is even more for encoding.
>
> Yesterday I have been talking with Hans on the IRC channel about the
> control
> for
> quantization parameters and he has suggested to use different for MPEG4,
> H263 and H264.
> Personally I'd like to have a common one, as the QP meaning is the same in
> those 3
> cases, the difference is the range of the value.
> So I think that this still is a subject that could use more discussion as
> there are
> a few ideas.
According to the fource.org, and if fourcc definition here has been made
from fourcc.org,
We need to have a discussion about new types that Kamil added not only h264
but divx_xxx.
QP might be a same topic. So let's discuss more at Poland meeting.
>
> Best regards,
>
> --
> Kamil Debski
> Linux Platform Group
> Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC 0/5] [media] s5p-tvout: Add S5P TVOUT driver
Hi! Sorry for not replying earlier. To be honest, there is not much I can say yet. The main new part in this driver is the HDMI/CEC support. And that is one of the topics of the upcoming Warsaw brainstorm meeting (several of your Samsung colleagues will be attending). An RFC for CEC support has been posted last week and hopefully we (Cisco Systems Norway) can get a HDMI RFC posted as well in time for the meeting. The main difference of our approach to HDMI is that we integrate it in V4L2 rather than creating new device nodes. Once the media controller is in we also have per-subdevice nodes in /dev which we want to utilize for the HDMI and CEC APIs. Functionality-wise the CEC RFC is effectively identical to your implementation. Regards, Hans On Friday, February 25, 2011 08:53:28 Abhilash Kesavan wrote: > This patch-set adds support for TV-OUT interface in the EXYNOS4 series of > SoCs. > TVOUT includes the HDMI interface, analog TV interface, mixer and video > processor. This is a full-featured driver providing the following: > > 1) HDMI Support > 2) Analog Support > 3) Mixer Support > 4) Video Processor Support > 5) Hotplug Detect Support > 6) HDCP Support > 7) CEC Support > 8) I2S/SPDIF Support > > The driver is under development and needs major modifications, as mentioned > later in the TODO section, to conform to open source standards. Please have > a look at the driver design and offer any suggestions/comments. > > > I) HARDWARE > > Video processor is responsible for video scaling, de-interlacing, and video > post > processing of TVOUT data path. It reads reconstructed YCbCr video sequences > from > DRAM, processes the sequence, and sends it to mixer on-the-fly. Input to VP is > NV12 and NV21 (Linear and tiled) format while the output to the mixer is > YUV444. > > Mixer overlaps or blends input data such as graphic, video, background and > sends > the resulting data to the HDMI or analog TV interface. Along with the YUV444 > in- > put from VP interface, the mixer can receive two RGB inputs. It allows for > layer > blending, alpha blending, chroma key, scaling etc. > > HDMI interface supports 1.3 Tx subsystem V1.0 comprising an HDMI Tx core with > I2S input interface, CEC block, and HDCP key block. It receives YUV444 or > RGB888 > data from the mixer and converts it into HDMI packets. Supports a variety of > video formats varying from 480p to 1080p. > > Analog TV interface supports ITU-R BT 470 and EIA-770 compliant analog TV > signals with 1 channel 10bit DAC. Supports PAL-m@60Hz, PAL-60@60Hz, NTSC@60Hz, > NTSC-443@60Hz, PAL@50Hz, PAL-n@50Hz and (M)NTSC@60Hz formats for composite > output. > > > II) S/W DESIGN > > === > > --- > VFS > > --- > KERNEL | | > V V > -- > -- > V4L2 STACK FB STACKLinux Driver > Model > -- > -- > | || > =+===++ > | || > | | +-| > | | | | > V V V | > > +---+---+ > | | > | > | | > | > | - --- | > | > | Video Ctrl -- Graphics Ctrl -- TVOUT I/F| > | > | - --- V > | > | | | ||__ --- > | > | | | | | HPD Driver > | > | V V V V(GPIO) > | > | --- --- --- --- --- > | > | VP I/F Mixer I/F Analog I/FHDMI I/F > | > | --- --- --- --- > | > | | | | | | > | > DEVICE| | | | | |___ > | > DRIVE
Re: [PATCH] ARM: S5PC210: add support for i2c PMICs on Universal_C210 board
On Thu, Mar 03, 2011 at 11:40:26AM +0900, Kyungmin Park wrote: > On Tue, Feb 15, 2011 at 8:35 PM, Russell King - ARM Linux > wrote: > > On Tue, Feb 15, 2011 at 11:59:15AM +0100, Marek Szyprowski wrote: > >> #include > >> +#include > > > > Need I say anything about this? > > Hi Russell, > > How about to prevent it as compiler error? It's frequent mistake. > > At each mach/gpio.h > > #ifndef __LINUX_GPIO_H > #error "You should include instead of ." > #endif It doesn't stop people including linux/gpio.h and then mach/gpio.h, which is also a common mistake. Besides, it's easy to catch when you have a regexp setup in your mail reader to find them... -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
