RE: [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA
On Sat, 2011-08-13 at 13:11 +0900, Kukjin Kim wrote: Koul, Vinod wrote: On Thu, 2011-08-11 at 16:26 +0900, Kukjin Kim wrote: Koul, Vinod wrote: On Thu, 2011-08-04 at 18:53 +0200, Linus Walleij wrote: On Wed, Jul 27, 2011 at 7:31 AM, Boojin Kim boojin@samsung.com wrote: This patchset adds support DMA generic APIs for Samsung DMA. Patches look good to me, Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Do you want these to go thru slave-dma tree or arm tree, I am okay with either... Hi Vinod, Thanks. I'd like to keep its topic branch in my tree to avoid conflicts with other samsung stuff and I think, it should be merged into your slave-dma tree also for same reason. git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git #next/topic- dma-pl330 Or if you want to make some branch for it in your tree, please let me know so that I can merge it in my tree also. Okay can you update this branch with latest patchset (I think there were few comments on last patchset). Once you add all acks let me know the branch, I will merge it to my next Hi, I updated it so that you can merge it to yours. I think, if any fixing is required on that, it should be small so can be fixed easily after this merging. If any problems, please let me know :) Well, that not how things are supposed to be done. Fixing an error introduced is not recommended, rather original patch set should be fixed. Since you have already done 5 posting of your patch series, I am okay if you split things up, send me the parts that have already been reviewed and acked. I will host them on a branch for you. Once rest is reviewed and acked, I will merge this entire branch to my next. -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: S3C64XX: Remove un-used code
Remove un-used backlight code for SMDK6410 board
Signed-off-by: Banajit Goswami banaji...@samsung.com
---
arch/arm/mach-s3c64xx/mach-smdk6410.c | 39 -
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c
b/arch/arm/mach-s3c64xx/mach-smdk6410.c
index ecbea92..a9f3183 100644
--- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
+++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
@@ -262,45 +262,6 @@ static struct samsung_keypad_platdata smdk6410_keypad_data
__initdata = {
.cols = 8,
};
-static int smdk6410_backlight_init(struct device *dev)
-{
- int ret;
-
- ret = gpio_request(S3C64XX_GPF(15), Backlight);
- if (ret) {
- printk(KERN_ERR failed to request GPF for PWM-OUT1\n);
- return ret;
- }
-
- /* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_SFN(2));
-
- return 0;
-}
-
-static void smdk6410_backlight_exit(struct device *dev)
-{
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_OUTPUT);
- gpio_free(S3C64XX_GPF(15));
-}
-
-static struct platform_pwm_backlight_data smdk6410_backlight_data = {
- .pwm_id = 1,
- .max_brightness = 255,
- .dft_brightness = 255,
- .pwm_period_ns = 78770,
- .init = smdk6410_backlight_init,
- .exit = smdk6410_backlight_exit,
-};
-
-static struct platform_device smdk6410_backlight_device = {
- .name = pwm-backlight,
- .dev= {
- .parent = s3c_device_timer[1].dev,
- .platform_data = smdk6410_backlight_data,
- },
-};
-
static struct map_desc smdk6410_iodesc[] = {};
static struct platform_device *smdk6410_devices[] __initdata = {
--
1.7.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: EXYNOS4: Configure MAX8997 PMIC for Origen
On Tue, Aug 16, 2011 at 04:38:46PM +0530, Inderpal Singh wrote:
On 14 August 2011 20:31, Mark Brown
broo...@opensource.wolfsonmicro.comwrote:
On Thu, Aug 11, 2011 at 09:26:05AM +0530, Inderpal Singh wrote:
+static struct regulator_consumer_supply __initdata ldo7_consumer[] = {
+ REGULATOR_SUPPLY(avdd, soc-audio), /* Reatek ALC5625*/
+};
Ick, no. The soc-audio device is a virtual device within Linux and is
being phased out, any driver adding new soc-audio devices will be
rejected. The CODEC driver should deal with its own power.
Ok. So does it mean that sound cards will have their own devices? And those
device names should be listed as consumers?
As I said above The CODEC driver should deal with its own power.
+static struct i2c_board_info i2c0_devs[] __initdata = {
+[I2C0_MAX8997] = {
+ I2C_BOARD_INFO(max8997, (0xCC 1)),
+ .platform_data = origen_max8997_pdata,
+ },
+};
Why are you assigning the array index? That's very unusual.
Have seen this kind of initialisation at few places. It looked more
readable.
If its not preferred, I will remove it.
You shouldn't need to be looking up individual members in a board info
array in the first place.
+ s3c_i2c0_set_platdata(NULL);
+ i2c0_devs[I2C0_MAX8997].irq = gpio_to_irq(EXYNOS4_GPX0(4));
There should be defines to do this statically.
What advantages do you see in using defines?
It's non-idiomatic to modify the I2C board info at runtime, all the
numbers are known at compile time anyway.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] ARM: S5PC100: use dma-pl330 device name for clock
This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.
Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
dma-pl330 dma-pl330.0: Cannot get operation clock.
dma-pl330: probe of dma-pl330.0 failed with error -22
Signed-off-by: Vladimir Zapolskiy v...@mleia.com
Cc: Boojin Kim boojin@samsung.com
---
arch/arm/mach-s5pc100/clock.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/mach-s5pc100/clock.c
index 6527c05..8d47709 100644
--- a/arch/arm/mach-s5pc100/clock.c
+++ b/arch/arm/mach-s5pc100/clock.c
@@ -460,13 +460,13 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 2),
}, {
.name = dma,
- .devname= s3c-pl330.1,
+ .devname= dma-pl330.1,
.parent = clk_div_d1_bus.clk,
.enable = s5pc100_d1_0_ctrl,
.ctrlbit= (1 1),
}, {
.name = dma,
- .devname= s3c-pl330.0,
+ .devname= dma-pl330.0,
.parent = clk_div_d1_bus.clk,
.enable = s5pc100_d1_0_ctrl,
.ctrlbit= (1 0),
--
1.7.5.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock
This changeset replaces s3c-pl330.x clock device names with dma-pl330.x, otherwise there won't be a correspondence between clock device name and amba device name, thus clocks can't be enabled. Fixes runtime errors on clk_get() from drivers/dma/pl330.c: dma-pl330 dma-pl330.0: Cannot get operation clock. dma-pl330: probe of dma-pl330.0 failed with error -22 The changes are based on linux-samsung/next/topic-dma-pl330 branch. Vladimir Zapolskiy (3): ARM: EXYNOS4: use dma-pl330 device name for clock ARM: S5PC100: use dma-pl330 device name for clock ARM: S5PV210: use dma-pl330 device name for clock arch/arm/mach-exynos4/clock.c |4 ++-- arch/arm/mach-s5pc100/clock.c |4 ++-- arch/arm/mach-s5pv210/clock.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) -- 1.7.5.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: SAMSUNG: Modify the devname for pl330 clock
This patch modified the devname for pl330 clock from 's3c-pl330' to 'dma-pl330'
to support new pl330 driver on dmaengine.
NOTE: This patch sould be added after merging new pl330 driver on dmaengine.
Signed-off-by: Boojin Kim boojin@samsung.com
---
arch/arm/mach-exynos4/clock.c |4 ++--
arch/arm/mach-s5p64x0/clock-s5p6440.c |1 +
arch/arm/mach-s5p64x0/clock-s5p6450.c |1 +
arch/arm/mach-s5pc100/clock.c |4 ++--
arch/arm/mach-s5pv210/clock.c |4 ++--
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-exynos4/clock.c
index fee2dd8..04c997a 100644
--- a/arch/arm/mach-exynos4/clock.c
+++ b/arch/arm/mach-exynos4/clock.c
@@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 10),
}, {
.name = dma,
- .devname= s3c-pl330.0,
+ .devname= dma-pl330.0,
.enable = exynos4_clk_ip_fsys_ctrl,
.ctrlbit= (1 0),
}, {
.name = dma,
- .devname= s3c-pl330.1,
+ .devname= dma-pl330.1,
.enable = exynos4_clk_ip_fsys_ctrl,
.ctrlbit= (1 1),
}, {
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c
b/arch/arm/mach-s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 8),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c
b/arch/arm/mach-s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 3),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
diff --git a/arch/arm/mach-s5pc100/clock.c b/arch/arm/mach-s5pc100/clock.c
index 6527c05..8d47709 100644
--- a/arch/arm/mach-s5pc100/clock.c
+++ b/arch/arm/mach-s5pc100/clock.c
@@ -460,13 +460,13 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 2),
}, {
.name = dma,
- .devname= s3c-pl330.1,
+ .devname= dma-pl330.1,
.parent = clk_div_d1_bus.clk,
.enable = s5pc100_d1_0_ctrl,
.ctrlbit= (1 1),
}, {
.name = dma,
- .devname= s3c-pl330.0,
+ .devname= dma-pl330.0,
.parent = clk_div_d1_bus.clk,
.enable = s5pc100_d1_0_ctrl,
.ctrlbit= (1 0),
diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
index d35726a..239aaad 100644
--- a/arch/arm/mach-s5pv210/clock.c
+++ b/arch/arm/mach-s5pv210/clock.c
@@ -295,13 +295,13 @@ static struct clk_ops clk_fout_apll_ops = {
static struct clk init_clocks_off[] = {
{
.name = dma,
- .devname= s3c-pl330.0,
+ .devname= dma-pl330.0,
.parent = clk_hclk_psys.clk,
.enable = s5pv210_clk_ip0_ctrl,
.ctrlbit= (1 3),
}, {
.name = dma,
- .devname= s3c-pl330.1,
+ .devname= dma-pl330.1,
.parent = clk_hclk_psys.clk,
.enable = s5pv210_clk_ip0_ctrl,
.ctrlbit= (1 4),
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock
Vladimir Zapolskiy wrote:
Sent: Wednesday, August 17, 2011 6:31 AM
To: Kukjin Kim
Cc: linux-samsung-soc@vger.kernel.org; linux-arm-
ker...@lists.infradead.org; Vladimir Zapolskiy; Boojin Kim
Subject: [PATCH 1/3] ARM: EXYNOS4: use dma-pl330 device name for clock
This change replaces s3c-pl330.x clock device names with dma-pl330.x,
otherwise there won't be a correspondence between clock device name
and amba device name, thus clocks can't be enabled.
Fixes runtime errors on clk_get() from drivers/dma/pl330.c:
dma-pl330 dma-pl330.0: Cannot get operation clock.
dma-pl330: probe of dma-pl330.0 failed with error -22
Signed-off-by: Vladimir Zapolskiy v...@mleia.com
Cc: Boojin Kim boojin@samsung.com
---
arch/arm/mach-exynos4/clock.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos4/clock.c b/arch/arm/mach-
exynos4/clock.c
index fee2dd8..04c997a 100644
--- a/arch/arm/mach-exynos4/clock.c
+++ b/arch/arm/mach-exynos4/clock.c
@@ -460,12 +460,12 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 10),
}, {
.name = dma,
- .devname= s3c-pl330.0,
+ .devname= dma-pl330.0,
.enable = exynos4_clk_ip_fsys_ctrl,
.ctrlbit= (1 0),
}, {
.name = dma,
- .devname= s3c-pl330.1,
+ .devname= dma-pl330.1,
.enable = exynos4_clk_ip_fsys_ctrl,
.ctrlbit= (1 1),
}, {
--
1.7.5.1
I checked this patch just now.
This patch looks good to me. but this missed regarding s5p64x0 dma-pl330
clock.
So, need to following.
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c
b/arch/arm/mach-s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 8),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c
b/arch/arm/mach-s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 3),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
Ohters, looks ok to me
Acked-by: Boojin Kim boojin@samsung.com
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] ARM: SAMSUNG: register the second instance of PL330 DMAC
From: Alim Akhtar alim.akh...@samsung.com Two instance of platform data is provided for PL330 but only one PL330 DMAC instance is registered with amba_device. These patch sets registers the second instance with amba_device. These patches are based on kgene's tree next/topic-dma-pl330 branch. http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;;a=summary Alim Akhtar (3): ARM: EXYNOS4: register the second instance of pl330 DMAC ARM: S5PV210: register the second instance of pl330 DMAC ARM: S5PC100: register the second instance of pl330 DMAC arch/arm/mach-exynos4/dma.c |1 + arch/arm/mach-s5pc100/dma.c |1 + arch/arm/mach-s5pv210/dma.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) -- 1.7.2.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] ARM: EXYNOS4: register the second instance of pl330 DMAC
From: Alim Akhtar alim.akh...@samsung.com
Platform data is provided for two instance of pl330 DMAC,
but only one DMAC is register with amba_device.
This patch register the second instance.
Signed-off-by: Alim Akhtar alim.akh...@samsung.com
---
arch/arm/mach-exynos4/dma.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos4/dma.c b/arch/arm/mach-exynos4/dma.c
index d57d662..9667c61 100644
--- a/arch/arm/mach-exynos4/dma.c
+++ b/arch/arm/mach-exynos4/dma.c
@@ -243,6 +243,7 @@ struct amba_device exynos4_device_pdma1 = {
static int __init exynos4_dma_init(void)
{
amba_device_register(exynos4_device_pdma0, iomem_resource);
+ amba_device_register(exynos4_device_pdma1, iomem_resource);
return 0;
}
--
1.7.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] ARM: S5PV210: register the second instance of pl330 DMAC
From: Alim Akhtar alim.akh...@samsung.com
Platform data is provided for two instance of pl330 DMAC,
but only one DMAC is register with amba_device.
This patch register the second instance.
Signed-off-by: Alim Akhtar alim.akh...@samsung.com
---
arch/arm/mach-s5pv210/dma.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/dma.c b/arch/arm/mach-s5pv210/dma.c
index f79d0b0..86b749c 100644
--- a/arch/arm/mach-s5pv210/dma.c
+++ b/arch/arm/mach-s5pv210/dma.c
@@ -254,6 +254,7 @@ struct amba_device s5pv210_device_pdma1 = {
static int __init s5pv210_dma_init(void)
{
amba_device_register(s5pv210_device_pdma0, iomem_resource);
+ amba_device_register(s5pv210_device_pdma1, iomem_resource);
return 0;
}
--
1.7.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] ARM: S5PC100: register the second instance of pl330 DMAC
From: Alim Akhtar alim.akh...@samsung.com
Platform data is provided for two instance of pl330 DMAC,
but only one DMAC is register with amba_device.
This patch register the second instance.
Signed-off-by: Alim Akhtar alim.akh...@samsung.com
---
arch/arm/mach-s5pc100/dma.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pc100/dma.c b/arch/arm/mach-s5pc100/dma.c
index ef803e9..065a087 100644
--- a/arch/arm/mach-s5pc100/dma.c
+++ b/arch/arm/mach-s5pc100/dma.c
@@ -260,6 +260,7 @@ struct amba_device s5pc100_device_pdma1 = {
static int __init s5pc100_dma_init(void)
{
amba_device_register(s5pc100_device_pdma0, iomem_resource);
+ amba_device_register(s5pc100_device_pdma1, iomem_resource);
return 0;
}
--
1.7.2.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] ARM: SAMSUNG: register the second instance of PL330 DMAC
Does it also need to provide the mdma? On Wed, Aug 17, 2011 at 1:06 PM, alim akhtar alim.akh...@samsung.com wrote: From: Alim Akhtar alim.akh...@samsung.com Two instance of platform data is provided for PL330 but only one PL330 DMAC instance is registered with amba_device. These patch sets registers the second instance with amba_device. These patches are based on kgene's tree next/topic-dma-pl330 branch. http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;;a=summary Alim Akhtar (3): ARM: EXYNOS4: register the second instance of pl330 DMAC ARM: S5PV210: register the second instance of pl330 DMAC ARM: S5PC100: register the second instance of pl330 DMAC arch/arm/mach-exynos4/dma.c | 1 + arch/arm/mach-s5pc100/dma.c | 1 + arch/arm/mach-s5pv210/dma.c | 1 + 3 files changed, 3 insertions(+), 0 deletions(-) -- 1.7.2.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
