[PATCH] ARM: S5P64X0: Add the devname for DMA clock
This patch adds devname for DMA clock.
NOTE: This patch should be added after merging new pl330 driver on dmaengine.
Signed-off-by: Boojin Kim boojin@samsung.com
---
arch/arm/mach-s5p64x0/clock-s5p6440.c |1 +
arch/arm/mach-s5p64x0/clock-s5p6450.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c
b/arch/arm/mach-s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 8),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c
b/arch/arm/mach-s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 3),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3] ARM: Samsung: fix watchdog reset issue with clk_get()
clkdev framework uses global mutex to protect clock tree, so it is not
possible to call clk_get() in interrupt context. This patch fixes this
issue and makes system reset by watchdog call working again.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/plat-samsung/clock.c | 11 +++
arch/arm/plat-samsung/include/plat/clock.h |3 +++
.../arm/plat-samsung/include/plat/watchdog-reset.h | 10 +++---
3 files changed, 17 insertions(+), 7 deletions(-)
history:
v3:
- moved initialization to arch_initcall, cleaned the code
v2:
- added missing '__init' section modifiers
diff --git a/arch/arm/plat-samsung/clock.c b/arch/arm/plat-samsung/clock.c
index 302c426..3b44519 100644
--- a/arch/arm/plat-samsung/clock.c
+++ b/arch/arm/plat-samsung/clock.c
@@ -64,6 +64,17 @@ static LIST_HEAD(clocks);
*/
DEFINE_SPINLOCK(clocks_lock);
+/* Global watchdog clock used by arch_wtd_reset() callback */
+struct clk *s3c2410_wdtclk;
+static int __init s3c_wdt_reset_init(void)
+{
+ s3c2410_wdtclk = clk_get(NULL, watchdog);
+ if (IS_ERR(s3c2410_wdtclk))
+ printk(KERN_WARNING %s: warning: cannot get watchdog clock\n,
__func__);
+ return 0;
+}
+arch_initcall(s3c_wdt_reset_init);
+
/* enable and disable calls for use with the clk struct */
static int clk_null_enable(struct clk *clk, int enable)
diff --git a/arch/arm/plat-samsung/include/plat/clock.h
b/arch/arm/plat-samsung/include/plat/clock.h
index 87d5b38..8f95700 100644
--- a/arch/arm/plat-samsung/include/plat/clock.h
+++ b/arch/arm/plat-samsung/include/plat/clock.h
@@ -121,3 +121,6 @@ extern int s3c64xx_sclk_ctrl(struct clk *clk, int enable);
extern void s3c_pwmclk_init(void);
+/* Global watchdog clock used by arch_wtd_reset() callback */
+
+extern struct clk *s3c2410_wdtclk;
diff --git a/arch/arm/plat-samsung/include/plat/watchdog-reset.h
b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
index 54b762a..40dbb2b 100644
--- a/arch/arm/plat-samsung/include/plat/watchdog-reset.h
+++ b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
@@ -10,6 +10,7 @@
* published by the Free Software Foundation.
*/
+#include plat/clock.h
#include plat/regs-watchdog.h
#include mach/map.h
@@ -19,17 +20,12 @@
static inline void arch_wdt_reset(void)
{
- struct clk *wdtclk;
-
printk(arch_reset: attempting watchdog reset\n);
__raw_writel(0, S3C2410_WTCON); /* disable watchdog, to be safe */
- wdtclk = clk_get(NULL, watchdog);
- if (!IS_ERR(wdtclk)) {
- clk_enable(wdtclk);
- } else
- printk(KERN_WARNING %s: warning: cannot get watchdog clock\n,
__func__);
+ if (s3c2410_wdtclk)
+ clk_enable(s3c2410_wdtclk);
/* put initial values into count and data */
__raw_writel(0x80, S3C2410_WTCNT);
--
1.7.1.569.g6f426
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] CPUFREQ: ARM Exynos4210 PM/Suspend Compatibility with Different Bootloaders
We have various bootloaders for Exynos4210 machines. Some of they
set the ARM core frequency at boot time even when the boot is a resume
from suspend-to-RAM. Such changes may create inconsistency in the
data of CPUFREQ driver and have incurred hang issues with suspend-to-RAM.
This patch enables to save and restore CPU frequencies with pm-notifier and
sets the frequency at the initial (boot-time) value so that there wouldn't
be any inconsistency between bootloader and kernel. This patch does not
use CPUFREQ's suspend/resume callbacks because they are syscore-ops, which
do not allow to use mutex that is being used by regulators that are used by
the target function.
This also prevents any CPUFREQ transitions during suspend-resume context,
which could be dangerous at noirq-context along with regulator framework.
Signed-off-by: MyungJoo Ham myungjoo@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/cpufreq/exynos4210-cpufreq.c | 106 -
1 files changed, 102 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/exynos4210-cpufreq.c
b/drivers/cpufreq/exynos4210-cpufreq.c
index b7c3a84..101898a 100644
--- a/drivers/cpufreq/exynos4210-cpufreq.c
+++ b/drivers/cpufreq/exynos4210-cpufreq.c
@@ -17,6 +17,8 @@
#include linux/slab.h
#include linux/regulator/consumer.h
#include linux/cpufreq.h
+#include linux/notifier.h
+#include linux/suspend.h
#include mach/map.h
#include mach/regs-clock.h
@@ -36,6 +38,10 @@ static struct regulator *int_regulator;
static struct cpufreq_freqs freqs;
static unsigned int memtype;
+static unsigned int locking_frequency;
+static bool frequency_locked;
+static DEFINE_MUTEX(cpufreq_lock);
+
enum exynos4_memory_type {
DDR2 = 4,
LPDDR2,
@@ -405,22 +411,32 @@ static int exynos4_target(struct cpufreq_policy *policy,
{
unsigned int index, old_index;
unsigned int arm_volt, int_volt;
+ int err = -EINVAL;
freqs.old = exynos4_getspeed(policy-cpu);
+ mutex_lock(cpufreq_lock);
+
+ if (frequency_locked target_freq != locking_frequency) {
+ err = -EAGAIN;
+ goto out;
+ }
+
if (cpufreq_frequency_table_target(policy, exynos4_freq_table,
freqs.old, relation, old_index))
- return -EINVAL;
+ goto out;
if (cpufreq_frequency_table_target(policy, exynos4_freq_table,
target_freq, relation, index))
- return -EINVAL;
+ goto out;
+
+ err = 0;
freqs.new = exynos4_freq_table[index].frequency;
freqs.cpu = policy-cpu;
if (freqs.new == freqs.old)
- return 0;
+ goto out;
/* get the voltage value */
arm_volt = exynos4_volt_table[index].arm_volt;
@@ -447,10 +463,16 @@ static int exynos4_target(struct cpufreq_policy *policy,
cpufreq_notify_transition(freqs, CPUFREQ_POSTCHANGE);
- return 0;
+out:
+ mutex_unlock(cpufreq_lock);
+ return err;
}
#ifdef CONFIG_PM
+/*
+ * These suspend/resume are used as syscore_ops, it is already too
+ * late to set regulator voltages at this stage.
+ */
static int exynos4_cpufreq_suspend(struct cpufreq_policy *policy)
{
return 0;
@@ -462,6 +484,78 @@ static int exynos4_cpufreq_resume(struct cpufreq_policy
*policy)
}
#endif
+/**
+ * exynos4_cpufreq_pm_notifier - block CPUFREQ's activities in suspend-resume
+ * context
+ * @notifier
+ * @pm_event
+ * @v
+ *
+ * While frequency_locked == true, target() ignores every frequency but
+ * locking_frequency. The locking_frequency value is the initial frequency,
+ * which is set by the bootloader. In order to eliminate possible
+ * inconsistency in clock values, we save and restore frequencies during
+ * suspend and resume and block CPUFREQ activities. Note that the standard
+ * suspend/resume cannot be used as they are too deep (syscore_ops) for
+ * regulator actions.
+ */
+static int exynos4_cpufreq_pm_notifier(struct notifier_block *notifier,
+ unsigned long pm_event, void *v)
+{
+ struct cpufreq_policy *policy = cpufreq_cpu_get(0); /* boot CPU */
+ static unsigned int saved_frequency;
+ unsigned int temp;
+
+ mutex_lock(cpufreq_lock);
+ switch (pm_event) {
+ case PM_SUSPEND_PREPARE:
+ if (frequency_locked)
+ goto out;
+ frequency_locked = true;
+
+ if (locking_frequency) {
+ saved_frequency = exynos4_getspeed(0);
+
+ mutex_unlock(cpufreq_lock);
+ exynos4_target(policy, locking_frequency,
+ CPUFREQ_RELATION_H);
+ mutex_lock(cpufreq_lock);
+ }
+
+ break;
+ case PM_POST_SUSPEND:
+
Re: [PATCH] ARM: S3C64XX: Remove un-used code
On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S3C64XX: Remove un-used code
Hi Mark, On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks and Regards, Banajit Goswami -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S3C64XX: Remove un-used code
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose. Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S3C64XX: Remove un-used code
Banajit Goswami wrote:
Remove un-used backlight code for SMDK6410 board
Signed-off-by: Banajit Goswami banaji...@samsung.com
---
arch/arm/mach-s3c64xx/mach-smdk6410.c | 39
-
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-
s3c64xx/mach-smdk6410.c
index ecbea92..a9f3183 100644
--- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
+++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
@@ -262,45 +262,6 @@ static struct samsung_keypad_platdata
smdk6410_keypad_data __initdata = {
.cols = 8,
};
-static int smdk6410_backlight_init(struct device *dev)
-{
- int ret;
-
- ret = gpio_request(S3C64XX_GPF(15), Backlight);
- if (ret) {
- printk(KERN_ERR failed to request GPF for PWM-OUT1\n);
- return ret;
- }
-
- /* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_SFN(2));
-
- return 0;
-}
-
-static void smdk6410_backlight_exit(struct device *dev)
-{
- s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_OUTPUT);
- gpio_free(S3C64XX_GPF(15));
-}
-
-static struct platform_pwm_backlight_data smdk6410_backlight_data = {
- .pwm_id = 1,
- .max_brightness = 255,
- .dft_brightness = 255,
- .pwm_period_ns = 78770,
- .init = smdk6410_backlight_init,
- .exit = smdk6410_backlight_exit,
-};
-
-static struct platform_device smdk6410_backlight_device = {
- .name = pwm-backlight,
- .dev= {
- .parent = s3c_device_timer[1].dev,
- .platform_data = smdk6410_backlight_data,
- },
-};
-
static struct map_desc smdk6410_iodesc[] = {};
static struct platform_device *smdk6410_devices[] __initdata = {
--
1.7.2.3
OK, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] Remove hw_addr dma leftovers from S3C24xx machs
Heiko Stübner wrote: While trying to sort the dma for S3C2416 I stumbled open the hw_addr declarations in the other dma.c files. It took me a while to figure out that they seem to be some sort of leftover, i.e. they are used in dma-pl080.c of the old Samsung kernels based on 2.6.21 but nowhere in current kernels. Therefore I think removing this stuff is appropriate. The patches apply against current linux-next and are compile-tested against s3c2410_defconfig and mini2440_defconfig. Heiko Stuebner (2): Remove hw_addr from s3c24XX dma channel declarations Remove s3c24xx_dma_addr definition arch/arm/mach-s3c2410/dma.c | 14 --- arch/arm/mach-s3c2412/dma.c | 18 -- arch/arm/mach-s3c2440/dma.c | 17 - arch/arm/mach-s3c2443/dma.c | 27 -- arch/arm/plat-samsung/include/plat/dma-s3c24xx.h |6 - 5 files changed, 0 insertions(+), 82 deletions(-) -- 1.7.5.4 Good :) Applied, thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA
Koul, Vinod wrote: On Sat, 2011-08-13 at 13:11 +0900, Kukjin Kim wrote: Koul, Vinod wrote: On Thu, 2011-08-11 at 16:26 +0900, Kukjin Kim wrote: Koul, Vinod wrote: On Thu, 2011-08-04 at 18:53 +0200, Linus Walleij wrote: On Wed, Jul 27, 2011 at 7:31 AM, Boojin Kim boojin@samsung.com wrote: This patchset adds support DMA generic APIs for Samsung DMA. Patches look good to me, Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Do you want these to go thru slave-dma tree or arm tree, I am okay with either... Hi Vinod, Thanks. I'd like to keep its topic branch in my tree to avoid conflicts with other samsung stuff and I think, it should be merged into your slave-dma tree also for same reason. git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git #next/topic- dma-pl330 Or if you want to make some branch for it in your tree, please let me know so that I can merge it in my tree also. Okay can you update this branch with latest patchset (I think there were few comments on last patchset). Once you add all acks let me know the branch, I will merge it to my next Hi, I updated it so that you can merge it to yours. I think, if any fixing is required on that, it should be small so can be fixed easily after this merging. If any problems, please let me know :) Well, that not how things are supposed to be done. Fixing an error introduced is not recommended, rather original patch set should be fixed. Since you have already done 5 posting of your patch series, I am okay if you split things up, send me the parts that have already been reviewed and acked. I will host them on a branch for you. Once rest is reviewed and acked, I will merge this entire branch to my next. OK, Boojin will send whole series soon. Then if you make a branch for me, I will merge it too. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: SAMSUNG: Consolidate common function to set SDHCI plat data
Banajit Goswami wrote:
Moves similar functions to set SDHCI platform data for all Samsung
boards to a common location, thereby saves a few lines.
Signed-off-by: Banajit Goswami banaji...@samsung.com
---
arch/arm/plat-samsung/dev-hsmmc.c | 19 +--
arch/arm/plat-samsung/dev-hsmmc1.c | 19 +--
arch/arm/plat-samsung/dev-hsmmc2.c | 19 +--
arch/arm/plat-samsung/dev-hsmmc3.c | 19 +--
arch/arm/plat-samsung/include/plat/sdhci.h |7 +++
arch/arm/plat-samsung/platformdata.c | 22
++
6 files changed, 33 insertions(+), 72 deletions(-)
diff --git a/arch/arm/plat-samsung/dev-hsmmc.c
b/arch/arm/plat-samsung/dev-
hsmmc.c
index db7a65c..06825c4 100644
--- a/arch/arm/plat-samsung/dev-hsmmc.c
+++ b/arch/arm/plat-samsung/dev-hsmmc.c
@@ -58,22 +58,5 @@ struct platform_device s3c_device_hsmmc0 = {
void s3c_sdhci0_set_platdata(struct s3c_sdhci_platdata *pd)
{
- struct s3c_sdhci_platdata *set = s3c_hsmmc0_def_platdata;
-
- set-cd_type = pd-cd_type;
- set-ext_cd_init = pd-ext_cd_init;
- set-ext_cd_cleanup = pd-ext_cd_cleanup;
- set-ext_cd_gpio = pd-ext_cd_gpio;
- set-ext_cd_gpio_invert = pd-ext_cd_gpio_invert;
-
- if (pd-max_width)
- set-max_width = pd-max_width;
- if (pd-cfg_gpio)
- set-cfg_gpio = pd-cfg_gpio;
- if (pd-cfg_card)
- set-cfg_card = pd-cfg_card;
- if (pd-host_caps)
- set-host_caps |= pd-host_caps;
- if (pd-clk_type)
- set-clk_type = pd-clk_type;
+ s3c_sdhci_set_platdata(pd, s3c_hsmmc0_def_platdata);
}
diff --git a/arch/arm/plat-samsung/dev-hsmmc1.c
b/arch/arm/plat-samsung/dev-
hsmmc1.c
index 2497321..4524ef4 100644
--- a/arch/arm/plat-samsung/dev-hsmmc1.c
+++ b/arch/arm/plat-samsung/dev-hsmmc1.c
@@ -58,22 +58,5 @@ struct platform_device s3c_device_hsmmc1 = {
void s3c_sdhci1_set_platdata(struct s3c_sdhci_platdata *pd)
{
- struct s3c_sdhci_platdata *set = s3c_hsmmc1_def_platdata;
-
- set-cd_type = pd-cd_type;
- set-ext_cd_init = pd-ext_cd_init;
- set-ext_cd_cleanup = pd-ext_cd_cleanup;
- set-ext_cd_gpio = pd-ext_cd_gpio;
- set-ext_cd_gpio_invert = pd-ext_cd_gpio_invert;
-
- if (pd-max_width)
- set-max_width = pd-max_width;
- if (pd-cfg_gpio)
- set-cfg_gpio = pd-cfg_gpio;
- if (pd-cfg_card)
- set-cfg_card = pd-cfg_card;
- if (pd-host_caps)
- set-host_caps |= pd-host_caps;
- if (pd-clk_type)
- set-clk_type = pd-clk_type;
+ s3c_sdhci_set_platdata(pd, s3c_hsmmc1_def_platdata);
}
diff --git a/arch/arm/plat-samsung/dev-hsmmc2.c
b/arch/arm/plat-samsung/dev-
hsmmc2.c
index f60aedb..9cede96 100644
--- a/arch/arm/plat-samsung/dev-hsmmc2.c
+++ b/arch/arm/plat-samsung/dev-hsmmc2.c
@@ -59,22 +59,5 @@ struct platform_device s3c_device_hsmmc2 = {
void s3c_sdhci2_set_platdata(struct s3c_sdhci_platdata *pd)
{
- struct s3c_sdhci_platdata *set = s3c_hsmmc2_def_platdata;
-
- set-cd_type = pd-cd_type;
- set-ext_cd_init = pd-ext_cd_init;
- set-ext_cd_cleanup = pd-ext_cd_cleanup;
- set-ext_cd_gpio = pd-ext_cd_gpio;
- set-ext_cd_gpio_invert = pd-ext_cd_gpio_invert;
-
- if (pd-max_width)
- set-max_width = pd-max_width;
- if (pd-cfg_gpio)
- set-cfg_gpio = pd-cfg_gpio;
- if (pd-cfg_card)
- set-cfg_card = pd-cfg_card;
- if (pd-host_caps)
- set-host_caps |= pd-host_caps;
- if (pd-clk_type)
- set-clk_type = pd-clk_type;
+ s3c_sdhci_set_platdata(pd, s3c_hsmmc2_def_platdata);
}
diff --git a/arch/arm/plat-samsung/dev-hsmmc3.c
b/arch/arm/plat-samsung/dev-
hsmmc3.c
index ede776f..0358ef4 100644
--- a/arch/arm/plat-samsung/dev-hsmmc3.c
+++ b/arch/arm/plat-samsung/dev-hsmmc3.c
@@ -62,22 +62,5 @@ struct platform_device s3c_device_hsmmc3 = {
void s3c_sdhci3_set_platdata(struct s3c_sdhci_platdata *pd)
{
- struct s3c_sdhci_platdata *set = s3c_hsmmc3_def_platdata;
-
- set-cd_type = pd-cd_type;
- set-ext_cd_init = pd-ext_cd_init;
- set-ext_cd_cleanup = pd-ext_cd_cleanup;
- set-ext_cd_gpio = pd-ext_cd_gpio;
- set-ext_cd_gpio_invert = pd-ext_cd_gpio_invert;
-
- if (pd-max_width)
- set-max_width = pd-max_width;
- if (pd-cfg_gpio)
- set-cfg_gpio = pd-cfg_gpio;
- if (pd-cfg_card)
- set-cfg_card = pd-cfg_card;
- if (pd-host_caps)
- set-host_caps |= pd-host_caps;
- if (pd-clk_type)
- set-clk_type = pd-clk_type;
+ s3c_sdhci_set_platdata(pd, s3c_hsmmc3_def_platdata);
}
diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-
samsung/include/plat/sdhci.h
index 058e096..20dc81c 100644
--- a/arch/arm/plat-samsung/include/plat/sdhci.h
+++
RE: [PATCH] ARM: S5P64X0: Add the devname for DMA clock
Boojin Kim wrote:
This patch adds devname for DMA clock.
NOTE: This patch should be added after merging new pl330 driver on
dmaengine.
Signed-off-by: Boojin Kim boojin@samsung.com
---
arch/arm/mach-s5p64x0/clock-s5p6440.c |1 +
arch/arm/mach-s5p64x0/clock-s5p6450.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6440.c b/arch/arm/mach-
s5p64x0/clock-s5p6440.c
index c1f548f..c54c65d 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6440.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6440.c
@@ -147,6 +147,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 8),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
diff --git a/arch/arm/mach-s5p64x0/clock-s5p6450.c b/arch/arm/mach-
s5p64x0/clock-s5p6450.c
index 3d9b609..2d04abf 100644
--- a/arch/arm/mach-s5p64x0/clock-s5p6450.c
+++ b/arch/arm/mach-s5p64x0/clock-s5p6450.c
@@ -180,6 +180,7 @@ static struct clk init_clocks_off[] = {
.ctrlbit= (1 3),
}, {
.name = dma,
+ .devname= dma-pl330,
.parent = clk_hclk_low.clk,
.enable = s5p64x0_hclk0_ctrl,
.ctrlbit= (1 12),
--
1.7.1
OK, will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/3] ARM: Samsung: use dma-pl330 device name for clock
Vladimir Zapolskiy wrote: This changeset replaces s3c-pl330.x clock device names with dma-pl330.x, otherwise there won't be a correspondence between clock device name and amba device name, thus clocks can't be enabled. Fixes runtime errors on clk_get() from drivers/dma/pl330.c: dma-pl330 dma-pl330.0: Cannot get operation clock. dma-pl330: probe of dma-pl330.0 failed with error -22 The changes are based on linux-samsung/next/topic-dma-pl330 branch. Vladimir Zapolskiy (3): ARM: EXYNOS4: use dma-pl330 device name for clock ARM: S5PC100: use dma-pl330 device name for clock ARM: S5PV210: use dma-pl330 device name for clock arch/arm/mach-exynos4/clock.c |4 ++-- arch/arm/mach-s5pc100/clock.c |4 ++-- arch/arm/mach-s5pv210/clock.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) -- 1.7.5.1 OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S3C64XX: Remove un-used code
Mark Brown wrote: On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose. Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code. Yes, I agree with your opinion...It was difficult to know why it is un-used code when I applied that. OK, I will amend its commit log in my tree to clear. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S3C64XX: Remove un-used code
Hi Mr. Kim, On Fri, Aug 19, 2011 at 10:59 AM, Kukjin Kim kgene@samsung.com wrote: Mark Brown wrote: On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote: On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote: Remove un-used backlight code for SMDK6410 board Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it. No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose. Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code. Yes, I agree with your opinion...It was difficult to know why it is un-used code when I applied that. Yes, I will explain more in comments in future! OK, I will amend its commit log in my tree to clear. Thank you! Thanks and Regards, Banajit Goswami -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
