Re: Pull Requeset: Exynos4 Register Address Update for Devfreq Drivers.
On Sat, Dec 24, 2011 at 10:58 AM, Kukjin Kim wrote: > As I commented, looks ok to me and will apply patches not pull and since I > didn't get your answer to ask 'topic branch is required for this', I didn't > yet. > > As a note, if there is no reason to create based on not -rc, just use -rc. > > Merry Christmas. > Thanks. > Hello, Having a topic branch for devfreq is fine and I don't care whether there is one or not as long as the required registers are supported. Because the registers added in the patches do not seem to be devfreq specific, I don't think we should have another branch for this. Thus, having the patches in your Exynos' branch is also fine. I'll let future pull-requested branches be rebased on rcX anyway. Thanks. Cheers! Happy new year! - MyungJoo -- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
Hi Kamil,
On 9 December 2011 21:34, Kamil Debski wrote:
> Signed-off-by: Kamil Debski
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> arch/arm/mach-exynos/mach-nuri.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 0afcc3b..176092c 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -171,6 +171,7 @@ config MACH_SMDKV310
> select S5P_DEV_FIMC1
> select S5P_DEV_FIMC2
> select S5P_DEV_FIMC3
> + select S5P_DEV_G2D
Shouldn't this entry be under "config MACH_NURI" instead of MACH_SMDKV310 ?
> select S5P_DEV_I2C_HDMIPHY
> select S5P_DEV_MFC
> select S5P_DEV_TV
> diff --git a/arch/arm/mach-exynos/mach-nuri.c
> b/arch/arm/mach-exynos/mach-nuri.c
> index 236bbe1..5251e91 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[]
> __initdata = {
> &s3c_device_i2c3,
> &i2c9_gpio,
> &s3c_device_adc,
> + &s5p_device_g2d,
> &s3c_device_rtc,
> &s5p_device_mfc,
> &s5p_device_mfc_l,
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: EXYNOS: Adds Samsung TRATS board support
Hi Kukjun Kim, > -Original Message- > From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux-arm-kernel- > boun...@lists.infradead.org] On Behalf Of Kyungmin Park > Sent: Monday, December 26, 2011 8:56 AM > To: Kukjin Kim > Cc: HeungJun, Kim; linux-samsung-soc@vger.kernel.org; arm-linux > Subject: Re: [PATCH] ARM: EXYNOS: Adds Samsung TRATS board support > > On 12/24/11, Kukjin Kim wrote: > > HeungJun, Kim wrote: > >> > >> This patch adds Samsung Mobile TRATS board support. > >> > >> Signed-off-by: HeungJun, Kim > >> Signed-off-by: Kyungmin Park > >> --- > >> arch/arm/mach-exynos/Kconfig | 11 ++ > >> arch/arm/mach-exynos/Makefile |1 + > >> arch/arm/mach-exynos/board-trats.c | 340 > >> > >> 3 files changed, 352 insertions(+), 0 deletions(-) > >> create mode 100644 arch/arm/mach-exynos/board-trats.c > >> > > > > If this is for v3.3, unfortunately, it's a little late to add board file and > > since many things have changed I don't want to cause the conflicts with > > others now. > > > > BTW, why is the name board-xxx not mach-xxx like others? > > It's mentioned several times, > How do you talk with other when talk about the smdk? > "I'm using the smdk machine and it's based on smdk machine?" > As board is more proper word and it's easy to know when find the board > at source code. > So hope to use the board if it's not big deal. If you don't mind, I want to let you know additional information. I also agree with Mr.Park. Generally in the robot field, the term "machine" means the total things including the machinery part and even the brain "board", and the machine is more bigger concept. Probably, in the other field, this confusion will be occurred when they see the linux kernel source first. So, I think these terms might be necessary to distinguish. Thanks and Regards, Heungjun Kim > > BR, > Kyungmin Park > > > >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > >> index 0afcc3b..3bbbef8 100644 > >> --- a/arch/arm/mach-exynos/Kconfig > >> +++ b/arch/arm/mach-exynos/Kconfig > >> @@ -304,6 +304,17 @@ config MACH_ORIGEN > >>help > >> Machine support for ORIGEN based on Samsung EXYNOS4210 > >> > >> +config MACH_TRATS > >> + bool "Mobile TRATS Board" > >> + select CPU_EXYNOS4210 > >> + select S3C_DEV_WDT > >> + select S3C_DEV_HSMMC > >> + select S3C_DEV_I2C5 > >> + select EXYNOS4_SETUP_I2C5 > >> + select EXYNOS4_SETUP_SDHCI > >> + help > >> +Machine support for Samsung Mobile TRATS Board. > >> + > >> comment "EXYNOS4212 Boards" > >> > >> config MACH_SMDK4212 > >> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile > >> index 57e5296..f3bdda9 100644 > >> --- a/arch/arm/mach-exynos/Makefile > >> +++ b/arch/arm/mach-exynos/Makefile > >> @@ -33,6 +33,7 @@ obj-$(CONFIG_MACH_ARMLEX4210)+= mach- > >> armlex4210.o > >> obj-$(CONFIG_MACH_UNIVERSAL_C210) += mach-universal_c210.o > >> obj-$(CONFIG_MACH_NURI) += mach-nuri.o > >> obj-$(CONFIG_MACH_ORIGEN) += mach-origen.o > >> +obj-$(CONFIG_MACH_TRATS) += board-trats.o > >> > >> obj-$(CONFIG_MACH_SMDK4212) += mach-smdk4x12.o > >> obj-$(CONFIG_MACH_SMDK4412) += mach-smdk4x12.o > >> diff --git a/arch/arm/mach-exynos/board-trats.c b/arch/arm/mach- > >> exynos/board-trats.c > >> new file mode 100644 > >> index 000..4c13dfc > >> --- /dev/null > >> +++ b/arch/arm/mach-exynos/board-trats.c > >> @@ -0,0 +1,340 @@ > >> +/* > >> + * linux/arch/arm/mach-exynos4/board-trats.c > >> + * > >> + * Copyright (c) 2011 Samsung Electronics Co., Ltd. > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#include > >> +#include > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +#include > >> + > >> +/* Following are default values for UCON, ULCON and UFCON UART registers > >> */ > >> +#define TRATS_UCON_DEFAULT(S3C2410_UCON_TXILEVEL |\ > >> + S3C2410_UCON_RXILEVEL |\ > >> + S3C2410_UCON_TXIRQMODE | \ > >> + S3C2410_UCON_RXIRQMODE | \ > >> + S3C2410_UCON_RXFIFO_TOI | \ > >> + S3C2443_UCON_RXERR_IRQEN) > >> + > >> +#define TRATS_ULCON_DEFAULT S3C2410_LCON_CS8 > >> + > >> +#define TRATS_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | \ > >> + S5PV210_UFCON_TXTRIG256 | \ > >> + S5PV210_UFCON_RXTRIG256)
Re: [rtc-linux] Re: [PATCH v2 0/4] Implement RTC support for S3C2443/S3C2416/S3C2450
On Fri, 23 Dec 2011 11:43:00 + Mark Brown wrote: > > Who is Andrew and should I include him in the recipients? I only found > > Alessandro Zummo in the MAINTAINERS file for rtc stuff and am lacking any > > comment from the rtc-side until now. > > Andrew Morton. Alessandro hasn't been terribly active for a while now. But I'm still keeping an eye on the patches ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: EXYNOS: Adds Samsung TRATS board support
On 12/24/11, Kukjin Kim wrote:
> HeungJun, Kim wrote:
>>
>> This patch adds Samsung Mobile TRATS board support.
>>
>> Signed-off-by: HeungJun, Kim
>> Signed-off-by: Kyungmin Park
>> ---
>> arch/arm/mach-exynos/Kconfig | 11 ++
>> arch/arm/mach-exynos/Makefile |1 +
>> arch/arm/mach-exynos/board-trats.c | 340
>>
>> 3 files changed, 352 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-exynos/board-trats.c
>>
>
> If this is for v3.3, unfortunately, it's a little late to add board file and
> since many things have changed I don't want to cause the conflicts with
> others now.
>
> BTW, why is the name board-xxx not mach-xxx like others?
It's mentioned several times,
How do you talk with other when talk about the smdk?
"I'm using the smdk machine and it's based on smdk machine?"
As board is more proper word and it's easy to know when find the board
at source code.
So hope to use the board if it's not big deal.
BR,
Kyungmin Park
>
>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>> index 0afcc3b..3bbbef8 100644
>> --- a/arch/arm/mach-exynos/Kconfig
>> +++ b/arch/arm/mach-exynos/Kconfig
>> @@ -304,6 +304,17 @@ config MACH_ORIGEN
>> help
>>Machine support for ORIGEN based on Samsung EXYNOS4210
>>
>> +config MACH_TRATS
>> +bool "Mobile TRATS Board"
>> +select CPU_EXYNOS4210
>> +select S3C_DEV_WDT
>> +select S3C_DEV_HSMMC
>> +select S3C_DEV_I2C5
>> +select EXYNOS4_SETUP_I2C5
>> +select EXYNOS4_SETUP_SDHCI
>> +help
>> + Machine support for Samsung Mobile TRATS Board.
>> +
>> comment "EXYNOS4212 Boards"
>>
>> config MACH_SMDK4212
>> diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
>> index 57e5296..f3bdda9 100644
>> --- a/arch/arm/mach-exynos/Makefile
>> +++ b/arch/arm/mach-exynos/Makefile
>> @@ -33,6 +33,7 @@ obj-$(CONFIG_MACH_ARMLEX4210) += mach-
>> armlex4210.o
>> obj-$(CONFIG_MACH_UNIVERSAL_C210) += mach-universal_c210.o
>> obj-$(CONFIG_MACH_NURI) += mach-nuri.o
>> obj-$(CONFIG_MACH_ORIGEN) += mach-origen.o
>> +obj-$(CONFIG_MACH_TRATS)+= board-trats.o
>>
>> obj-$(CONFIG_MACH_SMDK4212) += mach-smdk4x12.o
>> obj-$(CONFIG_MACH_SMDK4412) += mach-smdk4x12.o
>> diff --git a/arch/arm/mach-exynos/board-trats.c b/arch/arm/mach-
>> exynos/board-trats.c
>> new file mode 100644
>> index 000..4c13dfc
>> --- /dev/null
>> +++ b/arch/arm/mach-exynos/board-trats.c
>> @@ -0,0 +1,340 @@
>> +/*
>> + * linux/arch/arm/mach-exynos4/board-trats.c
>> + *
>> + * Copyright (c) 2011 Samsung Electronics Co., Ltd.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
>> +#include
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#include
>> +
>> +/* Following are default values for UCON, ULCON and UFCON UART registers
>> */
>> +#define TRATS_UCON_DEFAULT (S3C2410_UCON_TXILEVEL |\
>> + S3C2410_UCON_RXILEVEL |\
>> + S3C2410_UCON_TXIRQMODE | \
>> + S3C2410_UCON_RXIRQMODE | \
>> + S3C2410_UCON_RXFIFO_TOI | \
>> + S3C2443_UCON_RXERR_IRQEN)
>> +
>> +#define TRATS_ULCON_DEFAULT S3C2410_LCON_CS8
>> +
>> +#define TRATS_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE | \
>> + S5PV210_UFCON_TXTRIG256 | \
>> + S5PV210_UFCON_RXTRIG256)
>> +
>> +enum fixed_regulator_id {
>> +FIXED_REG_ID_MMC = 0,
>> +};
>> +
>> +static struct s3c2410_uartcfg trats_uartcfgs[] __initdata = {
>> +{
>> +.hwport = 0,
>> +.ucon = TRATS_UCON_DEFAULT,
>> +.ulcon = TRATS_ULCON_DEFAULT,
>> +.ufcon = TRATS_UFCON_DEFAULT,
>> +},
>> +{
>> +.hwport = 1,
>> +.ucon = TRATS_UCON_DEFAULT,
>> +.ulcon = TRATS_ULCON_DEFAULT,
>> +.ufcon = TRATS_UFCON_DEFAULT,
>> +},
>> +{
>> +.hwport = 2,
>> +.ucon = TRATS_UCON_DEFAULT,
>> +.ulcon = TRATS_ULCON_DEFAULT,
>> +.ufcon = TRATS_UFCON_DEFAULT,
>> +},
>> +{
>> +.hwport = 3,
>> +.ucon = TRATS_UCON_DEFAULT,
>> +.ulcon = TRATS_ULCON_DEFAULT,
>> +.ufcon = TRATS_UFCON_DEFAULT,
>> +},
>> +};
>> +
>> +/* eMMC */
>> +static stru
