Re: [PATCH v2 6/6] arm: exynos: removing exynos-drm device registration from non-dt platforms
On Saturday 13 of October 2012 02:12:35 Rahul Sharma wrote: > As exynos-drm is a software device, its registration is moved to the > exynos drm driver. This will provide generic solution for device > registration for dt and non-dt platforms. Corresponding patches are > posted to dri-devel list. > > Signed-off-by: Rahul Sharma > --- > arch/arm/mach-exynos/Makefile |1 - > arch/arm/mach-exynos/dev-drm.c | 29 > arch/arm/mach-exynos/mach-nuri.c > |3 -- > arch/arm/mach-exynos/mach-origen.c |3 -- > arch/arm/mach-exynos/mach-smdk4x12.c |3 -- > arch/arm/mach-exynos/mach-smdkv310.c |3 -- > arch/arm/mach-exynos/mach-universal_c210.c |3 -- > arch/arm/plat-samsung/include/plat/devs.h |2 - > 8 files changed, 0 insertions(+), 47 deletions(-) > delete mode 100644 arch/arm/mach-exynos/dev-drm.c Hmm, shouldn't this patch belong to the series adding registration in the driver? (http://comments.gmane.org/gmane.comp.video.dri.devel/75121) It doesn't look to be directly related to adding dt support for exynos5 hdmi. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/6] dts: exynos: add device tree support for exynos5 hdmiphy
On Saturday 13 of October 2012 02:12:32 Rahul Sharma wrote:
> This patch adds support for device tree based discovery for exynos5
> hdmiphy.
>
> Signed-off-by: Rahul Sharma
> ---
> .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 ++
> arch/arm/boot/dts/exynos5250.dtsi |8
> arch/arm/mach-exynos/mach-exynos5-dt.c |2 ++
> 4 files changed, 32 insertions(+), 0 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
>
> diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
> b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt new file
> mode 100644
> index 000..c4face5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt
> @@ -0,0 +1,12 @@
> +Device-Tree bindings for hdmiphy driver
> +
> +Required properties:
> +- compatible: value should be "samsung,exynos5-hdmiphy".
> +- reg: I2C address of the hdmiphy device.
> +
> +Example:
> +
> + hdmiphy {
> + compatible = "samsung,exynos5-hdmiphy";
> + reg = <0x38>;
> + };
> \ No newline at end of file
Please put a new line at end of file.
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 2a478ab..af9271c
> 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -79,6 +79,16 @@
> status = "disabled";
> };
>
> +i2c@12CE {
Wrong indentation.
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <66000>;
> +
> + hdmiphy {
hdmiphy@38
> + compatible = "samsung,exynos5-hdmiphy";
> + reg = <0x38>;
> + };
> + };
> +
Rest of the patch looks fine.
Best regards,
Tomasz Figa
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/6] dts: exynos: add device tree support for exynos5 hdmi
On Saturday 13 of October 2012 02:12:30 Rahul Sharma wrote:
> This patch adds support for device tree based discovery for exynos5
> hdmi. Hdmi node is also renamed with "exynos5-hdmi".
>
> Signed-off-by: Rahul Sharma
> ---
> .../devicetree/bindings/drm/exynos/hdmi.txt| 22
> arch/arm/boot/dts/exynos5250-smdk5250.dts
> |4 +++ arch/arm/boot/dts/exynos5250.dtsi |6
> + arch/arm/mach-exynos/include/mach/map.h|1 +
> arch/arm/mach-exynos/mach-exynos5-dt.c |2 +
> 5 files changed, 35 insertions(+), 0 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/drm/exynos/hdmi.txt
>
> diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
> b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt new file mode
> 100644
> index 000..8b0fa7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
> @@ -0,0 +1,22 @@
> +Device-Tree bindings for drm hdmi driver
> +
> +Required properties:
> +- compatible: value should be "samsung,exynos5-hdmi".
> +- reg: physical base address of the hdmi and length of memory mapped
> + region.
> +- interrupts: interrupt number to the cpu.
> +- hpd-gpio: following information about the hotplug gpio pin.
> + a) phandle of the gpio controller node.
> + b) pin number within the gpio controller.
> + c) pin function mode.
> + d) optional flags and pull up/down.
> + e) drive strength.
> +
> +Example:
> +
> + hdmi {
> + compatible = "samsung,exynos5-hdmi";
> + reg = <0x1453 0x10>;
> + interrupts = <0 95 0>;
> + hpd-gpio = <&gpx3 7 0xf 1 3>;
> + };
> \ No newline at end of file
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index a352df4..2a478ab
> 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -166,4 +166,8 @@
> spi_2: spi@12d4 {
> status = "disabled";
> };
> +
> + hdmi {
> + hpd-gpio = <&gpx3 7 0xf 1 3>;
> + };
> };
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi index f69e389..eea84a3 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -492,4 +492,10 @@
> #gpio-cells = <4>;
> };
> };
> +
> + hdmi {
I guess it's discussable, but I would follow the convention of adding
@ADDR to every node with reg property.
> + compatible = "samsung,exynos5-hdmi";
> + reg = <0x1453 0x10>;
> + interrupts = <0 95 0>;
> +};
Indentation of the closing bracket looks incorrect.
Rest of the patch looks fine.
Best regards,
Tomasz Figa
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 6/6] arm: exynos: removing exynos-drm device registration from non-dt platforms
On Saturday 13 of October 2012 08:19:30 Rahul Sharma wrote: > Hi Tomasz, > > On Sat, Oct 13, 2012 at 3:42 AM, Tomasz Figa wrote: > > Hi Rahul, > > > > On Friday 12 of October 2012 00:27:47 Rahul Sharma wrote: > >> As exynos-drm is a software device, its registration is moved to the > >> exynos drm driver. This will provide generic solution for device > >> registration for dt and non-dt platforms. Corresponding patches are > >> posted to dri-devel list. > > > > In which patch is exynos drm registration being moved to exynos drm > > driver? > > > > Best regards, > > Tomasz Figa > > Patch set is listed at > http://comments.gmane.org/gmane.comp.video.dri.devel/75121. Thanks. You should list it as a dependency of this series in cover letter to make things clear. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 1/6] dts: exynos: add device tree support for exynos5 hdmi
On Saturday 13 of October 2012 08:15:46 Rahul Sharma wrote:
> Hi Tomasz,
>
> On Sat, Oct 13, 2012 at 3:34 AM, Tomasz Figa
wrote:
> > Hi Rahul,
> >
> > On Friday 12 of October 2012 00:27:42 Rahul Sharma wrote:
> >> This patch adds support for device tree based discovery for exynos5
> >> hdmi. Hdmi node is also renamed with "exynos5-hdmi".
> >>
> >> Signed-off-by: Rahul Sharma
> >> ---
> >>
> >> arch/arm/boot/dts/exynos5250-smdk5250.dts |4
> >> arch/arm/boot/dts/exynos5250.dtsi |7 +++
> >> arch/arm/mach-exynos/include/mach/map.h |1 +
> >> arch/arm/mach-exynos/mach-exynos5-dt.c|2 ++
> >> 4 files changed, 14 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> >> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index a352df4..2a478ab
> >> 100644
> >> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> >> @@ -166,4 +166,8 @@
> >>
> >> spi_2: spi@12d4 {
> >>
> >> status = "disabled";
> >>
> >> };
> >>
> >> +
> >> + hdmi {
> >> + hpd-gpio = <&gpx3 7 0xf 1 3>;
> >> + };
> >>
> >> };
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> >> b/arch/arm/boot/dts/exynos5250.dtsi index f69e389..4e019b5 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -492,4 +492,11 @@
> >>
> >> #gpio-cells = <4>;
> >>
> >> };
> >>
> >> };
> >>
> >> +
> >> + hdmi {
> >
> > hdmi@1453
> >
> >> + compatible = "samsung,exynos5-hdmi";
> >> + reg = <0x1453 0x10>;
> >> + interrupts = <0 95 0>;
> >> + version = "1.4";
> >> +};
> >
> > Is it just me or there is something wrong with indentation of this
> > bracket?
> >
> > Best regards,
> > Tomasz Figa
>
> My understanding was when there are multiple hardware instances of
> same IP, addresses
> are put along with the name like i2c, uart. But when only single hw IP
> is present like
> hdmi, mixer, watchdog, rtc etc address concatenation is optional.
> Please correct me if
> I am wrong. I will do the respective change.
I guess there might be no strict convention on this, but whichever dts
file I look at, it has @addr in any node that contains reg property.
> in V2 patchset "version", "vp-support" properties are dropped and made
> part of driver data
> inside driver. I also added DT binding documentation for new nodes.
>
> I had posted V2 yesterday but not visible on samsung-soc mailing list.
> I will forward you the
> patches.
I can see V2 now on linux-samsung-soc, so I will review it as well.
Best regards,
Tomasz Figa
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/4] DMA: PL330: Fix mem leaks and balance probe/remove
On Fri, Oct 5, 2012 at 3:47 PM, Inderpal Singh wrote: > The first 2 patches of this series fix memory leaks because the memory > allocated for peripheral channels and DMA descriptors were not getting > freed. > > The last 2 patches balance the module's remove function. > > This series depends on "61c6e7531d3b66b3 DMA: PL330: Check the > pointer returned by kzalloc" which is on slave-dma's "fixes" branch. > Hence slave-dma tree's "next" branch was merged with "fixes" and > applied patch at [1] to fix the build error. > > [1] http://permalink.gmane.org/gmane.linux.kernel.next/24274 > > Changes since v1: > - Protect only list_add_tail with spin_locks > - Return EBUSY from remove if channel is in use > - unregister dma_device in remove > > Inderpal Singh (4): > DMA: PL330: Free memory allocated for peripheral channels > DMA: PL330: Change allocation method to properly free DMA > descriptors > DMA: PL330: Balance module remove function with probe > DMA: PL330: unregister dma_device in module's remove function > > drivers/dma/pl330.c | 53 > --- > 1 file changed, 38 insertions(+), 15 deletions(-) > All seem fine. Acked-by: Jassi Brar Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
