Re: [PATCH] [RFC PATCH] dmaengine: pl330: residual - do not reset on last descriptor.
Le mardi 07 juillet 2015 à 14:13 +0200, Alban Browaeys a écrit : Le mardi 07 juillet 2015 à 20:53 +0900, Krzysztof Kozlowski a écrit I am not quite sure what bug you are trying to fix here. It isn't described in commit message. Also I don't get why the residue=0 is being removed. This will break the residue calculation... Some time ago I posted a patch fixing sound issues on Odroid XU3. Today Vinod applied it: https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave -dma.git/commit/?h=fixesid=5dd90e5b91e0f5c925b12b132c7cd2753887025 6 I don't know if this is the same issue... can you describe exactly what you are trying to fix, why and how? This was about choppy sound issue left after the dma pause fix: https://www.mail-archive.com/linux-samsung -soc%40vger.kernel.org/msg44567.html From a glance at the commit you mention I would say it is the same issue. Will try this commit instead in a few hours and report. The commit of yours, that is https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit /?h=fixesid=5dd90e5b91e0f5c925b12b132c7cd2753887025 , fixes Odroid U2/U3 choppy sound too. Thanks. Alban choppy sound) on Odroid XU3-Lite. On current linux-next (next-20150612) the sound is awful (choppy) after few seconds of play. For example first four of: $ aplay /usr/share/sounds/alsa/Front_Right.wav work fine. But then it just gets worse and underruns are reported: $ Playing WAVE '/usr/share/sounds/alsa/Front_Right.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Mono -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths
On 08.07.2015 14:36, Javier Martinez Canillas wrote: A previously defined Device Tree node, can be extended either by defining a node using the same full path or by creating a label for the node and referencing to it. Using full paths is more error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect. A misstyped label on the other hand, will cause a dtc compile error which s/misstyped/mistyped/ makes it easier to detect the mistake since happens at build-time instead. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 ++--- 1 file changed, 799 insertions(+), 801 deletions(-) I didn't look carefully enough to call it a review (I trust the 'diff' of yours) but it seems fine to me: Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] ARM: dts: Include exynos5420-pinctrl after the nodes were defined
On 08.07.2015 14:36, Javier Martinez Canillas wrote: The dtc compiler combines all the defined nodes that have the same path so a device node definition can be in one file and later be extended in another one. That's the case of the Exynos5420 pinctrl device nodes that are defined in the exynos5420.dtsi file and extended in exynos5420-pinctrl.dtsi. But since the exynos5420.dtsi file includes the exynos5420-pinctrl.dtsi before the pinctrl device nodes are actually defined, the definition of the pinctrl device nodes happens in exynos5420-pinctrl.dtsi and are extended in exynos5420.dtsi. That is the opposite of the original intention so even when there is no difference in practice, the exynos5420-pinctrl.dtsi include should be moved at the end of the exynos5420.dtsi file after the pinctrl device nodes have been already defined. This will also allow to later change the exynos5420-pinctrl.dtsi file to use labels instead of full paths to extend the pinctrl nodes. Since keeping the include at the top, would cause a dtc build error due the pinctrl labels not being defined yet. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes
On 08.07.2015 14:36, Javier Martinez Canillas wrote: Hello Kukjin and Krzysztof, This is a trivial series that changes Exynos5 pinctrl dtsi files to extend the pinctrl nodes using labels instead of full paths. Using labels is less error prone since a misstyped label leads to a build error while full paths can lead to the creation of a new node instead of overriding the original which makes the mistake harder to detect. I tested the changes by decompiling the Exynos5* dtbs and comparing before and after. The resulting dts were identical modulo some node ordering due the pinctrl include change. Is the DTB before and after the same? It should not change by re-ordering. Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] ARM: dts: Include exynos5250-pinctrl after the nodes were defined
On 08.07.2015 14:36, Javier Martinez Canillas wrote: The dtc compiler combines all the defined nodes that have the same path so a device node definition can be in one file and later be extended in another one. That's the case of the Exynos5250 pinctrl device nodes that are defined in the exynos5250.dtsi file and extended in exynos5250-pinctrl.dtsi. But since the exynos5250.dtsi file includes the exynos5250-pinctrl.dtsi before the pinctrl device nodes are actually defined, the definition of the pinctrl device nodes happens in exynos5250-pinctrl.dtsi and are extended in exynos5250.dtsi. That is the opposite of the original intention so even when there is no difference in practice, the exynos5250-pinctrl.dtsi include should be moved at the end of the exynos5250.dtsi file after the pinctrl device nodes have been already defined. This will also allow to later change the exynos5250-pinctrl.dtsi file to use labels instead of full paths to extend the pinctrl nodes. Since keeping the include at the top, would cause a dtc build error due the pinctrl labels not being defined yet. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Yeah, I stomped on this too. I left it as is because it is more natural to have all includes at the beginning... but DTSI for Exynos3250 and 4415 already follow such convention and extending by labels is nice too, so overall I agree: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: consistently use int for temperatures
Sascha Hauer writes: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near UINT_MAX for temperatures below 0°C. This will probably immediately shut the machine down due to overtemperature if started below 0°C. 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC is above the melting point of all known materials. Consistently use a plain 'int' for temperatures throughout the thermal code and the drivers. This only changes the places in the drivers where the temperature is passed around as pointer, when drivers internally use another type this is not changed. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Cc: linux...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: Jean Delvare jdelv...@suse.de Cc: Peter Feuerer pe...@piie.net Cc: Heiko Stuebner he...@sntech.de Cc: Lukasz Majewski l.majew...@samsung.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Thierry Reding thierry.red...@gmail.com Cc: linux-a...@vger.kernel.org Cc: platform-driver-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-o...@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: Guenter Roeck li...@roeck-us.net Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Maxime Ripard maxime.rip...@free-electrons.com Cc: Darren Hart dvh...@infradead.org Cc: lm-sens...@lm-sensors.org --- [...] For: drivers/platform/x86/acerhdf.c | 9 drivers/thermal/gov_bang_bang.c| 5 ++-- Reviewed-by: Peter Feuerer pe...@piie.net [...] -- --peter; -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths
Hello Krzysztof, On 07/08/2015 01:29 AM, Krzysztof Kozlowski wrote: On 08.07.2015 14:36, Javier Martinez Canillas wrote: A previously defined Device Tree node, can be extended either by defining a node using the same full path or by creating a label for the node and referencing to it. Using full paths is more error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect. A misstyped label on the other hand, will cause a dtc compile error which s/misstyped/mistyped/ sigh, it's so ironic that I mistyped that. Do you want me to re-post the whole series with the typo fixed or you / Kukjin would fix in both patches when applying? makes it easier to detect the mistake since happens at build-time instead. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 ++--- 1 file changed, 799 insertions(+), 801 deletions(-) I didn't look carefully enough to call it a review (I trust the 'diff' of yours) but it seems fine to me: Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com Thanks a lot for. Best regards, Krzysztof Best regards, -- Javier Martinez Canillas Sr. Linux Kernel Developer Open Source Group Samsung Research America -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/10] i2c/drm: fix i2c adapter device driver user counter
The 01/10 change adds and exports new of_get_i2c_adapter_by_node() interface of i2c core, the rest of patches fix current users of of_find_i2c_adapter_by_node() interface. of_find_i2c_adapter_by_node() call requires quite often missing put_device(), and i2c_put_adapter() releases a device locked by i2c_get_adapter() only. In general module_put(adapter-owner) and put_device(dev) are not interchangeable. This is a common error reproduction scenario as a result of the misusage described above (this is run on iMX6 platform with HDMI and I2C bus drivers compiled as kernel modules for clearness): root@mx6q:~# lsmod | grep i2c i2c_imx10213 0 root@mx6q:~# lsmod | grep dw_hdmi_imx dw_hdmi_imx 3631 0 dw_hdmi11846 1 dw_hdmi_imx imxdrm 8674 3 dw_hdmi_imx,imx_ipuv3_crtc,imx_ldb drm_kms_helper113765 5 dw_hdmi,imxdrm,imx_ipuv3_crtc,imx_ldb root@mx6q:~# rmmod dw_hdmi_imx root@mx6q:~# lsmod | grep i2c i2c_imx10213 -1 ^ root@mx6q:~# rmmod i2c_imx rmmod: ERROR: Module i2c_imx is in use To fix existing users of these interfaces and to avoid any further confusion and misusage in future, add one more interface of_get_i2c_adapter_by_node(), it is similar to i2c_get_adapter() in sense that an I2C bus device driver found and locked by user can be correctly unlocked by i2c_put_adapter(). Mainly the change concerns DRM users of I2C bus device. The change is based on torvalds/master branch, d6ac4ffc61a RFC of the 01/10 change is http://www.spinics.net/lists/linux-i2c/msg20257.html Vladimir Zapolskiy (10): i2c: add and export of_get_i2c_adapter_by_node() interface drm: dw_hdmi: use of_get_i2c_adapter_by_node interface drm: exynos_hdmi: use of_get_i2c_adapter_by_node interface drm: imx-tve: use of_get_i2c_adapter_by_node interface drm: panel-simple: use of_get_i2c_adapter_by_node interface drm: sti_hdmi: use of_get_i2c_adapter_by_node interface drm: tegra: use of_get_i2c_adapter_by_node interface drm: tilcdc: use of_get_i2c_adapter_by_node interface fbdev: omap2: connector-dvi: use of_get_i2c_adapter_by_node interface i2c: i2c-arb-gpio-challenge: use of_get_i2c_adapter_by_node interface drivers/gpu/drm/bridge/dw_hdmi.c | 14 -- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 +-- drivers/gpu/drm/imx/imx-tve.c | 56 +++--- drivers/gpu/drm/panel/panel-simple.c | 9 ++-- drivers/gpu/drm/sti/sti_hdmi.c | 19 +++- drivers/gpu/drm/tegra/output.c | 19 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 +-- drivers/i2c/i2c-core.c | 20 drivers/i2c/muxes/i2c-arb-gpio-challenge.c | 3 +- .../video/fbdev/omap2/displays-new/connector-dvi.c | 2 +- include/linux/i2c.h| 6 +++ 11 files changed, 104 insertions(+), 57 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 03/10] drm: exynos_hdmi: use of_get_i2c_adapter_by_node interface
This change is needed to properly lock I2C bus driver, which serves DDC.
On release of_get_i2c_adapter_by_node() requires i2c_put_adapter() call,
which replaces put_device(). By the way added of_node_put(ddc_node) to
eliminate memory leak, if OF_DYNAMIC is enabled.
Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 99e2864..399eff9 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -2407,7 +2407,8 @@ static int hdmi_probe(struct platform_device *pdev)
}
out_get_ddc_adpt:
- hdata-ddc_adpt = of_find_i2c_adapter_by_node(ddc_node);
+ hdata-ddc_adpt = of_get_i2c_adapter_by_node(ddc_node);
+ of_node_put(ddc_node);
if (!hdata-ddc_adpt) {
DRM_ERROR(Failed to get ddc i2c adapter by node\n);
return -EPROBE_DEFER;
@@ -2485,7 +2486,7 @@ err_hdmiphy:
if (hdata-hdmiphy_port)
put_device(hdata-hdmiphy_port-dev);
err_ddc:
- put_device(hdata-ddc_adpt-dev);
+ i2c_put_adapter(hdata-ddc_adpt);
return ret;
}
@@ -2501,7 +2502,7 @@ static int hdmi_remove(struct platform_device *pdev)
if (hdata-hdmiphy_port)
put_device(hdata-hdmiphy_port-dev);
- put_device(hdata-ddc_adpt-dev);
+ i2c_put_adapter(hdata-ddc_adpt);
pm_runtime_disable(pdev-dev);
component_del(pdev-dev, hdmi_component_ops);
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes
Krzysztof, On 07/08/2015 01:27 AM, Krzysztof Kozlowski wrote: On 08.07.2015 14:36, Javier Martinez Canillas wrote: Hello Kukjin and Krzysztof, This is a trivial series that changes Exynos5 pinctrl dtsi files to extend the pinctrl nodes using labels instead of full paths. Using labels is less error prone since a misstyped label leads to a build error while full paths can lead to the creation of a new node instead of overriding the original which makes the mistake harder to detect. I tested the changes by decompiling the Exynos5* dtbs and comparing before and after. The resulting dts were identical modulo some node ordering due the pinctrl include change. Is the DTB before and after the same? It should not change by re-ordering. The DTB differ but I'm not that familiar with how dtc represents the FDT to know what is changing in the binary. But as mentioned, the decompiled DTS only changes in which position the pinctrl are defined and both DTS are identical if I do: $ cat decompiled.dts | sort Best regards, Krzysztof -- Javier Martinez Canillas Sr. Linux Kernel Developer Open Source Group Samsung Research America -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] arm:irqchip: IRQCHIP_DECLARE macro is now accessible
* Krzysztof Kozlowski k.kozlow...@samsung.com [150707 16:49]: On 08.07.2015 05:02, Joel Porquet wrote: The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h', making it globally accessible. See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d (irqchip: Move IRQCHIP_DECLARE macro to include/linux/irqchip.h). This patch adds inclusions of 'include/linux/irqchip.h' and replaces uses of macro OF_DECLARE_2 with IRQCHIP_DECLARE. Signed-off-by: Joel Porquet j...@porquet.org --- arch/arm/mach-exynos/suspend.c | 3 ++- arch/arm/mach-imx/gpc.c | 7 ++- arch/arm/mach-omap2/omap-wakeupgen.c | 7 ++- 3 files changed, 6 insertions(+), 11 deletions(-) For Exynos: Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com For omap changes: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: multi_v7_defconfig: Remove old Samsung USB PHY configs
The old drivers/usb/phy/phy-samsung-usb{2,3} are now deleted since
were replaced by newers drivers that use the Generic PHY framework
but their Kconfig options were left over in multi_v7_defconfig.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
arch/arm/configs/multi_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/multi_v7_defconfig
b/arch/arm/configs/multi_v7_defconfig
index 77f4b76d16e9..e3fdc3dd02f6 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -493,8 +493,6 @@ CONFIG_USB_CHIPIDEA_HOST=y
CONFIG_AB8500_USB=y
CONFIG_KEYSTONE_USB_PHY=y
CONFIG_OMAP_USB3=y
-CONFIG_SAMSUNG_USB2PHY=y
-CONFIG_SAMSUNG_USB3PHY=y
CONFIG_USB_GPIO_VBUS=y
CONFIG_USB_ISP1301=y
CONFIG_USB_MXS_PHY=y
--
2.4.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths
On 08.07.2015 23:05, Javier Martinez Canillas wrote: Hello Krzysztof, On 07/08/2015 01:29 AM, Krzysztof Kozlowski wrote: On 08.07.2015 14:36, Javier Martinez Canillas wrote: A previously defined Device Tree node, can be extended either by defining a node using the same full path or by creating a label for the node and referencing to it. Using full paths is more error prone since if there was a typo error, a new node will be created instead of extending the node as it was desired. This will lead to run-time errors that could be hard to detect. A misstyped label on the other hand, will cause a dtc compile error which s/misstyped/mistyped/ sigh, it's so ironic that I mistyped that. Do you want me to re-post the whole series with the typo fixed or you / Kukjin would fix in both patches when applying? I'll fix it when applying to my tree. As for Kukjin, it depends whether he will pick it up from LKML or from me. Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes
On 08.07.2015 23:15, Javier Martinez Canillas wrote: Krzysztof, On 07/08/2015 01:27 AM, Krzysztof Kozlowski wrote: On 08.07.2015 14:36, Javier Martinez Canillas wrote: Hello Kukjin and Krzysztof, This is a trivial series that changes Exynos5 pinctrl dtsi files to extend the pinctrl nodes using labels instead of full paths. Using labels is less error prone since a misstyped label leads to a build error while full paths can lead to the creation of a new node instead of overriding the original which makes the mistake harder to detect. I tested the changes by decompiling the Exynos5* dtbs and comparing before and after. The resulting dts were identical modulo some node ordering due the pinctrl include change. Is the DTB before and after the same? It should not change by re-ordering. The DTB differ but I'm not that familiar with how dtc represents the FDT to know what is changing in the binary. But as mentioned, the decompiled DTS only changes in which position the pinctrl are defined and both DTS are identical if I do: $ cat decompiled.dts | sort Right, the DTB may differ because of change of definition's location. If sorting fixes this then I'm convinced. Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: multi_v7_defconfig: Remove old Samsung USB PHY configs
On 09.07.2015 07:40, Javier Martinez Canillas wrote:
The old drivers/usb/phy/phy-samsung-usb{2,3} are now deleted since
were replaced by newers drivers that use the Generic PHY framework
s/newers/newer/
(this can be fixed when applying)
but their Kconfig options were left over in multi_v7_defconfig.
Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com
---
arch/arm/configs/multi_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] clk: exynos4: Fix wrong clock for Exynos4x12 ADC
2015-07-06 14:12 GMT+09:00 Tomasz Figa tomasz.f...@gmail.com: 2015-07-06 13:03 GMT+09:00 Krzysztof Kozlowski k.kozlow...@samsung.com: 2015-06-12 14:46 GMT+09:00 Javier Martinez Canillas jav...@dowhile0.org: Hello Krzysztof, On Fri, Jun 12, 2015 at 3:53 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: The TSADC gate clock was used in Exynos4x12 DTSI for exynos-adc driver. However TSADC is present only on Exynos4210 so on Trats2 board (with Exynos4412 SoC) the exynos-adc driver could not be probed: ERROR: could not get clock /adc@126C:adc(0) exynos-adc 126c.adc: failed getting clock, err = -2 exynos-adc: probe of 126c.adc failed with error -2 Instead on Exynos4x12 SoCs the main clock used by Analog to Digital Converter is located in different register and it is named in datasheet as PCLK_ADC. Regardless of the name the purpose of this PCLK_ADC clock is the same as purpose of TSADC from Exynos4210. The patch adds gate clock for Exynos4x12 using the proper register so backward compatibility is preserved. This fixes the probe of exynos-adc driver on Exynos4x12 boards and allows accessing sensors connected to it on Trats2 board (ntc,ncp15wb473 AP and battery thermistors). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org Fixes: c63c57433003 (ARM: dts: Add ADC's dt data to read raw data for exynos4x12) Link: https://lkml.org/lkml/2015/6/11/85 --- Changes since v1: 1. After discussion on LKML this solution was chosen because it smaller, simpler, self-contained (one patch to fix issue) and maintains backward compatibility. Thanks to Javier Martinez Canillas and Tomasz Figa for valuable comments. 2. Dropped patch 2/2 because now it is not needed. The clock id TSADC will be used on all Exynos4 boards. 3. Added CC-stable. --- drivers/clk/samsung/clk-exynos4.c | 2 ++ 1 file changed, 2 insertions(+) Patch looks good to me. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Hi Tomasz and Sylwester, Any comments on this version of patch? Tomasz, you gave me comments on previous version. Are their satisfied? Acked-by: Tomasz Figa tomasz.f...@gmail.com Thanks for ack. Sylwester, are you gonna to pick it up or this should go through other tree? Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
