Re: [PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND
On 06/01/2013 08:27 PM, Sylwester Nawrocki wrote: > On 05/27/2013 12:57 PM, Chen Gang wrote: >> >> When randconfig with MMU for arm s5pv210 (and select all cpu type), >> need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: >> >>arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': >>arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to >> `cpu_resume' >> >> >> Signed-off-by: Chen Gang >> --- >> arch/arm/plat-samsung/Kconfig |1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/plat-samsung/Kconfig >> b/arch/arm/plat-samsung/Kconfig >> index f8ed2de..b388d93 100644 >> --- a/arch/arm/plat-samsung/Kconfig >> +++ b/arch/arm/plat-samsung/Kconfig >> @@ -483,6 +483,7 @@ config S5P_PM >> >> config S5P_SLEEP >> bool >> +select ARM_CPU_SUSPEND if PM >> help >> Internal config node to apply common S5P sleep management code. >> Can be selected by S5P and newer SoCs with similar sleep >> procedure. > > We have discussed this about two months ago [1] and the conclusion was > to also > remove "select ARM_CPU_SUSPEND if PM" line from > arch/arm/mach-exynos/Kconfig. > It is still unresolved then, I'm getting similar linker errors with > s3c2410_defconfig... > I do not think they are the same. This patch says: S5P_SLEEP need ARM_CPU_SUSPEND, or can not pass compiling (S5P_SLEEP need some functions in ARM_CPU_SUSPEND). Your patch means PLAT_SAMSUNG need ARM_CPU_SUSPEND, but in fact, PLAT_SAMSUNG may not need ARM_CPU_SUSPEND. > LD init/built-in.o > arch/arm/mach-s3c24xx/built-in.o: In function `s3c_cpu_resume': > /home/snawrocki/linux/media_tree/arch/arm/mach-s3c24xx/sleep.S:83: > undefined reference to `cpu_resume' > arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': > /home/snawrocki/linux/media_tree/arch/arm/plat-samsung/pm.c:305: > undefined reference to `cpu_suspend' > make: *** [vmlinux] Error 1 > > I guess, this error output means S5P_SLEEP and PM need ARM_CPU_SUSPEND (which has the implementation of 'cpu_resume' and 'cpu_suspend') Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND
When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume' Signed-off-by: Chen Gang --- arch/arm/plat-samsung/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index f8ed2de..b388d93 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -483,6 +483,7 @@ config S5P_PM config S5P_SLEEP bool + select ARM_CPU_SUSPEND if PM help Internal config node to apply common S5P sleep management code. Can be selected by S5P and newer SoCs with similar sleep procedure. -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
On 05/27/2013 06:12 PM, Kukjin Kim wrote: >>> config S5P_SLEEP >>> > > bool >>> > > + select ARM_CPU_SUSPEND > Probably, > > + select ARM_CPU_SUSPEND if PM ? > > selecting the S5P_SLEEP depends on PM though... After reference another platform, they are really all "select ARM_CPU_SUSPEND if PM", we'd really better to follow by to let readers easy understanding. I will send patch v2. Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
Hello Maintainers: Please help check this patch whether OK, when you have time. Thanks. On 05/20/2013 04:54 PM, Chen Gang wrote: > > When randconfig with MMU for arm s5pv210 (and select all cpu type), > need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: > > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': > arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume' > > > Signed-off-by: Chen Gang > --- > arch/arm/plat-samsung/Kconfig |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index f8ed2de..1d38541 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -483,6 +483,7 @@ config S5P_PM > > config S5P_SLEEP > bool > + select ARM_CPU_SUSPEND > help > Internal config node to apply common S5P sleep management code. > Can be selected by S5P and newer SoCs with similar sleep procedure. > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume' Signed-off-by: Chen Gang --- arch/arm/plat-samsung/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index f8ed2de..1d38541 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -483,6 +483,7 @@ config S5P_PM config S5P_SLEEP bool + select ARM_CPU_SUSPEND help Internal config node to apply common S5P sleep management code. Can be selected by S5P and newer SoCs with similar sleep procedure. -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y
On 2013年04月24日 20:09, Rafael J. Wysocki wrote: > On Wednesday, April 24, 2013 04:40:38 PM Viresh Kumar wrote: >> > On Wed, Apr 24, 2013 at 4:34 PM, Chen Gang wrote: >>> > > >>> > > For arm S5pv210 with allmodconfig, ARM_S5PV210_CPUFREQ need >>> > > CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue. >>> > > >>> > > The related operation: >>> > > + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o >>> > > .tmp_vmlinux1 -T /root/linux-next/arch/arm/kernel/vmlinux.lds >>> > > arch/arm/kernel/head.o init/built-in.o --start-group usr/built-in.o >>> > > arch/arm/nwfpe/built-in.o arch/arm/vfp/built-in.o >>> > > arch/arm/kernel/built-in.o arch/arm/mm/built-in.o >>> > > arch/arm/common/built-in.o arch/arm/net/built-in.o >>> > > arch/arm/crypto/built-in.o arch/arm/mach-s5pv210/built-in.o >>> > > arch/arm/plat-samsung/built-in.o kernel/built-in.o mm/built-in.o >>> > > fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o >>> > > block/built-in.o arch/arm/lib/lib.a lib/lib.a arch/arm/lib/built-in.o >>> > > lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o >>> > > net/built-in.o --end-group >>> > > >>> > > The related errors: >>> > > drivers/built-in.o: In function `s5pv210_target': >>> > > drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to >>> > > `cpufreq_frequency_table_target' >>> > > drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to >>> > > `cpufreq_frequency_table_target' >>> > > drivers/built-in.o: In function `s5pv210_verify_speed': >>> > > drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to >>> > > `cpufreq_frequency_table_verify' >>> > > drivers/built-in.o: In function `s5pv210_cpu_init': >>> > > drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to >>> > > `cpufreq_frequency_table_get_attr' >>> > > drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to >>> > > `cpufreq_frequency_table_cpuinfo' >>> > > make: *** [vmlinux] Error 1 >>> > > >>> > > Signed-off-by: Chen Gang >>> > > --- >>> > > drivers/cpufreq/Kconfig.arm |1 + >>> > > 1 files changed, 1 insertions(+), 0 deletions(-) >>> > > >>> > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm >>> > > index bce2195..bbcd719 100644 >>> > > --- a/drivers/cpufreq/Kconfig.arm >>> > > +++ b/drivers/cpufreq/Kconfig.arm >>> > > @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ >>> > > config ARM_S5PV210_CPUFREQ >>> > > bool "Samsung S5PV210 and S5PC110" >>> > > depends on CPU_S5PV210 >>> > > + select CPU_FREQ_TABLE >> > >> > Acked-by: Viresh Kumar > Applied. > > Thanks, > Rafael Thanks, too. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.
On 2013年04月25日 01:59, Jean-Christophe PLAGNIOL-VILLARD wrote: > On Apr 25, 2013, at 1:46 AM, Russell King - ARM Linux > wrote: > >> > On Wed, Apr 24, 2013 at 12:20:24PM +0800, Chen Gang wrote: >>> >> If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, >>> >> but in fact, only AT91X40 need ARM7TDMI, so need not let them visible. >> > >> > I'll apply it myself this evening. Can I add: >> > >> > Tested-by: Chen Gang > you add it mine too > > Tested-by: Jean-Christophe PLAGNIOL-VILLARD Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.
On 2013年04月25日 01:46, Russell King - ARM Linux wrote: > On Wed, Apr 24, 2013 at 12:20:24PM +0800, Chen Gang wrote: >> > If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, >> > but in fact, only AT91X40 need ARM7TDMI, so need not let them visible. > I'll apply it myself this evening. Can I add: > > Tested-by: Chen Gang > > to it? > > Ok, thanks. this patch is really provided by you (Arnd also provided the same patch, but it seems a little later than you). And I really only reported and tested it. And next, I should continue to find and make another patches for ARM. Thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y
On 2013年04月24日 19:10, Viresh Kumar wrote: > On Wed, Apr 24, 2013 at 4:34 PM, Chen Gang wrote: >> > >> > For arm S5pv210 with allmodconfig, ARM_S5PV210_CPUFREQ need >> > CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue. >> > >> > The related operation: >> > + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_vmlinux1 >> > -T /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kernel/head.o >> > init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/built-in.o >> > arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm/built-in.o >> > arch/arm/common/built-in.o arch/arm/net/built-in.o >> > arch/arm/crypto/built-in.o arch/arm/mach-s5pv210/built-in.o >> > arch/arm/plat-samsung/built-in.o kernel/built-in.o mm/built-in.o >> > fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o >> > block/built-in.o arch/arm/lib/lib.a lib/lib.a arch/arm/lib/built-in.o >> > lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o >> > net/built-in.o --end-group >> > >> > The related errors: >> > drivers/built-in.o: In function `s5pv210_target': >> > drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to >> > `cpufreq_frequency_table_target' >> > drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to >> > `cpufreq_frequency_table_target' >> > drivers/built-in.o: In function `s5pv210_verify_speed': >> > drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to >> > `cpufreq_frequency_table_verify' >> > drivers/built-in.o: In function `s5pv210_cpu_init': >> > drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to >> > `cpufreq_frequency_table_get_attr' >> > drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to >> > `cpufreq_frequency_table_cpuinfo' >> > make: *** [vmlinux] Error 1 >> > >> > Signed-off-by: Chen Gang >> > --- >> > drivers/cpufreq/Kconfig.arm |1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm >> > index bce2195..bbcd719 100644 >> > --- a/drivers/cpufreq/Kconfig.arm >> > +++ b/drivers/cpufreq/Kconfig.arm >> > @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ >> > config ARM_S5PV210_CPUFREQ >> > bool "Samsung S5PV210 and S5PC110" >> > depends on CPU_S5PV210 >> > + select CPU_FREQ_TABLE > Acked-by: Viresh Kumar > > Thank you very much. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y
For arm S5pv210 with allmodconfig, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue. The related operation: + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_vmlinux1 -T /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kernel/head.o init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/built-in.o arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm/built-in.o arch/arm/common/built-in.o arch/arm/net/built-in.o arch/arm/crypto/built-in.o arch/arm/mach-s5pv210/built-in.o arch/arm/plat-samsung/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o block/built-in.o arch/arm/lib/lib.a lib/lib.a arch/arm/lib/built-in.o lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o net/built-in.o --end-group The related errors: drivers/built-in.o: In function `s5pv210_target': drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to `cpufreq_frequency_table_target' drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to `cpufreq_frequency_table_target' drivers/built-in.o: In function `s5pv210_verify_speed': drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to `cpufreq_frequency_table_verify' drivers/built-in.o: In function `s5pv210_cpu_init': drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to `cpufreq_frequency_table_get_attr' drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to `cpufreq_frequency_table_cpuinfo' make: *** [vmlinux] Error 1 Signed-off-by: Chen Gang --- drivers/cpufreq/Kconfig.arm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index bce2195..bbcd719 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ config ARM_S5PV210_CPUFREQ bool "Samsung S5PV210 and S5PC110" depends on CPU_S5PV210 + select CPU_FREQ_TABLE default y help This adds the CPUFreq driver for Samsung S5PV210 and -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5pv210: compiling issue, ARM_S3C64XX_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y
Oh, sorry, the subject and the comment is incorrect: it need use ARM_S5PV210_CPUFREQ instead of ARM_S3C64XX_CPUFREQ. I need send patch v2. On 2013年04月24日 18:35, Chen Gang wrote: > > For arm S5pv210 with allmodconfig, ARM_S3C64XX_CPUFREQ need > CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue. > > The related operation: > + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_vmlinux1 -T > /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kernel/head.o > init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/built-in.o > arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm/built-in.o > arch/arm/common/built-in.o arch/arm/net/built-in.o arch/arm/crypto/built-in.o > arch/arm/mach-s5pv210/built-in.o arch/arm/plat-samsung/built-in.o > kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o > security/built-in.o crypto/built-in.o block/built-in.o arch/arm/lib/lib.a > lib/lib.a arch/arm/lib/built-in.o lib/built-in.o drivers/built-in.o > sound/built-in.o firmware/built-in.o net/built-in.o --end-group > > The related errors: > drivers/built-in.o: In function `s5pv210_target': > drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to > `cpufreq_frequency_table_target' > drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to > `cpufreq_frequency_table_target' > drivers/built-in.o: In function `s5pv210_verify_speed': > drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to > `cpufreq_frequency_table_verify' > drivers/built-in.o: In function `s5pv210_cpu_init': > drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to > `cpufreq_frequency_table_get_attr' > drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to > `cpufreq_frequency_table_cpuinfo' > make: *** [vmlinux] Error 1 > > Signed-off-by: Chen Gang > --- > drivers/cpufreq/Kconfig.arm |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index bce2195..bbcd719 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ > config ARM_S5PV210_CPUFREQ > bool "Samsung S5PV210 and S5PC110" > depends on CPU_S5PV210 > + select CPU_FREQ_TABLE > default y > help > This adds the CPUFreq driver for Samsung S5PV210 and > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: S5pv210: compiling issue, ARM_S3C64XX_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y
For arm S5pv210 with allmodconfig, ARM_S3C64XX_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y, or will cause compiling issue. The related operation: + arm-linux-gnu-ld -EL -p --no-undefined -X --build-id -X -o .tmp_vmlinux1 -T /root/linux-next/arch/arm/kernel/vmlinux.lds arch/arm/kernel/head.o init/built-in.o --start-group usr/built-in.o arch/arm/nwfpe/built-in.o arch/arm/vfp/built-in.o arch/arm/kernel/built-in.o arch/arm/mm/built-in.o arch/arm/common/built-in.o arch/arm/net/built-in.o arch/arm/crypto/built-in.o arch/arm/mach-s5pv210/built-in.o arch/arm/plat-samsung/built-in.o kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o block/built-in.o arch/arm/lib/lib.a lib/lib.a arch/arm/lib/built-in.o lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o net/built-in.o --end-group The related errors: drivers/built-in.o: In function `s5pv210_target': drivers/cpufreq/s5pv210-cpufreq.c:225: undefined reference to `cpufreq_frequency_table_target' drivers/cpufreq/s5pv210-cpufreq.c:237: undefined reference to `cpufreq_frequency_table_target' drivers/built-in.o: In function `s5pv210_verify_speed': drivers/cpufreq/s5pv210-cpufreq.c:182: undefined reference to `cpufreq_frequency_table_verify' drivers/built-in.o: In function `s5pv210_cpu_init': drivers/cpufreq/s5pv210-cpufreq.c:556: undefined reference to `cpufreq_frequency_table_get_attr' drivers/cpufreq/s5pv210-cpufreq.c:560: undefined reference to `cpufreq_frequency_table_cpuinfo' make: *** [vmlinux] Error 1 Signed-off-by: Chen Gang --- drivers/cpufreq/Kconfig.arm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index bce2195..bbcd719 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -187,6 +187,7 @@ config ARM_S3C64XX_CPUFREQ config ARM_S5PV210_CPUFREQ bool "Samsung S5PV210 and S5PC110" depends on CPU_S5PV210 + select CPU_FREQ_TABLE default y help This adds the CPUFreq driver for Samsung S5PV210 and -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.
If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, but in fact, only AT91X40 need ARM7TDMI, so need not let them visible. Signed-off-by: Chen Gang --- arch/arm/mach-at91/Kconfig.non_dt |1 + arch/arm/mm/Kconfig |4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-at91/Kconfig.non_dt b/arch/arm/mach-at91/Kconfig.non_dt index 6c24985..dc972e1 100644 --- a/arch/arm/mach-at91/Kconfig.non_dt +++ b/arch/arm/mach-at91/Kconfig.non_dt @@ -47,6 +47,7 @@ config ARCH_AT91X40 select ARCH_USES_GETTIMEOFFSET select MULTI_IRQ_HANDLER select SPARSE_IRQ + select CPU_ARM7TDMI endchoice diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 9e8101e..3397d05 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -6,7 +6,7 @@ comment "Processor Type" # ARM7TDMI config CPU_ARM7TDMI - bool "Support ARM7TDMI processor" + bool depends on !MMU select CPU_32v4T select CPU_ABRT_LV4T @@ -56,7 +56,7 @@ config CPU_ARM740T # ARM9TDMI config CPU_ARM9TDMI - bool "Support ARM9TDMI processor" + bool depends on !MMU select CPU_32v4T select CPU_ABRT_NOMMU -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.
Oh, sorry, I forgot to disable word wrap, I should send patch v2 again. For this patch itself, I just copy it from Russell's and Arnd's, and want it to be applied. On 2013年04月24日 12:12, Chen Gang wrote: > > If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, > but in fact, only AT91X40 need ARM7TDMI, so not need let them visible. > > Signed-off-by: Chen Gang > --- > arch/arm/mach-at91/Kconfig.non_dt |1 + > arch/arm/mm/Kconfig |4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-at91/Kconfig.non_dt > b/arch/arm/mach-at91/Kconfig.non_dt > index 6c24985..dc972e1 100644 > --- a/arch/arm/mach-at91/Kconfig.non_dt > +++ b/arch/arm/mach-at91/Kconfig.non_dt > @@ -47,6 +47,7 @@ config ARCH_AT91X40 > select ARCH_USES_GETTIMEOFFSET > select MULTI_IRQ_HANDLER > select SPARSE_IRQ > + select CPU_ARM7TDMI > > endchoice > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index 9e8101e..3397d05 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -6,7 +6,7 @@ comment "Processor Type" > > # ARM7TDMI > config CPU_ARM7TDMI > - bool "Support ARM7TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_LV4T > @@ -56,7 +56,7 @@ config CPU_ARM740T > > # ARM9TDMI > config CPU_ARM9TDMI > - bool "Support ARM9TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_NOMMU > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: Kconfig: let ARM9TDMI and ARM7TDMI invisible.
If CONFIG_MMU is disabled, it will let ARM9TDMI and ARM7TDMI visible, but in fact, only AT91X40 need ARM7TDMI, so not need let them visible. Signed-off-by: Chen Gang --- arch/arm/mach-at91/Kconfig.non_dt |1 + arch/arm/mm/Kconfig |4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-at91/Kconfig.non_dt b/arch/arm/mach-at91/Kconfig.non_dt index 6c24985..dc972e1 100644 --- a/arch/arm/mach-at91/Kconfig.non_dt +++ b/arch/arm/mach-at91/Kconfig.non_dt @@ -47,6 +47,7 @@ config ARCH_AT91X40 select ARCH_USES_GETTIMEOFFSET select MULTI_IRQ_HANDLER select SPARSE_IRQ + select CPU_ARM7TDMI endchoice diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 9e8101e..3397d05 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -6,7 +6,7 @@ comment "Processor Type" # ARM7TDMI config CPU_ARM7TDMI - bool "Support ARM7TDMI processor" + bool depends on !MMU select CPU_32v4T select CPU_ABRT_LV4T @@ -56,7 +56,7 @@ config CPU_ARM740T # ARM9TDMI config CPU_ARM9TDMI - bool "Support ARM9TDMI processor" + bool depends on !MMU select CPU_32v4T select CPU_ABRT_NOMMU -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月17日 18:02, Russell King - ARM Linux wrote: > On Wed, Apr 17, 2013 at 05:25:34PM +0800, Chen Gang wrote: >> CONFIG_CPU_ARM7TDMI=y >> CONFIG_CPU_ARM9TDMI=y >> CONFIG_CPU_V7=y >> CONFIG_CPU_32v4T=y >> CONFIG_CPU_32v6K=y >> CONFIG_CPU_32v7=y > > This is an invalid configuration. A single kernel can not support ARMv7 > and ARMv4T simultaneously. > > The problem is caused by MMU=n, which exposes the CPU_ARM7TDMI and > CPU_ARM9TDMI options, which in turn select 32v4T. This is in turn > caused by the incomplete integration of uclinux. > > I think the only thing which can be done is to remove the ARM9TDMI > support code, which doesn't seem to be used by anything, and adjust > ARM7TDMI so that it isn't visible, but is selected by ARCH_AT91X40 > (which seems to be its only user.) > > Here's the slightly smaller version of that: > I apply your patch below. and also let CONFIG_MMU=y in menuconfig (just Arnd suggested). it passes compilation. I prefer to let the patch below to integrate into next-tree. if I should do it (e.g. need send the patch again in normal way), I should try. thanks. gchen. > diff --git a/arch/arm/mach-at91/Kconfig.non_dt > b/arch/arm/mach-at91/Kconfig.non_dt > index 6c24985..dc972e1 100644 > --- a/arch/arm/mach-at91/Kconfig.non_dt > +++ b/arch/arm/mach-at91/Kconfig.non_dt > @@ -47,6 +47,7 @@ config ARCH_AT91X40 > select ARCH_USES_GETTIMEOFFSET > select MULTI_IRQ_HANDLER > select SPARSE_IRQ > + select CPU_ARM7TDMI > > endchoice > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index cb812a1..deb6c6a 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -6,7 +6,7 @@ comment "Processor Type" > > # ARM7TDMI > config CPU_ARM7TDMI > - bool "Support ARM7TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_LV4T > @@ -56,7 +56,7 @@ config CPU_ARM740T > > # ARM9TDMI > config CPU_ARM9TDMI > - bool "Support ARM9TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_NOMMU > > > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月17日 19:02, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:53 Wed 17 Apr , Arnd Bergmann wrote:
>> On Wednesday 17 April 2013, Will Deacon wrote:
>>>> arm-linux-gnu-gcc -Wp,-MD,arch/arm/vfp/.vfphw.o.d -nostdinc -isystem
>>>> /usr/lib/gcc/arm-linux-gnueabi/4.7.1/include
>>>> -I/root/linux-next/arch/arm/include -Iarch/arm/include/generated
>>>> -Iinclude -I/root/linux-next/arch/arm/include/uapi
>>>> -Iarch/arm/include/generated/uapi -I/root/linux-next/include/uapi
>>>> -Iinclude/generated/uapi -include /root/linux-next/include/linux/kconfig.h
>>>> -D__KERNEL__ -mlittle-endian -Iarch/arm/mach-s5pv210/include
>>>> -Iarch/arm/plat-samsung/include -D__ASSEMBLY__ -mabi=apcs-gnu
>>>> -mno-thumb-interwork -marm -D__LINUX_ARM_ARCH__=4 -march=armv4t
>>>> -mtune=arm9tdmi -include asm/unified.h -Wa,-mfpu=softvfp+vfp
>>>> -mfloat-abi=soft-c -o arch/arm/vfp/vfphw.o arch/arm/vfp/vfphw.S
>>>>
>>>>
>>>> compiling err:
>>>>
>>>> arch/arm/vfp/vfphw.S: Assembler messages:
>>>> arch/arm/vfp/vfphw.S:295: Error: selected processor does not support ARM
>>>> mode `mrrc p11,3,r0,r1,c0'
>>>> arch/arm/vfp/vfphw.S:295: Error: selected processor does not support ARM
>>>> mode `mrrc p11,3,r0,r1,c1'
>>>
>>> The problem here is that you've ended up targetting a platform (s5pv210)
>>> that selects CPU_V7. VFP is then subsequently selected, but CONFIG_MMU=n, so
>>> 7TDMI and 9TDMI (v4 CPUs, no VFP) are selectable. Selecting either of those,
>>> causes these warnings.
>>>
>>> Unfortunately, I'm not sure how best to fix this. Most of the !MMU CPUs are
>>> tied to a particular board (lots of `if ARCH_INTEGRATOR' predicates), but we
>>> don't want to do that for 7tdmi.
>>>
>>> If we could enforce the strict exclusion of {<= ARMv5} and {ARMv6+} in the
>>> Kconfig, that would solve your problem.
>>
>> I have not tried to get no-MMU kernels to build in general. I think the way
>> it should be done is to not offer any user-selectable CPU types at all but
>> always select the CPU from the board.
>>
>> For randconfig tests, I would recommend turning on CONFIG_MMU unconditionally
>> using an appropriate KCONFIG_ALLCONFIG= file.
>>
>> The alternative is to use the patch below, but it may be incomplete: I could
>> not find anything other than AT91x40 in the kernel that actually has an
>> ARM7TDMI or ARM9TDMI.
>>
>> Arnd
>>
>> diff --git a/arch/arm/mach-at91/Kconfig.non_dt
>> b/arch/arm/mach-at91/Kconfig.non_dt
>> index 6c24985..dc972e1 100644
>> --- a/arch/arm/mach-at91/Kconfig.non_dt
>> +++ b/arch/arm/mach-at91/Kconfig.non_dt
>> @@ -47,6 +47,7 @@ config ARCH_AT91X40
>> select ARCH_USES_GETTIMEOFFSET
>> select MULTI_IRQ_HANDLER
>> select SPARSE_IRQ
>> +select CPU_ARM7TDMI
>>
>> endchoice
>>
>> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
>> index 84af266..c5e4ef0 100644
>> --- a/arch/arm/mm/Kconfig
>> +++ b/arch/arm/mm/Kconfig
>> @@ -6,7 +6,6 @@ comment "Processor Type"
>>
>> # ARM7TDMI
>> config CPU_ARM7TDMI
>> -bool "Support ARM7TDMI processor"
> whith the bool type at least
>> depends on !MMU
>> select CPU_32v4T
>> select CPU_ABRT_LV4T
>> @@ -56,7 +55,6 @@ config CPU_ARM740T
>>
>> # ARM9TDMI
>> config CPU_ARM9TDMI
>> -bool "Support ARM9TDMI processor"
>> depends on !MMU
>> select CPU_32v4T
>> select CPU_ABRT_NOMMU
>>
>> ___
>> linux-arm-kernel mailing list
>> linux-arm-ker...@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
thank you for your all valuable information.
if no one have time to continue to try, I should try (glad to try)
if I try, I think I should:
a. make a related patch according to all of you said.
b. make menuconfig with the original .config
save directly, and exit the menuconfig.
c. check the related CONFIG_* value in new .config
d. build
e. ...
z. I should fix this issue within this month.
welcome any suggestions or completions.
thanks.
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月17日 18:53, Arnd Bergmann wrote:
> On Wednesday 17 April 2013, Will Deacon wrote:
>>> > > arm-linux-gnu-gcc -Wp,-MD,arch/arm/vfp/.vfphw.o.d -nostdinc -isystem
>>> > > /usr/lib/gcc/arm-linux-gnueabi/4.7.1/include
>>> > > -I/root/linux-next/arch/arm/include -Iarch/arm/include/generated
>>> > > -Iinclude -I/root/linux-next/arch/arm/include/uapi
>>> > > -Iarch/arm/include/generated/uapi -I/root/linux-next/include/uapi
>>> > > -Iinclude/generated/uapi -include
>>> > > /root/linux-next/include/linux/kconfig.h -D__KERNEL__ -mlittle-endian
>>> > > -Iarch/arm/mach-s5pv210/include -Iarch/arm/plat-samsung/include
>>> > > -D__ASSEMBLY__ -mabi=apcs-gnu -mno-thumb-interwork -marm
>>> > > -D__LINUX_ARM_ARCH__=4 -march=armv4t -mtune=arm9tdmi -include
>>> > > asm/unified.h -Wa,-mfpu=softvfp+vfp -mfloat-abi=soft-c -o
>>> > > arch/arm/vfp/vfphw.o arch/arm/vfp/vfphw.S
>>> > >
>>> > >
>>> > > compiling err:
>>> > >
>>> > > arch/arm/vfp/vfphw.S: Assembler messages:
>>> > > arch/arm/vfp/vfphw.S:295: Error: selected processor does not support
>>> > > ARM mode `mrrc p11,3,r0,r1,c0'
>>> > > arch/arm/vfp/vfphw.S:295: Error: selected processor does not support
>>> > > ARM mode `mrrc p11,3,r0,r1,c1'
>> >
>> > The problem here is that you've ended up targetting a platform (s5pv210)
>> > that selects CPU_V7. VFP is then subsequently selected, but CONFIG_MMU=n,
>> > so
>> > 7TDMI and 9TDMI (v4 CPUs, no VFP) are selectable. Selecting either of
>> > those,
>> > causes these warnings.
>> >
>> > Unfortunately, I'm not sure how best to fix this. Most of the !MMU CPUs are
>> > tied to a particular board (lots of `if ARCH_INTEGRATOR' predicates), but
>> > we
>> > don't want to do that for 7tdmi.
>> >
>> > If we could enforce the strict exclusion of {<= ARMv5} and {ARMv6+} in the
>> > Kconfig, that would solve your problem.
> I have not tried to get no-MMU kernels to build in general. I think the way
> it should be done is to not offer any user-selectable CPU types at all but
> always select the CPU from the board.
>
> For randconfig tests, I would recommend turning on CONFIG_MMU unconditionally
> using an appropriate KCONFIG_ALLCONFIG= file.
>
> The alternative is to use the patch below, but it may be incomplete: I could
> not find anything other than AT91x40 in the kernel that actually has an
> ARM7TDMI or ARM9TDMI.
>
> Arnd
it seems we really need think of the design carefully.
I think we can assume that the crazy users (e.g. me) want to let
randconfig on each arm platform (scan one by one) to intend to make issues.
:-)
gchen.
>
> diff --git a/arch/arm/mach-at91/Kconfig.non_dt
> b/arch/arm/mach-at91/Kconfig.non_dt
> index 6c24985..dc972e1 100644
> --- a/arch/arm/mach-at91/Kconfig.non_dt
> +++ b/arch/arm/mach-at91/Kconfig.non_dt
> @@ -47,6 +47,7 @@ config ARCH_AT91X40
> select ARCH_USES_GETTIMEOFFSET
> select MULTI_IRQ_HANDLER
> select SPARSE_IRQ
> + select CPU_ARM7TDMI
>
> endchoice
>
> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> index 84af266..c5e4ef0 100644
> --- a/arch/arm/mm/Kconfig
> +++ b/arch/arm/mm/Kconfig
> @@ -6,7 +6,6 @@ comment "Processor Type"
>
> # ARM7TDMI
> config CPU_ARM7TDMI
> - bool "Support ARM7TDMI processor"
> depends on !MMU
> select CPU_32v4T
> select CPU_ABRT_LV4T
> @@ -56,7 +55,6 @@ config CPU_ARM740T
>
> # ARM9TDMI
> config CPU_ARM9TDMI
> - bool "Support ARM9TDMI processor"
> depends on !MMU
> select CPU_32v4T
> select CPU_ABRT_NOMMU
>
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月17日 18:02, Russell King - ARM Linux wrote: > On Wed, Apr 17, 2013 at 05:25:34PM +0800, Chen Gang wrote: >> > CONFIG_CPU_ARM7TDMI=y >> > CONFIG_CPU_ARM9TDMI=y >> > CONFIG_CPU_V7=y >> > CONFIG_CPU_32v4T=y >> > CONFIG_CPU_32v6K=y >> > CONFIG_CPU_32v7=y > This is an invalid configuration. A single kernel can not support ARMv7 > and ARMv4T simultaneously. > > The problem is caused by MMU=n, which exposes the CPU_ARM7TDMI and > CPU_ARM9TDMI options, which in turn select 32v4T. This is in turn > caused by the incomplete integration of uclinux. > > I think the only thing which can be done is to remove the ARM9TDMI > support code, which doesn't seem to be used by anything, and adjust > ARM7TDMI so that it isn't visible, but is selected by ARCH_AT91X40 > (which seems to be its only user.) > > Here's the slightly smaller version of that: > thank you very much for your analysing. should I do something for it next ? (at least, I should learn the information both of yours) is it suitable to integrate the patch below to next-* tree ? if it it suitable, need I do something for it ? thanks. :-) > diff --git a/arch/arm/mach-at91/Kconfig.non_dt > b/arch/arm/mach-at91/Kconfig.non_dt > index 6c24985..dc972e1 100644 > --- a/arch/arm/mach-at91/Kconfig.non_dt > +++ b/arch/arm/mach-at91/Kconfig.non_dt > @@ -47,6 +47,7 @@ config ARCH_AT91X40 > select ARCH_USES_GETTIMEOFFSET > select MULTI_IRQ_HANDLER > select SPARSE_IRQ > + select CPU_ARM7TDMI > > endchoice > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index cb812a1..deb6c6a 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -6,7 +6,7 @@ comment "Processor Type" > > # ARM7TDMI > config CPU_ARM7TDMI > - bool "Support ARM7TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_LV4T > @@ -56,7 +56,7 @@ config CPU_ARM740T > > # ARM9TDMI > config CPU_ARM9TDMI > - bool "Support ARM9TDMI processor" > + bool > depends on !MMU > select CPU_32v4T > select CPU_ABRT_NOMMU > > > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月17日 18:01, Will Deacon wrote:
> The problem here is that you've ended up targetting a platform (s5pv210)
> that selects CPU_V7. VFP is then subsequently selected, but CONFIG_MMU=n, so
> 7TDMI and 9TDMI (v4 CPUs, no VFP) are selectable. Selecting either of those,
> causes these warnings.
>
> Unfortunately, I'm not sure how best to fix this. Most of the !MMU CPUs are
> tied to a particular board (lots of `if ARCH_INTEGRATOR' predicates), but we
> don't want to do that for 7tdmi.
>
> If we could enforce the strict exclusion of {<= ARMv5} and {ARMv6+} in the
> Kconfig, that would solve your problem.
thank you very much for your analysing.
:-)
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
On 2013年04月03日 18:10, Will Deacon wrote: > I think the main problem is that you've reported an issue created from a > randconfig, but you haven't made the config in question available. excuse me, my English is not quite well. I guess your meaning is : I need also provide the related .config file in this mail. so we can be more easier to find the root cause. is it correct ? BTW: unlucky, the original .config has been deleted. I can try to reproduce it, so let us to fix it with more efficiency. thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
Hello Maintainers: when you have time, could you help to check this suggestion ? if we really need treat it as an issue, and also no one have time to fix it, I should try. thanks. gchen. On 2013年03月25日 10:10, Chen Gang wrote: > Hello Maintainers: > > is it an issue that need solving ? > > :-) > > > details: > > make: > make V=1 EXTRA_CFLAGS=-W ARCH=arm randconfig > make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig > set arm-linux-gnu- for "Cross-compiler tool prefix" > set "Samsung S5PV210/S5PC210" for "ARM system type" > make V=1 EXTRA_CFLAGS=-W ARCH=arm > > > err: > arch/arm/kernel/entry-armv.S: Assembler messages: > arch/arm/kernel/entry-armv.S:207: Error: selected processor does not > support ARM mode `clrex' > arch/arm/kernel/entry-armv.S:231: Error: selected processor does not > support ARM mode `clrex' > arch/arm/kernel/entry-armv.S:314: Error: selected processor does not > support ARM mode `clrex' > arch/arm/kernel/entry-armv.S:335: Error: selected processor does not > support ARM mode `clrex' > arch/arm/kernel/entry-armv.S:813: Error: selected processor does not > support ARM mode `ldrd r4,r5,[r0]' > arch/arm/kernel/entry-armv.S:814: Error: selected processor does not > support ARM mode `ldrd r6,r7,[r1]' > arch/arm/kernel/entry-armv.S:816: Error: selected processor does not > support ARM mode `ldrexd r0,r1,[r2]' > arch/arm/kernel/entry-armv.S:819: Error: selected processor does not > support ARM mode `strexdeq r3,r6,r7,[r2]' > make[1]: *** [arch/arm/kernel/entry-armv.o] Error 1 > make: *** [arch/arm/kernel] Error 2 > > related gcc command: > arm-linux-gnu-gcc -Wp,-MD,arch/arm/kernel/.entry-armv.o.d -nostdinc -isystem > /usr/lib/gcc/arm-linux-gnueabi/4.7.1/include > -I/android/public-kernel/linux-next/arch/arm/include > -Iarch/arm/include/generated -Iinclude > -I/android/public-kernel/linux-next/arch/arm/include/uapi > -Iarch/arm/include/generated/uapi > -I/android/public-kernel/linux-next/include/uapi -Iinclude/generated/uapi > -include /android/public-kernel/linux-next/include/linux/kconfig.h > -D__KERNEL__ -mlittle-endian -Iarch/arm/mach-s5pv210/include > -Iarch/arm/plat-samsung/include -D__ASSEMBLY__ -mabi=apcs-gnu > -mno-thumb-interwork -marm -D__LINUX_ARM_ARCH__=4 -march=armv4t > -mtune=arm9tdmi -include asm/unified.h -msoft-float -c -o > arch/arm/kernel/entry-armv.o arch/arm/kernel/entry-armv.S > > > > thanks. > -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM:s3c24xx: beautify code, data->hwirq is unsigned long which is always >= 0
data->hwirq is unsigned long which is always >= 0
Signed-off-by: Chen Gang
---
arch/arm/mach-s3c24xx/irq.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/irq.c b/arch/arm/mach-s3c24xx/irq.c
index 5c9f8b7..143f57b 100644
--- a/arch/arm/mach-s3c24xx/irq.c
+++ b/arch/arm/mach-s3c24xx/irq.c
@@ -210,7 +210,7 @@ static int s3c_irqext0_type(struct irq_data *data, unsigned
int type)
void __iomem *gpcon_reg;
unsigned long gpcon_offset, extint_offset;
- if ((data->hwirq >= 0) && (data->hwirq <= 3)) {
+ if (data->hwirq <= 3) {
gpcon_reg = S3C2410_GPFCON;
extint_reg = S3C24XX_EXTINT0;
gpcon_offset = (data->hwirq) * 2;
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] kernel: 'now' may be used uninitialized in posix_cpu_timer_schedule function
oh, sorry, it seems better to let ARM folks know about it.
;-)
On 2013年03月26日 14:36, Chen Gang wrote:
> Hello Maintainers:
>
> compiling with EXTRA_CFLAGS=-W:
> make V=1 EXTRA_CFLAGS=-W ARCH=arm s3c2410_defconfig
> make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig
> set 'arm-linux-gnu-' for cross chain prefix
> make V=1 EXTRA_CFLAGS=-W ARCH=arm
>
> it will report:
> kernel/posix-cpu-timers.c:1065:19: warning: ‘now’ may be used
> uninitialized in this function [-Wuninitialized]
>
> it seems it is really a bug.
> can any member help to fix it ?
> or provide additional suggestion ?
> (it seems only "unsigned long long now = 0" is not enough).
>
> :-)
>
>
>
> in kernel/posix-cpu-timers.c:
> for variable 'now' is defined without initialization (line 1029)
> it may be used without initialization (line 1066)
>
>
> 1026 void posix_cpu_timer_schedule(struct k_itimer *timer)
> 1027 {
> 1028 struct task_struct *p = timer->it.cpu.task;
> 1029 unsigned long long now;
> 1030
> 1031 if (unlikely(p == NULL))
> 1032 /*
> 1033 * The task was cleaned up already, no future firings.
> 1034 */
> 1035 goto out;
> 1036
> 1037 /*
> 1038 * Fetch the current sample and update the timer's expiry time.
> 1039 */
> 1040 if (CPUCLOCK_PERTHREAD(timer->it_clock)) {
> 1041 cpu_clock_sample(timer->it_clock, p, &now);
> 1042 bump_cpu_timer(timer, now);
> 1043 if (unlikely(p->exit_state)) {
> 1044 clear_dead_task(timer, now);
> 1045 goto out;
> 1046 }
> 1047 read_lock(&tasklist_lock); /* arm_timer needs it. */
> 1048 spin_lock(&p->sighand->siglock);
> 1049 } else {
> 1050 read_lock(&tasklist_lock);
> 1051 if (unlikely(p->sighand == NULL)) {
> 1052 /*
> 1053 * The process has been reaped.
> 1054 * We can't even collect a sample any more.
> 1055 */
> 1056 put_task_struct(p);
> 1057 timer->it.cpu.task = p = NULL;
> 1058 timer->it.cpu.expires = 0;
> 1059 goto out_unlock;
> 1060 } else if (unlikely(p->exit_state) &&
> thread_group_empty(p)) {
> 1061 /*
> 1062 * We've noticed that the thread is dead, but
> 1063 * not yet reaped. Take this opportunity to
> 1064 * drop our task ref.
> 1065 */
> 1066 clear_dead_task(timer, now);
> 1067 goto out_unlock;
> 1068 }
> 1069 spin_lock(&p->sighand->siglock);
> 1070 cpu_timer_sample_group(timer->it_clock, p, &now);
> 1071 bump_cpu_timer(timer, now);
> 1072 /* Leave the tasklist_lock locked for the call below. */
> 1073 }
> 1074
> 1075 /*
> 1076 * Now re-arm for the new expiry time.
> 1077 */
> 1078 BUG_ON(!irqs_disabled());
> 1079 arm_timer(timer);
> 1080 spin_unlock(&p->sighand->siglock);
> 1081
> 1082 out_unlock:
> 1083 read_unlock(&tasklist_lock);
> 1084
> 1085 out:
> 1086 timer->it_overrun_last = timer->it_overrun;
> 1087 timer->it_overrun = -1;
> 1088 ++timer->it_requeue_pending;
> 1089 }
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Suggestion] ARM:S5pv210: compiling issue for s5pv210 by using randconfig
Hello Maintainers: is it an issue that need solving ? :-) details: make: make V=1 EXTRA_CFLAGS=-W ARCH=arm randconfig make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig set arm-linux-gnu- for "Cross-compiler tool prefix" set "Samsung S5PV210/S5PC210" for "ARM system type" make V=1 EXTRA_CFLAGS=-W ARCH=arm err: arch/arm/kernel/entry-armv.S: Assembler messages: arch/arm/kernel/entry-armv.S:207: Error: selected processor does not support ARM mode `clrex' arch/arm/kernel/entry-armv.S:231: Error: selected processor does not support ARM mode `clrex' arch/arm/kernel/entry-armv.S:314: Error: selected processor does not support ARM mode `clrex' arch/arm/kernel/entry-armv.S:335: Error: selected processor does not support ARM mode `clrex' arch/arm/kernel/entry-armv.S:813: Error: selected processor does not support ARM mode `ldrd r4,r5,[r0]' arch/arm/kernel/entry-armv.S:814: Error: selected processor does not support ARM mode `ldrd r6,r7,[r1]' arch/arm/kernel/entry-armv.S:816: Error: selected processor does not support ARM mode `ldrexd r0,r1,[r2]' arch/arm/kernel/entry-armv.S:819: Error: selected processor does not support ARM mode `strexdeq r3,r6,r7,[r2]' make[1]: *** [arch/arm/kernel/entry-armv.o] Error 1 make: *** [arch/arm/kernel] Error 2 related gcc command: arm-linux-gnu-gcc -Wp,-MD,arch/arm/kernel/.entry-armv.o.d -nostdinc -isystem /usr/lib/gcc/arm-linux-gnueabi/4.7.1/include -I/android/public-kernel/linux-next/arch/arm/include -Iarch/arm/include/generated -Iinclude -I/android/public-kernel/linux-next/arch/arm/include/uapi -Iarch/arm/include/generated/uapi -I/android/public-kernel/linux-next/include/uapi -Iinclude/generated/uapi -include /android/public-kernel/linux-next/include/linux/kconfig.h -D__KERNEL__ -mlittle-endian -Iarch/arm/mach-s5pv210/include -Iarch/arm/plat-samsung/include -D__ASSEMBLY__ -mabi=apcs-gnu -mno-thumb-interwork -marm -D__LINUX_ARM_ARCH__=4 -march=armv4t -mtune=arm9tdmi -include asm/unified.h -msoft-float -c -o arch/arm/kernel/entry-armv.o arch/arm/kernel/entry-armv.S thanks. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5PV210: version merging compiling issue for 'struct fimc_source_info'
于 2013年02月26日 17:50, Sylwester Nawrocki 写道: > No, the fix is not yet in linux-next. I has not been merged through the media > tree and it might take some time until it gets to Linus's tree now. You can > use > one of following patches to fix this build break: > > http://www.spinics.net/lists/linux-samsung-soc/msg16023.html > https://patchwork.kernel.org/patch/2143211 > http://patchwork.linuxtv.org/patch/16892 thank you. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5PV210: version merging compiling issue for 'struct fimc_source_info'
于 2013年02月16日 19:39, Kyungmin Park 写道:
> Hi,
>
> You can find it at recent patch from Arnd.
>
excuse me, could you please provide more information about it ?
I have checked 2 tags:
the next-20130225 tag in
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
in Feb 1 2013, by Sylwester Nawrocki, Kyungmin Park, Mauro Carvalho Chehab
git number: 56bc911ac3b94c731db3a6de20258827f1a61c20
in include/media/s5p_fimc.h, the structure fimc_source_info is changed.
in arch/arm/mach-s5pv210/mach-goni.c, the structure fimc_source_info is
not changed.
still use .bus_type (not use .fimc_bus_type like others).
it seems, the relative members forgot to change it to .fimc_bus_type.
did the patch from Arnd still not applied into next tree ?
the v3.8-rc7 tag in git clone
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
it seems no relative changes (change nothing).
thanks.
:-)
gchen.
> Thank you,
> Kyungmin Park
>
> On Saturday, February 16, 2013, Chen Gang wrote:
>
> Hello Kukjin Kim:
>
> � it is a compiling issue, please help check when you have time.
>
> thanks.
>
> gchen.
>
> in arch/arm/mach-s5pv210/mach-goni.c:848:
> � error: unknown field 'bus_type' specified in initializer
>
> 843 static struct fimc_source_info goni_camera_sensors[] = {
> 844 � � � � {
> 845 � � � � � � � � .mux_id � � � � = 0,
> 846 � � � � � � � � .flags � � � � �= V4L2_MBUS_PCLK_SAMPLE_FALLING |
> 847 � � � � � � � � � � � � � � � � � V4L2_MBUS_VSYNC_ACTIVE_LOW,
> 848 � � � � � � � � .bus_type � � � = FIMC_BUS_TYPE_ITU_601,
> 849 � � � � � � � � .board_info � � = &noon010pc30_board_info,
> 850 � � � � � � � � .i2c_bus_num � �= 0,
> 851 � � � � � � � � .clk_frequency �= 1600UL,
> 852 � � � � },
> 853 };
>
>
> in include/media/s5p_fimc.h:50
>
> �37 /**
> �38 �* struct fimc_source_info - video source description required
> for the host
> �39 �* � � � � � � � � � � � � � interface configuration
> �40 �*
> �41 �* @board_info: pointer to I2C subdevice's board info
> �42 �* @clk_frequency: frequency of the clock the host interface
> provides to sensor
> �43 �* @fimc_bus_type: FIMC camera input type
> �44 �* @sensor_bus_type: image sensor bus type, MIPI, ITU-R BT.601 etc.
> �45 �* @flags: the parallel sensor bus flags defining signals
> polarity (V4L2_MBUS_*)
> �46 �* @i2c_bus_num: i2c control bus id the sensor is attached to
> �47 �* @mux_id: FIMC camera interface multiplexer index (separate
> for MIPI and ITU)
> �48 �* @clk_id: index of the SoC peripheral clock for sensors
> �49 �*/
> �50 struct fimc_source_info {
> �51 � � � � struct i2c_board_info *board_info;
> �52 � � � � unsigned long clk_frequency;
> �53 � � � � enum fimc_bus_type fimc_bus_type;
> �54 � � � � enum fimc_bus_type sensor_bus_type;
> �55 � � � � u16 flags;
> �56 � � � � u16 i2c_bus_num;
> �57 � � � � u16 mux_id;
> �58 � � � � u8 clk_id;
> �59 };
> �60
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM:plat-s3c24xx: for memcpy, reading more things out of boundary
Hello relative members:
please give a glance for this patch, when you have time.
thanks.
:-)
gchen.
于 2013年01月24日 13:27, Chen Gang 写道:
>
> the size is made by "plls_no + 1".
> so when copy from original buffer, need dec 1, or reading out of boundary.
>
> additional info:
> plls_no is ARRARY_SIZE(plls).
>
>
> Signed-off-by: Chen Gang
> ---
> arch/arm/plat-s3c24xx/cpu-freq.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/plat-s3c24xx/cpu-freq.c
> b/arch/arm/plat-s3c24xx/cpu-freq.c
> index 4680799..df093b2 100644
> --- a/arch/arm/plat-s3c24xx/cpu-freq.c
> +++ b/arch/arm/plat-s3c24xx/cpu-freq.c
> @@ -700,7 +700,8 @@ int __init s3c_plltab_register(struct
> cpufreq_frequency_table *plls,
>
> vals = kmalloc(size, GFP_KERNEL);
> if (vals) {
> - memcpy(vals, plls, size);
> + memcpy(vals, plls,
> + size - sizeof(struct cpufreq_frequency_table));
> pll_reg = vals;
>
> /* write a terminating entry, we don't store it in the
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Suggestion] ARM:S5PV210: version merging compiling issue for 'struct fimc_source_info'
于 2013年02月16日 19:39, Kyungmin Park 写道: > > You can find it at recent patch from Arnd. > thanks. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[Suggestion] ARM:S5PV210: version merging compiling issue for 'struct fimc_source_info'
Hello Kukjin Kim:
it is a compiling issue, please help check when you have time.
thanks.
gchen.
in arch/arm/mach-s5pv210/mach-goni.c:848:
error: unknown field 'bus_type' specified in initializer
843 static struct fimc_source_info goni_camera_sensors[] = {
844 {
845 .mux_id = 0,
846 .flags = V4L2_MBUS_PCLK_SAMPLE_FALLING |
847 V4L2_MBUS_VSYNC_ACTIVE_LOW,
848 .bus_type = FIMC_BUS_TYPE_ITU_601,
849 .board_info = &noon010pc30_board_info,
850 .i2c_bus_num= 0,
851 .clk_frequency = 1600UL,
852 },
853 };
in include/media/s5p_fimc.h:50
37 /**
38 * struct fimc_source_info - video source description required for the host
39 * interface configuration
40 *
41 * @board_info: pointer to I2C subdevice's board info
42 * @clk_frequency: frequency of the clock the host interface provides to
sensor
43 * @fimc_bus_type: FIMC camera input type
44 * @sensor_bus_type: image sensor bus type, MIPI, ITU-R BT.601 etc.
45 * @flags: the parallel sensor bus flags defining signals polarity
(V4L2_MBUS_*)
46 * @i2c_bus_num: i2c control bus id the sensor is attached to
47 * @mux_id: FIMC camera interface multiplexer index (separate for MIPI and
ITU)
48 * @clk_id: index of the SoC peripheral clock for sensors
49 */
50 struct fimc_source_info {
51 struct i2c_board_info *board_info;
52 unsigned long clk_frequency;
53 enum fimc_bus_type fimc_bus_type;
54 enum fimc_bus_type sensor_bus_type;
55 u16 flags;
56 u16 i2c_bus_num;
57 u16 mux_id;
58 u8 clk_id;
59 };
60
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM:plat-s3c24xx: for memcpy, reading more things out of boundary
the size is made by "plls_no + 1".
so when copy from original buffer, need dec 1, or reading out of boundary.
additional info:
plls_no is ARRARY_SIZE(plls).
Signed-off-by: Chen Gang
---
arch/arm/plat-s3c24xx/cpu-freq.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/plat-s3c24xx/cpu-freq.c b/arch/arm/plat-s3c24xx/cpu-freq.c
index 4680799..df093b2 100644
--- a/arch/arm/plat-s3c24xx/cpu-freq.c
+++ b/arch/arm/plat-s3c24xx/cpu-freq.c
@@ -700,7 +700,8 @@ int __init s3c_plltab_register(struct
cpufreq_frequency_table *plls,
vals = kmalloc(size, GFP_KERNEL);
if (vals) {
- memcpy(vals, plls, size);
+ memcpy(vals, plls,
+ size - sizeof(struct cpufreq_frequency_table));
pll_reg = vals;
/* write a terminating entry, we don't store it in the
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256
the buff is 256 limited, so need use vsnprintf instead of vsprintf Signed-off-by: Chen Gang Cc: Ben Dooks --- arch/arm/plat-samsung/pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c index 1507028..d896add 100644 --- a/arch/arm/plat-samsung/pm.c +++ b/arch/arm/plat-samsung/pm.c @@ -51,7 +51,7 @@ void s3c_pm_dbg(const char *fmt, ...) char buff[256]; va_start(va, fmt); - vsprintf(buff, fmt, va); + vsnprintf(buff, sizeof(buff), fmt, va); va_end(va); printascii(buff); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256
于 2013年01月22日 00:00, Russell King - ARM Linux 写道: > sizeof(buff) would be better here so that it depends on the actual buffer > size. thank you, I will send patch v2. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256
于 2013年01月21日 21:56, Ben Dooks 写道: > How about: vsnprintf(buff, sizeof(buff), fmt, va); > > It means we do not end up assuming the size of 'buff' and will be correct > if the code is changed to declare 'buff' to be a different size. thank you, I will send patch v2. :-) -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256
the buff size is 256, so need use vsnprintf instead of vsprintf. Signed-off-by: Chen Gang --- arch/arm/plat-samsung/pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c index 1507028..8d07b45 100644 --- a/arch/arm/plat-samsung/pm.c +++ b/arch/arm/plat-samsung/pm.c @@ -51,7 +51,7 @@ void s3c_pm_dbg(const char *fmt, ...) char buff[256]; va_start(va, fmt); - vsprintf(buff, fmt, va); + vsnprintf(buff, 256, fmt, va); va_end(va); printascii(buff); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue
On 01/18/2013 11:33 AM, Kukjin Kim wrote: > Chen,Gang( ??) wrote: >> thank you, I should notice it next time. >> an incorrect subject is not easy to get maintainer's notice >> maybe it is the reason why you can not reply in time, since you can not >> notice it. >> >> :-) >> > Just I was busy ;-) sorry for late my reply. > not mind, most of us are often busy, I will have more patience, next time. > Anyway Gang, don't post with html typed e-mail, probably, you got some kind > of error that your previous reply wasn't accepted from mailing list mail > server. Please make sure that your e-mail is plain text type for mailing list. > > [...] thank you, I should notice, next time. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue
Hello kgene.kim
when you have free time, please give a glance for this patch.
I sent it according to script/get_maintainter.pl.
if I sent to an incorrect member, please tell me, thanks.
Regards
gchen.
于 2013年01月07日 20:31, Chen Gang 写道:
>
> if not define CONFIG_CPU_S5PV210
>
> it will define NULL in common.h for:
> s5pv210_map_io, s5pv210_init_clocks, s5pv210_init, s5pv210_init_uarts
>
> so need using #ifdef CONFIG_CPU_S5PV210 for them too, in common.c.
> or compiling issue will occur.
>
>
> Signed-off-by: Chen Gang
> ---
> arch/arm/mach-s5pv210/common.c |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-s5pv210/common.c b/arch/arm/mach-s5pv210/common.c
> index 9dfe93e..5c88f88 100644
> --- a/arch/arm/mach-s5pv210/common.c
> +++ b/arch/arm/mach-s5pv210/common.c
> @@ -167,6 +167,8 @@ void __init s5pv210_init_io(struct map_desc *mach_desc,
> int size)
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
> }
>
> +#ifdef CONFIG_CPU_S5PV210
> +
> void __init s5pv210_map_io(void)
> {
> /* initialise device information early */
> @@ -209,6 +211,9 @@ void __init s5pv210_init_clocks(int xtal)
> s5pv210_setup_clocks();
> }
>
> +#endif /* CONFIG_CPU_S5PV210 */
> +
> +
> void __init s5pv210_init_irq(void)
> {
> u32 vic[4]; /* S5PV210 supports 4 VIC */
> @@ -227,6 +232,8 @@ struct bus_type s5pv210_subsys = {
> .dev_name = "s5pv210-core",
> };
>
> +#ifdef CONFIG_CPU_S5PV210
> +
> static struct device s5pv210_dev = {
> .bus= &s5pv210_subsys,
> };
> @@ -249,3 +256,5 @@ void __init s5pv210_init_uarts(struct s3c2410_uartcfg
> *cfg, int no)
> {
> s3c24xx_init_uartdevs("s5pv210-uart", s5p_uart_resources, cfg, no);
> }
> +
> +#endif /* CONFIG_CPU_S5PV210 */
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue
if not define CONFIG_CPU_S5PV210
it will define NULL in common.h for:
s5pv210_map_io, s5pv210_init_clocks, s5pv210_init, s5pv210_init_uarts
so need using #ifdef CONFIG_CPU_S5PV210 for them too, in common.c.
or compiling issue will occur.
Signed-off-by: Chen Gang
---
arch/arm/mach-s5pv210/common.c |9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/mach-s5pv210/common.c b/arch/arm/mach-s5pv210/common.c
index 9dfe93e..5c88f88 100644
--- a/arch/arm/mach-s5pv210/common.c
+++ b/arch/arm/mach-s5pv210/common.c
@@ -167,6 +167,8 @@ void __init s5pv210_init_io(struct map_desc *mach_desc, int
size)
s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
}
+#ifdef CONFIG_CPU_S5PV210
+
void __init s5pv210_map_io(void)
{
/* initialise device information early */
@@ -209,6 +211,9 @@ void __init s5pv210_init_clocks(int xtal)
s5pv210_setup_clocks();
}
+#endif /* CONFIG_CPU_S5PV210 */
+
+
void __init s5pv210_init_irq(void)
{
u32 vic[4]; /* S5PV210 supports 4 VIC */
@@ -227,6 +232,8 @@ struct bus_type s5pv210_subsys = {
.dev_name = "s5pv210-core",
};
+#ifdef CONFIG_CPU_S5PV210
+
static struct device s5pv210_dev = {
.bus= &s5pv210_subsys,
};
@@ -249,3 +256,5 @@ void __init s5pv210_init_uarts(struct s3c2410_uartcfg *cfg,
int no)
{
s3c24xx_init_uartdevs("s5pv210-uart", s5p_uart_resources, cfg, no);
}
+
+#endif /* CONFIG_CPU_S5PV210 */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue
于 2013年01月07日 17:36, Chen Gang 写道:
>
>
> +#ifdef CONFIG_CPU_S5PV210
> +
> struct bus_type s5pv210_subsys = {
> .name = "s5pv210-core",
> .dev_name = "s5pv210-core",
sorry, it is my fault.
should let s5pv210_subsys outside of #ifdef CONFIG_CPU_S5PV210.
it is used in pm.c
I need send patch v2.
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue
if not define CONFIG_CPU_S5PV210
it will define NULL in common.h for:
s5pv210_map_io, s5pv210_init_clocks, s5pv210_init, s5pv210_init_uarts
so need using #ifdef CONFIG_CPU_S5PV210 for them too, in common.c.
or compiling issue will occur.
Signed-off-by: Chen Gang
---
arch/arm/mach-s5pv210/common.c |9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/mach-s5pv210/common.c b/arch/arm/mach-s5pv210/common.c
index 9dfe93e..ad56485 100644
--- a/arch/arm/mach-s5pv210/common.c
+++ b/arch/arm/mach-s5pv210/common.c
@@ -167,6 +167,8 @@ void __init s5pv210_init_io(struct map_desc *mach_desc, int
size)
s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
}
+#ifdef CONFIG_CPU_S5PV210
+
void __init s5pv210_map_io(void)
{
/* initialise device information early */
@@ -209,6 +211,9 @@ void __init s5pv210_init_clocks(int xtal)
s5pv210_setup_clocks();
}
+#endif /* CONFIG_CPU_S5PV210 */
+
+
void __init s5pv210_init_irq(void)
{
u32 vic[4]; /* S5PV210 supports 4 VIC */
@@ -222,6 +227,8 @@ void __init s5pv210_init_irq(void)
s5p_init_irq(vic, ARRAY_SIZE(vic));
}
+#ifdef CONFIG_CPU_S5PV210
+
struct bus_type s5pv210_subsys = {
.name = "s5pv210-core",
.dev_name = "s5pv210-core",
@@ -249,3 +256,5 @@ void __init s5pv210_init_uarts(struct s3c2410_uartcfg *cfg,
int no)
{
s3c24xx_init_uartdevs("s5pv210-uart", s5p_uart_resources, cfg, no);
}
+
+#endif /* CONFIG_CPU_S5PV210 */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
