[PATCH 3/4] PCI: exynos: Mark the msi cascade handler IRQF_NO_THREAD

[Kevin Hao]

The cascade handler must run in hard interrupt context, otherwise
it will cause dead lock if we force threading of all the interrupt
handlers via kernel command parameter threadirqs.

Signed-off-by: Kevin Hao haoke...@gmail.com
---
 drivers/pci/host/pci-exynos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
index f9f468d9a819..7b6be7791d33 100644
--- a/drivers/pci/host/pci-exynos.c
+++ b/drivers/pci/host/pci-exynos.c
@@ -523,7 +523,8 @@ static int __init exynos_add_pcie_port(struct pcie_port *pp,
 
ret = devm_request_irq(pdev-dev, pp-msi_irq,
exynos_pcie_msi_irq_handler,
-   IRQF_SHARED, exynos-pcie, pp);
+   IRQF_SHARED | IRQF_NO_THREAD,
+   exynos-pcie, pp);
if (ret) {
dev_err(pdev-dev, failed to request msi irq\n);
return ret;
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

[Kevin Hao]

On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote:
 Hi Grant,
 
 I observe the following boot failure with today's (next-20140220) linux-next
 tree on Exynos based boards with the default exynos_defconfig.

Does this help?

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8a27fc907ab6..9cc893530b9a 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -381,12 +381,16 @@ static int __of_device_is_compatible(const struct 
device_node *device,
 
/* Compatible match has highest priority */
if (compat  compat[0]) {
-   of_property_for_each_string(device, compatible, prop, cp) {
+   prop = __of_find_property(device, compatible, NULL);
+   if (!prop)
+   return 0;
+
+   for (cp = of_prop_next_string(prop, NULL); cp;
+   cp = of_prop_next_string(prop, cp), index++) {
if (of_compat_cmp(cp, compat, strlen(compat)) == 0) {
score = INT_MAX/2 - (index  2);
break;
}
-   index++;
}
if (!score)
return 0;


Thanks,
Kevin


pgpsI35hZCgSq.pgp
Description: PGP signature

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

[Kevin Hao]

On Thu, Feb 20, 2014 at 03:57:07PM +0530, Sachin Kamat wrote:
 Hi Kevin,
 
 On 20 February 2014 15:42, Kevin Hao haoke...@gmail.com wrote:
  On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote:
  Hi Grant,
 
  I observe the following boot failure with today's (next-20140220) 
  linux-next
  tree on Exynos based boards with the default exynos_defconfig.
 
  Does this help?
 
 The below patch works for me. Thanks for the fix.

Thanks Sachin.

Hi Grant,

I assume you would fold this change into the original patch. But if you want
a separate patch, please let me know.

Thanks,
Kevin


pgpxZKMhAc2Y7.pgp
Description: PGP signature