Re: [PATCH] ARM: EXYNOS: Add static mapping for EXYNOS Audio Subsystem
On Wed, Aug 1, 2012 at 8:56 AM, Kukjin Kim wrote:
> Padmavathi Venna wrote:
>>
>> The CMU of EXYNOS can't control Audio Subsystem's clocks because
>> AUDSS SFRs aren't located in CMU. But AUDSS is a kind of CMU for
>> Audio Subsystem and need to use clock framework. This mapping
>> address will be used for AUDSS clock control.
>>
>> Signed-off-by: sangsu4u.park
>
> Maybe Sangsu Park?
>
>> Signed-off-by: Padmavathi Venna
>> ---
>> arch/arm/mach-exynos/common.c|5 +
>> arch/arm/mach-exynos/include/mach/map.h |1 +
>> arch/arm/plat-samsung/include/plat/map-s5p.h |2 ++
>> 3 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
>> index 4eb39cd..4070c79 100644
>> --- a/arch/arm/mach-exynos/common.c
>> +++ b/arch/arm/mach-exynos/common.c
>> @@ -109,6 +109,11 @@ static struct map_desc exynos_iodesc[] __initdata = {
>> .pfn= __phys_to_pfn(EXYNOS_PA_CHIPID),
>> .length = SZ_4K,
>> .type = MT_DEVICE,
>> + }, {
>> + .virtual= (unsigned long)S5P_VA_AUDSS,
>> + .pfn= __phys_to_pfn(EXYNOS_PA_AUDSS),
>> + .length = SZ_4K,
>> + .type = MT_DEVICE,
>> },
>> };
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
>> exynos/include/mach/map.h
>> index 5cf7d91..9c044a0 100644
>> --- a/arch/arm/mach-exynos/include/mach/map.h
>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>> @@ -39,6 +39,7 @@
>>
>> #define EXYNOS4_PA_G2D 0x1280
>>
>> +#define EXYNOS_PA_AUDSS 0x0381
>> #define EXYNOS_PA_I2S0 0x0383
>> #define EXYNOS4_PA_I2S1 0xE210
>> #define EXYNOS4_PA_I2S2 0xE2A0
>> diff --git a/arch/arm/plat-samsung/include/plat/map-s5p.h b/arch/arm/plat-
>> samsung/include/plat/map-s5p.h
>> index c2d7bda..3558277 100644
>> --- a/arch/arm/plat-samsung/include/plat/map-s5p.h
>> +++ b/arch/arm/plat-samsung/include/plat/map-s5p.h
>> @@ -40,6 +40,8 @@
>> #define S5P_VA_GIC_CPU S3C_ADDR(0x0281)
>> #define S5P_VA_GIC_DIST S3C_ADDR(0x0282)
>>
>> +#define S5P_VA_AUDSS S3C_ADDR(0x0291)
>
> Is there any reason to use the offset, 0x0291?
>
> [...]
>
> And I think, this patch should be patch-set with your '[PATCH] ARM: EXYNOS:
> Add clocks for EXYNOS Audio Subsystem.'
Okay. In the next version I will send it along with clock support for audio.
>
> Thanks.
>
> Best regards,
> Kgene.
Thanks&Regards
Padma
> --
> Kukjin Kim , Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: EXYNOS: Add static mapping for EXYNOS Audio Subsystem
Padmavathi Venna wrote:
>
> The CMU of EXYNOS can't control Audio Subsystem's clocks because
> AUDSS SFRs aren't located in CMU. But AUDSS is a kind of CMU for
> Audio Subsystem and need to use clock framework. This mapping
> address will be used for AUDSS clock control.
>
> Signed-off-by: sangsu4u.park
Maybe Sangsu Park?
> Signed-off-by: Padmavathi Venna
> ---
> arch/arm/mach-exynos/common.c|5 +
> arch/arm/mach-exynos/include/mach/map.h |1 +
> arch/arm/plat-samsung/include/plat/map-s5p.h |2 ++
> 3 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
> index 4eb39cd..4070c79 100644
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@ -109,6 +109,11 @@ static struct map_desc exynos_iodesc[] __initdata = {
> .pfn= __phys_to_pfn(EXYNOS_PA_CHIPID),
> .length = SZ_4K,
> .type = MT_DEVICE,
> + }, {
> + .virtual= (unsigned long)S5P_VA_AUDSS,
> + .pfn= __phys_to_pfn(EXYNOS_PA_AUDSS),
> + .length = SZ_4K,
> + .type = MT_DEVICE,
> },
> };
>
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
> exynos/include/mach/map.h
> index 5cf7d91..9c044a0 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -39,6 +39,7 @@
>
> #define EXYNOS4_PA_G2D 0x1280
>
> +#define EXYNOS_PA_AUDSS 0x0381
> #define EXYNOS_PA_I2S0 0x0383
> #define EXYNOS4_PA_I2S1 0xE210
> #define EXYNOS4_PA_I2S2 0xE2A0
> diff --git a/arch/arm/plat-samsung/include/plat/map-s5p.h b/arch/arm/plat-
> samsung/include/plat/map-s5p.h
> index c2d7bda..3558277 100644
> --- a/arch/arm/plat-samsung/include/plat/map-s5p.h
> +++ b/arch/arm/plat-samsung/include/plat/map-s5p.h
> @@ -40,6 +40,8 @@
> #define S5P_VA_GIC_CPU S3C_ADDR(0x0281)
> #define S5P_VA_GIC_DIST S3C_ADDR(0x0282)
>
> +#define S5P_VA_AUDSS S3C_ADDR(0x0291)
Is there any reason to use the offset, 0x0291?
[...]
And I think, this patch should be patch-set with your '[PATCH] ARM: EXYNOS:
Add clocks for EXYNOS Audio Subsystem.'
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: EXYNOS: Add static mapping for EXYNOS Audio Subsystem
The CMU of EXYNOS can't control Audio Subsystem's clocks because
AUDSS SFRs aren't located in CMU. But AUDSS is a kind of CMU for
Audio Subsystem and need to use clock framework. This mapping
address will be used for AUDSS clock control.
Signed-off-by: sangsu4u.park
Signed-off-by: Padmavathi Venna
---
arch/arm/mach-exynos/common.c|5 +
arch/arm/mach-exynos/include/mach/map.h |1 +
arch/arm/plat-samsung/include/plat/map-s5p.h |2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c
index 4eb39cd..4070c79 100644
--- a/arch/arm/mach-exynos/common.c
+++ b/arch/arm/mach-exynos/common.c
@@ -109,6 +109,11 @@ static struct map_desc exynos_iodesc[] __initdata = {
.pfn= __phys_to_pfn(EXYNOS_PA_CHIPID),
.length = SZ_4K,
.type = MT_DEVICE,
+ }, {
+ .virtual= (unsigned long)S5P_VA_AUDSS,
+ .pfn= __phys_to_pfn(EXYNOS_PA_AUDSS),
+ .length = SZ_4K,
+ .type = MT_DEVICE,
},
};
diff --git a/arch/arm/mach-exynos/include/mach/map.h
b/arch/arm/mach-exynos/include/mach/map.h
index 5cf7d91..9c044a0 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -39,6 +39,7 @@
#define EXYNOS4_PA_G2D 0x1280
+#define EXYNOS_PA_AUDSS0x0381
#define EXYNOS_PA_I2S0 0x0383
#define EXYNOS4_PA_I2S10xE210
#define EXYNOS4_PA_I2S20xE2A0
diff --git a/arch/arm/plat-samsung/include/plat/map-s5p.h
b/arch/arm/plat-samsung/include/plat/map-s5p.h
index c2d7bda..3558277 100644
--- a/arch/arm/plat-samsung/include/plat/map-s5p.h
+++ b/arch/arm/plat-samsung/include/plat/map-s5p.h
@@ -40,6 +40,8 @@
#define S5P_VA_GIC_CPU S3C_ADDR(0x0281)
#define S5P_VA_GIC_DISTS3C_ADDR(0x0282)
+#define S5P_VA_AUDSS S3C_ADDR(0x0291)
+
#define VA_VIC(x) (S3C_VA_IRQ + ((x) * 0x1))
#define VA_VIC0VA_VIC(0)
#define VA_VIC1VA_VIC(1)
--
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
