RE: [PATCH] ARM: dts: correct the dw-mshc timing properties as per binding
Alim Akhtar wrote: [...] Signed-off-by: Alim Akhtar alim.akh...@samsung.com Tested-by: Doug Anderson diand...@chromium.org Acked-by: Doug Anderson diand...@chromium.org Looks OK to me, applied. Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: correct the dw-mshc timing properties as per binding
Hi Doug, On Tue, Jan 8, 2013 at 12:34 AM, Doug Anderson diand...@chromium.org wrote: Alim, On Mon, Jan 7, 2013 at 3:19 AM, Alim Akhtar alim.akh...@samsung.com wrote: As per the current exynos-dw-mshc bindings, dw-mshc-sdr-timing and dw-mshc-ddr-timing properties are having only two cells, these properties are wrongly set for exynos5250 based cros5250 and smdk5250 platfroms. This patch corrects above timing propreties for above platfroms Thanks for catching this. Given that this just removes a number from the dts file that isn't read by the code, I don't expect any functional change and I don't see any. I also double-checked usage and compared to the current Chrome OS tree. The third number (that you removed) is already correctly specified in the dts as samsung,dw-mshc-ciu-div. :) Yes, no functional changes as the removed number is passed using dw-mshc-ciu-div property now as mentioned by you. Signed-off-by: Alim Akhtar alim.akh...@samsung.com Tested-by: Doug Anderson diand...@chromium.org Acked-by: Doug Anderson diand...@chromium.org Thanks!!! -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: dts: correct the dw-mshc timing properties as per binding
As per the current exynos-dw-mshc bindings, dw-mshc-sdr-timing and dw-mshc-ddr-timing properties are having only two cells, these properties are wrongly set for exynos5250 based cros5250 and smdk5250 platfroms. This patch corrects above timing propreties for above platfroms Signed-off-by: Alim Akhtar alim.akh...@samsung.com --- arch/arm/boot/dts/cros5250-common.dtsi| 12 ++-- arch/arm/boot/dts/exynos5250-smdk5250.dts | 8 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi index fddd174..46c0980 100644 --- a/arch/arm/boot/dts/cros5250-common.dtsi +++ b/arch/arm/boot/dts/cros5250-common.dtsi @@ -96,8 +96,8 @@ fifo-depth = 0x80; card-detect-delay = 200; samsung,dw-mshc-ciu-div = 3; - samsung,dw-mshc-sdr-timing = 2 3 3; - samsung,dw-mshc-ddr-timing = 1 2 3; + samsung,dw-mshc-sdr-timing = 2 3; + samsung,dw-mshc-ddr-timing = 1 2; slot@0 { reg = 0; @@ -120,8 +120,8 @@ fifo-depth = 0x80; card-detect-delay = 200; samsung,dw-mshc-ciu-div = 3; - samsung,dw-mshc-sdr-timing = 2 3 3; - samsung,dw-mshc-ddr-timing = 1 2 3; + samsung,dw-mshc-sdr-timing = 2 3; + samsung,dw-mshc-ddr-timing = 1 2; slot@0 { reg = 0; @@ -141,8 +141,8 @@ fifo-depth = 0x80; card-detect-delay = 200; samsung,dw-mshc-ciu-div = 3; - samsung,dw-mshc-sdr-timing = 2 3 3; - samsung,dw-mshc-ddr-timing = 1 2 3; + samsung,dw-mshc-sdr-timing = 2 3; + samsung,dw-mshc-ddr-timing = 1 2; slot@0 { reg = 0; diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 942d576..e05b18f 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -115,8 +115,8 @@ fifo-depth = 0x80; card-detect-delay = 200; samsung,dw-mshc-ciu-div = 3; - samsung,dw-mshc-sdr-timing = 2 3 3; - samsung,dw-mshc-ddr-timing = 1 2 3; + samsung,dw-mshc-sdr-timing = 2 3; + samsung,dw-mshc-ddr-timing = 1 2; slot@0 { reg = 0; @@ -139,8 +139,8 @@ fifo-depth = 0x80; card-detect-delay = 200; samsung,dw-mshc-ciu-div = 3; - samsung,dw-mshc-sdr-timing = 2 3 3; - samsung,dw-mshc-ddr-timing = 1 2 3; + samsung,dw-mshc-sdr-timing = 2 3; + samsung,dw-mshc-ddr-timing = 1 2; slot@0 { reg = 0; -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: correct the dw-mshc timing properties as per binding
Alim, On Mon, Jan 7, 2013 at 3:19 AM, Alim Akhtar alim.akh...@samsung.com wrote: As per the current exynos-dw-mshc bindings, dw-mshc-sdr-timing and dw-mshc-ddr-timing properties are having only two cells, these properties are wrongly set for exynos5250 based cros5250 and smdk5250 platfroms. This patch corrects above timing propreties for above platfroms Thanks for catching this. Given that this just removes a number from the dts file that isn't read by the code, I don't expect any functional change and I don't see any. I also double-checked usage and compared to the current Chrome OS tree. The third number (that you removed) is already correctly specified in the dts as samsung,dw-mshc-ciu-div. :) Signed-off-by: Alim Akhtar alim.akh...@samsung.com Tested-by: Doug Anderson diand...@chromium.org Acked-by: Doug Anderson diand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html