Re: [PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes

2015-01-21 Thread Inha Song 
Hi,

Thanks for your comment.

On Wed, 21 Jan 2015 12:41:55 +0100
Sylwester Nawrocki  wrote:

> Hi,
> 
> On 21/01/15 06:58, Inha Song wrote:
> > Add MAX98090 audio codec, I2S interface and the sound nodes to support
> > audio on Odroid-XU3 board.
> > 
> > Signed-off-by: Inha Song 
> > ---
> >  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34 
> > ++
> >  1 file changed, 34 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts 
> > b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > index 7874da2..79493d1 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > @@ -310,6 +310,40 @@
> > rtc@101E {
> > status = "okay";
> > };
> > +
> > +   sound: sound {
> > +   compatible = "samsung,odroidu3-audio";
> 
> How about using simple-card instead ? I've been trying to switch
> Odroid X2/U3 to simple card. Here a corresponding dts patch:
> http://www.spinics.net/lists/linux-samsung-soc/msg41083.html
> For that recent patches for the I2S driver which area already in -next
> might be needed.

Oh, I missed your patchs.
I will rework this patch based on your patch.

Best Regards,
Inha Song.

> 
> > +   samsung,model = "Odroid-XU3";
> > +   samsung,i2s-controller = <&i2s0>;
> > +   samsung,audio-codec = <&max98090>;
> > +   assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> > + <&clock_audss EXYNOS_MOUT_I2S>;
> > +   assigned-clock-parents = <&clock CLK_FIN_PLL>,
> > +   <&clock_audss EXYNOS_MOUT_AUDSS>;
> > +   samsung,audio-routing =
> > +   "Headphone Jack", "HPL",
> > +   "Headphone Jack", "HPR",
> > +   "Headphone Jack", "MICBIAS",
> > +   "IN1", "Headphone Jack",
> > +   "Speakers", "SPKL",
> > +   "Speakers", "SPKR";
> > +   };
> > +};
> > +
> > +&hsi2c_5 {
> > +   status = "okay";
> > +   max98090: max98090@10 {
> > +   compatible = "maxim,max98090";
> > +   reg = <0x10>;
> > +   interrupt-parent = <&gpx3>;
> > +   interrupts = <2 0>;
> > +   clocks = <&clock_audss EXYNOS_DOUT_AUD_BUS>;
> > +   clock-names = "mclk";
> > +   };
> > +};
> 
> -- 
> Thanks,
> Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes

2015-01-21 Thread Sylwester Nawrocki 
Hi,

On 21/01/15 06:58, Inha Song wrote:
> Add MAX98090 audio codec, I2S interface and the sound nodes to support
> audio on Odroid-XU3 board.
> 
> Signed-off-by: Inha Song 
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34 
> ++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts 
> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 7874da2..79493d1 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -310,6 +310,40 @@
>   rtc@101E {
>   status = "okay";
>   };
> +
> + sound: sound {
> + compatible = "samsung,odroidu3-audio";

How about using simple-card instead ? I've been trying to switch
Odroid X2/U3 to simple card. Here a corresponding dts patch:
http://www.spinics.net/lists/linux-samsung-soc/msg41083.html
For that recent patches for the I2S driver which area already in -next
might be needed.

> + samsung,model = "Odroid-XU3";
> + samsung,i2s-controller = <&i2s0>;
> + samsung,audio-codec = <&max98090>;
> + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> +   <&clock_audss EXYNOS_MOUT_I2S>;
> + assigned-clock-parents = <&clock CLK_FIN_PLL>,
> + <&clock_audss EXYNOS_MOUT_AUDSS>;
> + samsung,audio-routing =
> + "Headphone Jack", "HPL",
> + "Headphone Jack", "HPR",
> + "Headphone Jack", "MICBIAS",
> + "IN1", "Headphone Jack",
> + "Speakers", "SPKL",
> + "Speakers", "SPKR";
> + };
> +};
> +
> +&hsi2c_5 {
> + status = "okay";
> + max98090: max98090@10 {
> + compatible = "maxim,max98090";
> + reg = <0x10>;
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 0>;
> + clocks = <&clock_audss EXYNOS_DOUT_AUD_BUS>;
> + clock-names = "mclk";
> + };
> +};

-- 
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes

2015-01-20 Thread Inha Song 
Add MAX98090 audio codec, I2S interface and the sound nodes to support
audio on Odroid-XU3 board.

Signed-off-by: Inha Song 
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34 ++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts 
b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 7874da2..79493d1 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -310,6 +310,40 @@
rtc@101E {
status = "okay";
};
+
+   sound: sound {
+   compatible = "samsung,odroidu3-audio";
+   samsung,model = "Odroid-XU3";
+   samsung,i2s-controller = <&i2s0>;
+   samsung,audio-codec = <&max98090>;
+   assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
+ <&clock_audss EXYNOS_MOUT_I2S>;
+   assigned-clock-parents = <&clock CLK_FIN_PLL>,
+   <&clock_audss EXYNOS_MOUT_AUDSS>;
+   samsung,audio-routing =
+   "Headphone Jack", "HPL",
+   "Headphone Jack", "HPR",
+   "Headphone Jack", "MICBIAS",
+   "IN1", "Headphone Jack",
+   "Speakers", "SPKL",
+   "Speakers", "SPKR";
+   };
+};
+
+&hsi2c_5 {
+   status = "okay";
+   max98090: max98090@10 {
+   compatible = "maxim,max98090";
+   reg = <0x10>;
+   interrupt-parent = <&gpx3>;
+   interrupts = <2 0>;
+   clocks = <&clock_audss EXYNOS_DOUT_AUD_BUS>;
+   clock-names = "mclk";
+   };
+};
+
+&i2s0 {
+   status = "okay";
 };
 
 &hdmi {
-- 
2.0.0.390.gcb682f8

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html