RE: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-17 Thread Kukjin Kim 
Inderpal Singh wrote:
 
 Since 0 is not considered as error at dmaengine level, return ENOMEM
 from pl330_alloc_chan_resources in case of failure.
 
 Signed-off-by: Inderpal Singh inderpal.si...@linaro.org

Acked-by: Kukjin Kim kgene@samsung.com

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

 ---
  drivers/dma/pl330.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
 index e4feba6..14d881c 100644
 --- a/drivers/dma/pl330.c
 +++ b/drivers/dma/pl330.c
 @@ -2393,7 +2393,7 @@ static int pl330_alloc_chan_resources(struct
 dma_chan *chan)
   pch-pl330_chid = pl330_request_channel(pdmac-pif);
   if (!pch-pl330_chid) {
   spin_unlock_irqrestore(pch-lock, flags);
 - return 0;
 + return -ENOMEM;
   }
 
   tasklet_init(pch-task, pl330_tasklet, (unsigned long) pch);
 --
 1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-16 Thread Inderpal Singh 
Since 0 is not considered as error at dmaengine level, return ENOMEM
from pl330_alloc_chan_resources in case of failure.

Signed-off-by: Inderpal Singh inderpal.si...@linaro.org
---
 drivers/dma/pl330.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index e4feba6..14d881c 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2393,7 +2393,7 @@ static int pl330_alloc_chan_resources(struct dma_chan 
*chan)
pch-pl330_chid = pl330_request_channel(pdmac-pif);
if (!pch-pl330_chid) {
spin_unlock_irqrestore(pch-lock, flags);
-   return 0;
+   return -ENOMEM;
}
 
tasklet_init(pch-task, pl330_tasklet, (unsigned long) pch);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-16 Thread Jassi Brar 
On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh
inderpal.si...@linaro.org wrote:
 Since 0 is not considered as error at dmaengine level, return ENOMEM
 from pl330_alloc_chan_resources in case of failure.

 Signed-off-by: Inderpal Singh inderpal.si...@linaro.org

Acked-by: Jassi Brar jassisinghb...@gmail.com


 ---
  drivers/dma/pl330.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
 index e4feba6..14d881c 100644
 --- a/drivers/dma/pl330.c
 +++ b/drivers/dma/pl330.c
 @@ -2393,7 +2393,7 @@ static int pl330_alloc_chan_resources(struct dma_chan 
 *chan)
 pch-pl330_chid = pl330_request_channel(pdmac-pif);
 if (!pch-pl330_chid) {
 spin_unlock_irqrestore(pch-lock, flags);
 -   return 0;
 +   return -ENOMEM;
 }

 tasklet_init(pch-task, pl330_tasklet, (unsigned long) pch);
 --
 1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html