RE: [PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
Rafael J. Wysocki wrote: > > On Saturday, August 08, 2015 04:36:34 PM Krzysztof Kozlowski wrote: > > W dniu 06.08.2015 o 09:23, Rafael J. Wysocki pisze: > > > On Tuesday, August 04, 2015 04:45:16 PM Kukjin Kim wrote: > > >> From: Shailendra Verma > > >> > > >> During probe free the memory allocated to "exynos_info" in case of > > >> unknown SoC type. > > >> > > >> Signed-off-by: Shailendra Verma > > >> Acked-by: Viresh Kumar > > >> Acked-by: Lukasz Majewski > > >> [k.kozlowski: Rebased the patch around if(of_machine_is_compatible)] > > >> Signed-off-by: Krzysztof Kozlowski > > >> Signed-off-by: Kukjin Kim > > >> --- > > >> Hi Rafael and Viresh, > > >> > > >> Since this is a fix to prevent memory leak, it would be better if > > >> this could be sent to linus during -rc via cpufreq tree. > > > > > > I'm not planning more pull requests for 4.2 and this one doesn't seem to > > > be > > > a good enough reason for a pull request of its own, though. > > > > > > Of course, if there are more urgent fixes, I can push it along with them, > > > but there are none so far. > > > > The cpufreq driver will be removed completely in v4.3 or v4.4 with > > patchset adding cpufreq-dt support for Exynos 4x12. This means that this > > patch makes sense only for 4.2 and as a stable backport (but it was not > > marked as such). > > Since I have one more ACPI fix for 4.2, I've applied this one and will > push it to Linus next week. > Rafael, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
On Saturday, August 08, 2015 04:36:34 PM Krzysztof Kozlowski wrote: > W dniu 06.08.2015 o 09:23, Rafael J. Wysocki pisze: > > On Tuesday, August 04, 2015 04:45:16 PM Kukjin Kim wrote: > >> From: Shailendra Verma > >> > >> During probe free the memory allocated to "exynos_info" in case of > >> unknown SoC type. > >> > >> Signed-off-by: Shailendra Verma > >> Acked-by: Viresh Kumar > >> Acked-by: Lukasz Majewski > >> [k.kozlowski: Rebased the patch around if(of_machine_is_compatible)] > >> Signed-off-by: Krzysztof Kozlowski > >> Signed-off-by: Kukjin Kim > >> --- > >> Hi Rafael and Viresh, > >> > >> Since this is a fix to prevent memory leak, it would be better if > >> this could be sent to linus during -rc via cpufreq tree. > > > > I'm not planning more pull requests for 4.2 and this one doesn't seem to be > > a good enough reason for a pull request of its own, though. > > > > Of course, if there are more urgent fixes, I can push it along with them, > > but there are none so far. > > The cpufreq driver will be removed completely in v4.3 or v4.4 with > patchset adding cpufreq-dt support for Exynos 4x12. This means that this > patch makes sense only for 4.2 and as a stable backport (but it was not > marked as such). Since I have one more ACPI fix for 4.2, I've applied this one and will push it to Linus next week. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
On 08-08-15, 16:36, Krzysztof Kozlowski wrote: > The cpufreq driver will be removed completely in v4.3 or v4.4 with > patchset adding cpufreq-dt support for Exynos 4x12. This means that this > patch makes sense only for 4.2 and as a stable backport (but it was not > marked as such). > > Anyone thinks that the patch will be worth stable back-porting? Doesn't look worth enough to me.. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
W dniu 06.08.2015 o 09:23, Rafael J. Wysocki pisze: > On Tuesday, August 04, 2015 04:45:16 PM Kukjin Kim wrote: >> From: Shailendra Verma >> >> During probe free the memory allocated to "exynos_info" in case of >> unknown SoC type. >> >> Signed-off-by: Shailendra Verma >> Acked-by: Viresh Kumar >> Acked-by: Lukasz Majewski >> [k.kozlowski: Rebased the patch around if(of_machine_is_compatible)] >> Signed-off-by: Krzysztof Kozlowski >> Signed-off-by: Kukjin Kim >> --- >> Hi Rafael and Viresh, >> >> Since this is a fix to prevent memory leak, it would be better if >> this could be sent to linus during -rc via cpufreq tree. > > I'm not planning more pull requests for 4.2 and this one doesn't seem to be > a good enough reason for a pull request of its own, though. > > Of course, if there are more urgent fixes, I can push it along with them, > but there are none so far. The cpufreq driver will be removed completely in v4.3 or v4.4 with patchset adding cpufreq-dt support for Exynos 4x12. This means that this patch makes sense only for 4.2 and as a stable backport (but it was not marked as such). Anyone thinks that the patch will be worth stable back-porting? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
On Tuesday, August 04, 2015 04:45:16 PM Kukjin Kim wrote: > From: Shailendra Verma > > During probe free the memory allocated to "exynos_info" in case of > unknown SoC type. > > Signed-off-by: Shailendra Verma > Acked-by: Viresh Kumar > Acked-by: Lukasz Majewski > [k.kozlowski: Rebased the patch around if(of_machine_is_compatible)] > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kukjin Kim > --- > Hi Rafael and Viresh, > > Since this is a fix to prevent memory leak, it would be better if > this could be sent to linus during -rc via cpufreq tree. I'm not planning more pull requests for 4.2 and this one doesn't seem to be a good enough reason for a pull request of its own, though. Of course, if there are more urgent fixes, I can push it along with them, but there are none so far. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cpufreq: exynos: Fix for memory leak in case SoC name does not match
From: Shailendra Verma
During probe free the memory allocated to "exynos_info" in case of
unknown SoC type.
Signed-off-by: Shailendra Verma
Acked-by: Viresh Kumar
Acked-by: Lukasz Majewski
[k.kozlowski: Rebased the patch around if(of_machine_is_compatible)]
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Kukjin Kim
---
Hi Rafael and Viresh,
Since this is a fix to prevent memory leak, it would be better if
this could be sent to linus during -rc via cpufreq tree.
Thanks,
Kukjin
drivers/cpufreq/exynos-cpufreq.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index ae5b2bd..fa3dd84 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -180,7 +180,7 @@ static int exynos_cpufreq_probe(struct platform_device
*pdev)
ret = exynos5250_cpufreq_init(exynos_info);
} else {
pr_err("%s: Unknown SoC type\n", __func__);
- return -ENODEV;
+ ret = -ENODEV;
}
if (ret)
@@ -188,12 +188,14 @@ static int exynos_cpufreq_probe(struct platform_device
*pdev)
if (exynos_info->set_freq == NULL) {
dev_err(&pdev->dev, "No set_freq function (ERR)\n");
+ ret = -EINVAL;
goto err_vdd_arm;
}
arm_regulator = regulator_get(NULL, "vdd_arm");
if (IS_ERR(arm_regulator)) {
dev_err(&pdev->dev, "failed to get resource vdd_arm\n");
+ ret = -EINVAL;
goto err_vdd_arm;
}
@@ -225,7 +227,7 @@ err_cpufreq_reg:
regulator_put(arm_regulator);
err_vdd_arm:
kfree(exynos_info);
- return -EINVAL;
+ return ret;
}
static struct platform_driver exynos_cpufreq_platdrv = {
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
