Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
Naveen On Tue, Aug 27, 2013 at 10:33 PM, Naveen Krishna Ch naveenkrishna...@gmail.com wrote: I would like to know any comments on https://patchwork.kernel.org/patch/2513361/ Its been pending for a while now. Thanks, Naveen Ping Any comments please I assume you're asking for a ping for the _other_ patch (AKA: Handle timeout issues), not the one you're replying to here. Can you please just do a REPOST of the patch you'd like comments on? -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
On 23 May 2013 10:55, Naveen Krishna Ch naveenkrishna...@gmail.com wrote: On 23 May 2013 02:46, Jonathan Cameron ji...@kernel.org wrote: On 05/20/2013 06:09 PM, Doug Anderson wrote: Naveen, On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* - struct platform_device* - struct exynos_adc* seems wrong. Instead we should be doing struct device* - struct iio_dev* - struct exynos_adc* Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- drivers/iio/adc/exynos_adc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org Applied to the fixes-togreg branch of iio.git I'll hopefully send these on to Greg before the weekend. Jonathan, I would like to know any comments on https://patchwork.kernel.org/patch/2513361/ Its been pending for a while now. Thanks, Naveen Ping Any comments please -- To unsubscribe from this list: send the line unsubscribe linux-iio in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Shine bright, (: Nav :) -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
On 05/20/2013 06:09 PM, Doug Anderson wrote: Naveen, On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* - struct platform_device* - struct exynos_adc* seems wrong. Instead we should be doing struct device* - struct iio_dev* - struct exynos_adc* Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- drivers/iio/adc/exynos_adc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org Applied to the fixes-togreg branch of iio.git I'll hopefully send these on to Greg before the weekend. -- To unsubscribe from this list: send the line unsubscribe linux-iio in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
On 23 May 2013 02:46, Jonathan Cameron ji...@kernel.org wrote: On 05/20/2013 06:09 PM, Doug Anderson wrote: Naveen, On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* - struct platform_device* - struct exynos_adc* seems wrong. Instead we should be doing struct device* - struct iio_dev* - struct exynos_adc* Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- drivers/iio/adc/exynos_adc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org Applied to the fixes-togreg branch of iio.git I'll hopefully send these on to Greg before the weekend. Jonathan, I would like to know any comments on https://patchwork.kernel.org/patch/2513361/ Its been pending for a while now. Thanks, Naveen -- To unsubscribe from this list: send the line unsubscribe linux-iio in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
The exynos_adc device structure was wrongly extracted from the dev*
correcting the same.
Using the regular conversion of
struct device* - struct platform_device* - struct exynos_adc* seems wrong.
Instead we should be doing
struct device* - struct iio_dev* - struct exynos_adc*
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
drivers/iio/adc/exynos_adc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index a6c4df5..2347df5 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -403,8 +403,8 @@ static int exynos_adc_remove(struct platform_device *pdev)
#ifdef CONFIG_PM_SLEEP
static int exynos_adc_suspend(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct exynos_adc *info = platform_get_drvdata(pdev);
+ struct iio_dev *indio_dev = dev_get_drvdata(dev);
+ struct exynos_adc *info = iio_priv(indio_dev);
u32 con;
if (info-version == ADC_V2) {
@@ -426,8 +426,8 @@ static int exynos_adc_suspend(struct device *dev)
static int exynos_adc_resume(struct device *dev)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct exynos_adc *info = platform_get_drvdata(pdev);
+ struct iio_dev *indio_dev = dev_get_drvdata(dev);
+ struct exynos_adc *info = iio_priv(indio_dev);
int ret;
ret = regulator_enable(info-vdd);
--
1.7.12.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iio: exynos_adc: fix wrong structure extration in suspend and resume
Naveen, On Sun, May 19, 2013 at 11:34 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: The exynos_adc device structure was wrongly extracted from the dev* correcting the same. Using the regular conversion of struct device* - struct platform_device* - struct exynos_adc* seems wrong. Instead we should be doing struct device* - struct iio_dev* - struct exynos_adc* Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- drivers/iio/adc/exynos_adc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
