Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-18 Thread Lee Jones 
On Mon, 16 Jun 2014, Doug Anderson wrote:

 From: Bill Richardson wfric...@chromium.org
 
 struct cros_ec_device has a superfluous name field. We can get all the
 debugging info we need from the existing ec_name and phys_name fields, so
 let's take out the extra field.
 
 Signed-off-by: Bill Richardson wfric...@chromium.org
 Signed-off-by: Doug Anderson diand...@chromium.org
 ---
  drivers/mfd/cros_ec.c   | 2 +-
  drivers/mfd/cros_ec_i2c.c   | 1 -
  drivers/mfd/cros_ec_spi.c   | 1 -
  include/linux/mfd/cros_ec.h | 2 --
  4 files changed, 1 insertion(+), 5 deletions(-)

For the re-spin:
  Acked-by: Lee Jones lee.jo...@linaro.org

 diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
 index 9304056..d242714 100644
 --- a/drivers/mfd/cros_ec.c
 +++ b/drivers/mfd/cros_ec.c
 @@ -138,7 +138,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
   goto fail_mfd;
   }
  
 - dev_info(dev, Chrome EC (%s)\n, ec_dev-name);
 + dev_info(dev, Chrome EC device registered\n);
  
   return 0;
  
 diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
 index 37ed12f..5bb32f5 100644
 --- a/drivers/mfd/cros_ec_i2c.c
 +++ b/drivers/mfd/cros_ec_i2c.c
 @@ -132,7 +132,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
   return -ENOMEM;
  
   i2c_set_clientdata(client, ec_dev);
 - ec_dev-name = I2C;
   ec_dev-dev = dev;
   ec_dev-priv = client;
   ec_dev-irq = client-irq;
 diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
 index 2d713fe..09ca789 100644
 --- a/drivers/mfd/cros_ec_spi.c
 +++ b/drivers/mfd/cros_ec_spi.c
 @@ -374,7 +374,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
   cros_ec_spi_dt_probe(ec_spi, dev);
  
   spi_set_drvdata(spi, ec_dev);
 - ec_dev-name = SPI;
   ec_dev-dev = dev;
   ec_dev-priv = ec_spi;
   ec_dev-irq = spi-irq;
 diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
 index f27c037..2b0c598 100644
 --- a/include/linux/mfd/cros_ec.h
 +++ b/include/linux/mfd/cros_ec.h
 @@ -67,7 +67,6 @@ struct cros_ec_command {
   * @command_recv: receive a response
   * @command_sendrecv: send a command and receive a response
   *
 - * @name: Name of this EC interface
   * @priv: Private data
   * @irq: Interrupt to use
   * @din: input buffer (for data from EC)
 @@ -104,7 +103,6 @@ struct cros_ec_device {
   void *in_buf, int in_len);
  
   /* These are used to implement the platform-specific interface */
 - const char *name;
   void *priv;
   int irq;
   uint8_t *din;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass 
Hi Doug,

On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote:
 From: Bill Richardson wfric...@chromium.org

 struct cros_ec_device has a superfluous name field. We can get all the
 debugging info we need from the existing ec_name and phys_name fields, so
 let's take out the extra field.

Except that it no longer prints I2C/SPI - i.e. the transport that is
used. Is that not considered important?

Anyway:

Reviewed-by: Simon Glass s...@chromium.org

Regards,
Simon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Doug Anderson 
Simon,

On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass s...@chromium.org wrote:
 Hi Doug,

 On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote:
 From: Bill Richardson wfric...@chromium.org

 struct cros_ec_device has a superfluous name field. We can get all the
 debugging info we need from the existing ec_name and phys_name fields, so
 let's take out the extra field.

 Except that it no longer prints I2C/SPI - i.e. the transport that is
 used. Is that not considered important?

Before this change:
  [1.895472] cros-ec-spi spi2.0: Chrome EC (SPI)

After this change:
  [1.910671] cros-ec-spi spi2.0: Chrome EC device registered


I think having SPI in the name twice is probably enough.  ;)

-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass 
Hi Doug,

On 17 June 2014 21:22, Doug Anderson diand...@chromium.org wrote:

 Simon,

 On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass s...@chromium.org wrote:
  Hi Doug,
 
  On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote:
  From: Bill Richardson wfric...@chromium.org
 
  struct cros_ec_device has a superfluous name field. We can get all the
  debugging info we need from the existing ec_name and phys_name fields, so
  let's take out the extra field.
 
  Except that it no longer prints I2C/SPI - i.e. the transport that is
  used. Is that not considered important?

 Before this change:
   [1.895472] cros-ec-spi spi2.0: Chrome EC (SPI)

 After this change:
   [1.910671] cros-ec-spi spi2.0: Chrome EC device registered


 I think having SPI in the name twice is probably enough.  ;)

Ah that helps! Could have been in the commit message.

Reviewed-by: Simon Glass s...@chromium.org

Regards,
Simon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Doug Anderson 
Simon,

On Tue, Jun 17, 2014 at 9:25 PM, Simon Glass s...@chromium.org wrote:
 Hi Doug,

 On 17 June 2014 21:22, Doug Anderson diand...@chromium.org wrote:

 Simon,

 On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass s...@chromium.org wrote:
  Hi Doug,
 
  On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote:
  From: Bill Richardson wfric...@chromium.org
 
  struct cros_ec_device has a superfluous name field. We can get all the
  debugging info we need from the existing ec_name and phys_name fields, so
  let's take out the extra field.
 
  Except that it no longer prints I2C/SPI - i.e. the transport that is
  used. Is that not considered important?

 Before this change:
   [1.895472] cros-ec-spi spi2.0: Chrome EC (SPI)

 After this change:
   [1.910671] cros-ec-spi spi2.0: Chrome EC device registered


 I think having SPI in the name twice is probably enough.  ;)

 Ah that helps! Could have been in the commit message.

 Reviewed-by: Simon Glass s...@chromium.org

If I re-spin the series I'll add it.  I think the new message was in
the original commit in the TEST= clause and I left it out.  I
probably should have added it in with the proper wording...

-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-16 Thread Doug Anderson 
From: Bill Richardson wfric...@chromium.org

struct cros_ec_device has a superfluous name field. We can get all the
debugging info we need from the existing ec_name and phys_name fields, so
let's take out the extra field.

Signed-off-by: Bill Richardson wfric...@chromium.org
Signed-off-by: Doug Anderson diand...@chromium.org
---
 drivers/mfd/cros_ec.c   | 2 +-
 drivers/mfd/cros_ec_i2c.c   | 1 -
 drivers/mfd/cros_ec_spi.c   | 1 -
 include/linux/mfd/cros_ec.h | 2 --
 4 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index 9304056..d242714 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -138,7 +138,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
goto fail_mfd;
}
 
-   dev_info(dev, Chrome EC (%s)\n, ec_dev-name);
+   dev_info(dev, Chrome EC device registered\n);
 
return 0;
 
diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
index 37ed12f..5bb32f5 100644
--- a/drivers/mfd/cros_ec_i2c.c
+++ b/drivers/mfd/cros_ec_i2c.c
@@ -132,7 +132,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client,
return -ENOMEM;
 
i2c_set_clientdata(client, ec_dev);
-   ec_dev-name = I2C;
ec_dev-dev = dev;
ec_dev-priv = client;
ec_dev-irq = client-irq;
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index 2d713fe..09ca789 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -374,7 +374,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
cros_ec_spi_dt_probe(ec_spi, dev);
 
spi_set_drvdata(spi, ec_dev);
-   ec_dev-name = SPI;
ec_dev-dev = dev;
ec_dev-priv = ec_spi;
ec_dev-irq = spi-irq;
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index f27c037..2b0c598 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -67,7 +67,6 @@ struct cros_ec_command {
  * @command_recv: receive a response
  * @command_sendrecv: send a command and receive a response
  *
- * @name: Name of this EC interface
  * @priv: Private data
  * @irq: Interrupt to use
  * @din: input buffer (for data from EC)
@@ -104,7 +103,6 @@ struct cros_ec_device {
void *in_buf, int in_len);
 
/* These are used to implement the platform-specific interface */
-   const char *name;
void *priv;
int irq;
uint8_t *din;
-- 
2.0.0.526.g5318336

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html