Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
On Friday 05 September 2014 14:04:18 Paul Bolle wrote: > > On Thu, 2014-09-04 at 18:02 +0200, Arnd Bergmann wrote: > > I think it would be nice if you could submit a patch to remove the > > drivers from ASoC, then we can see if anybody complains. > > Just to know what I'm getting my self into: whom would you expect to > send me agitated messages once those patches have landed? That would be somebody who is using their own patches on top of mainline and didn't notice that upstream broke under them ;-) Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
Hi Arnd, On Thu, 2014-09-04 at 18:02 +0200, Arnd Bergmann wrote: > I think it would be nice if you could submit a patch to remove the > drivers from ASoC, then we can see if anybody complains. Just to know what I'm getting my self into: whom would you expect to send me agitated messages once those patches have landed? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
On Thursday 04 September 2014, Paul Bolle wrote: > > On Wed, 2014-07-16 at 14:53 +0200, Tomasz Figa wrote: > > I believe that both sound card drivers for Goni and Aquilla could be > > replaced with simple cards in DT, so I'll send a follow-up patch for this. > > References to MACH_GONI and MACH_AQUILA can still be seen in v3.17-rc3 > and next-20140903. Note that as consequence SND_SOC_GONI_AQUILA_WM8994 > can not be set anymore. > > > Most likely the same is the case for SMDK boards, but they don't seem to > > have any active users (see cover letter for more details), which means > > that probably they could be simply dropped from > > sound/soc/samsung/Kconfig in another follow-up patch. > > Ditto for MACH_SMDKC100, MACH_SMDKC110, and MACH_SMDKV210. Note that > here SND_SOC_SMDK_WM8580_PCM can not be set anymore. > > (This is intended to be a gentile reminder. I hope it actually comes > across like that.) At least I find those reminders useful. We clearly have a bug here that was recently introduced, and we should fix that. I think it would be nice if you could submit a patch to remove the drivers from ASoC, then we can see if anybody complains. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
On Wed, 2014-07-16 at 14:53 +0200, Tomasz Figa wrote: > I believe that both sound card drivers for Goni and Aquilla could be > replaced with simple cards in DT, so I'll send a follow-up patch for this. References to MACH_GONI and MACH_AQUILA can still be seen in v3.17-rc3 and next-20140903. Note that as consequence SND_SOC_GONI_AQUILA_WM8994 can not be set anymore. > Most likely the same is the case for SMDK boards, but they don't seem to > have any active users (see cover letter for more details), which means > that probably they could be simply dropped from > sound/soc/samsung/Kconfig in another follow-up patch. Ditto for MACH_SMDKC100, MACH_SMDKC110, and MACH_SMDKV210. Note that here SND_SOC_SMDK_WM8580_PCM can not be set anymore. (This is intended to be a gentile reminder. I hope it actually comes across like that.) Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
On 16.07.2014 12:04, Paul Bolle wrote: > On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote: [snip] >> - >> -config MACH_AQUILA >> -bool "Aquila" >> -select CPU_S5PV210 >> -select S3C_DEV_FB >> -select S3C_DEV_HSMMC >> -select S3C_DEV_HSMMC1 >> -select S3C_DEV_HSMMC2 >> -select S5PV210_SETUP_FB_24BPP >> -select S5PV210_SETUP_SDHCI >> -select S5PV210_SETUP_USB_PHY >> -select S5P_DEV_FIMC0 >> -select S5P_DEV_FIMC1 >> -select S5P_DEV_FIMC2 >> -select S5P_DEV_ONENAND >> -help >> - Machine support for the Samsung Aquila target based on S5PC110 SoC >> - > > This symbol is still referenced in sound/soc/samsung/Kconfig. More code that I missed. I believe that both sound card drivers for Goni and Aquilla could be replaced with simple cards in DT, so I'll send a follow-up patch for this. Most likely the same is the case for SMDK boards, but they don't seem to have any active users (see cover letter for more details), which means that probably they could be simply dropped from sound/soc/samsung/Kconfig in another follow-up patch. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 11/19] ARM: S5PV210: Remove support for board files
On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote: > Since all in-tree boards have been moved to device tree, we can now drop > legacy code and make mach-s5pv210 DT-only. This patch does it. > > Signed-off-by: Tomasz Figa > --- This patch showed up in next-20140716 too. >[...] > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index ed492cf..d6d0f92 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -19,181 +19,8 @@ config CPU_S5PV210 > help > Enable S5PV210 CPU support > > -config S5PV210_SETUP_I2C1 > - bool > - help > - Common setup code for i2c bus 1. > - > -config S5PV210_SETUP_I2C2 > - bool > - help > - Common setup code for i2c bus 2. > - > -config S5PV210_SETUP_IDE > - bool > - help > - Common setup code for S5PV210 IDE GPIO configurations > - > -config S5PV210_SETUP_FB_24BPP > - bool > - help > - Common setup code for S5PV210 with an 24bpp RGB display helper. > - > -config S5PV210_SETUP_KEYPAD > - bool > - help > - Common setup code for keypad. > - > -config S5PV210_SETUP_SDHCI > -bool > -select S5PV210_SETUP_SDHCI_GPIO > -help > - Internal helper functions for S5PV210 based SDHCI systems > - > -config S5PV210_SETUP_SDHCI_GPIO > - bool > - help > - Common setup code for SDHCI gpio. > - > -config S5PV210_SETUP_FIMC > - bool > - help > - Common setup code for the camera interfaces. > - > -config S5PV210_SETUP_SPI > - bool > - help > - Common setup code for SPI GPIO configurations. > - > -config S5PV210_SETUP_USB_PHY > - bool > - help > - Common setup code for USB PHY controller > - > -menu "S5PC110 Machines" > - > -config MACH_AQUILA > - bool "Aquila" > - select CPU_S5PV210 > - select S3C_DEV_FB > - select S3C_DEV_HSMMC > - select S3C_DEV_HSMMC1 > - select S3C_DEV_HSMMC2 > - select S5PV210_SETUP_FB_24BPP > - select S5PV210_SETUP_SDHCI > - select S5PV210_SETUP_USB_PHY > - select S5P_DEV_FIMC0 > - select S5P_DEV_FIMC1 > - select S5P_DEV_FIMC2 > - select S5P_DEV_ONENAND > - help > - Machine support for the Samsung Aquila target based on S5PC110 SoC > - This symbol is still referenced in sound/soc/samsung/Kconfig. > -config MACH_GONI > - bool "GONI" > - select CPU_S5PV210 > - select S3C_DEV_FB > - select S3C_DEV_HSMMC > - select S3C_DEV_HSMMC1 > - select S3C_DEV_HSMMC2 > - select S3C_DEV_I2C1 > - select S3C_DEV_I2C2 > - select S3C_DEV_USB_HSOTG > - select S5PV210_SETUP_FB_24BPP > - select S5PV210_SETUP_FIMC > - select S5PV210_SETUP_I2C1 > - select S5PV210_SETUP_I2C2 > - select S5PV210_SETUP_KEYPAD > - select S5PV210_SETUP_SDHCI > - select S5PV210_SETUP_USB_PHY > - select S5P_DEV_FIMC0 > - select S5P_DEV_FIMC1 > - select S5P_DEV_FIMC2 > - select S5P_DEV_MFC > - select S5P_DEV_ONENAND > - select S5P_DEV_TV > - select S5P_GPIO_INT > - select SAMSUNG_DEV_KEYPAD > - help > - Machine support for Samsung GONI board > - S5PC110(MCP) is one of package option of S5PV210 Ditto. > -config MACH_SMDKC110 > - bool "SMDKC110" > - select CPU_S5PV210 > - select S3C_DEV_I2C1 > - select S3C_DEV_I2C2 > - select S3C_DEV_RTC > - select S3C_DEV_WDT > - select S5PV210_SETUP_I2C1 > - select S5PV210_SETUP_I2C2 > - select S5PV210_SETUP_IDE > - select S5P_DEV_FIMC0 > - select S5P_DEV_FIMC1 > - select S5P_DEV_FIMC2 > - select S5P_DEV_MFC > - select SAMSUNG_DEV_IDE > - help > - Machine support for Samsung SMDKC110 > - S5PC110(MCP) is one of package option of S5PV210 Ditto. > -endmenu > - > menu "S5PV210 Machines" > > -config MACH_SMDKV210 > - bool "SMDKV210" > - select CPU_S5PV210 > - select S3C_DEV_FB > - select S3C_DEV_HSMMC > - select S3C_DEV_HSMMC1 > - select S3C_DEV_HSMMC2 > - select S3C_DEV_HSMMC3 > - select S3C_DEV_I2C1 > - select S3C_DEV_I2C2 > - select S3C_DEV_RTC > - select S3C_DEV_USB_HSOTG > - select S3C_DEV_WDT > - select S5PV210_SETUP_FB_24BPP > - select S5PV210_SETUP_I2C1 > - select S5PV210_SETUP_I2C2 > - select S5PV210_SETUP_IDE > - select S5PV210_SETUP_KEYPAD > - select S5PV210_SETUP_SDHCI > - select S5PV210_SETUP_USB_PHY > - select S5P_DEV_FIMC0 > - select S5P_DEV_FIMC1 > - select S5P_DEV_FIMC2 > - select S5P_DEV_JPEG > - select S5P_DEV_MFC > - select SAMSUNG_DEV_ADC > - select SAMSUNG_DEV_BACKLIGHT > - select SAMSUNG_DEV_IDE > - select SAMSUNG_DEV_KEYPAD > - select SAMSUNG_DEV_PWM > - select SAMSUNG_DEV_TS > - help > - Machine support for Samsung SMDKV210 > - Ditto. > -config MACH_TORBRECK > - bool "Torbreck" > - select ARCH_SPARSEMEM_ENABLE > - select CPU_S5PV210 > - select
[PATCH 11/19] ARM: S5PV210: Remove support for board files
Since all in-tree boards have been moved to device tree, we can now drop legacy code and make mach-s5pv210 DT-only. This patch does it. Signed-off-by: Tomasz Figa --- arch/arm/mach-s5pv210/Kconfig| 173 -- arch/arm/mach-s5pv210/Makefile | 19 - arch/arm/mach-s5pv210/common.c | 281 -- arch/arm/mach-s5pv210/common.h | 17 - arch/arm/mach-s5pv210/dev-audio.c| 246 - arch/arm/mach-s5pv210/dma.c | 130 - arch/arm/mach-s5pv210/mach-aquila.c | 687 --- arch/arm/mach-s5pv210/mach-goni.c| 915 --- arch/arm/mach-s5pv210/mach-smdkc110.c| 159 -- arch/arm/mach-s5pv210/mach-smdkv210.c| 336 arch/arm/mach-s5pv210/mach-torbreck.c| 135 - arch/arm/mach-s5pv210/pm.c | 24 +- arch/arm/mach-s5pv210/setup-fb-24bpp.c | 49 -- arch/arm/mach-s5pv210/setup-fimc.c | 43 -- arch/arm/mach-s5pv210/setup-i2c0.c | 6 +- arch/arm/mach-s5pv210/setup-i2c1.c | 28 - arch/arm/mach-s5pv210/setup-i2c2.c | 28 - arch/arm/mach-s5pv210/setup-ide.c| 39 -- arch/arm/mach-s5pv210/setup-keypad.c | 24 - arch/arm/mach-s5pv210/setup-sdhci-gpio.c | 103 arch/arm/mach-s5pv210/setup-spi.c| 34 -- arch/arm/mach-s5pv210/setup-usb-phy.c| 95 arch/arm/plat-samsung/include/plat/cpu.h | 1 - 23 files changed, 8 insertions(+), 3564 deletions(-) delete mode 100644 arch/arm/mach-s5pv210/common.c delete mode 100644 arch/arm/mach-s5pv210/dev-audio.c delete mode 100644 arch/arm/mach-s5pv210/dma.c delete mode 100644 arch/arm/mach-s5pv210/mach-aquila.c delete mode 100644 arch/arm/mach-s5pv210/mach-goni.c delete mode 100644 arch/arm/mach-s5pv210/mach-smdkc110.c delete mode 100644 arch/arm/mach-s5pv210/mach-smdkv210.c delete mode 100644 arch/arm/mach-s5pv210/mach-torbreck.c delete mode 100644 arch/arm/mach-s5pv210/setup-fb-24bpp.c delete mode 100644 arch/arm/mach-s5pv210/setup-fimc.c delete mode 100644 arch/arm/mach-s5pv210/setup-i2c1.c delete mode 100644 arch/arm/mach-s5pv210/setup-i2c2.c delete mode 100644 arch/arm/mach-s5pv210/setup-ide.c delete mode 100644 arch/arm/mach-s5pv210/setup-keypad.c delete mode 100644 arch/arm/mach-s5pv210/setup-sdhci-gpio.c delete mode 100644 arch/arm/mach-s5pv210/setup-spi.c delete mode 100644 arch/arm/mach-s5pv210/setup-usb-phy.c diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index ed492cf..d6d0f92 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b/arch/arm/mach-s5pv210/Kconfig @@ -19,181 +19,8 @@ config CPU_S5PV210 help Enable S5PV210 CPU support -config S5PV210_SETUP_I2C1 - bool - help - Common setup code for i2c bus 1. - -config S5PV210_SETUP_I2C2 - bool - help - Common setup code for i2c bus 2. - -config S5PV210_SETUP_IDE - bool - help - Common setup code for S5PV210 IDE GPIO configurations - -config S5PV210_SETUP_FB_24BPP - bool - help - Common setup code for S5PV210 with an 24bpp RGB display helper. - -config S5PV210_SETUP_KEYPAD - bool - help - Common setup code for keypad. - -config S5PV210_SETUP_SDHCI -bool -select S5PV210_SETUP_SDHCI_GPIO -help - Internal helper functions for S5PV210 based SDHCI systems - -config S5PV210_SETUP_SDHCI_GPIO - bool - help - Common setup code for SDHCI gpio. - -config S5PV210_SETUP_FIMC - bool - help - Common setup code for the camera interfaces. - -config S5PV210_SETUP_SPI - bool - help - Common setup code for SPI GPIO configurations. - -config S5PV210_SETUP_USB_PHY - bool - help - Common setup code for USB PHY controller - -menu "S5PC110 Machines" - -config MACH_AQUILA - bool "Aquila" - select CPU_S5PV210 - select S3C_DEV_FB - select S3C_DEV_HSMMC - select S3C_DEV_HSMMC1 - select S3C_DEV_HSMMC2 - select S5PV210_SETUP_FB_24BPP - select S5PV210_SETUP_SDHCI - select S5PV210_SETUP_USB_PHY - select S5P_DEV_FIMC0 - select S5P_DEV_FIMC1 - select S5P_DEV_FIMC2 - select S5P_DEV_ONENAND - help - Machine support for the Samsung Aquila target based on S5PC110 SoC - -config MACH_GONI - bool "GONI" - select CPU_S5PV210 - select S3C_DEV_FB - select S3C_DEV_HSMMC - select S3C_DEV_HSMMC1 - select S3C_DEV_HSMMC2 - select S3C_DEV_I2C1 - select S3C_DEV_I2C2 - select S3C_DEV_USB_HSOTG - select S5PV210_SETUP_FB_24BPP - select S5PV210_SETUP_FIMC - select S5PV210_SETUP_I2C1 - select S5PV210_SETUP_I2C2 - select S5PV210_SETUP_KEYPAD - select S5PV210_SETUP_SDHCI - select S5PV210_SETUP_USB_PHY - select S5P_DEV_FIMC0 - select S5P_DEV_FIMC1 - select S5P_DEV_FIMC2 - select S5P_
