Re: [PATCH 18/20] ARM: dts: Update device tree source files for EXYNOS5250
On 3 May 2012 01:25, Olof Johansson wrote:
> Hi,
>
> On Mon, Apr 30, 2012 at 12:14 PM, Thomas Abraham
> wrote:
>> Updated EXYNOS5 device tree source files to reflect changes in rev1
>> of EXYNOS5 SoC. This includes new additions to the EXYNOS5 dtsi and
>> SMDK5250 dts files and few minor fixes.
>>
>> Signed-off-by: Thomas Abraham
>> Signed-off-by: Kukjin Kim
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 52
>> +
>> arch/arm/boot/dts/exynos5250.dtsi | 44 +++-
>> 2 files changed, 65 insertions(+), 31 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index 399d17b..bcc4b89 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -23,4 +23,56 @@
>> chosen {
>> bootargs = "root=/dev/ram0 rw ramdisk=8192
>> console=ttySAC1,115200";
>> };
>> +
>> + i2c@12C6 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> Two nits:
>
> #a-c and #s-c is likely to always be 1/0, so you might as well move
> these to the dtsi file for the SoC.
This is fixed.
>
> Also, we tend to use non-caps here and in other locations (so it
> should be 12c6 here).
The dtsi file uses 'C' instead of 'c'. So any change here in dts file
would require a change in the dtsi file as well. So adding this change
in this patch does not seem correct. So I will not do this change for
now.
Thanks,
Thomas.
>
>
> -Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 18/20] ARM: dts: Update device tree source files for EXYNOS5250
Hi,
On Mon, Apr 30, 2012 at 12:14 PM, Thomas Abraham
wrote:
> Updated EXYNOS5 device tree source files to reflect changes in rev1
> of EXYNOS5 SoC. This includes new additions to the EXYNOS5 dtsi and
> SMDK5250 dts files and few minor fixes.
>
> Signed-off-by: Thomas Abraham
> Signed-off-by: Kukjin Kim
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 52
> +
> arch/arm/boot/dts/exynos5250.dtsi | 44 +++-
> 2 files changed, 65 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 399d17b..bcc4b89 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -23,4 +23,56 @@
> chosen {
> bootargs = "root=/dev/ram0 rw ramdisk=8192
> console=ttySAC1,115200";
> };
> +
> + i2c@12C6 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Two nits:
#a-c and #s-c is likely to always be 1/0, so you might as well move
these to the dtsi file for the SoC.
Also, we tend to use non-caps here and in other locations (so it
should be 12c6 here).
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 18/20] ARM: dts: Update device tree source files for EXYNOS5250
Updated EXYNOS5 device tree source files to reflect changes in rev1
of EXYNOS5 SoC. This includes new additions to the EXYNOS5 dtsi and
SMDK5250 dts files and few minor fixes.
Signed-off-by: Thomas Abraham
Signed-off-by: Kukjin Kim
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 52 +
arch/arm/boot/dts/exynos5250.dtsi | 44 +++-
2 files changed, 65 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 399d17b..bcc4b89 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -23,4 +23,56 @@
chosen {
bootargs = "root=/dev/ram0 rw ramdisk=8192
console=ttySAC1,115200";
};
+
+ i2c@12C6 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <2>;
+ gpios = <&gpb3 0 2 3 0>,
+ <&gpb3 1 2 3 0>;
+
+ eeprom@50 {
+ compatible = "samsung,s524ad0xd1";
+ reg = <0x50>;
+ };
+ };
+
+ i2c@12C7 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <2>;
+ gpios = <&gpb3 2 2 3 0>,
+ <&gpb3 3 2 3 0>;
+
+ eeprom@51 {
+ compatible = "samsung,s524ad0xd1";
+ reg = <0x51>;
+ };
+ };
+
+ i2c@12C8 {
+ status = "disabled";
+ };
+
+ i2c@12C9 {
+ status = "disabled";
+ };
+
+ i2c@12CA {
+ status = "disabled";
+ };
+
+ i2c@12CB {
+ status = "disabled";
+ };
+
+ i2c@12CC {
+ status = "disabled";
+ };
+
+ i2c@12CD {
+ status = "disabled";
+ };
};
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index dfc4335..76b7dba 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -23,11 +23,11 @@
compatible = "samsung,exynos5250";
interrupt-parent = <&gic>;
- gic:interrupt-controller@1049 {
+ gic:interrupt-controller@10481000 {
compatible = "arm,cortex-a9-gic";
#interrupt-cells = <3>;
interrupt-controller;
- reg = <0x1049 0x1000>, <0x1048 0x100>;
+ reg = <0x10481000 0x1000>, <0x10482000 0x2000>;
};
watchdog {
@@ -42,30 +42,6 @@
interrupts = <0 43 0>, <0 44 0>;
};
- sdhci@1220 {
- compatible = "samsung,exynos4210-sdhci";
- reg = <0x1220 0x100>;
- interrupts = <0 75 0>;
- };
-
- sdhci@1221 {
- compatible = "samsung,exynos4210-sdhci";
- reg = <0x1221 0x100>;
- interrupts = <0 76 0>;
- };
-
- sdhci@1222 {
- compatible = "samsung,exynos4210-sdhci";
- reg = <0x1222 0x100>;
- interrupts = <0 77 0>;
- };
-
- sdhci@1223 {
- compatible = "samsung,exynos4210-sdhci";
- reg = <0x1223 0x100>;
- interrupts = <0 78 0>;
- };
-
serial@12C0 {
compatible = "samsung,exynos4210-uart";
reg = <0x12C0 0x100>;
@@ -157,13 +133,13 @@
interrupts = <0 35 0>;
};
- mdma0: pdma@1080 {
+ mdma0: mdma@1080 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x1080 0x1000>;
interrupts = <0 33 0>;
};
- mdma1: pdma@11C1 {
+ mdma1: mdma@11C1 {
compatible = "arm,pl330", "arm,primecell";
reg = <0x11C1 0x1000>;
interrupts = <0 124 0>;
@@ -242,6 +218,12 @@
#gpio-cells = <4>;
};
+ gpc4: gpio-controller@114002E0 {
+ compatible = "samsung,exynos4-gpio";
+ reg = <0x114002E0 0x20>;
+ #gpio-cells = <4>;
+ };
+
gpd0: gpio-controller@11400160 {
compatible = "samsung,exynos4-gpio";
reg = <0x11400160 0x20>;
@@ -388,19 +370,19 @@
gpv2: gpio-controller@10D10040 {
compatible = "samsung,exynos4-gpio";
- reg = <0x10D10040 0x20>;
+ reg = <0x10D10060 0x20>;
