Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-22 Thread Lee Jones
On Thu, 25 Jun 2015, Lee Jones wrote:

 On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
 
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
  
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
  (X86 || ARM)
  
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
  
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
  
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
 
 Applied for v4.3, thanks.

Now applied for v4.2, thanks.

  diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
  index d3235e6f1953..653815950aa2 100644
  --- a/drivers/mfd/Kconfig
  +++ b/drivers/mfd/Kconfig
  @@ -94,7 +94,6 @@ config MFD_AXP20X
   
   config MFD_CROS_EC
  tristate ChromeOS Embedded Controller
  -   depends on X86 || ARM
  select MFD_CORE
  select CHROME_PLATFORMS
  select CROS_EC_PROTO
 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-21 Thread Javier Martinez Canillas
Hello Paul,

On Wed, Jul 22, 2015 at 3:13 AM, Paul Gortmaker
paul.gortma...@windriver.com wrote:
 [Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 
 (Thu 10:44) Javier Martinez Canillas wrote:

 Hello Lee,

 On 06/25/2015 10:38 AM, Lee Jones wrote:
  On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
 
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
 
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct 
  dependencies (X86 || ARM)
 
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
 
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
 
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
 
  Applied for v4.3, thanks.
 

 Thanks a lot.

 Olof,

 Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
 Since both patches 1/3 and 2/3 are needed to fix the build warning for
 !X86 and !ARM architectures.

 Hi all,

 Wondering if this fell through the cracks.  It used to be just a
 linux-next issue, but now it is a mainline issue.  This _really_ should
 be fixed and fed to Linus ASAP.  Ideally it should have been fixed before
 going to mainline as it was reported in plenty of time ; that is the
 whole point of linux-next to fix unanticipated fallout and revise.


Sorry that I didn't follow up on this but I recently changed jobs and
was quite busy and travelling.

The problem as is explained above in the quoted text is that $subject
is not enough to fix the issue, patch 1/3 should also be picked but
that is waiting for Olof's ack.
I agree that both patches 1/3 and 2/3 have to be sent as an -rc fix
since the commit that introduced the issue made it to 4.2.

Patch 3/3 can wait for 4.3 which BTW I see that has not been applied either.

 --
 paul@builder:~/git/linux-head$ git describe
 v4.2-rc3
 paul@builder:~/git/linux-head$ echo $ARCH
 sparc64
 paul@builder:~/git/linux-head$ make allyesconfig
 scripts/kconfig/conf  --allyesconfig Kconfig
 warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct 
 dependencies (X86 || ARM)
 #
 # configuration written to .config
 #
 paul@builder:~/git/linux-head$
 --

 Thanks,
 Paul.
 --


Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-21 Thread Olof Johansson
On Tue, Jul 21, 2015 at 6:13 PM, Paul Gortmaker
paul.gortma...@windriver.com wrote:
 [Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 
 (Thu 10:44) Javier Martinez Canillas wrote:

 Hello Lee,

 On 06/25/2015 10:38 AM, Lee Jones wrote:
  On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
 
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
 
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct 
  dependencies (X86 || ARM)
 
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
 
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
 
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
 
  Applied for v4.3, thanks.
 

 Thanks a lot.

 Olof,

 Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
 Since both patches 1/3 and 2/3 are needed to fix the build warning for
 !X86 and !ARM architectures.

 Hi all,

 Wondering if this fell through the cracks.  It used to be just a
 linux-next issue, but now it is a mainline issue.  This _really_ should
 be fixed and fed to Linus ASAP.  Ideally it should have been fixed before
 going to mainline as it was reported in plenty of time ; that is the
 whole point of linux-next to fix unanticipated fallout and revise.

Yep, agreed. I've been a bit removed from upstream work for the last
couple of months (getting back to it now), so I've been bad at
following up on this.

Acks sent now, Lee, please pick up for 4.2 if you don't mind.


-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-21 Thread Olof Johansson
On Thu, Jun 25, 2015 at 10:44:28AM +0200, Javier Martinez Canillas wrote:
 Hello Lee,
 
 On 06/25/2015 10:38 AM, Lee Jones wrote:
  On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
  
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
  
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
  (X86 || ARM)
  
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
  
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
  
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
  
  Applied for v4.3, thanks.
  
 
 Thanks a lot.
 
 Olof,
 
 Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
 Since both patches 1/3 and 2/3 are needed to fix the build warning for
 !X86 and !ARM architectures.

Yep, done.

-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-07-21 Thread Paul Gortmaker
[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 
(Thu 10:44) Javier Martinez Canillas wrote:

 Hello Lee,
 
 On 06/25/2015 10:38 AM, Lee Jones wrote:
  On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
  
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
  
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
  (X86 || ARM)
  
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
  
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
  
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
  
  Applied for v4.3, thanks.
  
 
 Thanks a lot.
 
 Olof,
 
 Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
 Since both patches 1/3 and 2/3 are needed to fix the build warning for
 !X86 and !ARM architectures.

Hi all,

Wondering if this fell through the cracks.  It used to be just a
linux-next issue, but now it is a mainline issue.  This _really_ should
be fixed and fed to Linus ASAP.  Ideally it should have been fixed before 
going to mainline as it was reported in plenty of time ; that is the
whole point of linux-next to fix unanticipated fallout and revise.

--
paul@builder:~/git/linux-head$ git describe 
v4.2-rc3
paul@builder:~/git/linux-head$ echo $ARCH
sparc64
paul@builder:~/git/linux-head$ make allyesconfig
scripts/kconfig/conf  --allyesconfig Kconfig
warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct 
dependencies (X86 || ARM)
#
# configuration written to .config
#
paul@builder:~/git/linux-head$ 
--

Thanks,
Paul.
--

 
 Best regards,
 Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-06-30 Thread Paul Gortmaker
[Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM] On 25/06/2015 
(Thu 10:44) Javier Martinez Canillas wrote:

 Hello Lee,
 
 On 06/25/2015 10:38 AM, Lee Jones wrote:
  On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
  
  A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
  
  (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
  (X86 || ARM)
  
  This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
  that dependency was removed since there isn't a reason why the option can
  not be selected on other architectures. So now the above warning will not
  happen and the MFD_CROS_EC dependency can be removed since is not needed.
  
  Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
  ---
  
   drivers/mfd/Kconfig | 1 -
   1 file changed, 1 deletion(-)
  
  Applied for v4.3, thanks.
  
 
 Thanks a lot.
 
 Olof,
 
 Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
 Since both patches 1/3 and 2/3 are needed to fix the build warning for
 !X86 and !ARM architectures.

Checking this didn't fall through the cracks ; still seeing the issue
in xtensa (and other arch) builds of linux-next currently:

http://kisskb.ellerman.id.au/kisskb/buildresult/12452368/

Paul.
--

 
 Best regards,
 Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-06-25 Thread Lee Jones
On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

 A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
 
 (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
 (X86 || ARM)
 
 This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
 that dependency was removed since there isn't a reason why the option can
 not be selected on other architectures. So now the above warning will not
 happen and the MFD_CROS_EC dependency can be removed since is not needed.
 
 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
 ---
 
  drivers/mfd/Kconfig | 1 -
  1 file changed, 1 deletion(-)

Applied for v4.3, thanks.

 diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
 index d3235e6f1953..653815950aa2 100644
 --- a/drivers/mfd/Kconfig
 +++ b/drivers/mfd/Kconfig
 @@ -94,7 +94,6 @@ config MFD_AXP20X
  
  config MFD_CROS_EC
   tristate ChromeOS Embedded Controller
 - depends on X86 || ARM
   select MFD_CORE
   select CHROME_PLATFORMS
   select CROS_EC_PROTO

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-06-25 Thread Javier Martinez Canillas
Hello Lee,

On 06/25/2015 10:38 AM, Lee Jones wrote:
 On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
 
 A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
 
 (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies 
 (X86 || ARM)
 
 This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
 that dependency was removed since there isn't a reason why the option can
 not be selected on other architectures. So now the above warning will not
 happen and the MFD_CROS_EC dependency can be removed since is not needed.
 
 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
 ---
 
  drivers/mfd/Kconfig | 1 -
  1 file changed, 1 deletion(-)
 
 Applied for v4.3, thanks.
 

Thanks a lot.

Olof,

Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
Since both patches 1/3 and 2/3 are needed to fix the build warning for
!X86 and !ARM architectures.

Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

2015-06-24 Thread Javier Martinez Canillas
A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:

(MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 
|| ARM)

This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
that dependency was removed since there isn't a reason why the option can
not be selected on other architectures. So now the above warning will not
happen and the MFD_CROS_EC dependency can be removed since is not needed.

Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index d3235e6f1953..653815950aa2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -94,7 +94,6 @@ config MFD_AXP20X
 
 config MFD_CROS_EC
tristate ChromeOS Embedded Controller
-   depends on X86 || ARM
select MFD_CORE
select CHROME_PLATFORMS
select CROS_EC_PROTO
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html