[PATCH 2/3] s5p-g2d: add G2D to mach-nuri
G2D is a 2D graphics accelerator engine present in the s5p family
of Samsung SoCs. It is capable of bitblt and raster operations on
images having dimensions of up to 8000x8000.
Signed-off-by: Kamil Debski
Signed-off-by: Kyungmin Park
---
arch/arm/mach-exynos/Kconfig |1 +
arch/arm/mach-exynos/mach-nuri.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4e36e8f..3bd0eec 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -271,6 +271,7 @@ config MACH_NURI
select S5P_DEV_FIMC1
select S5P_DEV_FIMC2
select S5P_DEV_FIMC3
+ select S5P_DEV_G2D
select S5P_DEV_MFC
select S5P_DEV_USB_EHCI
select S5P_SETUP_MIPIPHY
diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
index 4df7d3e..3df8bf4 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -1261,6 +1261,7 @@ static struct platform_device *nuri_devices[] __initdata
= {
&s3c_device_i2c3,
&i2c9_gpio,
&s3c_device_adc,
+ &s5p_device_g2d,
&s3c_device_rtc,
&s5p_device_mfc,
&s5p_device_mfc_l,
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
Hi Kamil,
On 9 December 2011 21:34, Kamil Debski wrote:
> Signed-off-by: Kamil Debski
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> arch/arm/mach-exynos/mach-nuri.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 0afcc3b..176092c 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -171,6 +171,7 @@ config MACH_SMDKV310
> select S5P_DEV_FIMC1
> select S5P_DEV_FIMC2
> select S5P_DEV_FIMC3
> + select S5P_DEV_G2D
Shouldn't this entry be under "config MACH_NURI" instead of MACH_SMDKV310 ?
> select S5P_DEV_I2C_HDMIPHY
> select S5P_DEV_MFC
> select S5P_DEV_TV
> diff --git a/arch/arm/mach-exynos/mach-nuri.c
> b/arch/arm/mach-exynos/mach-nuri.c
> index 236bbe1..5251e91 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[]
> __initdata = {
> &s3c_device_i2c3,
> &i2c9_gpio,
> &s3c_device_adc,
> + &s5p_device_g2d,
> &s3c_device_rtc,
> &s5p_device_mfc,
> &s5p_device_mfc_l,
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
Kyungmin Park wrote: > > On 12/20/11, Mark Brown wrote: > > On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: > >> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > > > >> > I'm not sure I understand why we would not be ready to do things like > >> > this? I'd also expect that doing things in a board specific fashion > >> > might create issues with things being set up twice. > > > >> Please see the below, > >> https://lkml.org/lkml/2011/11/15/16 > > > >> Even though I can't agree with his opinions. There are other voice like > >> this. > > > >> I also want to common registration and select at each board. > > > > So, I looked at the discussion there and I'm not sure I'm buying what's > > being said; it seems to be as much a fear of change and a lack of > > awareness of modern infrastructure as anything else. It seems to me > > that this is a case where we should just be turning round and saying > > that the default position ought to be the other way around, if things > > need to be done per board there should be a strong reason for it. > > Please ask the Mr. Kim. Now he's working on common file so include > these functionality. > then other boards can follow up. > Hi, I'm not sure it can be included on common.c now, anyway let me check it soon. Merry Christmas. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On 12/20/11, Mark Brown wrote: > On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: >> On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > >> > I'm not sure I understand why we would not be ready to do things like >> > this? I'd also expect that doing things in a board specific fashion >> > might create issues with things being set up twice. > >> Please see the below, >> https://lkml.org/lkml/2011/11/15/16 > >> Even though I can't agree with his opinions. There are other voice like >> this. > >> I also want to common registration and select at each board. > > So, I looked at the discussion there and I'm not sure I'm buying what's > being said; it seems to be as much a fear of change and a lack of > awareness of modern infrastructure as anything else. It seems to me > that this is a case where we should just be turning round and saying > that the default position ought to be the other way around, if things > need to be done per board there should be a strong reason for it. Please ask the Mr. Kim. Now he's working on common file so include these functionality. then other boards can follow up. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On Mon, Dec 12, 2011 at 11:32:28PM +0900, Kyungmin Park wrote: > On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown > > I'm not sure I understand why we would not be ready to do things like > > this? I'd also expect that doing things in a board specific fashion > > might create issues with things being set up twice. > Please see the below, > https://lkml.org/lkml/2011/11/15/16 > Even though I can't agree with his opinions. There are other voice like this. > I also want to common registration and select at each board. So, I looked at the discussion there and I'm not sure I'm buying what's being said; it seems to be as much a fear of change and a lack of awareness of modern infrastructure as anything else. It seems to me that this is a case where we should just be turning round and saying that the default position ought to be the other way around, if things need to be done per board there should be a strong reason for it. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On Mon, Dec 12, 2011 at 7:03 PM, Mark Brown wrote: > On Mon, Dec 12, 2011 at 06:27:30PM +0900, Kyungmin Park wrote: >> On 12/12/11, Mark Brown wrote: > >> >> + &s5p_device_g2d, > >> > For devices like g2d which are always part of the SoC and which don't >> > require any external wiring on the board I was thinking we should just >> > have the core code for the SoC register the device rather than including >> > it in each board individually. It'd save effort and ensure that people >> > automatically get to use the feature. > >> I'm welcome to use these scheme. make a common.c and register it >> automatically. >> but I'm not sure we're ready to use this scheme. and I hope to start >> these work at smdk board instead of this patch. > > I'm not sure I understand why we would not be ready to do things like > this? I'd also expect that doing things in a board specific fashion > might create issues with things being set up twice. Please see the below, https://lkml.org/lkml/2011/11/15/16 Even though I can't agree with his opinions. There are other voice like this. I also want to common registration and select at each board. Thank you, Kyungmin Park > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On Mon, Dec 12, 2011 at 06:27:30PM +0900, Kyungmin Park wrote: > On 12/12/11, Mark Brown wrote: > >> + &s5p_device_g2d, > > For devices like g2d which are always part of the SoC and which don't > > require any external wiring on the board I was thinking we should just > > have the core code for the SoC register the device rather than including > > it in each board individually. It'd save effort and ensure that people > > automatically get to use the feature. > I'm welcome to use these scheme. make a common.c and register it > automatically. > but I'm not sure we're ready to use this scheme. and I hope to start > these work at smdk board instead of this patch. I'm not sure I understand why we would not be ready to do things like this? I'd also expect that doing things in a board specific fashion might create issues with things being set up twice. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On 12/12/11, Mark Brown wrote:
> On Fri, Dec 09, 2011 at 05:04:41PM +0100, Kamil Debski wrote:
>
>> index 236bbe1..5251e91 100644
>> --- a/arch/arm/mach-exynos/mach-nuri.c
>> +++ b/arch/arm/mach-exynos/mach-nuri.c
>> @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[]
>> __initdata = {
>> &s3c_device_i2c3,
>> &i2c9_gpio,
>> &s3c_device_adc,
>> +&s5p_device_g2d,
>
> For devices like g2d which are always part of the SoC and which don't
> require any external wiring on the board I was thinking we should just
> have the core code for the SoC register the device rather than including
> it in each board individually. It'd save effort and ensure that people
> automatically get to use the feature.
I'm welcome to use these scheme. make a common.c and register it automatically.
but I'm not sure we're ready to use this scheme. and I hope to start
these work at smdk board instead of this patch.
Thank you,
Kyungmin Park
>
> The crypto accelerators are another example of this - it's not really
> board specific if they're useful.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] s5p-g2d: add G2D to mach-nuri
On Fri, Dec 09, 2011 at 05:04:41PM +0100, Kamil Debski wrote:
> index 236bbe1..5251e91 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[]
> __initdata = {
> &s3c_device_i2c3,
> &i2c9_gpio,
> &s3c_device_adc,
> + &s5p_device_g2d,
For devices like g2d which are always part of the SoC and which don't
require any external wiring on the board I was thinking we should just
have the core code for the SoC register the device rather than including
it in each board individually. It'd save effort and ensure that people
automatically get to use the feature.
The crypto accelerators are another example of this - it's not really
board specific if they're useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] s5p-g2d: add G2D to mach-nuri
Signed-off-by: Kamil Debski
Signed-off-by: Kyungmin Park
---
arch/arm/mach-exynos/Kconfig |1 +
arch/arm/mach-exynos/mach-nuri.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 0afcc3b..176092c 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -171,6 +171,7 @@ config MACH_SMDKV310
select S5P_DEV_FIMC1
select S5P_DEV_FIMC2
select S5P_DEV_FIMC3
+ select S5P_DEV_G2D
select S5P_DEV_I2C_HDMIPHY
select S5P_DEV_MFC
select S5P_DEV_TV
diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
index 236bbe1..5251e91 100644
--- a/arch/arm/mach-exynos/mach-nuri.c
+++ b/arch/arm/mach-exynos/mach-nuri.c
@@ -1262,6 +1262,7 @@ static struct platform_device *nuri_devices[] __initdata
= {
&s3c_device_i2c3,
&i2c9_gpio,
&s3c_device_adc,
+ &s5p_device_g2d,
&s3c_device_rtc,
&s5p_device_mfc,
&s5p_device_mfc_l,
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] s5p-g2d: add G2D to mach-nuri
G2D is a 2D graphics accelerator engine present in the s5p family
of Samsung SoCs. It is capable of bitblt and raster operations on
images having dimensions of up to 8000x8000.
Signed-off-by: Kamil Debski
Signed-off-by: Kyungmin Park
---
arch/arm/mach-exynos4/Kconfig |1 +
arch/arm/mach-exynos4/mach-nuri.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index 876e216..374d1fc 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -218,6 +218,7 @@ config MACH_NURI
select S5P_DEV_MFC
select S3C_DEV_RTC
select S5P_DEV_USB_EHCI
+ select S5P_DEV_G2D
select S3C_DEV_USB_HSOTG
select EXYNOS4_DEV_PD
select EXYNOS4_SETUP_FIMD0
diff --git a/arch/arm/mach-exynos4/mach-nuri.c
b/arch/arm/mach-exynos4/mach-nuri.c
index 120731d..0cc44c5 100644
--- a/arch/arm/mach-exynos4/mach-nuri.c
+++ b/arch/arm/mach-exynos4/mach-nuri.c
@@ -1134,6 +1134,7 @@ static struct platform_device *nuri_devices[] __initdata
= {
&i2c9_gpio,
&s3c_device_usb_hsotg,
&s3c_device_adc,
+ &s5p_device_g2d,
&s3c_device_rtc,
&s5p_device_mfc,
&s5p_device_mfc_l,
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
