Re: [PATCH 6/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos5 platforms
On 24 May 2012 13:19, Kukjin Kim wrote:
> Thomas Abraham wrote:
>>
>> Add device nodes for the three instances of spi controllers in Exynos5
>> platforms and enable instance spi 1 for smdk5250 board.
>>
>> Signed-off-by: Thomas Abraham
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 47
>> -
>> arch/arm/boot/dts/exynos5250.dtsi | 46
>>
>> 2 files changed, 92 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index 49945cc..dca572d 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>
> [...]
>
>> - bootargs = "root=/dev/ram0 rw ramdisk=8192
>> console=ttySAC1,115200";
>> + bootargs ="root=/dev/ram0 rw ramdisk=8192
>> initrd=0x4100,8M console=ttySAC2,115200 init=/linuxrc";
>
> Yes, we need above. But it should be separated patch from here.
This is mistake. I will remove this from here. Thanks for pointing this out.
>
> [...]
>
>> + spi_1: spi@12d3 {
>> + gpios = <&gpa2 4 2 3 0>,
>> + <&gpa2 6 2 3 0>,
>> + <&gpa2 7 2 3 0>;
>> +
>> + w25q80bw@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "w25x80";
>> + reg = <0>;
>> + spi-max-frequency = <1>;
>> +
>> + controller-data {
>> + cs-gpio = <&gpa2 5 1 0 3>;
>> + samsung,spi-feedback-delay = <0>;
>> + };
>> +
>> + partition@0 {
>> + label = "U-Boot";
>> + reg = <0x0 0x4>;
>> + read-only;
>> + };
>> +
>> + partition@4 {
>> + label = "Kernel";
>> + reg = <0x4 0xc>;
>> + };
>> + };
>> + };
>
> See my previous comments on 5/6.
Yes, there is a onboard spi flash.
>
> [...]
>
>> + combiner:interrupt-controller@1044 {
>> + compatible = "samsung,exynos4210-combiner";
>> + #interrupt-cells = <2>;
>> + interrupt-controller;
>> + samsung,combiner-nr = <32>;
>> + reg = <0x1044 0x1000>;
>> + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
>> + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
>> + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
>> + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>,
>> + <0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>,
>> + <0 20 0>, <0 21 0>, <0 22 0>, <0 23 0>,
>> + <0 24 0>, <0 25 0>, <0 26 0>, <0 27 0>,
>> + <0 28 0>, <0 29 0>, <0 30 0>, <0 31 0>;
>> + };
>
> Already merged above in my tree.
Right. I completely missed this one. I will remove this from here.
Thanks a lot for your review and comments.
Regards,
Thomas.
>
> [...]
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim , Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos5 platforms
Thomas Abraham wrote:
>
> Add device nodes for the three instances of spi controllers in Exynos5
> platforms and enable instance spi 1 for smdk5250 board.
>
> Signed-off-by: Thomas Abraham
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 47
> -
> arch/arm/boot/dts/exynos5250.dtsi | 46
>
> 2 files changed, 92 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 49945cc..dca572d 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
[...]
> - bootargs = "root=/dev/ram0 rw ramdisk=8192
> console=ttySAC1,115200";
> + bootargs ="root=/dev/ram0 rw ramdisk=8192
> initrd=0x4100,8M console=ttySAC2,115200 init=/linuxrc";
Yes, we need above. But it should be separated patch from here.
[...]
> + spi_1: spi@12d3 {
> + gpios = <&gpa2 4 2 3 0>,
> + <&gpa2 6 2 3 0>,
> + <&gpa2 7 2 3 0>;
> +
> + w25q80bw@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "w25x80";
> + reg = <0>;
> + spi-max-frequency = <1>;
> +
> + controller-data {
> + cs-gpio = <&gpa2 5 1 0 3>;
> + samsung,spi-feedback-delay = <0>;
> + };
> +
> + partition@0 {
> + label = "U-Boot";
> + reg = <0x0 0x4>;
> + read-only;
> + };
> +
> + partition@4 {
> + label = "Kernel";
> + reg = <0x4 0xc>;
> + };
> + };
> + };
See my previous comments on 5/6.
[...]
> + combiner:interrupt-controller@1044 {
> + compatible = "samsung,exynos4210-combiner";
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + samsung,combiner-nr = <32>;
> + reg = <0x1044 0x1000>;
> + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
> + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
> + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
> + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>,
> + <0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>,
> + <0 20 0>, <0 21 0>, <0 22 0>, <0 23 0>,
> + <0 24 0>, <0 25 0>, <0 26 0>, <0 27 0>,
> + <0 28 0>, <0 29 0>, <0 30 0>, <0 31 0>;
> + };
Already merged above in my tree.
[...]
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/6] ARM: dts: Add nodes for spi controllers for Samsung Exynos5 platforms
Add device nodes for the three instances of spi controllers in Exynos5
platforms and enable instance spi 1 for smdk5250 board.
Signed-off-by: Thomas Abraham
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 47 -
arch/arm/boot/dts/exynos5250.dtsi | 46
2 files changed, 92 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 49945cc..dca572d 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -16,12 +16,18 @@
model = "SAMSUNG SMDK5250 board based on EXYNOS5250";
compatible = "samsung,smdk5250", "samsung,exynos5250";
+ aliases {
+ spi0 = &spi_0;
+ spi1 = &spi_1;
+ spi2 = &spi_2;
+ };
+
memory {
reg = <0x4000 0x8000>;
};
chosen {
- bootargs = "root=/dev/ram0 rw ramdisk=8192
console=ttySAC1,115200";
+ bootargs ="root=/dev/ram0 rw ramdisk=8192 initrd=0x4100,8M
console=ttySAC2,115200 init=/linuxrc";
};
i2c@12C6 {
@@ -48,6 +54,45 @@
};
};
+
+ spi_1: spi@12d3 {
+ gpios = <&gpa2 4 2 3 0>,
+ <&gpa2 6 2 3 0>,
+ <&gpa2 7 2 3 0>;
+
+ w25q80bw@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "w25x80";
+ reg = <0>;
+ spi-max-frequency = <1>;
+
+ controller-data {
+ cs-gpio = <&gpa2 5 1 0 3>;
+ samsung,spi-feedback-delay = <0>;
+ };
+
+ partition@0 {
+ label = "U-Boot";
+ reg = <0x0 0x4>;
+ read-only;
+ };
+
+ partition@4 {
+ label = "Kernel";
+ reg = <0x4 0xc>;
+ };
+ };
+ };
+
+ spi_0: spi@12d2 {
+ status = "disabled";
+ };
+
+ spi_2: spi@12d4 {
+ status = "disabled";
+ };
+
i2c@12C8 {
status = "disabled";
};
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 5ca0cdb..9d7add0 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -30,6 +30,22 @@
reg = <0x10481000 0x1000>, <0x10482000 0x2000>;
};
+ combiner:interrupt-controller@1044 {
+ compatible = "samsung,exynos4210-combiner";
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ samsung,combiner-nr = <32>;
+ reg = <0x1044 0x1000>;
+ interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
+<0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
+<0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
+<0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>,
+<0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>,
+<0 20 0>, <0 21 0>, <0 22 0>, <0 23 0>,
+<0 24 0>, <0 25 0>, <0 26 0>, <0 27 0>,
+<0 28 0>, <0 29 0>, <0 30 0>, <0 31 0>;
+ };
+
watchdog {
compatible = "samsung,s3c2410-wdt";
reg = <0x101D 0x100>;
@@ -130,6 +146,36 @@
#size-cells = <0>;
};
+ spi_0: spi@12d2 {
+ compatible = "samsung,exynos4210-spi";
+ reg = <0x12d2 0x100>;
+ interrupts = <0 66 0>;
+ tx-dma-channel = <&pdma0 5>;
+ rx-dma-channel = <&pdma0 4>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ spi_1: spi@12d3 {
+ compatible = "samsung,exynos4210-spi";
+ reg = <0x12d3 0x100>;
+ interrupts = <0 67 0>;
+ tx-dma-channel = <&pdma1 5>;
+ rx-dma-channel = <&pdma1 4>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ spi_2: spi@12d4 {
+ compatible = "samsung,exynos4210-spi";
+ reg = <0x12d4 0x100>;
+ interrupts = <0 68 0>;
+ tx-dma-channel = <&pdma0 7>;
+ rx-dma-channel = <&pdma0 6>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
amba {
#address-cells = <1>;
#size-cells = <1>;
--
1.6.6.rc2
--
To unsubscribe from this list: send the line "unsu
