[PATCH V3 2/6] ARM: s5p: remove useless churn in sleep.S
This patch cleans up sleep code in preparation for L2 resume code and hotplug functions Signed-off-by: Lorenzo Pieralisi Signed-off-by: Amit Daniel Kachhap --- arch/arm/plat-s5p/sleep.S |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-s5p/sleep.S b/arch/arm/plat-s5p/sleep.S index 0fd591b..c371ba2 100644 --- a/arch/arm/plat-s5p/sleep.S +++ b/arch/arm/plat-s5p/sleep.S @@ -23,7 +23,6 @@ */ #include -#include .text @@ -44,6 +43,9 @@ * other way of restoring the stack pointer after sleep, and we * must not write to the code segment (code is read-only) */ + .align + .data ENTRY(s3c_cpu_resume) b cpu_resume +ENDPROC(s3c_cpu_resume) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 2/6] ARM: s5p: remove useless churn in sleep.S
On Tue, Nov 22, 2011 at 03:05:28PM +0530, Amit Daniel Kachhap wrote: > This patch cleans up sleep code in preparation for L2 resume code > and hotplug functions I wonder whether anyone read the comments in this file before they changed the section for the code. /* * sleep magic, to allow the bootloader to check for an valid * image to resume to. Must be the first word before the * s3c_cpu_resume entry. */ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V3 2/6] ARM: s5p: remove useless churn in sleep.S
On Tue, Nov 22, 2011 at 3:18 PM, Russell King - ARM Linux wrote: > On Tue, Nov 22, 2011 at 03:05:28PM +0530, Amit Daniel Kachhap wrote: >> This patch cleans up sleep code in preparation for L2 resume code >> and hotplug functions > > I wonder whether anyone read the comments in this file before they > changed the section for the code. > /* > * sleep magic, to allow the bootloader to check for an valid > * image to resume to. Must be the first word before the > * s3c_cpu_resume entry. > */ Ok,This looks like an error. Thanks for pointing this out. Will put the entire section into data. > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
