RE: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416
Heiko Stübner wrote: This is the second installment of beginning devicetree support the Samsung S3C24xx architectures and focuses on the s3c2416 for now. Included is the devicetree support for the s3c24xx irq controller and basic support for smdk2416 boards, which can sucessfully boot. After the discussion with Thomas Abraham on v1 and staring to long at all of this, I'm not even sure if having the interrupt mapping in the binding is the correct way to go anymore. The key positive aspect of this solution is, that after everything is running via dt all the SoC specific mapping tables in the driver can go away, cutting its length in half. The other option would be as Thomas suggested to define specific irq- controller types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and keep the mapping data in the code, as it is now. So I would be very thankful for a bit of guidance on what is the better way. The series depends on the finalized s3c24xx irq rework, which probably won't make it into 3.9 and also the clocksource dt support by Tomasz Figa, which are not in any tree yet. Changes since v1: - adapt to changes in the underlying s3c24xx irq rework = more shared init code - use irqchip infrastructure - limit number of possible irq-types to not encode implementation details into the binding - include new samsung-clocksource Heiko Stuebner (3): ARM: S3C24XX: move irq driver to drivers/irqchip irqchip: irq-s3c24xx: add devicetree support ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs .../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++ arch/arm/boot/dts/Makefile |1 + arch/arm/boot/dts/s3c2416-smdk2416.dts | 79 arch/arm/boot/dts/s3c2416.dtsi | 193 arch/arm/boot/dts/s3c24xx.dtsi | 165 + arch/arm/mach-s3c24xx/Kconfig | 10 + arch/arm/mach-s3c24xx/Makefile |3 +- arch/arm/mach-s3c24xx/mach-s3c2416-dt.c| 91 + drivers/irqchip/Makefile |1 + .../irq.c = drivers/irqchip/irq-s3c24xx.c | 128 + 10 files changed, 723 insertions(+), 1 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt- controller/samsung,s3c24xx-irq.txt create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts create mode 100644 arch/arm/boot/dts/s3c2416.dtsi create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c rename arch/arm/mach-s3c24xx/irq.c = drivers/irqchip/irq-s3c24xx.c (92%) -- 1.7.2.3 Basically, looks good to me and thanks for your effort. BTW, if you don't mind, would be better to send to upstream next time. Because I need to consider other s3c24xx SoCs for DT... Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416
Am Mittwoch, 10. April 2013, 12:15:48 schrieb Kukjin Kim:
Heiko Stübner wrote:
This is the second installment of beginning devicetree support the
Samsung S3C24xx architectures and focuses on the s3c2416 for now.
Included is the devicetree support for the s3c24xx irq controller and
basic support for smdk2416 boards, which can sucessfully boot.
After the discussion with Thomas Abraham on v1 and staring to long at all
of
this, I'm not even sure if having the interrupt mapping in the binding
is the correct way to go anymore.
The key positive aspect of this solution is, that after everything is
running
via dt all the SoC specific mapping tables in the driver can go away,
cutting
its length in half.
The other option would be as Thomas suggested to define specific irq-
controller
types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and
keep
the mapping data in the code, as it is now.
So I would be very thankful for a bit of guidance on what is the better
way.
The series depends on the finalized s3c24xx irq rework, which probably
won't
make it into 3.9 and also the clocksource dt support by Tomasz Figa,
which are not in any tree yet.
Changes since v1:
- adapt to changes in the underlying s3c24xx irq rework
= more shared init code
- use irqchip infrastructure
- limit number of possible irq-types to not encode implementation details
into the binding
- include new samsung-clocksource
Heiko Stuebner (3):
ARM: S3C24XX: move irq driver to drivers/irqchip
irqchip: irq-s3c24xx: add devicetree support
ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs
.../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/s3c2416-smdk2416.dts | 79
arch/arm/boot/dts/s3c2416.dtsi | 193
arch/arm/boot/dts/s3c24xx.dtsi
| 165 + arch/arm/mach-s3c24xx/Kconfig
| 10 +
arch/arm/mach-s3c24xx/Makefile |3 +-
arch/arm/mach-s3c24xx/mach-s3c2416-dt.c| 91 +
drivers/irqchip/Makefile |1 +
.../irq.c = drivers/irqchip/irq-s3c24xx.c | 128 +
10 files changed, 723 insertions(+), 1 deletions(-)
create mode 100644 Documentation/devicetree/bindings/interrupt-
controller/samsung,s3c24xx-irq.txt
create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts
create mode 100644 arch/arm/boot/dts/s3c2416.dtsi
create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi
create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c
rename arch/arm/mach-s3c24xx/irq.c = drivers/irqchip/irq-s3c24xx.c
(92%)
--
1.7.2.3
Basically, looks good to me and thanks for your effort.
BTW, if you don't mind, would be better to send to upstream next time.
Because I need to consider other s3c24xx SoCs for DT...
hehe, you're digging up quite old stuff :-)
This of course got superseeded by the different approach to s3c24xx-irq dt-
support and the pinctrl work.
I'll send a new version of the dt support which takes into account all the
recent changes in the next couple of days.
Of course I'm ok with delaying this until 3.11. At least all the building
blocks (irq and pinctrl) are there now.
Heiko
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416
This is the second installment of beginning devicetree support the Samsung S3C24xx architectures and focuses on the s3c2416 for now. Included is the devicetree support for the s3c24xx irq controller and basic support for smdk2416 boards, which can sucessfully boot. After the discussion with Thomas Abraham on v1 and staring to long at all of this, I'm not even sure if having the interrupt mapping in the binding is the correct way to go anymore. The key positive aspect of this solution is, that after everything is running via dt all the SoC specific mapping tables in the driver can go away, cutting its length in half. The other option would be as Thomas suggested to define specific irq-controller types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and keep the mapping data in the code, as it is now. So I would be very thankful for a bit of guidance on what is the better way. The series depends on the finalized s3c24xx irq rework, which probably won't make it into 3.9 and also the clocksource dt support by Tomasz Figa, which are not in any tree yet. Changes since v1: - adapt to changes in the underlying s3c24xx irq rework = more shared init code - use irqchip infrastructure - limit number of possible irq-types to not encode implementation details into the binding - include new samsung-clocksource Heiko Stuebner (3): ARM: S3C24XX: move irq driver to drivers/irqchip irqchip: irq-s3c24xx: add devicetree support ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs .../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++ arch/arm/boot/dts/Makefile |1 + arch/arm/boot/dts/s3c2416-smdk2416.dts | 79 arch/arm/boot/dts/s3c2416.dtsi | 193 arch/arm/boot/dts/s3c24xx.dtsi | 165 + arch/arm/mach-s3c24xx/Kconfig | 10 + arch/arm/mach-s3c24xx/Makefile |3 +- arch/arm/mach-s3c24xx/mach-s3c2416-dt.c| 91 + drivers/irqchip/Makefile |1 + .../irq.c = drivers/irqchip/irq-s3c24xx.c | 128 + 10 files changed, 723 insertions(+), 1 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/samsung,s3c24xx-irq.txt create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts create mode 100644 arch/arm/boot/dts/s3c2416.dtsi create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c rename arch/arm/mach-s3c24xx/irq.c = drivers/irqchip/irq-s3c24xx.c (92%) -- 1.7.2.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
