Re: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used
On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org +#ifdef CONFIG_OF Wouldn't it be better to use #ifdef CONFIG_PINCTRL_SAMSUNG? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used
On 21 August 2012 17:35, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org +#ifdef CONFIG_OF Wouldn't it be better to use #ifdef CONFIG_PINCTRL_SAMSUNG? Yes, this would be better. I will fix this. Yours, Linus Walleij Thanks, Thomas. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
