Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi Kukjin, Felipe,
Since the issue is only with arch patches, which I am going to resolve
asap, Will it be possible for you to consider taking only driver
patches? I can resend arch patches separately to linux-samsung after
updating if Kukjin is also fine with that?
Thanks,
Praveen
On Wed, Nov 14, 2012 at 9:38 AM, Praveen Paneri wrote:
> Hi,
>
> On Mon, Nov 12, 2012 at 10:11 AM, Kukjin Kim wrote:
>> Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>> Hi :-)
>>
>> [...]
>>
>>> Sure, but I still need Kukjin's 'say-so' for the arch/arm/plat-samsung
>>> and arch/arm/mach-exynos part.
>>>
>> Basically, this approach looks OK to me.
>>
>> BTW, I have some comments and need to update...
> Thanks! I highly appreciate your comments. It would have been even
> better if I had got these before the closing bell.
>>
>> From 4th patch...
>>
>>> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-
>>> s3c64xx/mach-smdk6410.c
>>
>> [...]
>>
>>> @@ -72,6 +73,8 @@
>>> #include
>>> #include
>>> #include
>>> +#include
> Well it comes from an older state where without this it was giving a
> build error. Although it shouldn't have been here. Will fix it.
>>
>> Why? In addition, this causes build error with s3c6400_defconfig.
>>
>> [...]
>>
>>> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
>>> index 03f654d..9cdb666 100644
>>
>> [...]
>>
>>> @@ -1370,6 +1371,30 @@ struct platform_device s5p_device_mixer = {
>>>
>>> /* USB */
>>>
>>> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
>>> +/* USB PHY*/
>>> +static struct resource samsung_usbphy_resource[] = {
>>> + [0] = {
>>> + .start = S3C_PA_USB_PHY,
>>> + .end = S3C_PA_USB_PHY + SZ_16 - 1,
>>> + .flags = IORESOURCE_MEM,
>>> + },
>>> +};
>>
>> +static struct resource samsung_usbphy_resource[] = {
>> + [0] = DEFINED_RES_MEM(S3C_PA_USB_PHY, SZ_16),
>> +};
>>
>> [...]
>>
>> Happens build error with s5pv210_defconfig
>>
>> arch/arm/plat-samsung/devs.c:1375: error: 'S3C_PA_USB_PHY' undeclared here
>> (not in a function)
>> make[2]: *** [arch/arm/plat-samsung/devs.o] Error 1
>> make[1]: *** [arch/arm/plat-samsung] Error 2
>> make[1]: *** Waiting for unfinished jobs
>>
>> And another build error with exynos_defconfig...
> Will check for both the configs and resolve it.
>
> Thanks,
> Praveen
>>
>> arch/arm/mach-exynos/built-in.o: In function `.LANCHOR1':
>> setup-i2c0.c:(.data+0x8080): undefined reference to
>> `s5p_usb_phy_pmu_isolation'
>>
>> From 5th patch
>>
>> If possible, please to use 'ARM: [sub-arch dir name]: [subject]' format.
>> So I preferred to use 'ARM: EXYNOS: Enabling samsung-usbphy driver for
>> EXYNOS4210' on that.
>>
>> Please make sure your patch has no problem for kernel compilation before
>> submitting...
>>
>> Thanks.
>>
>> Best regards,
>> Kgene.
>> --
>> Kukjin Kim , Senior Engineer,
>> SW Solution Development Team, Samsung Electronics Co., Ltd.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
>> in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi,
On Mon, Nov 12, 2012 at 10:11 AM, Kukjin Kim wrote:
> Felipe Balbi wrote:
>>
>> Hi,
>>
> Hi :-)
>
> [...]
>
>> Sure, but I still need Kukjin's 'say-so' for the arch/arm/plat-samsung
>> and arch/arm/mach-exynos part.
>>
> Basically, this approach looks OK to me.
>
> BTW, I have some comments and need to update...
Thanks! I highly appreciate your comments. It would have been even
better if I had got these before the closing bell.
>
> From 4th patch...
>
>> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-
>> s3c64xx/mach-smdk6410.c
>
> [...]
>
>> @@ -72,6 +73,8 @@
>> #include
>> #include
>> #include
>> +#include
Well it comes from an older state where without this it was giving a
build error. Although it shouldn't have been here. Will fix it.
>
> Why? In addition, this causes build error with s3c6400_defconfig.
>
> [...]
>
>> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
>> index 03f654d..9cdb666 100644
>
> [...]
>
>> @@ -1370,6 +1371,30 @@ struct platform_device s5p_device_mixer = {
>>
>> /* USB */
>>
>> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
>> +/* USB PHY*/
>> +static struct resource samsung_usbphy_resource[] = {
>> + [0] = {
>> + .start = S3C_PA_USB_PHY,
>> + .end = S3C_PA_USB_PHY + SZ_16 - 1,
>> + .flags = IORESOURCE_MEM,
>> + },
>> +};
>
> +static struct resource samsung_usbphy_resource[] = {
> + [0] = DEFINED_RES_MEM(S3C_PA_USB_PHY, SZ_16),
> +};
>
> [...]
>
> Happens build error with s5pv210_defconfig
>
> arch/arm/plat-samsung/devs.c:1375: error: 'S3C_PA_USB_PHY' undeclared here
> (not in a function)
> make[2]: *** [arch/arm/plat-samsung/devs.o] Error 1
> make[1]: *** [arch/arm/plat-samsung] Error 2
> make[1]: *** Waiting for unfinished jobs
>
> And another build error with exynos_defconfig...
Will check for both the configs and resolve it.
Thanks,
Praveen
>
> arch/arm/mach-exynos/built-in.o: In function `.LANCHOR1':
> setup-i2c0.c:(.data+0x8080): undefined reference to
> `s5p_usb_phy_pmu_isolation'
>
> From 5th patch
>
> If possible, please to use 'ARM: [sub-arch dir name]: [subject]' format.
> So I preferred to use 'ARM: EXYNOS: Enabling samsung-usbphy driver for
> EXYNOS4210' on that.
>
> Please make sure your patch has no problem for kernel compilation before
> submitting...
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim , Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Felipe Balbi wrote:
>
> Hi,
>
Hi :-)
[...]
> Sure, but I still need Kukjin's 'say-so' for the arch/arm/plat-samsung
> and arch/arm/mach-exynos part.
>
Basically, this approach looks OK to me.
BTW, I have some comments and need to update...
>From 4th patch...
> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-
> s3c64xx/mach-smdk6410.c
[...]
> @@ -72,6 +73,8 @@
> #include
> #include
> #include
> +#include
Why? In addition, this causes build error with s3c6400_defconfig.
[...]
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 03f654d..9cdb666 100644
[...]
> @@ -1370,6 +1371,30 @@ struct platform_device s5p_device_mixer = {
>
> /* USB */
>
> +#ifdef CONFIG_S3C_DEV_USB_HSOTG
> +/* USB PHY*/
> +static struct resource samsung_usbphy_resource[] = {
> + [0] = {
> + .start = S3C_PA_USB_PHY,
> + .end = S3C_PA_USB_PHY + SZ_16 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> +};
+static struct resource samsung_usbphy_resource[] = {
+ [0] = DEFINED_RES_MEM(S3C_PA_USB_PHY, SZ_16),
+};
[...]
Happens build error with s5pv210_defconfig
arch/arm/plat-samsung/devs.c:1375: error: 'S3C_PA_USB_PHY' undeclared here
(not in a function)
make[2]: *** [arch/arm/plat-samsung/devs.o] Error 1
make[1]: *** [arch/arm/plat-samsung] Error 2
make[1]: *** Waiting for unfinished jobs
And another build error with exynos_defconfig...
arch/arm/mach-exynos/built-in.o: In function `.LANCHOR1':
setup-i2c0.c:(.data+0x8080): undefined reference to
`s5p_usb_phy_pmu_isolation'
>From 5th patch
If possible, please to use 'ARM: [sub-arch dir name]: [subject]' format.
So I preferred to use 'ARM: EXYNOS: Enabling samsung-usbphy driver for
EXYNOS4210' on that.
Please make sure your patch has no problem for kernel compilation before
submitting...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi, On Fri, Nov 09, 2012 at 06:50:44PM +0530, Praveen Paneri wrote: > Hi, > > On Fri, Nov 9, 2012 at 6:06 PM, Kyungmin Park wrote: > > On Fri, Nov 9, 2012 at 8:54 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: > >>> Changes from v6: > >>> Modified register definitions according to the existing ones. > >>> Changed default PHY clk selection for SoCs. > >>> Improved binding text and rebased to the latest usb-next. > >>> > >>> Changes from v5: > >>> Moved clk_get() to driver's probe function. Now reference clock frequency > >>> selection value is stored in samsung_usbphy structure for later use. Used > >>> IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). > >>> > >>> Changes from v4: > >>> Moved header file contents to driver's source file > >>> Removed unnecessary print message from driver's probe function > >>> Dropped the Free Software Foundation address from the header > >>> Changed the platform data code to use __initdata > >>> > >>> Changes from v3: > >>> Replaced susbsys_initcall()/module_exit() by module_platform_driver(). > >>> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver > >>> is registered > >>> Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. > >>> > >>> Changes from v2: > >>> Changed the driver filenames to samsung-usbphy > >>> Changed 's3c' to 'samsung' for platform device as well as platform data > >>> Moved platform data structure to a separate file > >>> Rectified coding style related errors > >>> > >>> Changes from v1: > >>> Rebased patches to latest usb-next branch > >>> Changed the name 'sec_usbphy' to 'samsung_usbphy' > >>> > >>> This patch set introduces a phy driver for samsung SoCs. It uses the > >>> existing > >>> transceiver infrastructure to provide phy control functions. Use of this > >>> driver > >>> can be extended for usb host phy as well. Over the period of time all the > >>> phy > >>> related code for most of the samsung SoCs can be integrated here. > >>> Removing the existing phy code from mach-s3c64xx. Same can be done for > >>> other SoCs > >>> when they start supporting this phy driver. > >>> This driver is tested with smdk6410 and Exynos4210(with DT). > >>> > >>> Praveen Paneri (5): > >>> usb: phy: samsung: Introducing usb phy driver for hsotg > >>> usb: s3c-hsotg: Adding phy driver support > > For usb parts: > > Acked-by: Kyungmin Park > Thanks for the ack. > > > >>> ARM: S3C64XX: Removing old phy setup code > >>> ARM: S3C64XX: Enabling samsung-usbphy driver > >>> ARM: Exynos4210: Enabling samsung-usbphy driver > >> > >> guys I can't wait any longer. If I don't get proper Acks today, I will > >> go ahead without all the PHY changes from Samsung :-s > > > > To Praveen, > > > > To remove these dependency and merge issue, please send patches for > > each subsystem. In this case, usb patches for usb tree and others are > > for arm arch. > I will surely take care of this from now onwards. Hope these can be > taken as it is for now. Sure, but I still need Kukjin's 'say-so' for the arch/arm/plat-samsung and arch/arm/mach-exynos part. -- balbi signature.asc Description: Digital signature
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi, On Fri, Nov 9, 2012 at 6:06 PM, Kyungmin Park wrote: > On Fri, Nov 9, 2012 at 8:54 PM, Felipe Balbi wrote: >> Hi, >> >> On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: >>> Changes from v6: >>> Modified register definitions according to the existing ones. >>> Changed default PHY clk selection for SoCs. >>> Improved binding text and rebased to the latest usb-next. >>> >>> Changes from v5: >>> Moved clk_get() to driver's probe function. Now reference clock frequency >>> selection value is stored in samsung_usbphy structure for later use. Used >>> IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). >>> >>> Changes from v4: >>> Moved header file contents to driver's source file >>> Removed unnecessary print message from driver's probe function >>> Dropped the Free Software Foundation address from the header >>> Changed the platform data code to use __initdata >>> >>> Changes from v3: >>> Replaced susbsys_initcall()/module_exit() by module_platform_driver(). >>> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver >>> is registered >>> Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. >>> >>> Changes from v2: >>> Changed the driver filenames to samsung-usbphy >>> Changed 's3c' to 'samsung' for platform device as well as platform data >>> Moved platform data structure to a separate file >>> Rectified coding style related errors >>> >>> Changes from v1: >>> Rebased patches to latest usb-next branch >>> Changed the name 'sec_usbphy' to 'samsung_usbphy' >>> >>> This patch set introduces a phy driver for samsung SoCs. It uses the >>> existing >>> transceiver infrastructure to provide phy control functions. Use of this >>> driver >>> can be extended for usb host phy as well. Over the period of time all the >>> phy >>> related code for most of the samsung SoCs can be integrated here. >>> Removing the existing phy code from mach-s3c64xx. Same can be done for >>> other SoCs >>> when they start supporting this phy driver. >>> This driver is tested with smdk6410 and Exynos4210(with DT). >>> >>> Praveen Paneri (5): >>> usb: phy: samsung: Introducing usb phy driver for hsotg >>> usb: s3c-hsotg: Adding phy driver support > For usb parts: > Acked-by: Kyungmin Park Thanks for the ack. > >>> ARM: S3C64XX: Removing old phy setup code >>> ARM: S3C64XX: Enabling samsung-usbphy driver >>> ARM: Exynos4210: Enabling samsung-usbphy driver >> >> guys I can't wait any longer. If I don't get proper Acks today, I will >> go ahead without all the PHY changes from Samsung :-s > > To Praveen, > > To remove these dependency and merge issue, please send patches for > each subsystem. In this case, usb patches for usb tree and others are > for arm arch. I will surely take care of this from now onwards. Hope these can be taken as it is for now. Thanks, Praveen > > Thank you, > Kyungmin Park >> >> -- >> balbi >> >> ___ >> linux-arm-kernel mailing list >> linux-arm-ker...@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
On Fri, Nov 9, 2012 at 8:54 PM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: >> Changes from v6: >> Modified register definitions according to the existing ones. >> Changed default PHY clk selection for SoCs. >> Improved binding text and rebased to the latest usb-next. >> >> Changes from v5: >> Moved clk_get() to driver's probe function. Now reference clock frequency >> selection value is stored in samsung_usbphy structure for later use. Used >> IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). >> >> Changes from v4: >> Moved header file contents to driver's source file >> Removed unnecessary print message from driver's probe function >> Dropped the Free Software Foundation address from the header >> Changed the platform data code to use __initdata >> >> Changes from v3: >> Replaced susbsys_initcall()/module_exit() by module_platform_driver(). >> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver >> is registered >> Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. >> >> Changes from v2: >> Changed the driver filenames to samsung-usbphy >> Changed 's3c' to 'samsung' for platform device as well as platform data >> Moved platform data structure to a separate file >> Rectified coding style related errors >> >> Changes from v1: >> Rebased patches to latest usb-next branch >> Changed the name 'sec_usbphy' to 'samsung_usbphy' >> >> This patch set introduces a phy driver for samsung SoCs. It uses the existing >> transceiver infrastructure to provide phy control functions. Use of this >> driver >> can be extended for usb host phy as well. Over the period of time all the phy >> related code for most of the samsung SoCs can be integrated here. >> Removing the existing phy code from mach-s3c64xx. Same can be done for other >> SoCs >> when they start supporting this phy driver. >> This driver is tested with smdk6410 and Exynos4210(with DT). >> >> Praveen Paneri (5): >> usb: phy: samsung: Introducing usb phy driver for hsotg >> usb: s3c-hsotg: Adding phy driver support For usb parts: Acked-by: Kyungmin Park >> ARM: S3C64XX: Removing old phy setup code >> ARM: S3C64XX: Enabling samsung-usbphy driver >> ARM: Exynos4210: Enabling samsung-usbphy driver > > guys I can't wait any longer. If I don't get proper Acks today, I will > go ahead without all the PHY changes from Samsung :-s To Praveen, To remove these dependency and merge issue, please send patches for each subsystem. In this case, usb patches for usb tree and others are for arm arch. Thank you, Kyungmin Park > > -- > balbi > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi Kukjin, On Fri, Nov 9, 2012 at 5:24 PM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: >> Changes from v6: >> Modified register definitions according to the existing ones. >> Changed default PHY clk selection for SoCs. >> Improved binding text and rebased to the latest usb-next. >> >> Changes from v5: >> Moved clk_get() to driver's probe function. Now reference clock frequency >> selection value is stored in samsung_usbphy structure for later use. Used >> IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). >> >> Changes from v4: >> Moved header file contents to driver's source file >> Removed unnecessary print message from driver's probe function >> Dropped the Free Software Foundation address from the header >> Changed the platform data code to use __initdata >> >> Changes from v3: >> Replaced susbsys_initcall()/module_exit() by module_platform_driver(). >> Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver >> is registered >> Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. >> >> Changes from v2: >> Changed the driver filenames to samsung-usbphy >> Changed 's3c' to 'samsung' for platform device as well as platform data >> Moved platform data structure to a separate file >> Rectified coding style related errors >> >> Changes from v1: >> Rebased patches to latest usb-next branch >> Changed the name 'sec_usbphy' to 'samsung_usbphy' >> >> This patch set introduces a phy driver for samsung SoCs. It uses the existing >> transceiver infrastructure to provide phy control functions. Use of this >> driver >> can be extended for usb host phy as well. Over the period of time all the phy >> related code for most of the samsung SoCs can be integrated here. >> Removing the existing phy code from mach-s3c64xx. Same can be done for other >> SoCs >> when they start supporting this phy driver. >> This driver is tested with smdk6410 and Exynos4210(with DT). >> >> Praveen Paneri (5): >> usb: phy: samsung: Introducing usb phy driver for hsotg >> usb: s3c-hsotg: Adding phy driver support >> ARM: S3C64XX: Removing old phy setup code >> ARM: S3C64XX: Enabling samsung-usbphy driver >> ARM: Exynos4210: Enabling samsung-usbphy driver > > guys I can't wait any longer. If I don't get proper Acks today, I will > go ahead without all the PHY changes from Samsung :-s Can you please ack this patch series. Thanks, Praveen > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Hi, On Tue, Oct 30, 2012 at 10:27:32AM +0530, Praveen Paneri wrote: > Changes from v6: > Modified register definitions according to the existing ones. > Changed default PHY clk selection for SoCs. > Improved binding text and rebased to the latest usb-next. > > Changes from v5: > Moved clk_get() to driver's probe function. Now reference clock frequency > selection value is stored in samsung_usbphy structure for later use. Used > IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). > > Changes from v4: > Moved header file contents to driver's source file > Removed unnecessary print message from driver's probe function > Dropped the Free Software Foundation address from the header > Changed the platform data code to use __initdata > > Changes from v3: > Replaced susbsys_initcall()/module_exit() by module_platform_driver(). > Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver > is registered > Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. > > Changes from v2: > Changed the driver filenames to samsung-usbphy > Changed 's3c' to 'samsung' for platform device as well as platform data > Moved platform data structure to a separate file > Rectified coding style related errors > > Changes from v1: > Rebased patches to latest usb-next branch > Changed the name 'sec_usbphy' to 'samsung_usbphy' > > This patch set introduces a phy driver for samsung SoCs. It uses the existing > transceiver infrastructure to provide phy control functions. Use of this > driver > can be extended for usb host phy as well. Over the period of time all the phy > related code for most of the samsung SoCs can be integrated here. > Removing the existing phy code from mach-s3c64xx. Same can be done for other > SoCs > when they start supporting this phy driver. > This driver is tested with smdk6410 and Exynos4210(with DT). > > Praveen Paneri (5): > usb: phy: samsung: Introducing usb phy driver for hsotg > usb: s3c-hsotg: Adding phy driver support > ARM: S3C64XX: Removing old phy setup code > ARM: S3C64XX: Enabling samsung-usbphy driver > ARM: Exynos4210: Enabling samsung-usbphy driver guys I can't wait any longer. If I don't get proper Acks today, I will go ahead without all the PHY changes from Samsung :-s -- balbi signature.asc Description: Digital signature
[PATCH v7 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs
Changes from v6: Modified register definitions according to the existing ones. Changed default PHY clk selection for SoCs. Improved binding text and rebased to the latest usb-next. Changes from v5: Moved clk_get() to driver's probe function. Now reference clock frequency selection value is stored in samsung_usbphy structure for later use. Used IS_ENABLED() instead of #ifdef in samsung_usbphy_get_driver_data(). Changes from v4: Moved header file contents to driver's source file Removed unnecessary print message from driver's probe function Dropped the Free Software Foundation address from the header Changed the platform data code to use __initdata Changes from v3: Replaced susbsys_initcall()/module_exit() by module_platform_driver(). Accordingly in the hsotg driver returned -EPROBE_DEFER until phy driver is registered Removed unnecessary devm_usb_put_phy() call from the hsotg driver remove. Changes from v2: Changed the driver filenames to samsung-usbphy Changed 's3c' to 'samsung' for platform device as well as platform data Moved platform data structure to a separate file Rectified coding style related errors Changes from v1: Rebased patches to latest usb-next branch Changed the name 'sec_usbphy' to 'samsung_usbphy' This patch set introduces a phy driver for samsung SoCs. It uses the existing transceiver infrastructure to provide phy control functions. Use of this driver can be extended for usb host phy as well. Over the period of time all the phy related code for most of the samsung SoCs can be integrated here. Removing the existing phy code from mach-s3c64xx. Same can be done for other SoCs when they start supporting this phy driver. This driver is tested with smdk6410 and Exynos4210(with DT). Praveen Paneri (5): usb: phy: samsung: Introducing usb phy driver for hsotg usb: s3c-hsotg: Adding phy driver support ARM: S3C64XX: Removing old phy setup code ARM: S3C64XX: Enabling samsung-usbphy driver ARM: Exynos4210: Enabling samsung-usbphy driver .../devicetree/bindings/usb/samsung-usbphy.txt | 11 + arch/arm/boot/dts/exynos4210-smdkv310.dts |5 + arch/arm/mach-exynos/include/mach/map.h|1 + arch/arm/mach-exynos/mach-exynos4-dt.c |8 + arch/arm/mach-exynos/setup-usb-phy.c | 13 + arch/arm/mach-s3c64xx/include/mach/map.h |2 + arch/arm/mach-s3c64xx/mach-crag6410.c | 10 +- arch/arm/mach-s3c64xx/mach-smartq.c| 11 +- arch/arm/mach-s3c64xx/mach-smdk6410.c | 11 +- arch/arm/mach-s3c64xx/setup-usb-phy.c | 79 + arch/arm/plat-samsung/devs.c | 28 ++ arch/arm/plat-samsung/include/plat/devs.h |1 + arch/arm/plat-samsung/include/plat/usb-phy.h |1 + drivers/usb/gadget/s3c-hsotg.c | 37 ++- drivers/usb/phy/Kconfig|8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usbphy.c | 360 include/linux/platform_data/samsung-usbphy.h | 27 ++ 18 files changed, 523 insertions(+), 91 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/samsung-usbphy.txt create mode 100644 drivers/usb/phy/samsung-usbphy.c create mode 100644 include/linux/platform_data/samsung-usbphy.h -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
