Re: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2

2015-01-21 Thread Sylwester Nawrocki 
Hi,

On 19/01/15 10:48, Inha Song wrote:
 --- a/arch/arm/boot/dts/exynos4412-trats2.dts
 +++ b/arch/arm/boot/dts/exynos4412-trats2.dts

 + sound {
 + compatible = samsung,trats2-audio;

 + assigned-clocks = pmu_system_controller 0;
 + assigned-clock-parents =  clock CLK_XUSBXTI;

How about putting these properties in the pmu_system_controller
node?  After all the mux clock being configured here belongs to
the PMU subsystem. Wouldn't it work that way ?

 + samsung,i2s-controller = i2s0;
 + samsung,model = Trats2;
 + samsung,audio-codec = wm1811;
 + samsung,audio-routing =
 + SPK, SPKOUTLN,
 + SPK, SPKOUTLP,
 + SPK, SPKOUTRN,
 + SPK, SPKOUTRP;
 + };

-- 
Regards,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2

2015-01-21 Thread Inha Song 
Hi,
Thanks for your comments.

On Wed, 21 Jan 2015 17:23:21 +0100
Sylwester Nawrocki s.nawro...@samsung.com wrote:

 Hi,
 
 On 19/01/15 10:48, Inha Song wrote:
  --- a/arch/arm/boot/dts/exynos4412-trats2.dts
  +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
 
  +   sound {
  +   compatible = samsung,trats2-audio;
 
  +   assigned-clocks = pmu_system_controller 0;
  +   assigned-clock-parents =  clock CLK_XUSBXTI;
 
 How about putting these properties in the pmu_system_controller
 node?  After all the mux clock being configured here belongs to
 the PMU subsystem. Wouldn't it work that way ?
OK, I will move assigned clock properties to pmu_system_controller DT node.

Best Regards,
Inha Song.

 
  +   samsung,i2s-controller = i2s0;
  +   samsung,model = Trats2;
  +   samsung,audio-codec = wm1811;
  +   samsung,audio-routing =
  +   SPK, SPKOUTLN,
  +   SPK, SPKOUTLP,
  +   SPK, SPKOUTRN,
  +   SPK, SPKOUTRP;
  +   };
 
 -- 
 Regards,
 Sylwester
 ___
 Alsa-devel mailing list
 alsa-de...@alsa-project.org
 http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2

2015-01-19 Thread Inha Song 
This patch add WM1811 audio codec, I2S interface and the sound
machine nodes to enable audio on exynos4412-trats2 board.

Signed-off-by: Inha Song ideal.s...@samsung.com
---
 arch/arm/boot/dts/exynos4412-trats2.dts | 39 +
 1 file changed, 39 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
b/arch/arm/boot/dts/exynos4412-trats2.dts
index 29231b4..7a52cca 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -203,6 +203,25 @@
};
};
 
+   i2c@138A {
+   samsung,i2c-sda-delay = 100;
+   samsung,i2c-slave-addr = 0x10;
+   samsung,i2c-max-bus-freq = 10;
+   pinctrl-0 = i2c4_bus;
+   pinctrl-names = default;
+   status = okay;
+
+   wm1811: wm1811@1a {
+   compatible = wlf,wm1811;
+   reg = 0x1a;
+   clocks = pmu_system_controller 0;
+   clock-names = MCLK1;
+   DCVDD-supply = ldo3_reg;
+   DBVDD1-supply = ldo3_reg;
+   wlf,ldo1ena = gpj0 4 0;
+   };
+   };
+
i2c@138D {
samsung,i2c-sda-delay = 100;
samsung,i2c-slave-addr = 0x10;
@@ -838,6 +857,26 @@
};
};
 
+   i2s0: i2s@0383 {
+   pinctrl-0 = i2s0_bus;
+   pinctrl-names = default;
+   status = okay;
+   };
+
+   sound {
+   compatible = samsung,trats2-audio;
+   assigned-clocks = pmu_system_controller 0;
+   assigned-clock-parents =  clock CLK_XUSBXTI;
+   samsung,i2s-controller = i2s0;
+   samsung,model = Trats2;
+   samsung,audio-codec = wm1811;
+   samsung,audio-routing =
+   SPK, SPKOUTLN,
+   SPK, SPKOUTLP,
+   SPK, SPKOUTRN,
+   SPK, SPKOUTRP;
+   };
+
exynos-usbphy@125B {
status = okay;
};
-- 
2.0.0.390.gcb682f8

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html