Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250
Hi Chanwoo,
On 04.07.2014 11:18, Chanwoo Choi wrote:
> Dear Kukjin and Tomasz,
>
> On 07/04/2014 05:05 PM, Tomasz Figa wrote:
>> Hi Chanwoo,
>>
>> On 03.07.2014 09:52, Chanwoo Choi wrote:
>>> From: Tomasz Figa
>>>
>>> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo
>>> (1 channels) IIS-bus for audio interface with DMA-based operation.
>>>
>>> Signed-off-by: Tomasz Figa
>>> Signed-off-by: Inha Song
>>> Tested-by: Inha Song
>>> Signed-off-by: Chanwoo Choi
>>> Acked-by: Kyungmin Park
>>> ---
>>> arch/arm/boot/dts/exynos3250.dtsi | 13 +
>>> 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>> index 1f8384f..e9017ef 100644
>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>> @@ -644,6 +644,19 @@
>>> status = "disabled";
>>> };
>>>
>>> + i2s: i2s@1397 {
>>
>> Shouldn't the label be rather called "i2s2" as the pinctrl entry below
>> suggests?
>>
>>> + compatible = "samsung,s3c6410-i2s";
>>> + reg = <0x1397 0x100>;
>>> + interrupts = <0 126 0>;
>>> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
>>> + clock-names = "iis", "i2s_opclk0";
>>> + dmas = <&pdma0 14>, <&pdma0 13>;
>>> + dma-names = "tx", "rx";
>>> + pinctrl-0 = <&i2s2_bus>;
>>> + pinctrl-name = "default";
>>
>> "pinctrl-name" is not a valid property. I suppose it should be
>> "pinctrl-names".
>
> I modify this patch as following. If you confirm following patch, I'll
> re-send patchset(v2).
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 3e678fa..77a06df 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -425,6 +425,19 @@
> status = "disabled";
> };
>
> + i2s2: i2s@1397 {
> + compatible = "samsung,s3c6410-i2s";
> + reg = <0x1397 0x100>;
> + interrupts = <0 126 0>;
> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
> + clock-names = "iis", "i2s_opclk0";
> + dmas = <&pdma0 14>, <&pdma0 13>;
> + dma-names = "tx", "rx";
> + pinctrl-0 = <&i2s2_bus>;
> + pinctrl-names = "default";
> + status = "disabled";
> + };
> +
> pwm: pwm@139D {
> compatible = "samsung,exynos4210-pwm";
> reg = <0x139D 0x1000>;
>
Looks good.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250
Dear Kukjin and Tomasz,
On 07/04/2014 05:05 PM, Tomasz Figa wrote:
> Hi Chanwoo,
>
> On 03.07.2014 09:52, Chanwoo Choi wrote:
>> From: Tomasz Figa
>>
>> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo
>> (1 channels) IIS-bus for audio interface with DMA-based operation.
>>
>> Signed-off-by: Tomasz Figa
>> Signed-off-by: Inha Song
>> Tested-by: Inha Song
>> Signed-off-by: Chanwoo Choi
>> Acked-by: Kyungmin Park
>> ---
>> arch/arm/boot/dts/exynos3250.dtsi | 13 +
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>> b/arch/arm/boot/dts/exynos3250.dtsi
>> index 1f8384f..e9017ef 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -644,6 +644,19 @@
>> status = "disabled";
>> };
>>
>> +i2s: i2s@1397 {
>
> Shouldn't the label be rather called "i2s2" as the pinctrl entry below
> suggests?
>
>> +compatible = "samsung,s3c6410-i2s";
>> +reg = <0x1397 0x100>;
>> +interrupts = <0 126 0>;
>> +clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
>> +clock-names = "iis", "i2s_opclk0";
>> +dmas = <&pdma0 14>, <&pdma0 13>;
>> +dma-names = "tx", "rx";
>> +pinctrl-0 = <&i2s2_bus>;
>> +pinctrl-name = "default";
>
> "pinctrl-name" is not a valid property. I suppose it should be
> "pinctrl-names".
I modify this patch as following. If you confirm following patch, I'll re-send
patchset(v2).
diff --git a/arch/arm/boot/dts/exynos3250.dtsi
b/arch/arm/boot/dts/exynos3250.dtsi
index 3e678fa..77a06df 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -425,6 +425,19 @@
status = "disabled";
};
+ i2s2: i2s@1397 {
+ compatible = "samsung,s3c6410-i2s";
+ reg = <0x1397 0x100>;
+ interrupts = <0 126 0>;
+ clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
+ clock-names = "iis", "i2s_opclk0";
+ dmas = <&pdma0 14>, <&pdma0 13>;
+ dma-names = "tx", "rx";
+ pinctrl-0 = <&i2s2_bus>;
+ pinctrl-names = "default";
+ status = "disabled";
+ };
+
pwm: pwm@139D {
compatible = "samsung,exynos4210-pwm";
reg = <0x139D 0x1000>;
--
1.8.0
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250
Hi Chanwoo,
On 03.07.2014 09:52, Chanwoo Choi wrote:
> From: Tomasz Figa
>
> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo
> (1 channels) IIS-bus for audio interface with DMA-based operation.
>
> Signed-off-by: Tomasz Figa
> Signed-off-by: Inha Song
> Tested-by: Inha Song
> Signed-off-by: Chanwoo Choi
> Acked-by: Kyungmin Park
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 1f8384f..e9017ef 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -644,6 +644,19 @@
> status = "disabled";
> };
>
> + i2s: i2s@1397 {
Shouldn't the label be rather called "i2s2" as the pinctrl entry below
suggests?
> + compatible = "samsung,s3c6410-i2s";
> + reg = <0x1397 0x100>;
> + interrupts = <0 126 0>;
> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
> + clock-names = "iis", "i2s_opclk0";
> + dmas = <&pdma0 14>, <&pdma0 13>;
> + dma-names = "tx", "rx";
> + pinctrl-0 = <&i2s2_bus>;
> + pinctrl-name = "default";
"pinctrl-name" is not a valid property. I suppose it should be
"pinctrl-names".
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Add I2S dt node for Exynos3250
On 07/04/2014 04:43 PM, Kukjin Kim wrote:
> Chanwoo Choi wrote:
>>
>> From: Tomasz Figa
>>
>> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo
>> (1 channels) IIS-bus for audio interface with DMA-based operation.
>>
>> Signed-off-by: Tomasz Figa
>> Signed-off-by: Inha Song
>> Tested-by: Inha Song
>> Signed-off-by: Chanwoo Choi
>> Acked-by: Kyungmin Park
>> ---
>> arch/arm/boot/dts/exynos3250.dtsi | 13 +
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>> b/arch/arm/boot/dts/exynos3250.dtsi
>> index 1f8384f..e9017ef 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -644,6 +644,19 @@
>> status = "disabled";
>> };
>>
>> +i2s: i2s@1397 {
>> +compatible = "samsung,s3c6410-i2s";
>> +reg = <0x1397 0x100>;
>> +interrupts = <0 126 0>;
>> +clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
>> +clock-names = "iis", "i2s_opclk0";
>> +dmas = <&pdma0 14>, <&pdma0 13>;
>> +dma-names = "tx", "rx";
>> +pinctrl-0 = <&i2s2_bus>;
>> +pinctrl-name = "default";
>
> To put 'pinctrl-name' and then 'pinctrl-0' is better? :-)
The i2s dt node can drop "pinctrl-0/pinctrl-name" properties.
I will re-send this patchset (v2) after fixing it.
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: dts: Add I2S dt node for Exynos3250
Chanwoo Choi wrote:
>
> From: Tomasz Figa
>
> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo
> (1 channels) IIS-bus for audio interface with DMA-based operation.
>
> Signed-off-by: Tomasz Figa
> Signed-off-by: Inha Song
> Tested-by: Inha Song
> Signed-off-by: Chanwoo Choi
> Acked-by: Kyungmin Park
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 1f8384f..e9017ef 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -644,6 +644,19 @@
> status = "disabled";
> };
>
> + i2s: i2s@1397 {
> + compatible = "samsung,s3c6410-i2s";
> + reg = <0x1397 0x100>;
> + interrupts = <0 126 0>;
> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>;
> + clock-names = "iis", "i2s_opclk0";
> + dmas = <&pdma0 14>, <&pdma0 13>;
> + dma-names = "tx", "rx";
> + pinctrl-0 = <&i2s2_bus>;
> + pinctrl-name = "default";
To put 'pinctrl-name' and then 'pinctrl-0' is better? :-)
> + status = "disabled";
> + };
> +
> pwm: pwm@139D {
> compatible = "samsung,exynos4210-pwm";
> reg = <0x139D 0x1000>;
> --
> 1.8.0
Will apply.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
