RE: [PATCH v6 5/7] ARM: S5PV210: Access for DMCx registers

2010-08-04 Thread Kukjin Kim 
MyungJoo Ham wrote:
 
   The CPUFREQ driver requires an access to DMCx registers. We
 define physical addresses and mapping between physical and virtual
 addresses of DMCx registers.
 
 Signed-off-by: MyungJoo Ham myungjoo@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/mach-s5pv210/cpu.c  |   12 +++-
  arch/arm/mach-s5pv210/include/mach/map.h |4 
  2 files changed, 15 insertions(+), 1 deletions(-)
 
 diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
 index 74d4c08..2066695 100644
 --- a/arch/arm/mach-s5pv210/cpu.c
 +++ b/arch/arm/mach-s5pv210/cpu.c
 @@ -60,7 +60,17 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
   .pfn= __phys_to_pfn(S5PV210_PA_SROMC),
   .length = SZ_4K,
   .type   = MT_DEVICE,
 - }
 + }, {
 + .virtual= (unsigned long)S5P_VA_DMC0,
 + .pfn= __phys_to_pfn(S5PV210_PA_DMC0),
 + .length = SZ_4K,
 + .type   = MT_DEVICE,
 + }, {
 + .virtual= (unsigned long)S5P_VA_DMC1,
 + .pfn= __phys_to_pfn(S5PV210_PA_DMC1),
 + .length = SZ_4K,
 + .type   = MT_DEVICE,
 + },
  };
 
  static void s5pv210_idle(void)
 diff --git a/arch/arm/mach-s5pv210/include/mach/map.h b/arch/arm/mach-
 s5pv210/include/mach/map.h
 index 17687f0..daf6456 100644
 --- a/arch/arm/mach-s5pv210/include/mach/map.h
 +++ b/arch/arm/mach-s5pv210/include/mach/map.h
 @@ -108,4 +108,8 @@
  #define SAMSUNG_PA_ADC   S5PV210_PA_ADC
  #define SAMSUNG_PA_KEYPADS5PV210_PA_KEYPAD
 
 +/* DMC */

No need an obvious comment like above...

 +#define S5PV210_PA_DMC0  (0xF000)
 +#define S5PV210_PA_DMC1  (0xF140)

As I said, if you need adding new definition into the mach/map.h, please
keep the address order like others.
It can help to us for easily reading...

 +
  #endif /* __ASM_ARCH_MAP_H */
 --

And as I commented, to merge your 4th(previous, just adding VA) and 5th
patch to one is better...just for adding DMC map IO.


Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 5/7] ARM: S5PV210: Access for DMCx registers

2010-08-04 Thread Kyungmin Park 
On Wed, Aug 4, 2010 at 8:17 PM, Kukjin Kim kgene@samsung.com wrote:
 MyungJoo Ham wrote:

       The CPUFREQ driver requires an access to DMCx registers. We
 define physical addresses and mapping between physical and virtual
 addresses of DMCx registers.

 Signed-off-by: MyungJoo Ham myungjoo@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/mach-s5pv210/cpu.c              |   12 +++-
  arch/arm/mach-s5pv210/include/mach/map.h |    4 
  2 files changed, 15 insertions(+), 1 deletions(-)

 diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
 index 74d4c08..2066695 100644
 --- a/arch/arm/mach-s5pv210/cpu.c
 +++ b/arch/arm/mach-s5pv210/cpu.c
 @@ -60,7 +60,17 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
               .pfn            = __phys_to_pfn(S5PV210_PA_SROMC),
               .length         = SZ_4K,
               .type           = MT_DEVICE,
 -     }
 +     }, {
 +             .virtual        = (unsigned long)S5P_VA_DMC0,
 +             .pfn            = __phys_to_pfn(S5PV210_PA_DMC0),
 +             .length         = SZ_4K,
 +             .type           = MT_DEVICE,
 +     }, {
 +             .virtual        = (unsigned long)S5P_VA_DMC1,
 +             .pfn            = __phys_to_pfn(S5PV210_PA_DMC1),
 +             .length         = SZ_4K,
 +             .type           = MT_DEVICE,
 +     },
  };

  static void s5pv210_idle(void)
 diff --git a/arch/arm/mach-s5pv210/include/mach/map.h b/arch/arm/mach-
 s5pv210/include/mach/map.h
 index 17687f0..daf6456 100644
 --- a/arch/arm/mach-s5pv210/include/mach/map.h
 +++ b/arch/arm/mach-s5pv210/include/mach/map.h
 @@ -108,4 +108,8 @@
  #define SAMSUNG_PA_ADC               S5PV210_PA_ADC
  #define SAMSUNG_PA_KEYPAD    S5PV210_PA_KEYPAD

 +/* DMC */

 No need an obvious comment like above...

 +#define S5PV210_PA_DMC0              (0xF000)
 +#define S5PV210_PA_DMC1              (0xF140)

 As I said, if you need adding new definition into the mach/map.h, please
 keep the address order like others.
 It can help to us for easily reading...

Good, good, good,

I'm really appreciate it if the same rules apply to LSI internal trees.
I hope you check it LSI codes also.

Thank you,
Kyungmin Park


 +
  #endif /* __ASM_ARCH_MAP_H */
 --

 And as I commented, to merge your 4th(previous, just adding VA) and 5th
 patch to one is better...just for adding DMC map IO.


 Thanks.

 Best regards,
 Kgene.
 --
 Kukjin Kim kgene@samsung.com, Senior Engineer,
 SW Solution Development Team, Samsung Electronics Co., Ltd.

 --
 To unsubscribe from this list: send the line unsubscribe linux-samsung-soc 
 in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html