Re: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h

[Arnd Bergmann]

On Tuesday 30 September 2014 15:51:21 Pankaj Dubey wrote:
 
 +static inline void pmu_raw_writel(u32 val, u32 offset)
 +{
 +   __raw_writel(val, pmu_base_addr + offset);
 +}
 +
 +static inline u32 pmu_raw_readl(u32 offset)
 +{
 +   return __raw_readl(pmu_base_addr + offset);
 +}
 +
 

While you're at it, please convert these to use readl_relaxed() instead,
which is safe to use in drivers and works independent of CPU endianess.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h

[Pankaj Dubey]

Hi Arnd,

On Tuesday, September 30, 2014 4:09 PM, Arnd Bergmann wrote,
 To: linux-arm-ker...@lists.infradead.org
 Cc: Pankaj Dubey; linux-ker...@vger.kernel.org;
linux-samsung-soc@vger.kernel.org;
 kgene@samsung.com; li...@arm.linux.org.uk; naus...@samsung.com;
 tomasz.f...@gmail.com; thomas...@samsung.com; vikas.saj...@samsung.com
 Subject: Re: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions
from
 common.h
 
 On Tuesday 30 September 2014 15:51:21 Pankaj Dubey wrote:
 
  +static inline void pmu_raw_writel(u32 val, u32 offset) {
  +   __raw_writel(val, pmu_base_addr + offset); }
  +
  +static inline u32 pmu_raw_readl(u32 offset) {
  +   return __raw_readl(pmu_base_addr + offset); }
  +
 
 
 While you're at it, please convert these to use readl_relaxed() instead,
which is safe to
 use in drivers and works independent of CPU endianess.
 

OK, I will update this. 

Thanks,
Pankaj Dubey
   Arnd

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html