Re: [PATCH] ARM: dts: add board dts file for Exynos3250-based Monk board
On Thu, Oct 02, 2014 at 01:50:25AM +0100, YoungJun Cho wrote:
> From: Youngjun Cho
>
> This patch adds new board dts file to support Samsung Monk board which is
> based on Exynos3250 SoC and has different H/W configuration from Rinato.
>
> This patch is based on linux-samsung.git for-next branch and depends on
> [PATCH 0/2] ARM: dts: Add new board dts file for Exynos3250-based Rinato
> board[1]
>
> This dts file support following features:
> - eMMC
> - Main PMIC (Samsung S2MPS14)
> - Interface PMIC (Maxim MAX77836, MUIC, fuel-gauge, charger)
> - RTC of Exynos3250
> - ADC of Exynos3250 with NTC thermistor
> - I2S of Exynos3250
> - TMU of Exynos3250
> - Secure firmware for Exynos3250 secondary cpu boot
> - Serial ports of Exynos3250
> - gpio-key for power key
>
> [1] http://www.spinics.net/lists/arm-kernel/msg366849.html
>
> Signed-off-by: Youngjun Cho
> Signed-off-by: Chanwoo Choi
> Signed-off-by: Inki Dae
> Signed-off-by: Seung-Woo Kim
> Signed-off-by: Jaehoon Chung
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/boot/dts/Makefile| 3 +-
> arch/arm/boot/dts/exynos3250-monk.dts | 592
> ++
> 2 files changed, 594 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/exynos3250-monk.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5728918..0c8ae64 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
> dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
> da850-evm.dtb
> dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
> -dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-rinato.dtb \
> +dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
> + exynos3250-rinato.dtb \
> exynos4210-origen.dtb \
> exynos4210-smdkv310.dtb \
> exynos4210-trats.dtb \
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts
> b/arch/arm/boot/dts/exynos3250-monk.dts
> new file mode 100644
> index 000..9e94294
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -0,0 +1,592 @@
> +/*
> + * Samsung's Exynos3250 based Monk board device tree source
> + *
> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * Device tree source file for Samsung's Monk board which is based on
> + * Samsung Exynos3250 SoC.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +/dts-v1/;
> +#include "exynos3250.dtsi"
> +#include
> +
> +/ {
> + model = "Samsung Monk board";
> + compatible = "samsung,monk", "samsung,exynos3250", "samsung,exynos3";
> +
> + aliases {
> + i2c7 = &i2c_max77836;
> + };
> +
> + memory {
> + reg = <0x4000 0x0800
> + 0x4800 0x0800
> + 0x5000 0x0800
> + 0x5800 0x07F0>;
Nit: please bracket list entries individually.
That said, it looks like this could be coalesced into:
memory@4000 {
reg = <0x4000 0x1ff0>;
};
> + };
> +
> + chosen {
> + bootargs = "console=ttySAC1,115200N8 root=/dev/mmcblk0p15
> rootwait earlyprintk panic=5";
> + };
> +
> + firmware@0205F000 {
> + compatible = "samsung,secure-firmware";
> + reg = <0x0205F000 0x1000>;
> + } ;
Nit: useless space before the ';'.
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> +
> + power_key {
> + interrupt-parent = <&gpx2>;
> + interrupts = <7 0>;
> + gpios = <&gpx2 7 1>;
> + linux,code = ;
> + label = "power key";
> + debounce-interval = <10>;
> + gpio-key,wakeup;
> + };
> + };
> +
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vemmc_reg: voltage-regulator-0 {
> + compatible = "regulator-fixed";
> + regulator-name = "V_EMMC_2.8V-fixed";
> + regulator-min-microvolt = <280>;
> + regulator-max-microvolt = <280>;
> + gpio = <&gpk0 2 0>;
> + enable-active-high;
> + };
> + };
Why not put this directly under the root node? There's no reason to
group regulators simply because they're regulators, and there's only one
anyhow.
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: add board dts file for Exynos3250-based Monk board
+ Adding ARM maintainers.
I know it's too late. just to know we trying to push product board
support at mainline.
Thank you,
Kyungmin Park
On Thu, Oct 2, 2014 at 9:50 AM, YoungJun Cho wrote:
> From: Youngjun Cho
>
> This patch adds new board dts file to support Samsung Monk board which is
> based on Exynos3250 SoC and has different H/W configuration from Rinato.
>
> This patch is based on linux-samsung.git for-next branch and depends on
> [PATCH 0/2] ARM: dts: Add new board dts file for Exynos3250-based Rinato
> board[1]
>
> This dts file support following features:
> - eMMC
> - Main PMIC (Samsung S2MPS14)
> - Interface PMIC (Maxim MAX77836, MUIC, fuel-gauge, charger)
> - RTC of Exynos3250
> - ADC of Exynos3250 with NTC thermistor
> - I2S of Exynos3250
> - TMU of Exynos3250
> - Secure firmware for Exynos3250 secondary cpu boot
> - Serial ports of Exynos3250
> - gpio-key for power key
>
> [1] http://www.spinics.net/lists/arm-kernel/msg366849.html
>
> Signed-off-by: Youngjun Cho
> Signed-off-by: Chanwoo Choi
> Signed-off-by: Inki Dae
> Signed-off-by: Seung-Woo Kim
> Signed-off-by: Jaehoon Chung
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/boot/dts/Makefile| 3 +-
> arch/arm/boot/dts/exynos3250-monk.dts | 592
> ++
> 2 files changed, 594 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/exynos3250-monk.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5728918..0c8ae64 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -64,7 +64,8 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
> dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
> da850-evm.dtb
> dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
> -dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-rinato.dtb \
> +dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
> + exynos3250-rinato.dtb \
> exynos4210-origen.dtb \
> exynos4210-smdkv310.dtb \
> exynos4210-trats.dtb \
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts
> b/arch/arm/boot/dts/exynos3250-monk.dts
> new file mode 100644
> index 000..9e94294
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -0,0 +1,592 @@
> +/*
> + * Samsung's Exynos3250 based Monk board device tree source
> + *
> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
> + * http://www.samsung.com
> + *
> + * Device tree source file for Samsung's Monk board which is based on
> + * Samsung Exynos3250 SoC.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +/dts-v1/;
> +#include "exynos3250.dtsi"
> +#include
> +
> +/ {
> + model = "Samsung Monk board";
> + compatible = "samsung,monk", "samsung,exynos3250", "samsung,exynos3";
> +
> + aliases {
> + i2c7 = &i2c_max77836;
> + };
> +
> + memory {
> + reg = <0x4000 0x0800
> + 0x4800 0x0800
> + 0x5000 0x0800
> + 0x5800 0x07F0>;
> + };
> +
> + chosen {
> + bootargs = "console=ttySAC1,115200N8 root=/dev/mmcblk0p15
> rootwait earlyprintk panic=5";
> + };
> +
> + firmware@0205F000 {
> + compatible = "samsung,secure-firmware";
> + reg = <0x0205F000 0x1000>;
> + } ;
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> +
> + power_key {
> + interrupt-parent = <&gpx2>;
> + interrupts = <7 0>;
> + gpios = <&gpx2 7 1>;
> + linux,code = ;
> + label = "power key";
> + debounce-interval = <10>;
> + gpio-key,wakeup;
> + };
> + };
> +
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vemmc_reg: voltage-regulator-0 {
> + compatible = "regulator-fixed";
> + regulator-name = "V_EMMC_2.8V-fixed";
> + regulator-min-microvolt = <280>;
> + regulator-max-microvolt = <280>;
> + gpio = <&gpk0 2 0>;
> + enable-active-high;
> + };
> + };
> +
> + i2c_max77836: i2c-gpio-0 {
> + compatible = "i2c-gpio";
> + gpios = <&gpd0 2 0>, <&gpd0 3 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + max77836: subpmic@25 {
> + compatible = "maxim,max77836";
> + interrupt-parent = <&gpx1>;
> + interrupts = <5 0>;
> +
