Re: [PATCH] clk: samsung: fix cpu clock's flags checking
Michael/Sylwester, could you please merge this patch? It is a bugfix for ddeac8d968d41d13a52582d6e80395a329e9b1ff (clk: samsung: add infrastructure to register cpu clocks) which got merged in v4.2-rc1. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Krzysztof Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On 29/06/15 19:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
Hello Bartlomiej, On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? I don't know what is the policy for tags but Krzysztof is correct that this email address is going away this week so for future patches please use my personal @dowhile0.org address instead. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On Tuesday, June 30, 2015 07:45:15 PM Javier Martinez Canillas wrote: Hello Bartlomiej, On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote: On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Krzysztof has noted that I should use your @dowhile0.org e-mail address instead of @collabora.co.uk one, is this right? I don't know what is the policy for tags but Krzysztof is correct that this email address is going away this week so for future patches please use my personal @dowhile0.org address instead. OK, I'll update my patches scripts then. Thank you for review. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Krzysztof Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: samsung: fix cpu clock's flags checking
On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote: CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were incorrectly used as a bit numbers. Fix it. Tested on Exynos4210 based Origen board and on Exynos5250 based Arndale board. Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Michael Turquette mturque...@baylibre.com Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Thomas Abraham thomas...@samsung.com Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/clk/samsung/clk-cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
