Re: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-18 Thread Kukjin Kim 

On 12/16/11 17:24, Kyungmin Park wrote:

Hi Mr. Kim,

It's maybe missing for v3.3 merge at samsung soc.
Please give your opinion, how to handle it?


Looks ok to me at the moment, and as a note, I'm sorting it out now.



If you don't mind it, it can merge it by devfreq.


Hmm, I think, it should be handled in samsung tree to avoid useless 
conflicts with others. And if you need this in the devfreq tree now, 
please let me know so that I can create topic branch for it.


Thanks.

Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


On 12/1/11, MyungJoo Ham  wrote:

- Add DMC1
- Enlarge address space for DMC from 4k to 64k so that PPMU registers
   may be accessed.

Signed-off-by: MyungJoo Ham
Signed-off-by: Kyungmin Park
---
  arch/arm/mach-exynos/cpu.c  |7 ++-
  arch/arm/mach-exynos/include/mach/map.h |1 +
  2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
index 90ec247..8bdcba9 100644
--- a/arch/arm/mach-exynos/cpu.c
+++ b/arch/arm/mach-exynos/cpu.c
@@ -108,7 +108,12 @@ static struct map_desc exynos4_iodesc[] __initdata = {
}, {
.virtual= (unsigned long)S5P_VA_DMC0,
.pfn= __phys_to_pfn(EXYNOS4_PA_DMC0),
-   .length = SZ_4K,
+   .length = SZ_64K,
+   .type   = MT_DEVICE,
+   }, {
+   .virtual= (unsigned long)S5P_VA_DMC1,
+   .pfn= __phys_to_pfn(EXYNOS4_PA_DMC1),
+   .length = SZ_64K,
.type   = MT_DEVICE,
}, {
.virtual= (unsigned long)S5P_VA_SROMC,
diff --git a/arch/arm/mach-exynos/include/mach/map.h
b/arch/arm/mach-exynos/include/mach/map.h
index 058541d..870a980 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -57,6 +57,7 @@
  #define EXYNOS4_PA_KEYPAD 0x100A

  #define EXYNOS4_PA_DMC0   0x1040
+#define EXYNOS4_PA_DMC10x1041

  #define EXYNOS4_PA_COMBINER   0x1044

--
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-16 Thread Kyungmin Park 
Hi Mr. Kim,

It's maybe missing for v3.3 merge at samsung soc.
Please give your opinion, how to handle it?

If you don't mind it, it can merge it by devfreq.

Thank you,
Kyungmin Park


On 12/1/11, MyungJoo Ham  wrote:
> - Add DMC1
> - Enlarge address space for DMC from 4k to 64k so that PPMU registers
>   may be accessed.
>
> Signed-off-by: MyungJoo Ham 
> Signed-off-by: Kyungmin Park 
> ---
>  arch/arm/mach-exynos/cpu.c  |7 ++-
>  arch/arm/mach-exynos/include/mach/map.h |1 +
>  2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> index 90ec247..8bdcba9 100644
> --- a/arch/arm/mach-exynos/cpu.c
> +++ b/arch/arm/mach-exynos/cpu.c
> @@ -108,7 +108,12 @@ static struct map_desc exynos4_iodesc[] __initdata = {
>   }, {
>   .virtual= (unsigned long)S5P_VA_DMC0,
>   .pfn= __phys_to_pfn(EXYNOS4_PA_DMC0),
> - .length = SZ_4K,
> + .length = SZ_64K,
> + .type   = MT_DEVICE,
> + }, {
> + .virtual= (unsigned long)S5P_VA_DMC1,
> + .pfn= __phys_to_pfn(EXYNOS4_PA_DMC1),
> + .length = SZ_64K,
>   .type   = MT_DEVICE,
>   }, {
>   .virtual= (unsigned long)S5P_VA_SROMC,
> diff --git a/arch/arm/mach-exynos/include/mach/map.h
> b/arch/arm/mach-exynos/include/mach/map.h
> index 058541d..870a980 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -57,6 +57,7 @@
>  #define EXYNOS4_PA_KEYPAD0x100A
>
>  #define EXYNOS4_PA_DMC0  0x1040
> +#define EXYNOS4_PA_DMC1  0x1041
>
>  #define EXYNOS4_PA_COMBINER  0x1044
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-03 Thread Kukjin Kim 
Kyungmin Park wrote:
> 
> On 12/2/11, Kukjin Kim  wrote:
> > MyungJoo Ham wrote:
> >>
> >> - Add DMC1
> >> - Enlarge address space for DMC from 4k to 64k so that PPMU registers
> >>   may be accessed.
> >>
> >> Signed-off-by: MyungJoo Ham 
> >> Signed-off-by: Kyungmin Park 
> >> ---
> >>  arch/arm/mach-exynos/cpu.c  |7 ++-
> >>  arch/arm/mach-exynos/include/mach/map.h |1 +
> >>  2 files changed, 7 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> >> index 90ec247..8bdcba9 100644
> >> --- a/arch/arm/mach-exynos/cpu.c
> >> +++ b/arch/arm/mach-exynos/cpu.c
> >> @@ -108,7 +108,12 @@ static struct map_desc exynos4_iodesc[] __initdata
> =
> >> {
> >>}, {
> >>.virtual= (unsigned long)S5P_VA_DMC0,
> >>.pfn= __phys_to_pfn(EXYNOS4_PA_DMC0),
> >> -  .length = SZ_4K,
> >> +  .length = SZ_64K,
> >> +  .type   = MT_DEVICE,
> >> +  }, {
> >> +  .virtual= (unsigned long)S5P_VA_DMC1,
> >> +  .pfn= __phys_to_pfn(EXYNOS4_PA_DMC1),
> >> +  .length = SZ_64K,
> >>.type   = MT_DEVICE,
> >>}, {
> >>.virtual= (unsigned long)S5P_VA_SROMC,
> >> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
> >> exynos/include/mach/map.h
> >> index 058541d..870a980 100644
> >> --- a/arch/arm/mach-exynos/include/mach/map.h
> >> +++ b/arch/arm/mach-exynos/include/mach/map.h
> >> @@ -57,6 +57,7 @@
> >>  #define EXYNOS4_PA_KEYPAD 0x100A
> >>
> >>  #define EXYNOS4_PA_DMC0   0x1040
> >> +#define EXYNOS4_PA_DMC1   0x1041
> >
> > If required, so just '.length = SZ_128K'?...
> Doesn't it more confuse and difficult to use?
> 
> Even though there's not much definitions. it defines the offset concept.
> "arch/arm/mach-exynos/include/mach/regs-mem.h"
> 
OK.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-02 Thread Kyungmin Park 
On 12/2/11, Kukjin Kim  wrote:
> MyungJoo Ham wrote:
>>
>> - Add DMC1
>> - Enlarge address space for DMC from 4k to 64k so that PPMU registers
>>   may be accessed.
>>
>> Signed-off-by: MyungJoo Ham 
>> Signed-off-by: Kyungmin Park 
>> ---
>>  arch/arm/mach-exynos/cpu.c  |7 ++-
>>  arch/arm/mach-exynos/include/mach/map.h |1 +
>>  2 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
>> index 90ec247..8bdcba9 100644
>> --- a/arch/arm/mach-exynos/cpu.c
>> +++ b/arch/arm/mach-exynos/cpu.c
>> @@ -108,7 +108,12 @@ static struct map_desc exynos4_iodesc[] __initdata =
>> {
>>  }, {
>>  .virtual= (unsigned long)S5P_VA_DMC0,
>>  .pfn= __phys_to_pfn(EXYNOS4_PA_DMC0),
>> -.length = SZ_4K,
>> +.length = SZ_64K,
>> +.type   = MT_DEVICE,
>> +}, {
>> +.virtual= (unsigned long)S5P_VA_DMC1,
>> +.pfn= __phys_to_pfn(EXYNOS4_PA_DMC1),
>> +.length = SZ_64K,
>>  .type   = MT_DEVICE,
>>  }, {
>>  .virtual= (unsigned long)S5P_VA_SROMC,
>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
>> exynos/include/mach/map.h
>> index 058541d..870a980 100644
>> --- a/arch/arm/mach-exynos/include/mach/map.h
>> +++ b/arch/arm/mach-exynos/include/mach/map.h
>> @@ -57,6 +57,7 @@
>>  #define EXYNOS4_PA_KEYPAD   0x100A
>>
>>  #define EXYNOS4_PA_DMC0 0x1040
>> +#define EXYNOS4_PA_DMC1 0x1041
>
> If required, so just '.length = SZ_128K'?...
Doesn't it more confuse and difficult to use?

Even though there's not much definitions. it defines the offset concept.
"arch/arm/mach-exynos/include/mach/regs-mem.h"

BR,
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim , Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/4] ARM: EXYNOS4: Add DMC1, allow PPMU access for DMC.

2011-12-02 Thread Kukjin Kim 
MyungJoo Ham wrote:
> 
> - Add DMC1
> - Enlarge address space for DMC from 4k to 64k so that PPMU registers
>   may be accessed.
> 
> Signed-off-by: MyungJoo Ham 
> Signed-off-by: Kyungmin Park 
> ---
>  arch/arm/mach-exynos/cpu.c  |7 ++-
>  arch/arm/mach-exynos/include/mach/map.h |1 +
>  2 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/cpu.c b/arch/arm/mach-exynos/cpu.c
> index 90ec247..8bdcba9 100644
> --- a/arch/arm/mach-exynos/cpu.c
> +++ b/arch/arm/mach-exynos/cpu.c
> @@ -108,7 +108,12 @@ static struct map_desc exynos4_iodesc[] __initdata =
> {
>   }, {
>   .virtual= (unsigned long)S5P_VA_DMC0,
>   .pfn= __phys_to_pfn(EXYNOS4_PA_DMC0),
> - .length = SZ_4K,
> + .length = SZ_64K,
> + .type   = MT_DEVICE,
> + }, {
> + .virtual= (unsigned long)S5P_VA_DMC1,
> + .pfn= __phys_to_pfn(EXYNOS4_PA_DMC1),
> + .length = SZ_64K,
>   .type   = MT_DEVICE,
>   }, {
>   .virtual= (unsigned long)S5P_VA_SROMC,
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
> exynos/include/mach/map.h
> index 058541d..870a980 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -57,6 +57,7 @@
>  #define EXYNOS4_PA_KEYPAD0x100A
> 
>  #define EXYNOS4_PA_DMC0  0x1040
> +#define EXYNOS4_PA_DMC1  0x1041

If required, so just '.length = SZ_128K'?...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html