Re: Re: [PATCH 6/8] arm: exynos: config exynos5 hdmi-hpd gpio

2012-10-04 Thread RAHUL SHARMA 
Sure Mr. park,

I will correct this in v2.
I want to request you for reviewing the other patches in the set.

regards,
Rahul Sharma

On Thu, Oct 4, 2012 at 1:45 PM, Kyungmin Park  wrote:
> On 10/5/12, Rahul Sharma  wrote:
>> This patch adds support for the configuration of exynos5 hdmi-hpd gpio.
>> It sets the gpio fucntion to EINT which is required for recieving
>> external hpd interrupt in drm hdmi driver.
>>
>> Signed-off-by: Rahul Sharma 
>> ---
>>  arch/arm/mach-exynos/mach-exynos5-dt.c |9 +
>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
>> b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> index 003963c..9a6d569 100644
>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
>> @@ -11,6 +11,7 @@
>>
>>  #include 
>>  #include 
>> +#include 
>>
>>  #include 
>>  #include 
>> @@ -18,6 +19,7 @@
>>
>>  #include 
>>  #include 
>> +#include 
>>
>>  #include "common.h"
>>
>> @@ -81,10 +83,17 @@ static void __init exynos5250_dt_map_io(void)
>>   s3c24xx_init_clocks(2400);
>>  }
>>
>> +static void smdk_hpd_setup(void)
>> +{
>> + s3c_gpio_cfgpin(EXYNOS5_GPX3(7), S3C_GPIO_SFN(0xf));
>> + s3c_gpio_setpull(EXYNOS5_GPX3(7), S3C_GPIO_PULL_DOWN);
>> +}
> these should be described at dts file instead of here. and name is not
> good. smdk...
>
> Thank you,
> Kyungmin Park
>> +
>>  static void __init exynos5250_dt_machine_init(void)
>>  {
>>   of_platform_populate(NULL, of_default_bus_match_table,
>>   exynos5250_auxdata_lookup, NULL);
>> + smdk_hpd_setup();
>>  }
>>
>>  static char const *exynos5250_dt_compat[] __initdata = {
>> --
>> 1.7.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
>> in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>

Re: [PATCH 6/8] arm: exynos: config exynos5 hdmi-hpd gpio

2012-10-04 Thread Kyungmin Park 
On 10/5/12, Rahul Sharma  wrote:
> This patch adds support for the configuration of exynos5 hdmi-hpd gpio.
> It sets the gpio fucntion to EINT which is required for recieving
> external hpd interrupt in drm hdmi driver.
>
> Signed-off-by: Rahul Sharma 
> ---
>  arch/arm/mach-exynos/mach-exynos5-dt.c |9 +
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
> b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index 003963c..9a6d569 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -11,6 +11,7 @@
>
>  #include 
>  #include 
> +#include 
>
>  #include 
>  #include 
> @@ -18,6 +19,7 @@
>
>  #include 
>  #include 
> +#include 
>
>  #include "common.h"
>
> @@ -81,10 +83,17 @@ static void __init exynos5250_dt_map_io(void)
>   s3c24xx_init_clocks(2400);
>  }
>
> +static void smdk_hpd_setup(void)
> +{
> + s3c_gpio_cfgpin(EXYNOS5_GPX3(7), S3C_GPIO_SFN(0xf));
> + s3c_gpio_setpull(EXYNOS5_GPX3(7), S3C_GPIO_PULL_DOWN);
> +}
these should be described at dts file instead of here. and name is not
good. smdk...

Thank you,
Kyungmin Park
> +
>  static void __init exynos5250_dt_machine_init(void)
>  {
>   of_platform_populate(NULL, of_default_bus_match_table,
>   exynos5250_auxdata_lookup, NULL);
> + smdk_hpd_setup();
>  }
>
>  static char const *exynos5250_dt_compat[] __initdata = {
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html