Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
Hi Daniel, On Monday, July 28, 2014 09:43:02 AM Daniel Lezcano wrote: On 07/09/2014 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). Hi Bartlomiej, what is the status of this patchset ? Is it supposed to land for 3.17 ? I posted v4 yesterday: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg35197.html When it comes to merging the patchset for 3.17 it is up to Kukjin. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Thanks -- Daniel v3: - rebased on top of next-20140708 + http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32809.html (with rejects fixed) http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32808.html http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html (with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines ARM: EXYNOS: add AFTR mode support to firmware do_idle method ARM: EXYNOS: cpuidle: add secure firmware support to AFTR mode code ARM: EXYNOS: cpuidle: allow driver usage on Exynos4x12 SoCs arch/arm/include/asm/firmware.h | 2 +- arch/arm/mach-exynos/common.h| 7 ++- arch/arm/mach-exynos/exynos.c| 3 ++- arch/arm/mach-exynos/firmware.c | 36 ++-- arch/arm/mach-exynos/pm.c| 39 +-- drivers/cpuidle/cpuidle-exynos.c | 6 +++--- 6 files changed, 67 insertions(+), 26 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
On 08/05/2014 02:04 PM, Bartlomiej Zolnierkiewicz wrote: Hi Daniel, On Monday, July 28, 2014 09:43:02 AM Daniel Lezcano wrote: On 07/09/2014 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). Hi Bartlomiej, what is the status of this patchset ? Is it supposed to land for 3.17 ? I posted v4 yesterday: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg35197.html When it comes to merging the patchset for 3.17 it is up to Kukjin. Ok, thanks for the sync up. -- Daniel Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Thanks -- Daniel v3: - rebased on top of next-20140708 + http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32809.html (with rejects fixed) http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32808.html http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html (with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines ARM: EXYNOS: add AFTR mode support to firmware do_idle method ARM: EXYNOS: cpuidle: add secure firmware support to AFTR mode code ARM: EXYNOS: cpuidle: allow driver usage on Exynos4x12 SoCs arch/arm/include/asm/firmware.h | 2 +- arch/arm/mach-exynos/common.h| 7 ++- arch/arm/mach-exynos/exynos.c| 3 ++- arch/arm/mach-exynos/firmware.c | 36 ++-- arch/arm/mach-exynos/pm.c| 39 +-- drivers/cpuidle/cpuidle-exynos.c | 6 +++--- 6 files changed, 67 insertions(+), 26 deletions(-) -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
Hi Bartlomiej, I tried to apply this patchset on top of next-20140708 but it does not apply. Do you have a more recent version ? Thanks in advance -- Daniel On 07/09/2014 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). v3: - rebased on top of next-20140708 + http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32809.html (with rejects fixed) http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32808.html http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html (with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines ARM: EXYNOS: add AFTR mode support to firmware do_idle method ARM: EXYNOS: cpuidle: add secure firmware support to AFTR mode code ARM: EXYNOS: cpuidle: allow driver usage on Exynos4x12 SoCs arch/arm/include/asm/firmware.h | 2 +- arch/arm/mach-exynos/common.h| 7 ++- arch/arm/mach-exynos/exynos.c| 3 ++- arch/arm/mach-exynos/firmware.c | 36 ++-- arch/arm/mach-exynos/pm.c| 39 +-- drivers/cpuidle/cpuidle-exynos.c | 6 +++--- 6 files changed, 67 insertions(+), 26 deletions(-) -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
On 07/09/2014 07:17 PM, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). Hi Bartlomiej, what is the status of this patchset ? Is it supposed to land for 3.17 ? Thanks -- Daniel v3: - rebased on top of next-20140708 + http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32809.html (with rejects fixed) http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32808.html http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32991.html (with rejects fixed in patch #2) - addressed review comments from Tomasz Figa and Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (4): ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines ARM: EXYNOS: add AFTR mode support to firmware do_idle method ARM: EXYNOS: cpuidle: add secure firmware support to AFTR mode code ARM: EXYNOS: cpuidle: allow driver usage on Exynos4x12 SoCs arch/arm/include/asm/firmware.h | 2 +- arch/arm/mach-exynos/common.h| 7 ++- arch/arm/mach-exynos/exynos.c| 3 ++- arch/arm/mach-exynos/firmware.c | 36 ++-- arch/arm/mach-exynos/pm.c| 39 +-- drivers/cpuidle/cpuidle-exynos.c | 6 +++--- 6 files changed, 67 insertions(+), 26 deletions(-) -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
On Monday, July 14, 2014 04:41:25 PM Daniel Drake wrote: Hi Bartlomiej, Hi, On Wed, Jul 9, 2014 at 6:17 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). Thanks for this, I have tested it on ODROID-U2. I don't have any equipment to measure the power usage, but after offlining CPUs 1,2,3 via sysfs online file, a printk I added confirms that the system is going to enter aftr mode, and system stability seems as good as ever. Thank you for testing! Is there any automatic way that the cpus should be offlined, or is the intention that it must be done by hand like this? AFAIK Android kernel disables unused CPUs by itself. There is also ongoing work on Exynos coupled cpuidle driver for upstream kernels which will handle offlining of CPUs for AFTR mode transparently to the kernel (currently only Exynos4210 SoC is supported by the driver posted by Daniel Lezcano, we are working on Exynos3250 SoC support and once it is done we might try to also do Exynos4x12 SoCs version). Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/4] ARM: EXYNOS: cpuidle: fix AFTR mode on boards with secure firmware enabled
Hi Bartlomiej, On Wed, Jul 9, 2014 at 6:17 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: This patch series adds support for AFTR idle mode on boards with secure firmware enabled and allows EXYNOS cpuidle driver usage on Exynos4x12 SoCs. It has been tested on Trats2 board (using Exynos4412 SoC with secure firmware enabled) on which AFTR mode reduces power consumption by ~12% when EXYNOS cpuidle driver is enabled (in both cases the default exynos_defconfig config is used and CPU1-3 are offlined). Thanks for this, I have tested it on ODROID-U2. I don't have any equipment to measure the power usage, but after offlining CPUs 1,2,3 via sysfs online file, a printk I added confirms that the system is going to enter aftr mode, and system stability seems as good as ever. Is there any automatic way that the cpus should be offlined, or is the intention that it must be done by hand like this? Thanks, Daniel -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
