Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
Lee, Doug,
I've bisected a boot failure on Tegra Dalmore (which has a tps65090)
down to this patch. It started in -next 0501, so I guess Lee might
have pushed some patches out now even though the commit date is a
little while back?
The commit is:
commit 60e91b51b515b20f85697fcd397911fdb97bbdca
Author: Doug Anderson diand...@chromium.org
AuthorDate: Wed Apr 16 16:12:28 2014 -0700
Commit: Lee Jones lee.jo...@linaro.org
CommitDate: Wed Apr 23 12:34:01 2014 +0100
regulator: tps65090: Allow setting the overcurrent wait time
The tps65090 regulator allows you to specify how long you want it to
wait before detecting an overcurrent condition. Allow specifying that
through the device tree (or through platform data).
Signed-off-by: Doug Anderson diand...@chromium.org
Acked-by: Simon Glass s...@chromium.org
Acked-by: Michael Spang sp...@chromium.org
Acked-by: Sean Paul seanp...@chromium.org
Acked-by: Mark Brown broo...@kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Panic is line 309:
303 for (num = 0; num TPS65090_REGULATOR_MAX; num++) {
304 tps_pdata = tps65090_pdata-reg_pdata[num];
305
306 ri = pmic[num];
307 ri-dev = pdev-dev;
308 ri-desc = tps65090_regulator_desc[num];
309 ri-overcurrent_wait_valid =
tps_pdata-overcurrent_wait_valid;
310 ri-overcurrent_wait = tps_pdata-overcurrent_wait;
so it looks like tps_pdata is NULL. Should likely be a check for it?
-Olof
On Wed, Apr 23, 2014 at 8:48 AM, Doug Anderson diand...@chromium.org wrote:
Lee,
On Wed, Apr 23, 2014 at 4:51 AM, Lee Jones lee.jo...@linaro.org wrote:
The tps65090 regulator allows you to specify how long you want it to
wait before detecting an overcurrent condition. Allow specifying that
through the device tree (or through platform data).
Signed-off-by: Doug Anderson diand...@chromium.org
Signed-off-by: Simon Glass s...@chromium.org
Signed-off-by: Michael Spang sp...@chromium.org
Signed-off-by: Sean Paul seanp...@chromium.org
---
Changes in v3:
- Fixed kernel-doc notation for return
Changes in v2:
- Separated the overcurrent and retries changes into two patches.
- Now set overcurrent at probe time since it doesn't change.
.../devicetree/bindings/regulator/tps65090.txt | 4 ++
drivers/regulator/tps65090-regulator.c | 56
++
include/linux/mfd/tps65090.h | 5 ++
3 files changed, 65 insertions(+)
Applied, thanks.
U, Mark said that he had already applied this patch to his tree (I
mentioned it in my recent summary and you can see it in this thread
too). I don't see it on git.kernel.org though
https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=for-next
I'm worried this will cause a merge conflict if you both apply it.
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
On Thu, May 01, 2014 at 11:17:58AM -0700, Olof Johansson wrote: so it looks like tps_pdata is NULL. Should likely be a check for it? Yes, just about to post a fix. signature.asc Description: Digital signature
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
Mark, On Thu, May 1, 2014 at 11:49 AM, Mark Brown broo...@kernel.org wrote: On Thu, May 01, 2014 at 11:17:58AM -0700, Olof Johansson wrote: so it looks like tps_pdata is NULL. Should likely be a check for it? Yes, just about to post a fix. Doh, was working on it at the same time. https://patchwork.kernel.org/patch/4099981/ Sorry for the bug. :( Thanks for the report! -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
On Thu, May 01, 2014 at 11:52:28AM -0700, Doug Anderson wrote: Yes, just about to post a fix. Doh, was working on it at the same time. No worries, I dropped my patch in favour of yours now (though they look to be identical apart from the metadata!). signature.asc Description: Digital signature
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
The tps65090 regulator allows you to specify how long you want it to wait before detecting an overcurrent condition. Allow specifying that through the device tree (or through platform data). Signed-off-by: Doug Anderson diand...@chromium.org Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Michael Spang sp...@chromium.org Signed-off-by: Sean Paul seanp...@chromium.org --- Changes in v3: - Fixed kernel-doc notation for return Changes in v2: - Separated the overcurrent and retries changes into two patches. - Now set overcurrent at probe time since it doesn't change. .../devicetree/bindings/regulator/tps65090.txt | 4 ++ drivers/regulator/tps65090-regulator.c | 56 ++ include/linux/mfd/tps65090.h | 5 ++ 3 files changed, 65 insertions(+) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
Lee, On Wed, Apr 23, 2014 at 4:51 AM, Lee Jones lee.jo...@linaro.org wrote: The tps65090 regulator allows you to specify how long you want it to wait before detecting an overcurrent condition. Allow specifying that through the device tree (or through platform data). Signed-off-by: Doug Anderson diand...@chromium.org Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Michael Spang sp...@chromium.org Signed-off-by: Sean Paul seanp...@chromium.org --- Changes in v3: - Fixed kernel-doc notation for return Changes in v2: - Separated the overcurrent and retries changes into two patches. - Now set overcurrent at probe time since it doesn't change. .../devicetree/bindings/regulator/tps65090.txt | 4 ++ drivers/regulator/tps65090-regulator.c | 56 ++ include/linux/mfd/tps65090.h | 5 ++ 3 files changed, 65 insertions(+) Applied, thanks. U, Mark said that he had already applied this patch to his tree (I mentioned it in my recent summary and you can see it in this thread too). I don't see it on git.kernel.org though https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=for-next I'm worried this will cause a merge conflict if you both apply it. -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/5] regulator: tps65090: Allow setting the overcurrent wait time
On Wed, Apr 16, 2014 at 04:12:28PM -0700, Doug Anderson wrote: The tps65090 regulator allows you to specify how long you want it to wait before detecting an overcurrent condition. Allow specifying that through the device tree (or through platform data). Applied, thanks. +- ti,overcurrent-wait: This is applicable to FET registers, which have a + poorly defined overcurrent wait field. If this property is present it + should be between 0 - 3. If this property isn't present we won't touch the + overcurrent wait field and we'll leave it to the BIOS/EC to deal with. What I was driving at by asking if this was the raw register value was that the binding should make this clearer ideally. signature.asc Description: Digital signature
