Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Mon, Dec 19, 2011 at 01:04:18AM +0900, Kukjin Kim wrote: > Hmm, I cannot find the iommu/exynos branch what you said in your iommu > tree yet. Maybe you missed or any problem? Problems. I tried to apply the patches and there were conflicts. After solving them I wasn't able to find a kernel-config for Exynos that conpiled for upstream Linux. Additionally new objections were raised about the patches. Enough to not merge these patches at this point. When I have a config to at least compile-test the code you send me and repost the patches rebased to a recent upstream commit with the objections fixed I can retry to merge it. Thanks, Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On 12/02/11 17:49, 'Joerg Roedel' wrote: On Fri, Dec 02, 2011 at 05:43:21PM +0900, Kukjin Kim wrote: OK, I will merge iommu/exynos into Samsung tree after your creating that. I can't look at iommu/exynos branch in your tree, git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git. That's because I havn't merged any exynos patches yet :) But I will create it soon an merge this driver. Hi Joerg, Hmm, I cannot find the iommu/exynos branch what you said in your iommu tree yet. Maybe you missed or any problem? Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Mon, Dec 05, 2011 at 04:47:15PM +0100, Joerg Roedel wrote: > Okay, I merged it into arm/exynos, but it is not pushed yet. Actually > there were conflicts while merging, which I resolved. What I failed > to find is a config for Exynos that actually builds for upstream Linux. > Probably I havn't tried hard enough to find one... Can you provide a > kernel config that I can use for my testing and that builds a current > 3.2-rc4 kernel for Exynos? Okay, since there are new objections and since I can't even reliably build test the driver I unmerged it again. Please fix the outstanding issues and rebase it against a recent upstream kernel so that the result can be compiled to a kernel-image. Thanks, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Tue, Dec 06, 2011 at 09:13:18PM +0900, KyongHo Cho wrote: > > BTW, how do you test it at mainline kernel? > > > I merged IOMMU mainline branch to our kernel branch and tested it with > our FIMC, MFC, JPEG, 2D. This is not sufficient. Please do it the other way around, merge your outstanding changes into the mainline kernel (or for iommu topics my next branch) and test against that. This way it is easier to catch bugs in mainline. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Tue, Dec 6, 2011 at 9:13 PM, KyongHo Cho wrote: > On Tue, Dec 6, 2011 at 8:24 AM, Kyungmin Park wrote: >> On 12/6/11, Joerg Roedel wrote: >>> On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: Patch Summary: [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms >>> >>> Okay, I merged it into arm/exynos, but it is not pushed yet. Actually >>> there were conflicts while merging, which I resolved. What I failed >>> to find is a config for Exynos that actually builds for upstream Linux. >>> Probably I havn't tried hard enough to find one... Can you provide a >>> kernel config that I can use for my testing and that builds a current >>> 3.2-rc4 kernel for Exynos? >> and I hope to see the real example how to use it with exynos platform. >> >> Now I can't find the interface between exynos platform and generic exynos >> iommu. > In "[PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device > definitions" patch, > you can find sysmmu_init(). > It stores associations between a system MMU and a peripheral device in > platform data of platform device descriptor. > If Exynos IOMMU driver finds the association while probing, then the > driver can control the system MMU. Maybe it's still call the function directly instead of using struct dev field as OMAP did. Even though generic DMA mapping IOMMU doesn't used, you can connect the iommu field at arch/arm/include/asm/device.h BR, Kyungmin Park > >> BTW, how do you test it at mainline kernel? >> > I merged IOMMU mainline branch to our kernel branch and tested it with > our FIMC, MFC, JPEG, 2D. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Tue, Dec 6, 2011 at 8:24 AM, Kyungmin Park wrote: > On 12/6/11, Joerg Roedel wrote: >> On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: >>> Patch Summary: >>> [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions >>> [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms >> >> Okay, I merged it into arm/exynos, but it is not pushed yet. Actually >> there were conflicts while merging, which I resolved. What I failed >> to find is a config for Exynos that actually builds for upstream Linux. >> Probably I havn't tried hard enough to find one... Can you provide a >> kernel config that I can use for my testing and that builds a current >> 3.2-rc4 kernel for Exynos? > and I hope to see the real example how to use it with exynos platform. > > Now I can't find the interface between exynos platform and generic exynos > iommu. In "[PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions" patch, you can find sysmmu_init(). It stores associations between a system MMU and a peripheral device in platform data of platform device descriptor. If Exynos IOMMU driver finds the association while probing, then the driver can control the system MMU. > BTW, how do you test it at mainline kernel? > I merged IOMMU mainline branch to our kernel branch and tested it with our FIMC, MFC, JPEG, 2D. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On 12/6/11, Joerg Roedel wrote: > On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: >> Patch Summary: >> [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions >> [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms > > Okay, I merged it into arm/exynos, but it is not pushed yet. Actually > there were conflicts while merging, which I resolved. What I failed > to find is a config for Exynos that actually builds for upstream Linux. > Probably I havn't tried hard enough to find one... Can you provide a > kernel config that I can use for my testing and that builds a current > 3.2-rc4 kernel for Exynos? and I hope to see the real example how to use it with exynos platform. Now I can't find the interface between exynos platform and generic exynos iommu. BTW, how do you test it at mainline kernel? Thank you, Kyungmin Park > > Thanks, > > Joerg > > -- > AMD Operating System Research Center > > Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach > General Managers: Alberto Bozzo, Andrew Bowd > Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. > 43632 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: > Patch Summary: > [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions > [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms Okay, I merged it into arm/exynos, but it is not pushed yet. Actually there were conflicts while merging, which I resolved. What I failed to find is a config for Exynos that actually builds for upstream Linux. Probably I havn't tried hard enough to find one... Can you provide a kernel config that I can use for my testing and that builds a current 3.2-rc4 kernel for Exynos? Thanks, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Fri, Dec 02, 2011 at 05:43:21PM +0900, Kukjin Kim wrote: > OK, I will merge iommu/exynos into Samsung tree after your creating that. > > I can't look at iommu/exynos branch in your tree, > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git. That's because I havn't merged any exynos patches yet :) But I will create it soon an merge this driver. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
Joerg Roedel wrote: > > On Thu, Dec 01, 2011 at 04:29:17PM +0900, Kukjin Kim wrote: > > Anyway, that touches many Samsung stuff so it would be better if you > could > > create separate topic branch which can be merged into Samsung tree. And > if > > required, please add my ack on them. > > Yes, I use topic-branches a lot :) This will end up in iommu/exynos or > something like that. > Hi Joerg, OK, I will merge iommu/exynos into Samsung tree after your creating that. I can't look at iommu/exynos branch in your tree, git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Thu, Dec 01, 2011 at 04:29:17PM +0900, Kukjin Kim wrote: > Anyway, that touches many Samsung stuff so it would be better if you could > create separate topic branch which can be merged into Samsung tree. And if > required, please add my ack on them. Yes, I use topic-branches a lot :) This will end up in iommu/exynos or something like that. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
Joerg Roedel wrote: > > On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: > > Changes since v6: > > - Totally rewrite exynos_iommu_map() and exynos_iommu_unmap() according > > to the change in iommu_map() and iommu_unmap(). > > - Change special slab for Lv2 page table to kmalloc(). > > Okay, the driver looks good to me now. If there are no further > objections I am going to merge it for 3.3. > Hi Joerg, Sorry for late response, I came back just now from family travelling... Anyway, that touches many Samsung stuff so it would be better if you could create separate topic branch which can be merged into Samsung tree. And if required, please add my ack on them. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos
On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: > Changes since v6: > - Totally rewrite exynos_iommu_map() and exynos_iommu_unmap() according > to the change in iommu_map() and iommu_unmap(). > - Change special slab for Lv2 page table to kmalloc(). Okay, the driver looks good to me now. If there are no further objections I am going to merge it for 3.3. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
