Re: [PATCHv2 0/3] Add support for DRM display subsystem
On 03/13/12 19:39, Marek Szyprowski wrote: Hello, This patch set adds support for Exynos DRM display subsystem for Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3 kernel tree and provides unified and more powerful alternative for s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in platform data structure (added 'panel' entry). Best regards Marek Szyprowski Samsung Poland R&D Center Patch summary: Marek Szyprowski (3): ARM: Exynos: add platform device for core DRM subsystem ARM: Exynos: Add DRM core device support for Universal C210 board ARM: Exynos: Add DRM core support for NURI board arch/arm/mach-exynos/Kconfig |7 ++ arch/arm/mach-exynos/Makefile |1 + arch/arm/mach-exynos/dev-drm.c | 29 arch/arm/mach-exynos/mach-nuri.c | 33 arch/arm/mach-exynos/mach-universal_c210.c | 33 arch/arm/plat-samsung/include/plat/devs.h |2 + 6 files changed, 105 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-exynos/dev-drm.c Applied. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCHv2 0/3] Add support for DRM display subsystem
OK, I thought again and talked to some guys. It's okay to add updated to the non-dt board files on exynos4 for now. I know, until there is dt coverage for more drivers, actually it will be difficult to build/support a complete system with only dt support. Note, we need to keep adding more and more support for dt for exynos4 and exynos5. Then only we can stop the development of non-dt board files. Thanks for many opinions about this and if any objections, feel free to contact me. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/3] Add support for DRM display subsystem
On 05/10/2012 11:36 AM, Kukjin Kim wrote: > Note that I have a plan to replace board files with DT supporting in > mach-exynos/ next time. What is the purpose of one side decisions like this ? I find it really annoying. We have been building those board files through multiple kernel releases, it took much effort and time to create proper drivers and extending frameworks, like video or media. It is going to take some more effort to make those subsystems DT aware and add proper support at the drivers. This is being worked on and touching existing boards doesn't sound like an incentive to me. We have to deal with multiple boards and breaking existing ones which are almost completed just adds an effort for us of maintaining them internally. The mainline kernel is going to always be a half-product, not properly tested and validated. We get new boards that need to be supported in the kernel quite frequently, those boards share device IPs, so adapting the drivers to the DT is already our goal, for getting new boards supported in the mainline. I have no idea what that "replacing" is going to be about, but if you add support for all devices present in those boards and they will all work as before - I'll happily accept that. Although I'm afraid it is just going to be one big breakage and regression, in the name of "everything must migrate to the device tree". I would really appreciate more common agreement, rather than putting a spoke in somebody else's wheel. Once all devices in current mach-exynos board files get proper DT support we are going to remove the boards ourselves. I'm sure there is lots of other things that need more attention than that. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/3] Add support for DRM display subsystem
On 10 May 2012 20:16, Kyungmin Park wrote: > On Thu, May 10, 2012 at 10:48 PM, Arnd Bergmann wrote: >> On Thursday 10 May 2012, Kyungmin Park wrote: >>> > And I won't apply new feature for non-dt board file from now on. I think, >>> > we >>> > need to support DT in mach-exynos/ instead of non-DT and DT together, so >>> > please consider to move on dt supporting for Samsung mobile boards. >>> > >>> >>> Probably you misunderstand Arnd word. >>> >>> "From the statements made so far, I can see no clear policy that we can >>> apply to everyone. My take on this is that for any work I spend on >>> multiplatform kernel, I concentrate on the DT-based board files and >>> get them to work together first, but leave it up to the individual >>> subarch maintainers whether they want to add other board files into >>> the mix." >>> >>> It doesn't mean add new feature to non-DT board. don't add new board file. >> >> This is a completely separate discussion, the problem at hand doesn't >> have anything to do with building a kernel for multiple mach-* >> directories combined that I was referring to in the text you quote. >> >>> In this case, DRM is not yet ready to support DT. >>> >>> Okay, you can just drop this patches. but please note that this >>> patches are posted at Mar 13 before you decide. >> >> I think it's a good idea to make new features DT-only because this >> way we don't get any regressions and everyone who want to use >> the new feature will be able to test the DT support on his board. > The 'new feature' is some misleading word. In this case DRM drivers > are used from v3.2 at drivers. but not registered it at board file. > Basically agree to move DT and used it finally. Before that bring up > the board using DRM based graphics. >> >> This of course requires that basic DT support is available for the >> systems in question so we don't regress when moving away from the >> old board files. My impression is that we're getting close to that >> point on exynos thanks to Thomas' work on this. AFAICT we don't >> have a DT binding for screen timings yet, so you will still have >> to use auxdata for that or put the timings into the driver. > I'm also thanks to Thomas, he did a lot of works for eyxnos. but most > parts are missing at least exynos platform. > e.g., Please see the origen.dts. I wonder it's booted with any > graphical user interface platform, android or ubuntu. > Maybe not. We (Samsung Landing team) did manage to boot Origen with Ubuntu using DT support. But that is only upto home screen with minimal support. > > Anyway, as discussed in multi-platform support mail threads, we're > also moving to DT in the big picture. but still want to use existing > boards as is. For Exynos multimedia IPs, for instance, which already have drivers as well as platform support in mainline, do we still defer device registration in machine file until DT support for these IPs is added? > > Thank you, > Kyungmin Park > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/3] Add support for DRM display subsystem
On Thu, May 10, 2012 at 10:48 PM, Arnd Bergmann wrote: > On Thursday 10 May 2012, Kyungmin Park wrote: >> > And I won't apply new feature for non-dt board file from now on. I think, >> > we >> > need to support DT in mach-exynos/ instead of non-DT and DT together, so >> > please consider to move on dt supporting for Samsung mobile boards. >> > >> >> Probably you misunderstand Arnd word. >> >> "From the statements made so far, I can see no clear policy that we can >> apply to everyone. My take on this is that for any work I spend on >> multiplatform kernel, I concentrate on the DT-based board files and >> get them to work together first, but leave it up to the individual >> subarch maintainers whether they want to add other board files into >> the mix." >> >> It doesn't mean add new feature to non-DT board. don't add new board file. > > This is a completely separate discussion, the problem at hand doesn't > have anything to do with building a kernel for multiple mach-* > directories combined that I was referring to in the text you quote. > >> In this case, DRM is not yet ready to support DT. >> >> Okay, you can just drop this patches. but please note that this >> patches are posted at Mar 13 before you decide. > > I think it's a good idea to make new features DT-only because this > way we don't get any regressions and everyone who want to use > the new feature will be able to test the DT support on his board. The 'new feature' is some misleading word. In this case DRM drivers are used from v3.2 at drivers. but not registered it at board file. Basically agree to move DT and used it finally. Before that bring up the board using DRM based graphics. > > This of course requires that basic DT support is available for the > systems in question so we don't regress when moving away from the > old board files. My impression is that we're getting close to that > point on exynos thanks to Thomas' work on this. AFAICT we don't > have a DT binding for screen timings yet, so you will still have > to use auxdata for that or put the timings into the driver. I'm also thanks to Thomas, he did a lot of works for eyxnos. but most parts are missing at least exynos platform. e.g., Please see the origen.dts. I wonder it's booted with any graphical user interface platform, android or ubuntu. Maybe not. Anyway, as discussed in multi-platform support mail threads, we're also moving to DT in the big picture. but still want to use existing boards as is. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/3] Add support for DRM display subsystem
On Thursday 10 May 2012, Kyungmin Park wrote: > > And I won't apply new feature for non-dt board file from now on. I think, > > we > > need to support DT in mach-exynos/ instead of non-DT and DT together, so > > please consider to move on dt supporting for Samsung mobile boards. > > > > Probably you misunderstand Arnd word. > > "From the statements made so far, I can see no clear policy that we can > apply to everyone. My take on this is that for any work I spend on > multiplatform kernel, I concentrate on the DT-based board files and > get them to work together first, but leave it up to the individual > subarch maintainers whether they want to add other board files into > the mix." > > It doesn't mean add new feature to non-DT board. don't add new board file. This is a completely separate discussion, the problem at hand doesn't have anything to do with building a kernel for multiple mach-* directories combined that I was referring to in the text you quote. > In this case, DRM is not yet ready to support DT. > > Okay, you can just drop this patches. but please note that this > patches are posted at Mar 13 before you decide. I think it's a good idea to make new features DT-only because this way we don't get any regressions and everyone who want to use the new feature will be able to test the DT support on his board. This of course requires that basic DT support is available for the systems in question so we don't regress when moving away from the old board files. My impression is that we're getting close to that point on exynos thanks to Thomas' work on this. AFAICT we don't have a DT binding for screen timings yet, so you will still have to use auxdata for that or put the timings into the driver. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCHv2 0/3] Add support for DRM display subsystem
Hello, On Thursday, May 10, 2012 11:36 AM Kukjin Kim wrote: > Marek Szyprowski wrote: > > > > Hello, > > > > This patch set adds support for Exynos DRM display subsystem for > > Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3 > > kernel tree and provides unified and more powerful alternative for > > s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in > > platform data structure (added 'panel' entry). > > > > Best regards > > > > Marek Szyprowski > > Samsung Poland R&D Center > > > > Patch summary: > > > > Marek Szyprowski (3): > > ARM: Exynos: add platform device for core DRM subsystem > > ARM: Exynos: Add DRM core device support for Universal C210 board > > ARM: Exynos: Add DRM core support for NURI board > > > > arch/arm/mach-exynos/Kconfig |7 ++ > > arch/arm/mach-exynos/Makefile |1 + > > arch/arm/mach-exynos/dev-drm.c | 29 > > > arch/arm/mach-exynos/mach-nuri.c | 33 > > > > arch/arm/mach-exynos/mach-universal_c210.c | 33 > > > > arch/arm/plat-samsung/include/plat/devs.h |2 + > > 6 files changed, 105 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/mach-exynos/dev-drm.c > > > > -- > > 1.7.1.569.g6f426 > > Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one > kernel image. We can switch completely to DRM driver for both boards and remove entries for s3c-fb/tv if this is really needed. IMHO it is a bit lame that the DRM driver is already in the mainline, but none of the boards use it. Even if one wants to add support for it to his own board, he cannot find any reference code for it... > And I won't apply new feature for non-dt board file from now on. I think, we > need to support DT in mach-exynos/ instead of non-DT and DT together, so > please consider to move on dt supporting for Samsung mobile boards. > > Note that I have a plan to replace board files with DT supporting in > mach-exynos/ next time. Right now the DT support is so incomplete that even basic things like gpio interrupts are not yet supported. This will be a huge regression if you remove the existing board files and replace them with DT stubs. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 0/3] Add support for DRM display subsystem
On 5/10/12, Kukjin Kim wrote: > Marek Szyprowski wrote: >> >> Hello, >> >> This patch set adds support for Exynos DRM display subsystem for >> Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3 >> kernel tree and provides unified and more powerful alternative for >> s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in >> platform data structure (added 'panel' entry). >> >> Best regards >> >> Marek Szyprowski >> Samsung Poland R&D Center >> >> Patch summary: >> >> Marek Szyprowski (3): >> ARM: Exynos: add platform device for core DRM subsystem >> ARM: Exynos: Add DRM core device support for Universal C210 board >> ARM: Exynos: Add DRM core support for NURI board >> >> arch/arm/mach-exynos/Kconfig |7 ++ >> arch/arm/mach-exynos/Makefile |1 + >> arch/arm/mach-exynos/dev-drm.c | 29 > >> arch/arm/mach-exynos/mach-nuri.c | 33 >> >> arch/arm/mach-exynos/mach-universal_c210.c | 33 >> >> arch/arm/plat-samsung/include/plat/devs.h |2 + >> 6 files changed, 105 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/mach-exynos/dev-drm.c >> >> -- >> 1.7.1.569.g6f426 > > Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one > kernel image. > > And I won't apply new feature for non-dt board file from now on. I think, > we > need to support DT in mach-exynos/ instead of non-DT and DT together, so > please consider to move on dt supporting for Samsung mobile boards. > Probably you misunderstand Arnd word. "From the statements made so far, I can see no clear policy that we can apply to everyone. My take on this is that for any work I spend on multiplatform kernel, I concentrate on the DT-based board files and get them to work together first, but leave it up to the individual subarch maintainers whether they want to add other board files into the mix." It doesn't mean add new feature to non-DT board. don't add new board file. In this case, DRM is not yet ready to support DT. Okay, you can just drop this patches. but please note that this patches are posted at Mar 13 before you decide. BR, Kyungmin Park > Note that I have a plan to replace board files with DT supporting in > mach-exynos/ next time. > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim , Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCHv2 0/3] Add support for DRM display subsystem
Marek Szyprowski wrote: > > Hello, > > This patch set adds support for Exynos DRM display subsystem for > Universal C210 and NURI boards. Exynos DRM driver has been merged to 3.3 > kernel tree and provides unified and more powerful alternative for > s3c-fb and s5p-tv drivers. V2 includes update for the latest changes in > platform data structure (added 'panel' entry). > > Best regards > > Marek Szyprowski > Samsung Poland R&D Center > > Patch summary: > > Marek Szyprowski (3): > ARM: Exynos: add platform device for core DRM subsystem > ARM: Exynos: Add DRM core device support for Universal C210 board > ARM: Exynos: Add DRM core support for NURI board > > arch/arm/mach-exynos/Kconfig |7 ++ > arch/arm/mach-exynos/Makefile |1 + > arch/arm/mach-exynos/dev-drm.c | 29 > arch/arm/mach-exynos/mach-nuri.c | 33 > > arch/arm/mach-exynos/mach-universal_c210.c | 33 > > arch/arm/plat-samsung/include/plat/devs.h |2 + > 6 files changed, 105 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-exynos/dev-drm.c > > -- > 1.7.1.569.g6f426 Well, 2nd and 3rd patches can break multi-platform for EXYNOS SoCs with one kernel image. And I won't apply new feature for non-dt board file from now on. I think, we need to support DT in mach-exynos/ instead of non-DT and DT together, so please consider to move on dt supporting for Samsung mobile boards. Note that I have a plan to replace board files with DT supporting in mach-exynos/ next time. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
