RE: [scsi:misc 114/120] drivers/scsi/st.c:4594:3: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'long long int'

2015-05-31 Thread Seymour, Shane M
My apologies for this I'm fixing it now.

-Original Message-
From: kbuild test robot [mailto:fengguang...@intel.com] 
Sent: Monday, June 01, 2015 12:36 PM
To: Seymour, Shane M
Cc: kbuild-...@01.org; James Bottomley; Christoph Hellwig; 
linux-scsi@vger.kernel.org
Subject: [scsi:misc 114/120] drivers/scsi/st.c:4594:3: warning: format '%ld' 
expects argument of type 'long int', but argument 3 has type 'long long int'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   f6e08d7c118cc44f10bffdf52a31d7f40ce86ba7
commit: fc5280a80c124fe2d8b661513670a574fcd8bcbc [114/120] st: implement tape 
statistics
config: i386-allyesconfig (attached as .config)
reproduce:
  git checkout fc5280a80c124fe2d8b661513670a574fcd8bcbc
  # save the attached .config to linux build tree
  make ARCH=i386 

All warnings:

   drivers/scsi/st.c: In function 'read_cnt_show':
 drivers/scsi/st.c:4594:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-read_cnt));
  ^
   drivers/scsi/st.c: In function 'read_byte_cnt_show':
 drivers/scsi/st.c:4612:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-read_byte_cnt));
  ^
   drivers/scsi/st.c: In function 'read_ns_show':
 drivers/scsi/st.c:4628:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-tot_read_time));
  ^
   drivers/scsi/st.c: In function 'write_cnt_show':
 drivers/scsi/st.c:4645:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-write_cnt));
  ^
   drivers/scsi/st.c: In function 'write_byte_cnt_show':
 drivers/scsi/st.c:4662:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-write_byte_cnt));
  ^
   drivers/scsi/st.c: In function 'write_ns_show':
 drivers/scsi/st.c:4679:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-tot_write_time));
  ^
   drivers/scsi/st.c: In function 'in_flight_show':
 drivers/scsi/st.c:4697:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-in_flight));
  ^
   drivers/scsi/st.c: In function 'io_ns_show':
 drivers/scsi/st.c:4717:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-tot_io_time));
  ^
   drivers/scsi/st.c: In function 'other_cnt_show':
 drivers/scsi/st.c:4736:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-other_cnt));
  ^
   drivers/scsi/st.c: In function 'resid_cnt_show':
 drivers/scsi/st.c:4754:3: warning: format '%ld' expects argument of type 
 'long int', but argument 3 has type 'long long int' [-Wformat=]
  atomic64_read(STm-tape-stats-resid_cnt));
  ^

vim +4594 drivers/scsi/st.c

  4588  static ssize_t read_cnt_show(struct device *dev,
  4589  struct device_attribute *attr, char *buf)
  4590  {
  4591  struct st_modedef *STm = dev_get_drvdata(dev);
  4592  
  4593  return sprintf(buf, %ld,
 4594  atomic64_read(STm-tape-stats-read_cnt));
  4595  }
  4596  static DEVICE_ATTR_RO(read_cnt);
  4597  
  4598  /**
  4599   * read_byte_cnt_show - return read byte count - tape drives
  4600   * may use blocks less than 512 bytes this gives the raw byte count of
  4601   * of data read from the tape drive.
  4602   * @dev: struct device
  4603   * @attr: attribute structure
  4604   * @buf: buffer to return formatted data in
  4605   */
  4606  static ssize_t read_byte_cnt_show(struct device *dev,
  4607  struct device_attribute *attr, char *buf)
  4608  {
  4609  struct st_modedef *STm = dev_get_drvdata(dev);
  4610  
  4611  return sprintf(buf, %ld,
 4612  atomic64_read(STm-tape-stats-read_byte_cnt));
  4613  }
  4614  static DEVICE_ATTR_RO(read_byte_cnt);
  4615  
  4616  /**
  4617   * read_us_show - return read us - overall time spent waiting on reads 
in ns.
  4618   * @dev: struct device
  4619   * @attr: attribute structure
  4620   * @buf: buffer to return formatted data in
  4621   */
  4622  static ssize_t read_ns_show(struct device *dev,
  4623  struct device_attribute *attr, char *buf)
  4624  {
  4625  struct st_modedef *STm = dev_get_drvdata(dev);
  4626  
  4627  return sprintf(buf, %ld,
 4628  atomic64_read(STm-tape-stats-tot_read_time));
  4629  }
  

Re: [PATCH 2/3] megaraid_sas: use dev_printk when possible

2015-05-31 Thread James Bottomley
On Tue, 2015-04-28 at 18:14 -0500, Bjorn Helgaas wrote:
 Use dev_printk() when possible to make messages more useful.

I got the first one, but this one needs refreshing.  23 have the same
commit message, so they should be one patch, I think.

Thanks,

James


--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html