date:20160104

Re: [PATCH v2 11/16] qla2xxx: Add selective command queuing

2016-01-04 Thread Quinn Tran

On 12/29/15, 1:32 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart
Van Assche"  wrote:

>On 12/17/2015 08:57 PM, Himanshu Madhani wrote:
>>From: Quinn Tran 
>>queue work element to specific process lessen cache miss
>
>How about replacing this patch by something like the (untested) patch
>below ? The advantage of the patch below is that it doesn't require to
>modify other target driver to keep their current behavior.
>
>Thanks,
>
>Bart.

QT> Bart, Thanks for reviewing.  Good point.  Will rework patch to
preserve current behavior of other drivers. 

<>

Re: qla2xxx: Delete session if initiator is gone from FW

2016-01-04 Thread Himanshu Madhani

Hi Alexie/Dan, 

I will send follow up patch to fix this.

Thanks,
-Himanshu





On 12/24/15, 12:11 AM, "Alexei Potashnik"  wrote:

>I my original patch line 3583 was:
>
>+  bool logged_out = (status & 0x) ==
>CTIO_PORT_LOGGED_OUT;
>
>and line 3587 was:
>
>+  logged_out ? "PORT LOGGED OUT" : "PORT
>UNAVAILABLE",
>
>Forwarding  to Quinn and Himanshu who must have massaged it.
>
>Alexei
>
>> -Original Message-
>> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>> Sent: Tuesday, December 22, 2015 11:46 AM
>> To: ale...@purestorage.com
>> Cc: linux-scsi@vger.kernel.org
>> Subject: re: qla2xxx: Delete session if initiator is gone from FW
>>
>> Hello Alexei Potashnik,
>>
>> The patch b93bb8ecc389: "qla2xxx: Delete session if initiator is gone
>from
>> FW" from Dec 17, 2015, leads to the following static checker
>> warning:
>>
>>  drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
>>  warn: impossible condition '(logged_out == 41) => (0-1 == 41)'
>>
>> drivers/scsi/qla2xxx/qla_target.c
>>   3580  case CTIO_PORT_LOGGED_OUT:
>>   3581  case CTIO_PORT_UNAVAILABLE:
>>   3582  {
>>   3583  bool logged_out = (status & 0x);
>>   3584  ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
>>   3585  "qla_target(%d): CTIO with %s status
>%x "
>>   3586  "received (state %x, se_cmd %p)\n",
>vha->vp_idx,
>>   3587  (logged_out == CTIO_PORT_LOGGED_OUT)
>?
>>  ^^
>> Bool cannot equal 0x26.
>>
>>   3588  "PORT LOGGED OUT" : "PORT
>UNAVAILABLE",
>>   3589  status, cmd->state, se_cmd);
>>   3590
>>   3591  if (logged_out && cmd->sess) {
>> ^^
>>  == CTIO_PORT_LOGGED_OUT here?
>>
>>   3592  /*
>>   3593   * Session is already logged
>out, but we need
>>   3594   * to notify initiator, who's
>not aware of this
>>   3595   */
>>   3596  cmd->sess->logout_on_delete = 0;
>>   3597  cmd->sess->send_els_logo = 1;
>>   3598
>qlt_schedule_sess_for_deletion(cmd->sess, true);
>>   3599  }
>>   3600  break;
>>   3601  }
>>
>> regards,
>> dan carpenter

<>

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2016-01-04 Thread Lee Duncan

On 12/17/2015 11:24 AM, Lee Duncan wrote:
> On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>> "Hannes" == Hannes Reinecke  writes:
>>
 I'm not opposed to having the module option if others (Martin?) feel
 they need it, but generally I think it's better to keep things as
 simple as possible.  So, unless there are strong objections, I would
 say no.
>>
>> Hannes> Agreeing with Ewan here.
>>
>> Hannes> I guess it's up to you to tell us whether you absolutely need a
>> Hannes> module parameter ...
>>
>> Still not a big ida fan but since the most people seem to be in favor of
>> this I guess I'll have to bite the bullet.
>>
>> I don't see much value in the module parameter since it will require
>> customers to tweak their configs and reproduce. Not worth the hassle.
>>
> 
> Thank you Martin. I'll look at further cleaning up the host module, but
> I think this still much better than leaving the code as is.
> 

James:

Do you need me to resubmit this patch now that it's accepted?
-- 
Lee Duncan

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] mpt3sas: a correction in unmap_resources

2016-01-04 Thread Chaitra Basappa

Hi,
 Please consider this patch as Ack-by: Chaitra P B


Thanks,
 Chaitra

-Original Message-
From: Tomas Henzl [mailto:the...@redhat.com]
Sent: Wednesday, December 23, 2015 6:52 PM
To: linux-scsi@vger.kernel.org
Cc: kashyap.de...@avagotech.com; chaitra.basa...@avagotech.com;
mlomb...@redhat.com
Subject: [PATCH] mpt3sas: a correction in unmap_resources

It might happen that we try to free an already freed pointer.

Tomas

Reported-by: Maurizio Lombardi 
Signed-off-by: Tomas Henzl 
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c
b/drivers/scsi/mpt3sas/mpt3sas_base.c
index d4f1dcdb83..3b09b3d09f 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -1827,8 +1827,10 @@ mpt3sas_base_unmap_resources(struct MPT3SAS_ADAPTER
*ioc)
_base_free_irq(ioc);
_base_disable_msix(ioc);

-   if (ioc->msix96_vector)
+   if (ioc->msix96_vector) {
kfree(ioc->replyPostRegisterIndex);
+   ioc->replyPostRegisterIndex = NULL;
+   }

if (ioc->chip_phys) {
iounmap(ioc->chip);
-- 
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: st driver doesn't seem to grok LTO partitioning

2016-01-04 Thread Emmanuel Florac

Le Mon, 4 Jan 2016 12:22:34 +0200 (EET)
Kai Makisara  écrivait:

> >In the HP LTFS sources I found an interesting detail: the code does
> >LOAD before unformatting. A comment says that it is in some cases
> >better method to put the position to beginning of partition 0 than
> >other methods. You could try ‘mt load’ before trying to partition.
> >  
> Here is again a new version of the patch. This does load before 
> partitioning. The code performing default partitioning (FDP=1) has
> also been slightly modified (two more bits of the original mode page 
> retained).

OK, I'll test 'mt load' first, then the new patch. Stay tuned...

-- 

Emmanuel Florac |   Direction technique
|   Intellique
|   
|   +33 1 78 94 84 02

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: st driver doesn't seem to grok LTO partitioning

2016-01-04 Thread Kai Makisara

On Thursday 2015-12-31 18:08, "Kai Mäkisara (Kolumbus)" wrote:

...
>In the HP LTFS sources I found an interesting detail: the code does LOAD 
>before unformatting.
>A comment says that it is in some cases better method to put the position to 
>beginning of
>partition 0 than other methods. You could try ‘mt load’ before trying to 
>partition.
>
Here is again a new version of the patch. This does load before 
partitioning. The code performing default partitioning (FDP=1) has also 
been slightly modified (two more bits of the original mode page 
retained).

The patch has been tested with my DDS-4 drive.

Kai
-8<
--- ref/drivers/scsi/st.c   2015-12-21 18:54:05.068882001 +0200
+++ new/drivers/scsi/st.c   2016-01-04 12:09:07.702559815 +0200
@@ -9,7 +9,7 @@
Steve Hirsch, Andreas Koppenh"ofer, Michael Leodolter, Eyal Lebedinsky,
Michael Schaefer, J"org Weule, and Eric Youngdale.
 
-   Copyright 1992 - 2010 Kai Makisara
+   Copyright 1992 - 2016 Kai Makisara
email kai.makis...@kolumbus.fi
 
Some small formal changes - aeb, 950809
@@ -17,7 +17,7 @@
Last modified: 18-JAN-1998 Richard Gooch <rgo...@atnf.csiro.au> Devfs 
support
  */
 
-static const char *verstr = "20101219";
+static const char *verstr = "20160104";
 
 #include 
 
@@ -3296,7 +3296,10 @@
 #define PP_OFF_RESERVED7
 
 #define PP_BIT_IDP 0x20
+#define PP_BIT_FDP 0x80
 #define PP_MSK_PSUM_MB 0x10
+#define PP_MSK_PSUM_UNITS  0x18
+#define PP_MSK_POFM0x04
 
 /* Get the number of partitions on the tape. As a side effect reads the
mode page into the tape buffer. */
@@ -3322,6 +3325,29 @@
 }
 
 
+static int format_medium(struct scsi_tape *STp, int format)
+{
+   int result = 0;
+   int timeout = STp->long_timeout;
+   unsigned char scmd[MAX_COMMAND_SIZE];
+   struct st_request *SRpnt;
+
+   memset(scmd, 0, MAX_COMMAND_SIZE);
+   scmd[0] = FORMAT_UNIT;
+   scmd[2] = format;
+   if (STp->immediate) {
+   scmd[1] |= 1;   /* Don't wait for completion */
+   timeout = STp->device->request_queue->rq_timeout;
+   }
+   DEBC_printk(STp, "Sending FORMAT MEDIUM\n");
+   SRpnt = st_do_scsi(NULL, STp, scmd, 0, DMA_NONE,
+  timeout, MAX_RETRIES, 1);
+   if (!SRpnt)
+   result = STp->buffer->syscall_result;
+   return result;
+}
+
+
 /* Partition the tape into two partitions if size > 0 or one partition if
size == 0.
 
@@ -3340,11 +3366,15 @@
and 10 when 1 partition is defined (information from Eric Lee Green). This 
is
is acceptable also to some other old drives and enforced if the first 
partition
size field is used for the first additional partition size.
+
+   For drives that advertize SCSI-3 or newer, use the SSC-3 methods.
  */
 static int partition_tape(struct scsi_tape *STp, int size)
 {
int result;
+   bool scsi3 = STp->device->scsi_level >= SCSI_3,  needs_format = false;
int pgo, psd_cnt, psdo;
+   int psum = PP_MSK_PSUM_MB, units = 0;
unsigned char *bp;
 
result = read_mode_page(STp, PART_PAGE, 0);
@@ -3357,11 +3387,58 @@
pgo = MODE_HEADER_LENGTH + bp[MH_OFF_BDESCS_LENGTH];
DEBC_printk(STp, "Partition page length is %d bytes.\n",
bp[pgo + MP_OFF_PAGE_LENGTH] + 2);
+   DEBC_printk(STp, "PP: max %u, add %u, xdp %u, psum %02x, pofmetc %u, "
+   "rec %02x, units %02x, sizes: %u %u\n",
+   bp[pgo + PP_OFF_MAX_ADD_PARTS],
+   bp[pgo + PP_OFF_NBR_ADD_PARTS],
+   (bp[pgo + PP_OFF_FLAGS] & 0xe0) >> 5,
+   (bp[pgo + PP_OFF_FLAGS] & 0x18) >> 3,
+   bp[pgo + PP_OFF_FLAGS] & 0x07,
+   bp[pgo + 5],
+   bp[pgo + PP_OFF_PART_UNITS],
+   bp[pgo + 8] * 256 + bp[pgo + 9],
+   bp[pgo + 10] * 256 + bp[pgo + 11]);
+   DEBC_printk(STp, "MP: %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x 
%02x %02x\n",
+   bp[pgo], bp[pgo+1], bp[pgo+2], bp[pgo+3], bp[pgo+4], 
bp[pgo+5],
+   bp[pgo+6], bp[pgo+7], bp[pgo+8], bp[pgo+9], bp[pgo+10], 
bp[pgo+11]);
+
+   if (scsi3) {
+   needs_format = (bp[pgo + PP_OFF_FLAGS] & PP_MSK_POFM) != 0;
+   if (needs_format && size == 0) {
+   /* No need to write the mode page in this case */
+   result = format_medium(STp, 0);
+   goto out;
+   }
+
+   psd_cnt = size > 0 ? 2 : 1;
+   if ((bp[pgo + PP_OFF_FLAGS] & PP_MSK_PSUM_UNITS) == 
PP_MSK_PSUM_UNITS) {
+   /* Use

Re: st driver doesn't seem to grok LTO partitioning

2016-01-04 Thread Emmanuel Florac

Le Mon, 4 Jan 2016 12:22:34 +0200 (EET)
Kai Makisara  écrivait:

> >In the HP LTFS sources I found an interesting detail: the code does
> >LOAD before unformatting. A comment says that it is in some cases
> >better method to put the position to beginning of partition 0 than
> >other methods. You could try ‘mt load’ before trying to partition.
> >  
> Here is again a new version of the patch. This does load before 
> partitioning. The code performing default partitioning (FDP=1) has
> also been slightly modified (two more bits of the original mode page 
> retained).

You were right, it works by sending a "LOAD" first:

First, not working:

# mt -f /dev/nst0 mkpartition 0

Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Rewinding tape.
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Partition page length is 16 
bytes.
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: PP: max 3, add 1, xdp 1, 
psum 03, pofmetc 4, rec 03, units 09, sizes: 2543 38
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Sending FORMAT MEDIUM
Jan  4 12:02:17 shakuhachi kernel: st 7:0:0:0: st0: Error: 802, cmd: 4 0 0 
0 0 0
Jan  4 12:02:17 shakuhachi kernel: st0: Sense Key : Illegal Request [current] 
Jan  4 12:02:17 shakuhachi kernel: st0: Add. Sense: Position past beginning of 
medium

Then:

# mt -f /dev/nst0 load

Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Loading tape.
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:02:33 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).

# mt -f /dev/nst0 mkpartition 0


Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Rewinding tape.
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Partition page length is 16 
bytes.
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: PP: max 3, add 1, xdp 1, 
psum 03, pofmetc 4, rec 03, units 09, sizes: 2543 38
Jan  4 12:02:42 shakuhachi kernel: st 7:0:0:0: st0: Sending FORMAT MEDIUM

# tapeinfo -f /dev/sg6
Product Type: Tape Drive
Vendor ID: 'HP  '
Product ID: 'Ultrium 6-SCSI  '
Revision: '329U'
Attached Changer API: No
SerialNumber: 'HU1302U4RC'
MinBlock: 1
MaxBlock: 16777215
SCSI ID: 0
SCSI LUN: 0
Ready: yes
BufferedMode: yes
Medium Type: Not Loaded
Density Code: 0x5a
BlockSize: 0
DataCompEnabled: yes
DataCompCapable: yes
DataDeCompEnabled: yes
CompType: 0x1
DeCompType: 0x1
BOP: yes
Block Position: 0
ActivePartition: 0
EarlyWarningSize: 0
NumPartitions: 0
MaxPartitions: 3


-- 

Emmanuel Florac |   Direction technique
|   Intellique
|   
|   +33 1 78 94 84 02

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: st driver doesn't seem to grok LTO partitioning

2016-01-04 Thread Emmanuel Florac

Le Mon, 4 Jan 2016 12:22:34 +0200 (EET)
Kai Makisara <kai.makis...@kolumbus.fi> écrivait:

> Here is again a new version of the patch. This does load before 
> partitioning. The code performing default partitioning (FDP=1) has
> also been slightly modified (two more bits of the original mode page 
> retained).
> 
> The patch has been tested with my DDS-4 drive.

That works fine for me. I'm going to do some testing with other drives
I have (LTO-3 -- should fail -- and LTO-5).

# modprobe st

Jan  4 12:31:53 shakuhachi kernel: st: Version 20160104, fixed bufsize 32768, 
s/g segs 256
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: Attached scsi tape st0
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: try direct i/o: yes 
(alignment 512 B)
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:31:53 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).


# mt -f /dev/st0  stsetoption debug

Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Mode 0 options: buffer 
writes: 1, async writes: 1, read ahead: 1
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: can bsr: 1, two FMs: 0, 
fast mteom: 0, auto lock: 0,
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: defs for wr: 0, no 
block limits: 0, partitions: 0, s2 log: 0
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: sysv: 0 nowait: 0 sili: 
0 nowait_filemark: 0
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: debugging: 1
Jan  4 12:32:04 shakuhachi kernel: st 7:0:0:0: st0: Rewinding tape.

# mt -f /dev/st0  stsetoption can-partitions


Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Mode 0 options: buffer 
writes: 1, async writes: 1, read ahead: 1
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: can bsr: 1, two FMs: 0, 
fast mteom: 0, auto lock: 0,
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: defs for wr: 0, no 
block limits: 0, partitions: 1, s2 log: 0
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: sysv: 0 nowait: 0 sili: 
0 nowait_filemark: 0
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: debugging: 1
Jan  4 12:39:38 shakuhachi kernel: st 7:0:0:0: st0: Rewinding tape.

# mt -f /dev/nst0  mkpartition 1


Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Updating partition number 
in status.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Got tape pos. blk 0 part 0.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Loading tape.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Block limits 1 - 16777215 
bytes.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Mode sense. Length 11, 
medium 0, WBS 10, BLL 8
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Density 5a, tape length: 0, 
drv buffer: 1
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Block size: 0, buffer size: 
4096 (1 blocks).
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: Partition page length is 16 
bytes.
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: PP: max 3, add 0, xdp 1, 
psum 03, pofmetc 4, rec 03, units 09, sizes: 2620 0
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: MP: 11 0e 03 00 3c 03 09 00 
0a 3c 00 00
Jan  4 12:40:01 shakuhachi kernel: st 7:0:0:0: st0: psd_cnt 2, max.parts 3, 
nbr_parts 0
Jan  4 12:40:01 shaku

Re: [PATCH] mpt3sas: a correction in unmap_resources

2016-01-04 Thread Martin K. Petersen

> "Tomas" == Tomas Henzl  writes:

Tomas> It might happen that we try to free an already freed pointer.
Tomas> Tomas

Applied to 4.5/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices

2016-01-04 Thread Martin K. Petersen

> "Ewan" == Ewan D Milne  writes:

Ewan> The klist traversal used by the reading of /proc/scsi/scsi is not
Ewan> interlocked against device removal.  It takes a reference on the
Ewan> containing object, but this does not prevent the device from being
Ewan> removed from the list.  Thus, we get errors and eventually panic,
Ewan> as shown in the traces below.  Fix this by keeping a klist
Ewan> iterator in the seq_file private data.

Applied to 4.5/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/3] hpsa update

2016-01-04 Thread Martin K. Petersen

> "Don" == Don Brace  writes:

Don> These patches are based on Linus's tree The changes are: - correct
Don> missing changes from snprintf to scnprintf in path_info_show by
Don> Rasmus Villemoes - fix reported bus for SAS transport devices - add
Don> in enclosure information

Applied to 4.5/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052

2016-01-04 Thread Martin K. Petersen

> "Raghava" == Raghava Aditya Renukunta  
> writes:

Raghava> This patchset includes the following changes (bug fixes and new
Raghava> feature support) specific to aacraid driver.

Raghava> V2: Removed aac_fib_free_tag function Setup relevant fib
Raghava> variables only in once Created aac_fib_vector_assign function
Raghava> Made EEH functions static Added character device status macros
Raghava> Changed location of aac->shutdown to prevent race condition
Raghava> Withdrew patch that disables device ID wild card binding

You dropped all the review/fix/stable tags you had received from Tomas
and Johannes.

Please apply the relevant tags and resubmit this series.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: st driver doesn't seem to grok LTO partitioning

2016-01-04 Thread Emmanuel Florac

Le Mon, 4 Jan 2016 10:08:44 -0500
Laurence Oberman  écrivait:

> I am back at work with access to my tape changer today. Will pull the
> patches and help test as well.
> I assume I need to apply both patches, the earlier one and this
> latest one.
> 

No only the latest one.

-- 

Emmanuel Florac |   Direction technique
|   Intellique
|   
|   +33 1 78 94 84 02

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

2016-01-04 Thread Quinn Tran





On 12/20/15, 11:13 PM, "target-devel-ow...@vger.kernel.org on behalf of
Nicholas A. Bellinger"  wrote:

>On Thu, 2015-12-17 at 14:57 -0500, Himanshu Madhani wrote:
>> From: Quinn Tran 
>> 
>> At high traffic, the work queue can become a bottle neck.
>> Instead of putting each command on the work queue as 1 work
>> element, the fix would daisy chain a list of commands that came
>> from FW/interrupt under 1 work element to reduce lock contention.
>> 
>
>I'm wondering if we are better served by turning this into generic logic
>in kernel/workqueue.c to be used beyond qla2xxx, or:

QT> For every work element, the pool->lock is grabbed.  Unless the lock
can be grab 1 time and the rest of the work elements piggy back on it then
it¹s worth it to have a new kernel service.


>
>using WQ_UNBOUND (following iser-target) and verify if observed
>bottleneck is due to internal !(WQ_UNBOUND) usage in qla_target.c.

QT> we tried Unbound as one of the low hang fruits. However, Unbound has
negative affect when it comes to scaling.


>
>Out of curiosity, what level of performance improvement does this
>patch (as is) actually provide..?

QT> By itself ³without" this patch series would be minimal.  With the
patch series, it allows us to consistently maintain an additional (approx)
+50~70k IOPS @4k read. Otherwise, the load is not sustainable or has a
chance to increase.

The test I use is 2ports Initiator vs 2 ports target, 2 * Qlogic 16G dual
port, TCM ramdisk. 

>
>Thank you,
>
>--nab

>
>--
>To unsubscribe from this list: send the line "unsubscribe target-devel" in
>the body of a message to majord...@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

<>

Re: [PATCH v2 11/16] qla2xxx: Add selective command queuing

Re: qla2xxx: Delete session if initiator is gone from FW

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

RE: [PATCH] mpt3sas: a correction in unmap_resources

Re: st driver doesn't seem to grok LTO partitioning

Re: st driver doesn't seem to grok LTO partitioning

Re: st driver doesn't seem to grok LTO partitioning

Re: st driver doesn't seem to grok LTO partitioning

Re: [PATCH] mpt3sas: a correction in unmap_resources

Re: [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices

Re: [PATCH v3 0/3] hpsa update

Re: [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052

Re: st driver doesn't seem to grok LTO partitioning

Re: [PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

14 matches

Site Navigation

Mail list logo

Footer information