date:20160205

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

2016-02-05 Thread Praveen Murali

Hi Yijing,
  The fix was deemed inappropriate and I think the explanation provided by 
James was kind similar to what your observation is. Also, as far as I remember 
the consensus was that these error messages (sysfs group not found) are 
harmless at this point. I think James can provide a better explanation and 
direction for you (copying him here).

Praveen

> On Feb 5, 2016, at 1:20 AM, wangyijing  wrote:
> 
> Hi Dan and Praveen,
>   I found a patch titled "libsas: fix "sysfs group not found" warnings at 
> port teardown time" by google,
> https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html
> 
> I found the same warning calltrace in my platform, but I didn't find the 
> patch changes in the latest kernel 4.5-rc2.
> So is this issue still in kernel ?
> 
> I think your patch could fix this issue we found, but I'm worried about 
> another problem.
> 
> Now when unplug a disk
> 
> LLDD report a event loss_of_singal
>sas_deform_port
>   sas_unregister_domain_devices
>   sas_unregister_dev
>   sas_discover_event(dev->port, DISCE_DESTRUCT);
>   sas_port_delete
>   phy->port = NULL;
> 
> and after your patch changes
> 
> LLDD report a event loss_of_singal
>   sas_deform_port
>   sas_unregister_domain_devices
>   sas_unregister_dev
>   sas_discover_event(dev->port, DISCE_DESTRUCT);
>   phy->port = NULL;
> 
> ...
>   sas_destruct_devices
>   sas_port_delete   //now we actually delete the port device, but 
> we set  phy->port = NULL;  before this time.
> 
> 
> So if we hotplug the disk quickly, plug,unplug,plug,
> The new dmaed event(plug) would try to alloc and add a new port, but the old 
> port device is still alive.
> Another calltrace would occur
> 
> WARNING: CPU: 0 PID: 1038 at lib/kobject.c:240 
> kobject_add_internal+0x258/0x318()
> kobject_add_internal failed for port-0:0 with -EEXIST, don't try to register 
> things with the same name in the same directory.
> CPU: 0 PID: 1038 Comm: kworker/u64:2 Tainted: GW   4.1.6+ #140
> [] dump_backtrace+0x0/0x124
> [] show_stack+0x10/0x1c
> [] warn_slowpath_fmt+0x4c/0x58
> [] device_add+0x28c/0x5b8
> [] sas_port_add+0x20/0xbc
> [] sas_porte_bytes_dmaed
> [] process_one_work+0x13c/0x344
> 
> Because I am not a sas guy, so if you could comment this or post new patch, I 
> would be thanks a lot!
> 
> Thanks!
> Yijing.
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-05 Thread Quinn Tran

Bart,

Thanks for sharing the script.  Will drop the patch.

Regards,
Quinn Tran






On 2/5/16, 11:42 AM, "Bart Van Assche"  wrote:

>On 02/05/2016 10:49 AM, Quinn Tran wrote:
>> On 2/4/16, 10:20 AM, "Bart Van Assche"  wrote:
>>> On 02/04/2016 08:45 AM, Himanshu Madhani wrote:
 From: Quinn Tran 

> cat /sys/kernel/debug/qla2xxx/*/irq_cpuid
 qla2xxx_81
   IRQ Name  Vector  CPUID
  qla2xxx (default)  150 9
qla2xxx (rsp_q)  151 9
   qla2xxx (atio_q)  152 9
>>>
>>> Hello Quinn and Himanshu,
>>>
>>> Do you think it would be possible to generate this information via a
>>> user-space script from /proc/interrupts and /proc/irq//smp_affinity?
>>>
>>> Thanks,
>>>
>>> Bart.
>>
>> Bart,
>> 
>> Currently, the data from the 2 mentioned “/proc” entry points were not able 
>> to give us the host_id/port & the vector information.
>> 
>> The 2 alternatives are i) change the driver code to register host id along 
>> with the vector and add script to combine the infos,  ii) 1 code change that 
>> gives us the summary.
>> 
>> We choose path 2 for the ease of usage.
>
>Hello Quinn,
>
>Please have another look at /proc/interrupts and
>/proc/irq//smp_affinity. The information that is exported through
>this patch is already available there. This is why I think this patch
>should be dropped. All you need is something like the shell script below.
>
>Sample output (nn = NUMA node; num = IRQ vector):
>
> IRQs
>nn cpu num count name
>0  6   105  1753 PCI-MSI-edge  qla2xxx (rsp_q) 
>1  1   104  8781 PCI-MSI-edge  qla2xxx (default)   
>1  1   107  1629 PCI-MSI-edge  qla2xxx (rsp_q) 
>
>The shell script that produced the above output:
>
>ppi() {
>{ echo "$(<"/sys/devices/system/cpu/cpu$1/topology/physical_package_id")" 
> || echo '?'; } 2>/dev/null
>}
>
>echo " IRQs"
>printf "%-2s %-3s %-3s %12s %-50s\n" nn cpu num count name
>cat /proc/interrupts |
>  while read line; do
>num="$(echo "$line" | sed -n 
> 's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\1/p')"
>[ -z "$num" ] && continue
>count=0
>for c in $(echo "$line" | sed -n 
> 's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\2/p'); do
>   count=$((count+c))
>done
>name="$(echo "$line" | sed -n 
> 's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\3/p')"
>if [ -r "/proc/irq/$num/smp_affinity_list" ]; then
>   al="$(<"/proc/irq/$num/smp_affinity_list")"
>   cpu="${al/-*}" 
>   cpu="${cpu/,*}"
>   ppi="$(ppi "$cpu")"
>else
>   cpu="?"
>   ppi="?"
>fi
>printf "%-2s %-3d %-3d %12d %-50s\n" "$ppi" "$cpu" "$num" "$count" "$name"
>  done |
>  sort -n -k1,3
>
>Thanks,
>
>Bart.
<>

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

2016-02-05 Thread Todd Fujinaka

I've tried to read the code but I'm not sure where the strings are getting
parsed. I'm afraid I'm only familiar with the Ethernet drivers. In any case,
the patch didn't help and I had to add this second Marvell line. I'm not sure
if you can just wildcard the second and third fields or not.

I'm also trying to reply to a mailing-list that I'm not subscribed to using git
send-email. Please forgive the errors.

Todd Fujinaka 

-

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 47b9d13..bbfbfd9 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -205,6 +205,8 @@ static struct {
{"Intel", "Multi-Flex", NULL, BLIST_NO_RSOC},
{"iRiver", "iFP Mass Driver", NULL, BLIST_NOT_LOCKABLE | 
BLIST_INQUIRY_36},
{"LASOUND", "CDX7405", "3.10", BLIST_MAX5LUN | BLIST_SINGLELUN},
+   {"Marvell", "Console", NULL, BLIST_SKIP_VPD_PAGES},
+   {"Marvell", "91xx Config", "1.01", BLIST_SKIP_VPD_PAGES},
{"MATSHITA", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"MATSHITA", "DMC-LC5", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36},
{"MATSHITA", "DMC-LC40", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36},
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2016-02-05 Thread bugzilla-daemon

https://bugzilla.kernel.org/show_bug.cgi?id=101891

Dāvis  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |CODE_FIX

-- 
You are receiving this mail because:
You are watching the assignee of the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 71021] WARNING: CPU: 0 PID: 5517 at /build/buildd/linux-3.13.0/fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()

2016-02-05 Thread bugzilla-daemon

https://bugzilla.kernel.org/show_bug.cgi?id=71021

--- Comment #3 from Dāvis  ---
This still happens with 4.4.0
When removing disk

kernel: /mnt/Linux/linux/drivers/scsi/mvsas/mv_sas.c 1913:phy3 Removed Device
kernel: [ cut here ]
kernel: WARNING: CPU: 3 PID: 16820 at /mnt/Linux/linux/fs/sysfs/group.c:237
sysfs_remove_group+0x8b/0x90()
kernel: sysfs group 818a3b60 not found for kobject 'end_device-7:7'
kernel: Modules linked in: fuse nf_conntrack_netbios_ns nf_conntrack_broadcast
xt_tcpudp ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4
xt_conntrack ip_set nfnetlink ebtable_bro
kernel:  snd_usbmidi_lib videobuf2_v4l2 snd_rawmidi snd_seq_device mousedev
gf128mul input_leds joydev led_class glue_helper snd_hda_codec_hdmi
snd_hda_codec_realtek videobuf2_core r8169 v4l2_commo
kernel:  libsas libahci scsi_transport_sas syscopyarea sysfillrect sysimgblt
fb_sys_fops drm libata usbcore usb_common scsi_mod i2c_core wmi i8042 serio
button ip_tables x_tables [last unloaded: dr
kernel: CPU: 3 PID: 16820 Comm: kworker/u16:8 Tainted: PW  O   
4.4.0-ARCH-dirty #1
kernel: Hardware name: Gigabyte Technology Co., Ltd.
GA-990FXA-UD3/GA-990FXA-UD3, BIOS FFe 11/08/2013
kernel: Workqueue: scsi_wq_7 sas_destruct_devices [libsas]
kernel:   ad666a1d 8801d3103c50 812bf949
kernel:  8801d3103c98 8801d3103c88 810764f2 
kernel:  818a3b60 88021cb30410 8800cd642828 8800cd6427f8
kernel: Call Trace:
kernel:  [] dump_stack+0x4b/0x72
kernel:  [] warn_slowpath_common+0x82/0xc0
kernel:  [] warn_slowpath_fmt+0x5c/0x80
kernel:  [] ? kernfs_find_and_get_ns+0x48/0x60
kernel:  [] sysfs_remove_group+0x8b/0x90
kernel:  [] dpm_sysfs_remove+0x57/0x60
kernel:  [] device_del+0x58/0x260
kernel:  [] device_unregister+0x1e/0x60
kernel:  [] bsg_unregister_queue+0x60/0xb0
kernel:  [] sas_rphy_remove+0x48/0x70 [scsi_transport_sas]
kernel:  [] sas_rphy_delete+0x12/0x20 [scsi_transport_sas]
kernel:  [] sas_destruct_devices+0x63/0x90 [libsas]
kernel:  [] process_one_work+0x14b/0x440
kernel:  [] worker_thread+0x48/0x4a0
kernel:  [] ? process_one_work+0x440/0x440
kernel:  [] ? process_one_work+0x440/0x440
kernel:  [] kthread+0xd8/0xf0
kernel:  [] ? kthread_worker_fn+0x170/0x170
kernel:  [] ret_from_fork+0x3f/0x70
kernel:  [] ? kthread_worker_fn+0x170/0x170
kernel: ---[ end trace 640cb81c5c1e9aa7 ]---
kernel: [ cut here ]
kernel: WARNING: CPU: 4 PID: 16820 at /mnt/Linux/linux/fs/sysfs/group.c:237
sysfs_remove_group+0x8b/0x90()
kernel: sysfs group 818a3b60 not found for kobject 'end_device-7:7'
kernel: Modules linked in: fuse nf_conntrack_netbios_ns nf_conntrack_broadcast
xt_tcpudp ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4
xt_conntrack ip_set nfnetlink ebtable_bro
kernel:  snd_usbmidi_lib videobuf2_v4l2 snd_rawmidi snd_seq_device mousedev
gf128mul input_leds joydev led_class glue_helper snd_hda_codec_hdmi
snd_hda_codec_realtek videobuf2_core r8169 v4l2_commo
kernel:  libsas libahci scsi_transport_sas syscopyarea sysfillrect sysimgblt
fb_sys_fops drm libata usbcore usb_common scsi_mod i2c_core wmi i8042 serio
button ip_tables x_tables [last unloaded: dr
kernel: CPU: 4 PID: 16820 Comm: kworker/u16:8 Tainted: PW  O   
4.4.0-ARCH-dirty #1
kernel: Hardware name: Gigabyte Technology Co., Ltd.
GA-990FXA-UD3/GA-990FXA-UD3, BIOS FFe 11/08/2013
kernel: Workqueue: scsi_wq_7 sas_destruct_devices [libsas]
kernel:   ad666a1d 8801d3103bf8 812bf949
kernel:  8801d3103c40 8801d3103c30 810764f2 
kernel:  818a3b60 88021c6dd038 8800cd642828 8800cd6427f8
kernel: Call Trace:
kernel:  [] dump_stack+0x4b/0x72
kernel:  [] warn_slowpath_common+0x82/0xc0
kernel:  [] warn_slowpath_fmt+0x5c/0x80
kernel:  [] ? kernfs_find_and_get_ns+0x48/0x60
kernel:  [] ? kfree_const+0x22/0x30
kernel:  [] sysfs_remove_group+0x8b/0x90
kernel:  [] dpm_sysfs_remove+0x57/0x60
kernel:  [] device_del+0x58/0x260
kernel:  [] ? device_remove_file+0x19/0x20
kernel:  [] attribute_container_class_device_del+0x1a/0x20
kernel:  [] transport_remove_classdev+0x4e/0x60
kernel:  [] ? transport_add_class_device+0x40/0x40
kernel:  [] attribute_container_device_trigger+0xce/0xe0
kernel:  [] transport_remove_device+0x15/0x20
kernel:  [] sas_rphy_remove+0x50/0x70 [scsi_transport_sas]
kernel:  [] sas_rphy_delete+0x12/0x20 [scsi_transport_sas]
kernel:  [] sas_destruct_devices+0x63/0x90 [libsas]
kernel:  [] process_one_work+0x14b/0x440
kernel:  [] worker_thread+0x48/0x4a0
kernel:  [] ? process_one_work+0x440/0x440
kernel:  [] ? process_one_work+0x440/0x440
kernel:  [] kthread+0xd8/0xf0
kernel:  [] ? kthread_worker_fn+0x170/0x170
kernel:  [] ret_from_fork+0x3f/0x70
kernel:  [] ? kthread_worker_fn+0x170/0x170
kernel: ---[ end trace 640cb81c5c1e9aa8 ]---
kernel: [ cut here ]
kernel: WARNING: CPU: 4 PID:

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-05 Thread Quinn Tran

Bart,

Currently, the data from the 2 mentioned “/proc” entry points were not able to 
give us the host_id/port & the vector information.

The 2 alternatives are i) change the driver code to register host id along with 
the vector and add script to combine the infos,  ii) 1 code change that gives 
us the summary.

We choose path 2 for the ease of usage.

Regards,
Quinn Tran

On 2/4/16, 10:20 AM, "Bart Van Assche"  wrote:

>On 02/04/2016 08:45 AM, Himanshu Madhani wrote:
>> From: Quinn Tran 
>>
>>> cat /sys/kernel/debug/qla2xxx/*/irq_cpuid
>> qla2xxx_81
>>  IRQ Name  Vector  CPUID
>> qla2xxx (default)  150 9
>>   qla2xxx (rsp_q)  151 9
>>  qla2xxx (atio_q)  152 9
>
>Hello Quinn and Himanshu,
>
>Do you think it would be possible to generate this information via a 
>user-space script from /proc/interrupts and /proc/irq//smp_affinity?
>
>Thanks,
>
>Bart.
<>

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

2016-02-05 Thread Dāvis Mosāns

2016-02-05 11:20 GMT+02:00 wangyijing :
>
> Hi Dan and Praveen,
>I found a patch titled "libsas: fix "sysfs group not found" warnings at
> port teardown time" by google,
> https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html
>

 Maybe this is related?

 kernel: WARNING: CPU: 4 PID: 16820 at fs/sysfs/group.c:237
 sysfs_remove_group+0x8b/0x90()
 kernel: sysfs group 818a3b60 not found for kobject 'end_device-7:7'
 [...]
 kernel: Workqueue: scsi_wq_7 sas_destruct_devices [libsas]

 I'm getting this warning when removing disk from HighPoint RocketRAID 2760
 controller (mvsas driver)
 See https://bugzilla.kernel.org/show_bug.cgi?id=71021#c3
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

2016-02-05 Thread Bart Van Assche

On 02/05/2016 10:49 AM, Quinn Tran wrote:
> On 2/4/16, 10:20 AM, "Bart Van Assche"  wrote:
>> On 02/04/2016 08:45 AM, Himanshu Madhani wrote:
>>> From: Quinn Tran 
>>>
 cat /sys/kernel/debug/qla2xxx/*/irq_cpuid
>>> qla2xxx_81
>>>   IRQ Name  Vector  CPUID
>>>  qla2xxx (default)  150 9
>>>qla2xxx (rsp_q)  151 9
>>>   qla2xxx (atio_q)  152 9
>>
>> Hello Quinn and Himanshu,
>>
>> Do you think it would be possible to generate this information via a
>> user-space script from /proc/interrupts and /proc/irq//smp_affinity?
>>
>> Thanks,
>>
>> Bart.
>
> Bart,
> 
> Currently, the data from the 2 mentioned “/proc” entry points were not able 
> to give us the host_id/port & the vector information.
> 
> The 2 alternatives are i) change the driver code to register host id along 
> with the vector and add script to combine the infos,  ii) 1 code change that 
> gives us the summary.
> 
> We choose path 2 for the ease of usage.

Hello Quinn,

Please have another look at /proc/interrupts and
/proc/irq//smp_affinity. The information that is exported through
this patch is already available there. This is why I think this patch
should be dropped. All you need is something like the shell script below.

Sample output (nn = NUMA node; num = IRQ vector):

 IRQs
nn cpu num count name
0  6   105  1753 PCI-MSI-edge  qla2xxx (rsp_q) 
1  1   104  8781 PCI-MSI-edge  qla2xxx (default)   
1  1   107  1629 PCI-MSI-edge  qla2xxx (rsp_q) 

The shell script that produced the above output:

ppi() {
{ echo "$(<"/sys/devices/system/cpu/cpu$1/topology/physical_package_id")" 
|| echo '?'; } 2>/dev/null
}

echo " IRQs"
printf "%-2s %-3s %-3s %12s %-50s\n" nn cpu num count name
cat /proc/interrupts |
  while read line; do
num="$(echo "$line" | sed -n 
's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\1/p')"
[ -z "$num" ] && continue
count=0
for c in $(echo "$line" | sed -n 
's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\2/p'); do
count=$((count+c))
done
name="$(echo "$line" | sed -n 
's/^[[:blank:]]*\([0-9]*\):\([0-9[:blank:]]*\)\(.*\)/\3/p')"
if [ -r "/proc/irq/$num/smp_affinity_list" ]; then
al="$(<"/proc/irq/$num/smp_affinity_list")"
cpu="${al/-*}" 
cpu="${cpu/,*}"
ppi="$(ppi "$cpu")"
else
cpu="?"
ppi="?"
fi
printf "%-2s %-3d %-3d %12d %-50s\n" "$ppi" "$cpu" "$num" "$count" "$name"
  done |
  sort -n -k1,3

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-05 Thread Bart Van Assche


On 02/05/2016 09:26 AM, Himanshu Madhani wrote:

On 2/4/16, 10:16 AM, "Bart Van Assche"  wrote:

On 02/04/2016 08:45 AM, Himanshu Madhani wrote:

From: Quinn Tran 

   #cat  /sys/kernel/debug/qla2xxx/qla2xxx_31/tgt_sess
   qla2xxx_31
   Port ID   Port NameHandle
   ff:fc:01  21:fd:00:05:33:c7:ec:16  0
   01:0e:00  21:00:00:24:ff:7b:8a:e4  1
   01:0f:00  21:00:00:24:ff:7b:8a:e5  2
   


Hello Quinn and Himanshu,

The above information is not only useful to people who are debugging the
QLogic target driver but also to end users who want to check which
initiator ports have already logged in to a target port. Hence my
proposal to move this information from debugfs to another location (e.g.
configfs or sysfs). Users of other target drivers are probably also
interested in seeing which sessions are active. How about adding the
functionality for reporting session information per target port in the
LIO core in such a way that some attributes are available for all target
drivers (e.g. initiator port name, SCSI command statistics) and such
that target drivers can define additional attributes to exported for
each session (e.g. port ID, handle, ...).


We had initially implemented this as a sysfs hook, but knowing that sysfs
is not encouraged, we decided to put this information via debugfs. Would it
make more sense if we send a sysfs patch?


Hello Himanshu,

Let's try to reach agreement about the approach first before starting to 
rework this patch.


Five years ago I explained in a message that I posted on the linux-scsi 
mailing list why LIO should use sysfs to export information that changes 
dynamically (see also http://thread.gmane.org/gmane.linux.scsi/65615/). 
I think this patch shows that there is a real need to have detailed 
session information from LIO target drivers in user space. We need one 
directory per session instead of exporting all session information 
through a single file. sysfs is the right filesystem to export such 
information because configfs directories should be created by the user 
and not from inside the kernel. If no agreement can be reached about 
this over e-mail my proposal is to discuss this further at the 2016 
LSF/MM summit.


Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-05 Thread Giridhar Malavali



On 2/5/16, 12:00 PM, "Bart Van Assche"  wrote:

>On 02/05/2016 09:26 AM, Himanshu Madhani wrote:
>> On 2/4/16, 10:16 AM, "Bart Van Assche" 
>>wrote:
>>> On 02/04/2016 08:45 AM, Himanshu Madhani wrote:
 From: Quinn Tran 

#cat  /sys/kernel/debug/qla2xxx/qla2xxx_31/tgt_sess
qla2xxx_31
Port ID   Port NameHandle
ff:fc:01  21:fd:00:05:33:c7:ec:16  0
01:0e:00  21:00:00:24:ff:7b:8a:e4  1
01:0f:00  21:00:00:24:ff:7b:8a:e5  2

>>>
>>> Hello Quinn and Himanshu,
>>>
>>> The above information is not only useful to people who are debugging
>>>the
>>> QLogic target driver but also to end users who want to check which
>>> initiator ports have already logged in to a target port. Hence my
>>> proposal to move this information from debugfs to another location
>>>(e.g.
>>> configfs or sysfs). Users of other target drivers are probably also
>>> interested in seeing which sessions are active. How about adding the
>>> functionality for reporting session information per target port in the
>>> LIO core in such a way that some attributes are available for all
>>>target
>>> drivers (e.g. initiator port name, SCSI command statistics) and such
>>> that target drivers can define additional attributes to exported for
>>> each session (e.g. port ID, handle, ...).
>>
>> We had initially implemented this as a sysfs hook, but knowing that
>>sysfs
>> is not encouraged, we decided to put this information via debugfs.
>>Would it
>> make more sense if we send a sysfs patch?
>
>Hello Himanshu,
>
>Let's try to reach agreement about the approach first before starting to
>rework this patch.
>
>Five years ago I explained in a message that I posted on the linux-scsi
>mailing list why LIO should use sysfs to export information that changes
>dynamically (see also http://thread.gmane.org/gmane.linux.scsi/65615/).
>I think this patch shows that there is a real need to have detailed
>session information from LIO target drivers in user space. We need one
>directory per session instead of exporting all session information
>through a single file. sysfs is the right filesystem to export such
>information because configfs directories should be created by the user
>and not from inside the kernel. If no agreement can be reached about
>this over e-mail my proposal is to discuss this further at the 2016
>LSF/MM summit.

Bart, 

I see lot of target customers requesting for such information and having
something that can be created inside kernel space will be helpful. Let us
discuss further at 2016 LSF/MM summit.

‹ Giri



>
>Thanks,
>
>Bart.

<>

[Bug 71021] WARNING: CPU: 0 PID: 5517 at /build/buildd/linux-3.13.0/fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()

2016-02-05 Thread bugzilla-daemon

https://bugzilla.kernel.org/show_bug.cgi?id=71021

Yijing Wang  changed:

   What|Removed |Added

 CC||wangyij...@huawei.com

--- Comment #4 from Yijing Wang  ---
I also found the same issue when remove my disk in my platform, I think the
code logic is incorrect, this call trace would appear every disk remove. I
found  Dan Williams posted a fix patch, but it was not merged to kernel.

https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html

Following is my call trace:

WARNING: CPU: 2 PID: 6 at fs/sysfs/group.c:224 sysfs_remove_group+0x9c/0xa0()
sysfs group (power)80a2dbe8 not found for kobject '0:0:1:0'
Modules linked in:
CPU: 2 PID: 6 Comm: kworker/u64:0 Not tainted 4.1.6+ #157
Hardware name: Hisilicon PhosphorV660 Development Board (DT)
Workqueue: scsi_wq_0 sas_destruct_devices
Call trace:
[] dump_backtrace+0x0/0x124
[] show_stack+0x10/0x1c
[] dump_stack+0x78/0x98
[] warn_slowpath_common+0x98/0xd0
[] warn_slowpath_fmt+0x4c/0x58
[] sysfs_remove_group+0x98/0xa0
[] dpm_sysfs_remove+0x54/0x68
[] device_del+0x3c/0x208
[] device_unregister+0x10/0x2c
[] bsg_unregister_queue+0xbc/0xf8
[] __scsi_remove_device+0x9c/0xbc
[] scsi_remove_device+0x44/0x64
[] scsi_remove_target+0x198/0x258
[] sas_rphy_remove+0x8c/0xb4
[] sas_rphy_delete+0x34/0x54
[] sas_destruct_devices+0x60/0x98
[] process_one_work+0x13c/0x344
[] worker_thread+0x13c/0x494
[] kthread+0xd8/0xf0

-- 
You are receiving this mail because:
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

2016-02-05 Thread wangyijing

Yes, it seems to be the same issue.

在 2016/2/6 1:22, Dāvis Mosāns 写道:
> 2016-02-05 11:20 GMT+02:00 wangyijing :
>>
>> Hi Dan and Praveen,
>>I found a patch titled "libsas: fix "sysfs group not found" warnings at
>> port teardown time" by google,
>> https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html
>>
> 
>  Maybe this is related?
> 
>  kernel: WARNING: CPU: 4 PID: 16820 at fs/sysfs/group.c:237
>  sysfs_remove_group+0x8b/0x90()
>  kernel: sysfs group 818a3b60 not found for kobject 'end_device-7:7'
>  [...]
>  kernel: Workqueue: scsi_wq_7 sas_destruct_devices [libsas]
> 
>  I'm getting this warning when removing disk from HighPoint RocketRAID 2760
>  controller (mvsas driver)
>  See https://bugzilla.kernel.org/show_bug.cgi?id=71021#c3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

[Bug 71021] WARNING: CPU: 0 PID: 5517 at /build/buildd/linux-3.13.0/fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

Re: [PATCH 4/4] qla2xxx: Add DebugFS node to show irq vector's cpuid

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

[Bug 71021] WARNING: CPU: 0 PID: 5517 at /build/buildd/linux-3.13.0/fs/sysfs/group.c:214 sysfs_remove_group+0xc6/0xd0()

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

12 matches

Site Navigation

Mail list logo

Footer information