date:20160616

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby

Hi Joe,

On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches  wrote:
> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
>> Hi Joe,
>
> rehi Julian.

(I always put a salutation on my emails and always finish them with
"Thanks," =) )

>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches  wrote:
> []
>> > get_maintainer.pl also has a rarely used "--file-emails" option to
>> > scan for what appears to be email addresses in specific files.
>> >
>> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
>> > Arvind Kumar  (maintainer:VMware PVSCSI driver,in 
>> > file)
>> > VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
>> > "James E.J. Bottomley"  (maintainer:SCSI 
>> > SUBSYSTEM)
>> > "Martin K. Petersen"  (maintainer:SCSI 
>> > SUBSYSTEM)
>> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
>> > linux-ker...@vger.kernel.org (open list)
>> >
>> > note the "in file" after Arvind's name
>> Didn't know this, however my point stands: the maintainer line in the
>> file is redundant if we find maintainers through MAINTAINERS or the
>> get_maintainer.pl script.
>
> Yes, I'm not suggesting anything else.  Jim's name
> should appear in the MAINTAINERS file somewhere.
>
> The question to me is whether or not Jim Gill is
> taking over the maintainership of the entire
> VMware PVSCSI driver or just a few files of it.

As I see it, he's taking over maintainership of all of it: it's only
files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

Thanks,

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Joe Perches

On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote:
> Hi Joe,

rehi Julian.

> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches  wrote:
[]
> > get_maintainer.pl also has a rarely used "--file-emails" option to
> > scan for what appears to be email addresses in specific files.
> > 
> > $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> > Arvind Kumar  (maintainer:VMware PVSCSI driver,in 
> > file)
> > VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
> > "James E.J. Bottomley"  (maintainer:SCSI SUBSYSTEM)
> > "Martin K. Petersen"  (maintainer:SCSI 
> > SUBSYSTEM)
> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> > linux-ker...@vger.kernel.org (open list)
> > 
> > note the "in file" after Arvind's name
> Didn't know this, however my point stands: the maintainer line in the
> file is redundant if we find maintainers through MAINTAINERS or the
> get_maintainer.pl script.

Yes, I'm not suggesting anything else.  Jim's name
should appear in the MAINTAINERS file somewhere.

The question to me is whether or not Jim Gill is
taking over the maintainership of the entire
VMware PVSCSI driver or just a few files of it.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] cxlflash: Add device dependent flags

2016-06-16 Thread Manoj Kumar


On 6/15/2016 6:49 PM, Uma Krishnan wrote:

Device dependent flags are needed to support functions that are
specific to a particular device.




Acked-by: Manoj N. Kumar 


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby

Hi Joe,

On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches  wrote:
> On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
>> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c
>
> just fyi:  the script name is not plural

Thanks, must have typo'd it between running it and typing it into the email.

> $ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
> Arvind Kumar  (maintainer:VMware PVSCSI driver)
> VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley"  (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen"  (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-ker...@vger.kernel.org (open list)
>
> and another fyi:
>
> get_maintainer.pl also has a rarely used "--file-emails" option to
> scan for what appears to be email addresses in specific files.
>
> $ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
> Arvind Kumar  (maintainer:VMware PVSCSI driver,in 
> file)
> VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
> "James E.J. Bottomley"  (maintainer:SCSI SUBSYSTEM)
> "Martin K. Petersen"  (maintainer:SCSI SUBSYSTEM)
> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
> linux-ker...@vger.kernel.org (open list)
>
> note the "in file" after Arvind's name

Didn't know this, however my point stands: the maintainer line in the
file is redundant if we find maintainers through MAINTAINERS or the
get_maintainer.pl script.

Thanks,

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Joe Perches

On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote:
> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

just fyi:  the script name is not plural

$ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar  (maintainer:VMware PVSCSI driver)
VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley"  (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen"  (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-ker...@vger.kernel.org (open list)

and another fyi:

get_maintainer.pl also has a rarely used "--file-emails" option to
scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar  (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers  (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley"  (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen"  (maintainer:SCSI SUBSYSTEM)
linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver)
linux-ker...@vger.kernel.org (open list)

note the "in file" after Arvind's name
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby

Hi Arvind,

On Fri, Jun 17, 2016 at 12:03 PM, Arvind Kumar  wrote:
> Hi Julian,
>
> Thanks for spotting that. We will update that too.
>
> I don't really see it as redundant rather as a quick reference instead of 
> digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. 
> Specially for those readers who might not even know about the MAINTAINERS 
> file.

You can use the get_maintainers script in the scripts directory to
quickly get information from MAINTAINERS, i.e.:

./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

or

./scripts/get_maintainers.pl patchfile.patch

Thanks,

Julian Calaby


>
> Thanks!
> Arvind
> 
> From: Julian Calaby 
> Sent: Thursday, June 16, 2016 6:48 PM
> To: Jim Gill
> Cc: j...@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; 
> pv-driv...@vmware.com; linux-scsi; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, 
> email)
>
> Hi Jim,
>
> On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill  wrote:
>> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
>> From: Jim Gill 
>> Date: Thu, 16 Jun 2016 14:10:43 -0700
>> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
>> email)
>>
>> Signed-off-by: Jim Gill 
>> ---
>>  drivers/scsi/vmw_pvscsi.c | 2 +-
>>  drivers/scsi/vmw_pvscsi.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
>> index 6164634..4a0d3cd 100644
>> --- a/drivers/scsi/vmw_pvscsi.c
>> +++ b/drivers/scsi/vmw_pvscsi.c
>> @@ -17,7 +17,7 @@
>>   * along with this program; if not, write to the Free Software
>>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
>> USA.
>>   *
>> - * Maintained by: Arvind Kumar 
>> + * Maintained by: Jim Gill 
>
> Shouldn't you update MAINTAINERs too? And isn't having this
> information in these files redundant?
>
> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.cal...@gmail.com
> Profile: 
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_=CwIBaQ=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM=



-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Arvind Kumar

Hi Julian,

Thanks for spotting that. We will update that too.

I don't really see it as redundant rather as a quick reference instead of 
digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. 
Specially for those readers who might not even know about the MAINTAINERS file.

Thanks!
Arvind

From: Julian Calaby 
Sent: Thursday, June 16, 2016 6:48 PM
To: Jim Gill
Cc: j...@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; 
pv-driv...@vmware.com; linux-scsi; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, 
email)

Hi Jim,

On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill  wrote:
> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
> From: Jim Gill 
> Date: Thu, 16 Jun 2016 14:10:43 -0700
> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
> email)
>
> Signed-off-by: Jim Gill 
> ---
>  drivers/scsi/vmw_pvscsi.c | 2 +-
>  drivers/scsi/vmw_pvscsi.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index 6164634..4a0d3cd 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -17,7 +17,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> USA.
>   *
> - * Maintained by: Arvind Kumar 
> + * Maintained by: Jim Gill 

Shouldn't you update MAINTAINERs too? And isn't having this
information in these files redundant?

Thanks,

--
Julian Calaby

Email: julian.cal...@gmail.com
Profile: 
https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_=CwIBaQ=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM=
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby

Hi Jim,

On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill  wrote:
> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
> From: Jim Gill 
> Date: Thu, 16 Jun 2016 14:10:43 -0700
> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name,
> email)
>
> Signed-off-by: Jim Gill 
> ---
>  drivers/scsi/vmw_pvscsi.c | 2 +-
>  drivers/scsi/vmw_pvscsi.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index 6164634..4a0d3cd 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -17,7 +17,7 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> USA.
>   *
> - * Maintained by: Arvind Kumar 
> + * Maintained by: Jim Gill 

Shouldn't you update MAINTAINERs too? And isn't having this
information in these files redundant?

Thanks,

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Arvind Kumar

Looks fine to me.

Acked-by: Arvind Kumar (arvindku...@vmware.com)

Thanks!
Arvind

From: Jim Gill 
Sent: Thursday, June 16, 2016 6:05 PM
To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com
Cc: Arvind Kumar; pv-driv...@vmware.com; linux-scsi@vger.kernel.org; 
linux-ker...@vger.kernel.org
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

 From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill 
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by: Jim Gill 
---
  drivers/scsi/vmw_pvscsi.c | 2 +-
  drivers/scsi/vmw_pvscsi.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar 
+ * Maintained by: Jim Gill 
   *
   */

diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar 
+ * Maintained by: Jim Gill 
   *
   */

--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Jim Gill


From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill 
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by: Jim Gill 
---
 drivers/scsi/vmw_pvscsi.c | 2 +-
 drivers/scsi/vmw_pvscsi.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  *
- * Maintained by: Arvind Kumar 
+ * Maintained by: Jim Gill 
  *
  */
 
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h

index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  *
- * Maintained by: Arvind Kumar 
+ * Maintained by: Jim Gill 
  *
  */
 
--

2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V3 0/2] initial submit of Microsemi smarpqi driver

2016-06-16 Thread Don Brace

This driver is based on Linus's tree

This initial commit contains WIP of Microsemi's smartpqi module.

- add smartpqi to kernel.org
- remove PCI IDs from aacraid driver
  - Depends on adoption of smartpqi driver

Changes since V2
 - Corrected make ARCH=s390 kbuild test robot issue.
 - Answers to Hannes's Review posted in a separate reply

Changes since V1
 - Corrected make ARCH=i386 kbuild test robot issue.

Changes since initial upload
 - Forgot to give correct ownership to the author.

---

Don Brace (1):
  aacraid: remove wildcard for series 9 controllers

Kevin Barnett (1):
  smartpqi: initial commit of Microsemi smartpqi driver


 MAINTAINERS|   11 
 drivers/scsi/Kconfig   |1 
 drivers/scsi/Makefile  |1 
 drivers/scsi/aacraid/linit.c   |2 
 drivers/scsi/smartpqi/Kconfig  |   50 
 drivers/scsi/smartpqi/Makefile |3 
 drivers/scsi/smartpqi/smartpqi.h   | 1135 
 drivers/scsi/smartpqi/smartpqi_init.c  | 6824 
 drivers/scsi/smartpqi/smartpqi_sas_transport.c |  350 +
 drivers/scsi/smartpqi/smartpqi_sis.c   |  394 +
 drivers/scsi/smartpqi/smartpqi_sis.h   |   32 
 11 files changed, 8801 insertions(+), 2 deletions(-)
 create mode 100644 drivers/scsi/smartpqi/Kconfig
 create mode 100644 drivers/scsi/smartpqi/Makefile
 create mode 100644 drivers/scsi/smartpqi/smartpqi.h
 create mode 100644 drivers/scsi/smartpqi/smartpqi_init.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sas_transport.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.h

--
Signature
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V3 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-16 Thread Don Brace

Depends on smartpqi driver adoption

Reviewed-by: Kevin Barnett 
Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
---
 drivers/scsi/aacraid/linit.c |2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 79871f3..d5b26fa 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -160,7 +160,6 @@ static const struct pci_device_id aac_pci_tbl[] = {
{ 0x9005, 0x028b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 62 }, /* Adaptec PMC 
Series 6 (Tupelo) */
{ 0x9005, 0x028c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 63 }, /* Adaptec PMC 
Series 7 (Denali) */
{ 0x9005, 0x028d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 64 }, /* Adaptec PMC 
Series 8 */
-   { 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC 
Series 9 */
{ 0,}
 };
 MODULE_DEVICE_TABLE(pci, aac_pci_tbl);
@@ -239,7 +238,6 @@ static struct aac_driver_ident aac_drivers[] = {
{ aac_src_init, "aacraid", "ADAPTEC ", "RAID", 2, 
AAC_QUIRK_SRC }, /* Adaptec PMC Series 6 (Tupelo) */
{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID", 2, 
AAC_QUIRK_SRC }, /* Adaptec PMC Series 7 (Denali) */
{ aac_srcv_init, "aacraid", "ADAPTEC ", "RAID", 2, 
AAC_QUIRK_SRC }, /* Adaptec PMC Series 8 */
-   { aac_srcv_init, "aacraid", "ADAPTEC ", "RAID", 2, 
AAC_QUIRK_SRC } /* Adaptec PMC Series 9 */
 };
 
 /**

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-16 Thread Joe Perches

On Thu, 2016-06-16 at 16:20 -0500, Bryant G. Ly wrote:
> This driver is a pick up of the old IBM VIO scsi Target Driver
> that was started by Nick and Fujita 2-4 years ago.
> http://comments.gmane.org/gmane.linux.scsi/90119

(style trivia only, nothing important enough to force a respin
 but nice to fix one day)

Please use git format-patch -M so file renames are more obvious.

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> +IBM Power Virtual SCSI Device Target Driver
> +M:   Bryant G. Ly 
> +M:   Michael Cyr 
> +L:   linux-scsi@vger.kernel.org
> +L:   target-de...@vger.kernel.org
> +S:   Supportedybe 
> +F:   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

Maybe

F:  drivers/scsi/ibmscsi_tgt/

> +F:   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.h
> +F:   drivers/scsi/ibmvscsi_tgt/libsrp.c
> +F:   drivers/scsi/ibmvscsi_tgt/libsrp.h

and these become unnecessary

> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c 
> b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
[]
> +/**
> + * ibmvscsis_establish_new_q() - Establish new CRQ queue
> + */

If you use kernel-doc comment style,
please describe the function arguments too.

> +static long ibmvscsis_establish_new_q(struct scsi_info *vscsi,  uint 
> new_state)
> +{
> + long rc = ADAPT_SUCCESS;
> + uint format;
> +
> + vscsi->flags &= PRESERVE_FLAG_FIELDS;
> + vscsi->rsp_q_timer.timer_pops = 0;
> + vscsi->debit = 0;
> + vscsi->credit = 0;
> + rc = vio_enable_interrupts(vscsi->dma_dev);
> + if (rc) {
> + pr_warn("reset_queue: failed to enable interrupts, rc %ld\n",
> + rc);
> + } else {
> + rc = ibmvscsis_check_init_msg(vscsi, );
> + if (rc) {
> + dev_err(>dev, "reset_queue: check_init_msg 
> failed, rc %ld\n",
> + rc);
> + } else if (format == UNUSED_FORMAT &&
> +    new_state == WAIT_CONNECTION) {
> + rc = ibmvscsis_send_init_message(vscsi, INIT_MSG);
> + switch (rc) {
> + case H_SUCCESS:
> + case H_DROPPED:
> + case H_CLOSED:
> + rc = ADAPT_SUCCESS;
> + break;
> +
> + case H_PARAMETER:
> + case H_HARDWARE:
> + break;
> +
> + default:
> + vscsi->state = UNDEFINED;
> + rc = H_HARDWARE;
> + break;
> + }
> + }
> + }
> +
> + return rc;
> +}

This sort of code can have indent reduced by doing

rc = vio_enable_interrupts(...)
if (rc) {
pr_warn(...);
return rc;
}

rc = ibmvscsis_check_init_msg(...)
if (rc) {
dev_err(...);
return rc;
}

if (format == UNUSED_FORMAT && new_state == WAIT_CONNECTION) {
rc = ibmvscsis_send_init_message(vscsi, INIT_MSG);  
switch (rc) {
etc...
}
}

Why use pr_warn and dev_err in the same function?
Shouldn't dev_ be used whenever a struct device is available?

Also it's nice to use %s, __func__ instead of directly
embedding a function like name into the format string.

A lot of the pr_debug uses seem to be function tracing
and could be eliminated altogether.

> + /* can transition from this state to UNCONFIGURING */
> + case UNDEFINED:

Comment style for switch / case labels could not be indented
but start at the same indent level as the case statement.


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V2 0/2] initial submit of Microsemi smartpqi driver

2016-06-16 Thread Don Brace

> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, June 10, 2016 4:57 AM
> To: Don Brace; j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
> elli...@hpe.com
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH V2 0/2] initial submit of Microsemi smartpqi driver
> 
> EXTERNAL EMAIL
> 
> 
> On 06/09/2016 08:50 PM, Don Brace wrote:
> > These patches are based on Linus's tree
> >
> > - add smartpqi to kernel.org
> > - remove PCI IDs from aacraid driver
> >   - Depends on adoption of smartpqi driver
> >
> > Changes since initial upload
> >  - Forgot to give correct ownership to the author.
> > Changes since V1
> >  - Corrected make ARCH=i386 kbuild test robot issue.
> >
> > ---
> >
> > Don Brace (1):
> >   aacraid: remove wildcard for series 9 controllers
> >
> > Kevin Barnett (1):
> >   smartpqi: initial commit of Microsemi smartpqi driver
> >
> >
> >  drivers/scsi/smartpqi/Kconfig  |   50
> >  drivers/scsi/smartpqi/Makefile |3
> >  drivers/scsi/smartpqi/smartpqi.h   | 1135 
> >  drivers/scsi/smartpqi/smartpqi_init.c  | 6817
> 
> >  drivers/scsi/smartpqi/smartpqi_sas_transport.c |  350 +
> >  drivers/scsi/smartpqi/smartpqi_sis.c   |  394 +
> >  drivers/scsi/smartpqi/smartpqi_sis.h   |   32
> >  7 files changed, 8781 insertions(+)
> >  create mode 100644 drivers/scsi/smartpqi/Kconfig
> >  create mode 100644 drivers/scsi/smartpqi/Makefile
> >  create mode 100644 drivers/scsi/smartpqi/smartpqi.h
> >  create mode 100644 drivers/scsi/smartpqi/smartpqi_init.c
> >  create mode 100644 drivers/scsi/smartpqi/smartpqi_sas_transport.c
> >  create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.c
> >  create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.h
> >
> Some general comments:
> - Wouldn't it be better to split off CISS specific definitions from
> smartpqi.h into a separate header file? I guess this even could be
> shared with hpsa, right?
 -- The hpsa driver is now in maintenance mode, so eventually
it will no longer be in the kernel.
Additionally the ciss.h header is associated specifically
with Compaq and Hewlett-Packard Enterprise devices, while
the smartpqi driver is from Microsemi, and will be used with
devices from multiple vendors.

> - In the same vein: Maybe it's worth considering splitting off the PQI
> specific ones into a separate header file, too, and just keeping the
> smartpqi.h file for the driver specific definitions.
 -- It's possible, but the driver uses PQI to communicate
with the controllers, so we wanted to keep the
PQI structures in the controller header.
> - The device rescan / device mapping functionality is positively
> horrible. I still think it was a mistake having that in hpsa, but I'd be
> loath to see this one repeated in smartpqi. Why can't you use the LUN
> numbers directly? It's _quite_ easy to have the RAID and passthrough
> devices on a separate SCSI bus, so that shouldn't be an issue.
 -- The driver must maintain a representation of the devices because
the controllers operate in multiple modes (HBA, local RAID,
pass-through RAID, IO acceleration, encryption, etc).
The driver is responsible for enforcing certain limitations
in some of these modes, and for enabling certain functionality
in others.
 -- The state of enablement of the feature and the application of
limitations is done on a per device level, so the driver must
maintain an internal map of these devices. For example,
in the IO accel mode, the driver maintains extensive knowledge
of the underlying physical disks of a RAID volume: to determine
the eligibility of each IO request for the IO accelerated path,
and maintains state information per volume with respect to IO
accel path enablement on that device. This enablement can get
temporarily disabled while controller completes certain
background functions like RAID level migration, rebuilds, etc.
The driver must coordinate with the controller during these
path state transitions for each device.
 -- The storage administrator assigns LUN and sometimes target
numbering from the storage system's configuration app. The driver
uses those assigned LUN and target numbers so that addresses are
consistent across multiple servers, and persistent across reboots to
comply with requirements for clustering and shared storage.
> - The 'devices' sysfs attribute is a sysfs abuse. As per definition each
> sysfs attribute should be a single entry. If you want/need to have a
> listing consider adding a sysfs directory for the devices.
> But then again, if you drop the device rescan/mapping functionality and
> use the LUN numbers

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

2016-06-16 Thread Tejun Heo

On Thu, Jun 16, 2016 at 12:45:40PM +0800, DingXiang wrote:
...
> In fact,we don't need libata to deal with hotplug in sas environment.
> So we can't run ata hotplug task when ata port is sas host.

Martin, can you please confirm whether the above is true.  If so, I'll
route the patch through libata w/ stable cc'd.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

I'm a banker and i have a business that will benefit us

2016-06-16 Thread Natasha Romaric

Ik ben een bankier en ik heb een bedrijf dat ons ten goede zal komen
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

2016-06-16 Thread kbuild test robot

Hi,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.7-rc3 next-20160616]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Arnd-Bergmann/scsi-lpfc-avoid-harmless-comparison-warning/20160616-045453
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=alpha 

All warnings (new ones prefixed by >>):

   drivers/scsi/wd7000.c: In function 'mail_out':
   drivers/scsi/wd7000.c:915:44: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
   any2scsi((unchar *) ogmbs[ogmb].scbptr, (int) scbptr);
   ^
   drivers/scsi/wd7000.c: In function 'wd7000_queuecommand_lck':
   drivers/scsi/wd7000.c:1117:26: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
  any2scsi(scb->dataptr, (int) sgb);
 ^
   drivers/scsi/wd7000.c:1121:4: warning: 'isa_page_to_bus' is deprecated 
[-Wdeprecated-declarations]
   any2scsi(sgb[i].ptr, isa_page_to_bus(sg_page(sg)) + sg->offset);
   ^
   In file included from include/linux/io.h:25:0,
from include/linux/irq.h:24,
from include/asm-generic/hardirq.h:12,
from arch/alpha/include/asm/hardirq.h:7,
from include/linux/hardirq.h:8,
from include/linux/interrupt.h:12,
from drivers/scsi/wd7000.c:170:
   arch/alpha/include/asm/io.h:95:39: note: declared here
static inline dma_addr_t __deprecated isa_page_to_bus(struct page *page)
  ^
   drivers/scsi/wd7000.c:1128:4: warning: 'isa_page_to_bus' is deprecated 
[-Wdeprecated-declarations]
   any2scsi(scb->dataptr, isa_page_to_bus(sg_page(sg)) + sg->offset);
   ^
   In file included from include/linux/io.h:25:0,
from include/linux/irq.h:24,
from include/asm-generic/hardirq.h:12,
from arch/alpha/include/asm/hardirq.h:7,
from include/linux/hardirq.h:8,
from include/linux/interrupt.h:12,
from drivers/scsi/wd7000.c:170:
   arch/alpha/include/asm/io.h:95:39: note: declared here
static inline dma_addr_t __deprecated isa_page_to_bus(struct page *page)
  ^
   drivers/scsi/wd7000.c: In function 'wd7000_diagnostics':
   drivers/scsi/wd7000.c:1151:20: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
 any2scsi(icb.ptr, (int) );
   ^
   drivers/scsi/wd7000.c: In function 'wd7000_adapter_reset':
   drivers/scsi/wd7000.c:1236:46: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
 any2scsi((unchar *) & (init_cmd.mailboxes), (int) &(host->mb));
 ^
   In file included from include/linux/kernel.h:13:0,
from include/linux/delay.h:10,
from drivers/scsi/wd7000.c:168:
   drivers/scsi/wd7000.c: In function 'wd7000_detect':
   drivers/scsi/wd7000.c:1482:59: warning: cast from pointer to integer of 
different size [-Wpointer-to-int-cast]
dprintk("wd7000_detect: adapter allocated at 0x%x\n", (int) host);
  ^
   include/linux/printk.h:114:17: note: in definition of macro 'no_printk'
  printk(fmt, ##__VA_ARGS__); \
^
>> drivers/scsi/wd7000.c:1482:5: note: in expansion of macro 'dprintk'
dprintk("wd7000_detect: adapter allocated at 0x%x\n", (int) host);
^

vim +/dprintk +1482 drivers/scsi/wd7000.c

^1da177e Linus Torvalds 2005-04-16  1466
dprintk("ok!\n");
^1da177e Linus Torvalds 2005-04-16  1467  
^1da177e Linus Torvalds 2005-04-16  1468if (inb(iobase 
+ ASC_INTR_STAT) == 1) {
^1da177e Linus Torvalds 2005-04-16  1469/*
^1da177e Linus Torvalds 2005-04-16  1470 *  We 
register here, to get a pointer to the extra space,
^1da177e Linus Torvalds 2005-04-16  1471 *  
which we'll use as the Adapter structure (host) for
^1da177e Linus Torvalds 2005-04-16  1472 *  
this adapter.  It is located just after the registered
^1da177e Linus Torvalds 2005-04-16  1473 *

Re: block: don't check request size in blk_cloned_rq_check_limits()

2016-06-16 Thread Mauricio Faria de Oliveira


Hey,

On 06/15/2016 01:34 PM, Brian King wrote:

Mauricio was looking at this, adding him to cc. We did have a KVM config
where we could reproduce this issue as well, I think with some PCI passthrough
adapters. Mauricio - do you have any more details about the KVM config that
reproduced this issue and did you ever try to reproduce this with an upstream
kernel?


It's KVM guest w/ SLES 12 SP1 + kernel updates (3.12.53-60.30 introduced
the error) and PCI passthrough of Emulex FC and FCoE adapters, connected
to 4 storage systems (DS8000, XIV, SVC, and FlashSystem 840).

It seems only the XIV LUNs never hit the problem, but it didn't seem to
be storage-specific, as FS840 LUNs had a mix of hit/not-hit the problem.
One thing is that all paths of a LUN were either failed or not - no mix
within a LUN.

Unfortunately not too much analysis was performed on this system at the
time -- Hannes had already made good progress w/ the customer, and some
test kernel builds that resolved the issue were made available soon.

Now that the topic is under discussion, I've asked for some time slots
on that system, so we can test an upstream kernel and try to reproduce
the problem and analyze it more closely.


--
Mauricio Faria de Oliveira
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] bfa: clean up some bounds checking

2016-06-16 Thread walter harms



Am 16.06.2016 12:44, schrieb Dan Carpenter:
> This code is supposed to search ->adapter_hwpath[] and replace the
> second colon with a NUL character.  Unfortunately, the boundary checks
> that ensure we don't go beyond the end of the buffer have a couple
> problems.
> 
> Imagine that the string has no colons.  In that case, in the first loop,
> we read one space beyond the end of the buffer and then exit the loop.
> In the next loop, we increment once, read two characters beyond the end
> of the buffer and then exit.  Then after the loop we put a NUL character
> two characters past the end of the buffer.
> 
> Signed-off-by: Dan Carpenter 
> ---
> This is from static analysis and not tested.  Caveat emptor.
> 
> diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
> index d1ad020..dfb26f0 100644
> --- a/drivers/scsi/bfa/bfad_bsg.c
> +++ b/drivers/scsi/bfa/bfad_bsg.c
> @@ -106,10 +106,17 @@ bfad_iocmd_ioc_get_info(struct bfad_s *bfad, void *cmd)
>  
>   /* set adapter hw path */
>   strcpy(iocmd->adapter_hwpath, bfad->pci_name);
> - for (i = 0; iocmd->adapter_hwpath[i] != ':' && i < BFA_STRING_32; i++)
> - ;
> - for (; iocmd->adapter_hwpath[++i] != ':' && i < BFA_STRING_32; )
> - ;
> + i = -1;
> + while (++i < BFA_STRING_32) {
> + if (iocmd->adapter_hwpath[i] == ':')
> + break;
> + }
> + while (++i < BFA_STRING_32) {
> + if (iocmd->adapter_hwpath[i] == ':')
> + break;
> + }
> + if (i >= BFA_STRING_32)
> + i = BFA_STRING_32 - 1;
>   iocmd->adapter_hwpath[i] = '\0';
>   iocmd->status = BFA_STATUS_OK;
>   return 0;


I do not see the use case but i assume
the idea is to have a string like aa:bb:something
and kill everyhing after the second ':' ?
/*
a few word may help here also inside the code
*/


second: maybe we can us strchr here ?
s1=strchr(iocmd->adapter_hwpath,':');
if (s1 != NULL ) s1=strchr(s1,":");



re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch] bfa: clean up some bounds checking

2016-06-16 Thread Dan Carpenter

This code is supposed to search ->adapter_hwpath[] and replace the
second colon with a NUL character.  Unfortunately, the boundary checks
that ensure we don't go beyond the end of the buffer have a couple
problems.

Imagine that the string has no colons.  In that case, in the first loop,
we read one space beyond the end of the buffer and then exit the loop.
In the next loop, we increment once, read two characters beyond the end
of the buffer and then exit.  Then after the loop we put a NUL character
two characters past the end of the buffer.

Signed-off-by: Dan Carpenter 
---
This is from static analysis and not tested.  Caveat emptor.

diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index d1ad020..dfb26f0 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.c
@@ -106,10 +106,17 @@ bfad_iocmd_ioc_get_info(struct bfad_s *bfad, void *cmd)
 
/* set adapter hw path */
strcpy(iocmd->adapter_hwpath, bfad->pci_name);
-   for (i = 0; iocmd->adapter_hwpath[i] != ':' && i < BFA_STRING_32; i++)
-   ;
-   for (; iocmd->adapter_hwpath[++i] != ':' && i < BFA_STRING_32; )
-   ;
+   i = -1;
+   while (++i < BFA_STRING_32) {
+   if (iocmd->adapter_hwpath[i] == ':')
+   break;
+   }
+   while (++i < BFA_STRING_32) {
+   if (iocmd->adapter_hwpath[i] == ':')
+   break;
+   }
+   if (i >= BFA_STRING_32)
+   i = BFA_STRING_32 - 1;
iocmd->adapter_hwpath[i] = '\0';
iocmd->status = BFA_STATUS_OK;
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] scsi: lpfc: avoid harmless comparison warning

2016-06-16 Thread Johannes Thumshirn

On Wed, Jun 15, 2016 at 10:42:17PM +0200, Arnd Bergmann wrote:
> When building with -Wextra, we get a lot of warnings for the lpfc driver
> concerning expressions that are always true, starting with:
> 
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init':
> drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned 
> expression >= 0 is always true [-Werror=type-limits]
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_rrq_init':
> drivers/scsi/lpfc/lpfc_attr.c:2802:76: error: comparison of unsigned 
> expression >= 0 is always true [-Werror=type-limits]
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_suppress_link_up_init':
> drivers/scsi/lpfc/lpfc_attr.c:2812:2050: error: comparison of unsigned 
> expression >= 0 is always true [-Werror=type-limits]
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_log_verbose_init':
> drivers/scsi/lpfc/lpfc_attr.c:3064:1930: error: comparison of unsigned 
> expression >= 0 is always true [-Werror=type-limits]
> 
> The code works as intented, but it would be nice to shut up the
> warning so we don't clutter up build logs with this. Using a
> separate inline function for it makes it clear to the compiler
> that the comparison is necessary in the caller but still lets
> it do the constant-folding.
> 
> Signed-off-by: Arnd Bergmann 

Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] libata:fix kernel panic when hotplug

2016-06-16 Thread kbuild test robot

Hi,

[auto build test WARNING on tj-libata/for-next]
[also build test WARNING on v4.7-rc3 next-20160616]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/DingXiang/libata-fix-kernel-panic-when-hotplug/20160616-105155
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata for-next
config: x86_64-randconfig-s5-06161418 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
from include/linux/kernel.h:6,
from drivers/ata/libata-eh.c:35:
   drivers/ata/libata-eh.c: In function 'ata_scsi_port_error_handler':
   drivers/ata/libata-eh.c:820:19: error: 'ATA_PFLAG_SAS_HOST' undeclared 
(first use in this function)
   !(ap->pflags & ATA_PFLAG_SAS_HOST))
  ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
 if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
 ^~~~
>> drivers/ata/libata-eh.c:819:7: note: in expansion of macro 'if'
 else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
  ^~
   drivers/ata/libata-eh.c:820:19: note: each undeclared identifier is reported 
only once for each function it appears in
   !(ap->pflags & ATA_PFLAG_SAS_HOST))
  ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
 if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
 ^~~~
>> drivers/ata/libata-eh.c:819:7: note: in expansion of macro 'if'
 else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
  ^~

vim +/if +819 drivers/ata/libata-eh.c

   803  ap->ops->end_eh(ap);
   804  
   805  spin_unlock_irqrestore(ap->lock, flags);
   806  ata_eh_release(ap);
   807  } else {
   808  WARN_ON(ata_qc_from_tag(ap, ap->link.active_tag) == 
NULL);
   809  ap->ops->eng_timeout(ap);
   810  }
   811  
   812  scsi_eh_flush_done_q(>eh_done_q);
   813  
   814  /* clean up */
   815  spin_lock_irqsave(ap->lock, flags);
   816  
   817  if (ap->pflags & ATA_PFLAG_LOADING)
   818  ap->pflags &= ~ATA_PFLAG_LOADING;
 > 819  else if ((ap->pflags & ATA_PFLAG_SCSI_HOTPLUG) &&
   820   !(ap->pflags & ATA_PFLAG_SAS_HOST))
   821  schedule_delayed_work(>hotplug_task, 0);
   822  
   823  if (ap->pflags & ATA_PFLAG_RECOVERED)
   824  ata_port_info(ap, "EH complete\n");
   825  
   826  ap->pflags &= ~(ATA_PFLAG_SCSI_HOTPLUG | ATA_PFLAG_RECOVERED);
   827  

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH 2/3] cxlflash: Add device dependent flags

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

[PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

[PATCH V3 0/2] initial submit of Microsemi smarpqi driver

[PATCH V3 2/2] aacraid: remove wildcard for series 9 controllers

Re: [PATCH v6] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

RE: [PATCH V2 0/2] initial submit of Microsemi smartpqi driver

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

I'm a banker and i have a business that will benefit us

Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

Re: block: don't check request size in blk_cloned_rq_check_limits()

Re: [patch] bfa: clean up some bounds checking

[patch] bfa: clean up some bounds checking

Re: [PATCH 1/2] scsi: lpfc: avoid harmless comparison warning

Re: [PATCH V2] libata:fix kernel panic when hotplug

22 matches

Site Navigation

Mail list logo

Footer information