Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

[Martin K. Petersen]

> "James" == James Bottomley  writes:

James> Now that I look at the reviews, each of the reviewers said what
James> the correct thing to do was: return SAM_STAT_BUSY if SATL
James> commands are outstanding like the spec says.  You all get
James> negative brownie points for not insisting on a rework.

James> Does this patch (compile tested only) fix the problems for
James> everyone?

I also like this approach better.

Broadcom folks: Please comment and test.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: Reinstate lpfc_soft_wwn parameter

[Martin K. Petersen]

> "James" == James Smart  writes:

James> The lpfc 11.2.0.4 patch set deprecated, by removing, the
James> lpfc_soft_wwn parameter support.

James> This patch reinstates support, but adds a warning in the
James> enablement of the feature that indicates Broadcom (Emulex) does
James> not support the feature.

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

[Martin K. Petersen]

> "ojab" == ojab   writes:

ojab> MPI2 controllers sometimes got lost (i. e. disappears from
ojab> /sys/bus/pci/devices) if ASMP is enabled.

Broadcom folks: Please comment!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

[Martin K. Petersen]

> "Dave" == Dave Jones  writes:

Dave> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two
Dave> bodies of code that look similar but with s/req/rsp/ in the second
Dave> instance.  But in one case, it looks like this conversion was
Dave> missed.

Quinn?

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

[Martin K. Petersen]

> "Nicolas" == Nicolas Iooss  writes:

Nicolas> qla24xx_enable_msix() calls scnprintf() with a non-literal
Nicolas> format string. This makes clang report -Wformat-security
Nicolas> warnings when compiling this function:

Himanshu: Please review these two patches!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] scsi: bfa: Increase requested firmware version to 3.2.5.1

[Martin K. Petersen]

> "Benjamin" == Benjamin Poirier  writes:

Benjamin> bna & bfa firmware version 3.2.5.1 was submitted to
Benjamin> linux-firmware on Feb 17 19:10:20 2015 -0500 in 0ab54ff1dc
Benjamin> ("linux-firmware: Add QLogic BR Series Adapter Firmware").

Benjamin> Increase bfa's requested firmware version. Also increase the
Benjamin> driver version.  I only tested that all of the devices probe
Benjamin> without error.

Applied to 4.10/scsi-fixes.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] qla2xxx: Get mutex lock before checking optrom_state

[Martin K. Petersen]

> "Milan" == Milan P Gandhi  writes:

Milan> Hello, There is a race condition with qla2xxx optrom functions
Milan> where one thread might modify optrom buffer, optrom_state while
Milan> other thread is still reading from it.

Chad?

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] snic: Return error code on memory allocation failure

[Martin K. Petersen]

> "Burak" == Burak Ok  writes:

Burak> If a call to mempool_create_slab_pool() in snic_probe() returns
Burak> NULL, return -ENOMEM to indicate
Burak> failure. mempool_creat_slab_pool() only fails if it cannot
Burak> allocate memory.

Applied to 4.10/scsi-fixes.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2] mpt3sas: switch to pci_alloc_irq_vectors

[Martin K. Petersen]

> "Hannes" == Hannes Reinecke  writes:

Hannes> Cleanup the MSI-X handling allowing us to use the PCI-layer
Hannes> provided vector allocation.

Sreekanth, Sathya: Please review!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] scsi:fnic Avoid sending reset to fnic firmware when another reset is already in progress

[Martin K. Petersen]

> "Satish" == Satish Kharat  writes:

Satish,

Satish> This fix is to avoid calling fnic_fw_reset_handler through
Satish> fnic_host_reset when a finc reset is alreay in progress.

Applied to 4.10/scsi-fixes.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] hisi_sas: some CQ processing fixes

[Martin K. Petersen]

> "John" == John Garry  writes:

John> This patchset fixes some issues related to servicing of the
John> completion queue interrupt.  The major fix is that sensitive
John> hisi_hba structures need to be locked when free'ing a slot.
John> Another modification is that the v2 hw completion queue irq is now
John> serviced with a tasklet, as too much work was being done in the
John> ISR.

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: ufs-qcom: Fix module autoload

[Martin K. Petersen]

> "Javier" == Javier Martinez Canillas  writes:

Javier> If the driver is built as a module, autoload won't work because
Javier> the module alias information is not filled. So user-space can't
Javier> match the registered device with the corresponding module.

Javier> Export the module alias information using the
Javier> MODULE_DEVICE_TABLE() macro.

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 00/12] scsi: ufs: add trace/debug support, sysfs controls and few fixes

[Martin K. Petersen]

> "Subhash" == Subhash Jadavani  writes:

Subhash> This patch series adds following things:
Subhash>  - ftrace support to trace important events in UFS driver.
Subhash>  - debug dumps following failures to ease the debugging
Subhash>  - sysfs node to control clock gating, clock scaling and PM
Subhash>  - few fixes

Applied to 4.11/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Linux Foundation's open source file & storage conference CFP

[Ric Wheeler]

Hi all,

The CFP for the Linux Foundation's Vault conference is coming close to an end. 
The event is being held this year in Cambridge, Massachusetts on the days 
following the LSF/MM summit.


The first two year's events have been solid, focused events in my (slightly 
biased) opinion, so worth submitting to and definitely worth attending.


Submit a Proposal to Speak at Vault, Linux Storage and Filesystems Conference. 
Vault will be held alongside LSF-MM Summit on March 22 & 23 in Cambridge, MA. To 
submit (by 1/14) visit http://events.linuxfoundation.org/events/vault/program/cfp


Happy to answer any questions about the event.

Ric

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=176951

--- Comment #16 from mus@gmail.com ---
Created attachment 250411
  --> https://bugzilla.kernel.org/attachment.cgi?id=250411=edit
dmesg with ACPI errors (kernel 4.10rc2)

Bisecting this is really frustrating because it randomly works in different
combinations, depending on whether UEFI or Legacy boot is enabled in BIOS and
whether you boot via USB or SSD and sometimes pure chance...

The good(?) news is: kernel 4.10rc2 boots in almost all circumstances. But the
only combination that is actually stable is the same one that already works
with 4.8 and 4.9: booting with legacy mode enabled from the internal SSD.

When I boot 4.10rc2 with UEFI mode enabled in BIOS or via USB, the system
doesn't hang like with previous kernels. Instead I get quite a few ACPI errors
and the system manages to boot completely most of the time, but freezes
completely after a few seconds.

The full dmesg is attached. This is with UEFI mode enabled in BIOS and booting
4.10rc2 from the internal SSD. Hopefully the ACPI warnings and errors help
narrow this down...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SAS disk from RAID card (no RAID mode) problems

[Emmanuel Florac]

Le Tue, 27 Dec 2016 09:01:34 +0100
IW News  écrivait:

> Hi,
> 
> So there is no support for the mvsas driver?
> 
> The controller is integrated in the motherboard. I could by a PCIe one
> but, what's the deal them?

You didn't even say what's the SSD drive model. Maybe the drive is
faulty? The cabling?

-- 

Emmanuel Florac |   Direction technique
|   Intellique
|   
|   +33 1 78 94 84 02



pgp7MUQlTXPi7.pgp
Description: Signature digitale OpenPGP

RE: [PATCH] mpt3sas: Force request partial completion alignment

[Sathya Prakash Veerichetty]

Sreekanth,
Let us discuss internally more about this before ACKING this patch.

Thanks
Sathya

-Original Message-
From: Sreekanth Reddy [mailto:sreekanth.re...@broadcom.com]
Sent: Wednesday, January 04, 2017 4:33 AM
To: Guilherme G. Piccoli
Cc: linux-scsi@vger.kernel.org; PDL-MPT-FUSIONLINUX; Sathya Prakash; Chaitra
Basappa; Suganath Prabu Subramani; Brian King; mauri...@linux.vnet.ibm.com;
linux...@us.ibm.com
Subject: Re: [PATCH] mpt3sas: Force request partial completion alignment

Hi Guilherme,

Can please share us the driver logs (with driver logging_level set to
0x3f8) for the original issue (i.e. without this patch changes) and the HBA
firmware version you have used.

Also can you please share us the steps you have followed to reproduce this
issue, so that I can try on my setup.

Thanks,
Sreekanth

On Wed, Dec 28, 2016 at 6:21 PM, Guilherme G. Piccoli
 wrote:
> From: Ram Pai 
>
> The firmware or device, possibly under a heavy I/O load, can return on
> a partial unaligned boundary. Scsi-ml expects these requests to be
> completed on an alignment boundary. Scsi-ml blindly requeues the I/O
> without checking the alignment boundary of the I/O request for the
> remaining bytes. This leads to errors, since devices cannot perform
> non-aligned read/write operations.
>
> This patch fixes the issue in the driver. It aligns unaligned
> completions of FS requests, by truncating them to the nearest
> alignment boundary.
>
> Reported-by: Mauricio Faria De Oliveira 
> Signed-off-by: Guilherme G. Piccoli 
> Signed-off-by: Ram Pai 
> ---
>  drivers/scsi/mpt3sas/mpt3sas_scsih.c | 16 
>  1 file changed, 16 insertions(+)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index b5c966e..55332a3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -4644,6 +4644,8 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16
> smid, u8 msix_index, u32 reply)
> struct MPT3SAS_DEVICE *sas_device_priv_data;
> u32 response_code = 0;
> unsigned long flags;
> +   unsigned int sector_sz;
> +   struct request *req;
>
> mpi_reply = mpt3sas_base_get_reply_virt_addr(ioc, reply);
> scmd = _scsih_scsi_lookup_get_clear(ioc, smid); @@ -4703,6
> +4705,20 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8
> msix_index, u32 reply)
> }
>
> xfer_cnt = le32_to_cpu(mpi_reply->TransferCount);
> +
> +   /* In case of bogus fw or device, we could end up having
> +* unaligned partial completion. We can force alignment here,
> +* then scsi-ml does not need to handle this misbehavior.
> +*/
> +   sector_sz = scmd->device->sector_size;
> +   req = scmd->request;
> +   if (unlikely(sector_sz && req && (req->cmd_type == REQ_TYPE_FS) &&
> +   (xfer_cnt % sector_sz))) {
> +   sdev_printk(KERN_INFO, scmd->device,
> +   "unaligned partial completion avoided\n");
> +   xfer_cnt = (xfer_cnt / sector_sz) * sector_sz;
> +   }
> +
> scsi_set_resid(scmd, scsi_bufflen(scmd) - xfer_cnt);
> if (ioc_status & MPI2_IOCSTATUS_FLAG_LOG_INFO_AVAILABLE)
> log_info =  le32_to_cpu(mpi_reply->IOCLogInfo);
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html