Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails with following error

drivers/scsi/aha152x.o: In function `aha152x_host_reset_host':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple 
definition of `aha152x_host_reset_host'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324:
 first defined here
drivers/scsi/aha152x.o: In function `aha152x_release':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: multiple 
definition of `aha152x_release'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908:
 first defined here
ld: Warning: size of symbol `aha152x_release' changed from 68 in 
drivers/scsi/pcmcia/built-in.o to 100 in drivers/scsi/aha152x.o
drivers/scsi/aha152x.o: In function `aha152x_probe_one':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:772: multiple 
definition of `aha152x_probe_one'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:772:
 first defined here
drivers/scsi/fdomain.o:(.data+0x0): multiple definition of 
`fdomain_driver_template'
drivers/scsi/pcmcia/built-in.o:(.data+0x5a0): first defined here
drivers/scsi/fdomain.o: In function `fdomain_16x0_bus_reset':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: multiple 
definition of `fdomain_16x0_bus_reset'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568:
 first defined here
drivers/scsi/fdomain.o: In function `__fdomain_16x0_detect':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: multiple 
definition of `__fdomain_16x0_detect'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894:
 first defined here
ld: Warning: size of symbol `__fdomain_16x0_detect' changed from 1206 in 
drivers/scsi/pcmcia/built-in.o to 1700 in drivers/scsi/fdomain.o
drivers/scsi/fdomain.o: In function `fdomain_setup':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: multiple 
definition of `fdomain_setup'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554:
 first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2


-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] aha152x: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
 *info = link-priv;
 
 - aha152x_release(info-host);
 + GLOBAL(aha152x_release)(info-host);
   pcmcia_disable_device(link);
  }
 
 @@ -224,7 +226,7 @@ static int aha152x_resume(struct pcmcia_device *link)
  {
   scsi_info_t *info = link-priv;
 
 - aha152x_host_reset_host(info-host);
 + GLOBAL(aha152x_host_reset_host)(info-host);
 
   return 0;
  }
 diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
 --
Hi Tejun Heo,

Thanks, I have tested the patch fixes the build failure on aha152x.c.
Tested-By: Kamalesh Babulal [EMAIL PROTECTED]

Thanks  Regards,
Kamalesh Babulal.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.24-rc8-mm1 Build Failure on scsi driver

2008-01-17 Thread Kamalesh Babulal
Andrew Morton wrote:
 On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote:
 
 Hi Andrew,

 The kernel build fails with following error

 drivers/scsi/aha152x.o: In function `aha152x_host_reset_host':
 /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324: multiple 
 definition of `aha152x_host_reset_host'
 drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:1324:
  first defined here
 drivers/scsi/aha152x.o: In function `aha152x_release':
 /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908: multiple 
 definition of `aha152x_release'
 drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x.c:908:
  first defined here
 ld: Warning: size of symbol `aha152x_release' changed from 68 in 
 drivers/scsi/pcmcia/built-in.o to 100 in drivers/scsi/aha152x.o
 drivers/scsi/aha152x.o: In function `aha152x_probe_one':
 
 Neat.  Seems that the scsi build system is linking together two copies of
 drivers/scsi/aha152x.o.  One via drivers/scsi/aha152x.o directly and the
 other via drivers/scsi/pcmcia/built-in.o.
 
 Please send the .config.
 
 I'm looking suspiciously at this, from git-scsi-misc:
 
 commit 8ae732a91df051aba6820068a47b631a06599d84
 Author: Tejun Heo [EMAIL PROTECTED]
 Date:   Fri Dec 7 22:36:23 2007 +0900
 
 [SCSI] make pcmcia directory use obj-y|m instead of subdir-y|m
 
 subdir-y|m isn't supposed to contain modules or built-in components.
 Change subdir-$(CONFIG_PCMCIA) to obj-$(CONFIG_PCMCIA).
 
 Signed-off-by: Tejun Heo [EMAIL PROTECTED]
 Acked-by: Sam Ravnborg [EMAIL PROTECTED]
 Signed-off-by: James Bottomley [EMAIL PROTECTED]
 
 diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
 index b5441f5..93e1428 100644
 --- a/drivers/scsi/Makefile
 +++ b/drivers/scsi/Makefile
 @@ -17,7 +17,7 @@
  CFLAGS_aha152x.o =   -DAHA152X_STAT -DAUTOCONF
  CFLAGS_gdth.o= # -DDEBUG_GDTH=2 -D__SERIAL__ -D__COM2__ -DGDTH_STATISTICS
 
 -subdir-$(CONFIG_PCMCIA)  += pcmcia
 +obj-$(CONFIG_PCMCIA) += pcmcia/
 
  obj-$(CONFIG_SCSI)   += scsi_mod.o
  obj-$(CONFIG_SCSI_TGT)   += scsi_tgt.o

Hi Andrew,

Patch from Tejun Heo fixes the aha152x.c build failure, and following second 
part
of the build failure, is still occurring.

drivers/scsi/fdomain.o:(.data+0x0): multiple definition of 
`fdomain_driver_template'
drivers/scsi/pcmcia/built-in.o:(.data+0x5a0): first defined here
drivers/scsi/fdomain.o: In function `fdomain_16x0_bus_reset':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568: multiple 
definition of `fdomain_16x0_bus_reset'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:1568:
 first defined here
drivers/scsi/fdomain.o: In function `__fdomain_16x0_detect':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894: multiple 
definition of `__fdomain_16x0_detect'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:894:
 first defined here
ld: Warning: size of symbol `__fdomain_16x0_detect' changed from 1206 in 
drivers/scsi/pcmcia/built-in.o to 1700 in drivers/scsi/fdomain.o
drivers/scsi/fdomain.o: In function `fdomain_setup':
/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554: multiple 
definition of `fdomain_setup'
drivers/scsi/pcmcia/built-in.o:/home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/fdomain.c:554:
 first defined here
make[2]: *** [drivers/scsi/built-in.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote:
 aha152x.c and fdomain are built twice - once for the isa driver and
 once for the PCMCIA one.  Through #ifdefs, the compiled codes are
 slightly different; thus, global symbols need to be given different
 names depending on which flavor is being built.  This patch adds
 GLOBAL() macro to aha152x.h and fdomain.h which change the symbol
 depending on PCMCIA.
 
 This bug has always existed but has been masked by the fact the
 drivers/scsi/pcmcia used subdir-(y|m) instead of obj-(y|m) which made
 drivers/scsi/pcmcia/built_in.o not linked into the kernel and thus
 avoided the duplicate symbols during compilation.
 
Hi Tejun Heo,

Thanks, I have tested the patch, it fixes both build failures.

Tested-by: Kamalesh Babulal [EMAIL PROTECTED]
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
Ah... missed that one.  Here's the updated version.

 drivers/scsi/aha152x.c |   12 ++--
 drivers/scsi/aha152x.h |   20 +---
 drivers/scsi/fdomain.c |   20 ++--
 drivers/scsi/fdomain.h |   21 +
 drivers/scsi/pcmcia/aha152x_stub.c |   10 ++
 drivers/scsi/pcmcia/fdomain_stub.c |   10 ++
 6 files changed, 62 insertions(+), 31 deletions(-)

diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index ea8c699..0204f44 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -769,7 +769,7 @@ static irqreturn_t swintr(int irqno, void *dev_id)
return IRQ_HANDLED;
 }

-struct Scsi_Host *aha152x_probe_one(struct aha152x_setup *setup)
+struct Scsi_Host *GLOBAL(aha152x_probe_one)(struct aha152x_setup *setup)
 {
struct Scsi_Host *shpnt;

@@ -905,7 +905,7 @@ out_host_put:
return NULL;
 }

-void aha152x_release(struct Scsi_Host *shpnt)
+void GLOBAL(aha152x_release)(struct Scsi_Host *shpnt)
 {
if (!shpnt)
return;
@@ -1327,7 +1327,7 @@ static void reset_ports(struct Scsi_Host *shpnt)
  * Reset the host (bus and controller)
  *
  */
-int aha152x_host_reset_host(struct Scsi_Host *shpnt)
+int GLOBAL(aha152x_host_reset_host)(struct Scsi_Host *shpnt)
 {
DPRINTK(debug_eh, KERN_DEBUG scsi%d: host reset\n, shpnt-host_no);

@@ -1345,7 +1345,7 @@ int aha152x_host_reset_host(struct Scsi_Host *shpnt)
  */
 static int aha152x_host_reset(Scsi_Cmnd *SCpnt)
 {
-   return aha152x_host_reset_host(SCpnt-device-host);
+   return GLOBAL(aha152x_host_reset_host)(SCpnt-device-host);
 }

 /*
@@ -3916,7 +3916,7 @@ static int __init aha152x_init(void)

for (i=0; isetup_count; i++) {
if ( request_region(setup[i].io_port, IO_RANGE, aha152x) ) {
-   struct Scsi_Host *shpnt = aha152x_probe_one(setup[i]);
+   struct Scsi_Host *shpnt = 
GLOBAL(aha152x_probe_one)(setup[i]);

if( !shpnt ) {
release_region(setup[i].io_port, IO_RANGE);
@@ -3946,7 +3946,7 @@ static void __exit aha152x_exit(void)
list_for_each_entry(hd, aha152x_host_list, host_list) {
struct Scsi_Host *shost = container_of((void *)hd, struct 
Scsi_Host, hostdata);

-   aha152x_release(shost);
+   GLOBAL(aha152x_release)(shost);
}
 }

diff --git a/drivers/scsi/aha152x.h b/drivers/scsi/aha152x.h
index ac4bfa4..f441e54 100644
--- a/drivers/scsi/aha152x.h
+++ b/drivers/scsi/aha152x.h
@@ -330,8 +330,22 @@ struct aha152x_setup {
char *conf;
 };

-struct Scsi_Host *aha152x_probe_one(struct aha152x_setup *);
-void aha152x_release(struct Scsi_Host *);
-int aha152x_host_reset_host(struct Scsi_Host *);
+/*
+ * This file and aha152x.c are compiled in two different ways - for
+ * the isa driver and pcmcia one.  When building the pcmcia one, the
+ * file is slightly modified, so they can't share the same object
+ * file.  The following macro alters a symbol depending on whether
+ * pcmcia driver is being built or not and should be used for any
+ * global symbol.
+ */
+#if defined(PCMCIA)
+#define GLOBAL(x)  CS_##x
+#else
+#define GLOBAL(x)  ISA_##x
+#endif
+
+struct Scsi_Host *GLOBAL(aha152x_probe_one)(struct aha152x_setup *);
+void GLOBAL(aha152x_release)(struct Scsi_Host *);
+int GLOBAL(aha152x_host_reset_host)(struct Scsi_Host *);

 #endif /* _AHA152X_H */
diff --git a/drivers/scsi/fdomain.c b/drivers/scsi/fdomain.c
index 2cd6b49..e14c59b 100644
--- a/drivers/scsi/fdomain.c
+++ b/drivers/scsi/fdomain.c
@@ -550,7 +550,7 @@ static void print_banner( struct Scsi_Host *shpnt )
printk( \n );
 }

-int fdomain_setup(char *str)
+int GLOBAL(fdomain_setup)(char *str)
 {
int ints[4];

@@ -571,7 +571,7 @@ int fdomain_setup(char *str)
return 1;
 }

-__setup(fdomain=, fdomain_setup);
+__setup(fdomain=, GLOBAL(fdomain_setup));


 static void do_pause(unsigned amount)  /* Pause for amount*10 milliseconds */
@@ -890,7 +890,7 @@ fail:

 #endif

-struct Scsi_Host

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-12-04 Thread Kamalesh Babulal
Ingo Molnar wrote:
 * Kamalesh Babulal [EMAIL PROTECTED] wrote:
 
 So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not?
 Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4.
 
 just to make sure: this is a real lockup and failed bootup (or device 
 init), not just a message, right?
 
   Ingo
 --

Hi Ingo,

This softlockup is seen in the 2.6.24-rc4 either and looks like a message 
because 
this is seen while running tbench and machine continues running other test's 
after 
the softlockup messages and some times seen with the bootup, but the machines 
reaches the 
login prompt and able to continue running tests.

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-11-29 Thread Kamalesh Babulal
Andrew Morton wrote:
 On Thu, 29 Nov 2007 12:01:08 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote:
 
 Andrew Morton wrote:
 On Wed, 28 Nov 2007 12:47:19 +0530 Kamalesh Babulal [EMAIL PROTECTED] 
 wrote:

 Andrew Morton wrote:
 On Wed, 28 Nov 2007 11:59:00 +0530 Kamalesh Babulal [EMAIL PROTECTED] 
 wrote:

 Hi,
 (cc linux-scsi, for sym53c8xx)

 Soft lockup is detected while bootup with 2.6.24-rc3-git2 on powerbox
 I assume this is a post-2.6.23 regression?

 BUG: soft lockup - CPU#1 stuck for 11s! [insmod:375]
 NIP: c002f02c LR: d01414fc CTR: c002f018
 REGS: c0077cbef0b0 TRAP: 0901   Not tainted  
 (2.6.24-rc3-git2-autotest)
 MSR: 80009032 EE,ME,IR,DR  CR: 24022088  XER: 
 TASK = c0077cbd8000[375] 'insmod' THREAD: c0077cbec000 CPU: 1
 GPR00: d01414fc c0077cbef330 c052b930 
 d80080002014 
 GPR04: d8008000202c  c0077ca1cb00 
 d014ce54 
 GPR08: c0077ca1c63c  002a 
 c002f018 
 GPR12: d0143610 c0473d00 
 NIP [c002f02c] .ioread8+0x14/0x60
 LR [d01414fc] .sym_hcb_attach+0x1188/0x1378 [sym53c8xx]
 Call Trace:
 [c0077cbef330] [c0077cbef3c0] 0xc0077cbef3c0 (unreliable)
 [c0077cbef3a0] [d01414fc] .sym_hcb_attach+0x1188/0x1378 
 [sym53c8xx]
 [c0077cbef470] [d01395f8] .sym2_probe+0x700/0x99c [sym53c8xx]
 [c0077cbef710] [c01bc118] .pci_device_probe+0x124/0x1b0
 [c0077cbef7b0] [c0221138] .driver_probe_device+0x144/0x20c
 [c0077cbef850] [c0221450] .__driver_attach+0xcc/0x154
 [c0077cbef8e0] [c021ff94] .bus_for_each_dev+0x7c/0xd4
 [c0077cbef9a0] [c0220e9c] .driver_attach+0x28/0x40
 [c0077cbefa20] [c02204d8] .bus_add_driver+0x90/0x228
 [c0077cbefac0] [c0221858] .driver_register+0x94/0xb0
 [c0077cbefb40] [c01bc430] .__pci_register_driver+0x6c/0xcc
 [c0077cbefbe0] [d0143428] .sym2_init+0x108/0x15b0 [sym53c8xx]
 [c0077cbefc80] [c008ce80] .sys_init_module+0x17c4/0x1958
 [c0077cbefe30] [c000872c] syscall_exit+0x0/0x40
 Instruction dump:
 6000 786b0420 38210070 7d635b78 e8010010 7c0803a6 4e800020 7c0802a6 
 f8010010 f821ff91 7c0004ac 8923 0c09 4c00012c 79290620 
 2f8900ff 
 I see no obvious lockup sites near the end of sym_hcb_attach().  Maybe 
 it's
 being called lots of times from a higher level..  Do the traces all look
 the same?
 Hi Andrew,

 I see this call trace twice and both looks similar and on another reboot
 the following trace is seen twice in different cpu

 BUG: soft lockup detected on CPU#3!
 Call Trace:
 [C0003FEDEDA0] [C0010220] .show_stack+0x68/0x1b0 (unreliable)
 [C0003FEDEE40] [C00A061C] .softlockup_tick+0xf0/0x13c
 [C0003FEDEEF0] [C0072E2C] .run_local_timers+0x1c/0x30
 [C0003FEDEF70] [C0022FA0] .timer_interrupt+0xa8/0x488
 [C0003FEDF050] [C00034EC] decrementer_common+0xec/0x100
 --- Exception: 901 at .ioread8+0x14/0x60
 LR = .sym_hcb_attach+0x1194/0x1384 [sym53c8xx]
 [C0003FEDF340] [D02B3BC0] 0xd02b3bc0 (unreliable)
 [C0003FEDF3B0] [D029A3C0] .sym_hcb_attach+0x1194/0x1384 
 [sym53c8xx]
 [C0003FEDF480] [D0291D30] .sym2_probe+0x75c/0x9f8 [sym53c8xx]
 [C0003FEDF710] [C01B65A4] .pci_device_probe+0x13c/0x1dc
 [C0003FEDF7D0] [C0219A0C] .driver_probe_device+0xa0/0x15c
 [C0003FEDF870] [C0219C64] .__driver_attach+0xb4/0x138
 [C0003FEDF900] [C021913C] .bus_for_each_dev+0x7c/0xd4
 [C0003FEDF9C0] [C02198B0] .driver_attach+0x28/0x40
 [C0003FEDFA40] [C0218BA4] .bus_add_driver+0x98/0x18c
 [C0003FEDFAE0] [C021A064] .driver_register+0xa8/0xc4
 [C0003FEDFB60] [C01B68AC] .__pci_register_driver+0x5c/0xa4
 [C0003FEDFBF0] [D029C204] .sym2_init+0x104/0x1550 [sym53c8xx]
 [C0003FEDFC90] [C008D1F4] .sys_init_module+0x1764/0x1998
 [C0003FEDFE30] [C000869C] syscall_exit+0x0/0x40

 hm, odd.

 Can you look up sym_hcb_attach+0x1194/0x1384 in gdb?  Something like

 Hi Andrew,

 I tried with 2.6.24-rc3-git3 and got the following trace

 BUG: soft lockup - CPU#2 stuck for 11s! [insmod:375]
 NIP: c002f02c LR: d01414fc CTR: c002f018
 REGS: c0077ca3b0b0 TRAP: 0901   Not tainted  (2.6.24-rc3-git3-autokern1)
 MSR: 80009032 EE,ME,IR,DR  CR: 24022088  XER: 
 TASK = c0077cc58000[375] 'insmod' THREAD: c0077ca38000 CPU: 2
 GPR00: d01414fc c0077ca3b330 c052b880 d80080002014 
 GPR04: d8008000202c  c0077c82eb00 d014ce54 
 GPR08: c0077c82e63c  002a c002f018 
 GPR12: d0143610 c0473f80 
 NIP [c002f02c] .ioread8+0x14/0x60
 LR [d01414fc] .sym_hcb_attach+0x1188/0x1378 [sym53c8xx]

 Call Trace

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-11-29 Thread Kamalesh Babulal
Andrew Morton wrote:
 On Thu, 29 Nov 2007 23:00:47 -0800 Andrew Morton [EMAIL PROTECTED] wrote:
 
 On Fri, 30 Nov 2007 01:39:29 -0500 Kyle McMartin [EMAIL PROTECTED] wrote:

 On Thu, Nov 29, 2007 at 12:35:33AM -0800, Andrew Morton wrote:
 ten million is close enough to infinity for me to assume that we broke the
 driver and that's never going to terminate.

 how about this? doesn't break things on my pa8800:

 diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.c 
 b/drivers/scsi/sym53c8xx_2/sym_hipd.c
 index 463f119..ef01cb1 100644
 --- a/drivers/scsi/sym53c8xx_2/sym_hipd.c
 +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.c
 @@ -1037,10 +1037,13 @@ restart_test:
 /*
  *  Wait 'til done (with timeout)
  */
 -   for (i=0; iSYM_SNOOP_TIMEOUT; i++)
 +   do {
 if (INB(np, nc_istat)  (INTF|SIP|DIP))
 break;
 -   if (i=SYM_SNOOP_TIMEOUT) {
 +   msleep(10);
 +   } while (i++  SYM_SNOOP_TIMEOUT);
 +
 +   if (i = SYM_SNOOP_TIMEOUT) {
 printf (CACHE TEST FAILED: timeout.\n);
 return (0x20);
 }
 diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.h 
 b/drivers/scsi/sym53c8xx_2/sym_hipd.h
 index ad07880..85c483b 100644
 --- a/drivers/scsi/sym53c8xx_2/sym_hipd.h
 +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.h
 @@ -339,7 +339,7 @@
  /*
   *  Misc.
   */
 -#define SYM_SNOOP_TIMEOUT (1000)
 +#define SYM_SNOOP_TIMEOUT (1000)
  #define BUS_8_BIT  0
  #define BUS_16_BIT 1
  
 That might be the fix, but do we know what we're actually fixing?  afaik
 2.6.24-rc3 doesn't get this timeout, 2.6.24-rc3-mm2 does get it and we
 don't know why?

 
 looks at Subject:
 
 Checks that Rafael was cc'ed
 
 So 2.6.24-rc3 was OK and 2.6.24-rc3-git2 is not?

Yes, the 2.6.24-rc3 was Ok and this is seen from 2.6.24-rc3-git2/3/4.

-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-11-28 Thread Kamalesh Babulal
Andrew Morton wrote:
 On Wed, 28 Nov 2007 12:47:19 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote:
 
 Andrew Morton wrote:
 On Wed, 28 Nov 2007 11:59:00 +0530 Kamalesh Babulal [EMAIL PROTECTED] 
 wrote:

 Hi,
 (cc linux-scsi, for sym53c8xx)

 Soft lockup is detected while bootup with 2.6.24-rc3-git2 on powerbox
 I assume this is a post-2.6.23 regression?

 BUG: soft lockup - CPU#1 stuck for 11s! [insmod:375]
 NIP: c002f02c LR: d01414fc CTR: c002f018
 REGS: c0077cbef0b0 TRAP: 0901   Not tainted  (2.6.24-rc3-git2-autotest)
 MSR: 80009032 EE,ME,IR,DR  CR: 24022088  XER: 
 TASK = c0077cbd8000[375] 'insmod' THREAD: c0077cbec000 CPU: 1
 GPR00: d01414fc c0077cbef330 c052b930 d80080002014 
 GPR04: d8008000202c  c0077ca1cb00 d014ce54 
 GPR08: c0077ca1c63c  002a c002f018 
 GPR12: d0143610 c0473d00 
 NIP [c002f02c] .ioread8+0x14/0x60
 LR [d01414fc] .sym_hcb_attach+0x1188/0x1378 [sym53c8xx]
 Call Trace:
 [c0077cbef330] [c0077cbef3c0] 0xc0077cbef3c0 (unreliable)
 [c0077cbef3a0] [d01414fc] .sym_hcb_attach+0x1188/0x1378 
 [sym53c8xx]
 [c0077cbef470] [d01395f8] .sym2_probe+0x700/0x99c [sym53c8xx]
 [c0077cbef710] [c01bc118] .pci_device_probe+0x124/0x1b0
 [c0077cbef7b0] [c0221138] .driver_probe_device+0x144/0x20c
 [c0077cbef850] [c0221450] .__driver_attach+0xcc/0x154
 [c0077cbef8e0] [c021ff94] .bus_for_each_dev+0x7c/0xd4
 [c0077cbef9a0] [c0220e9c] .driver_attach+0x28/0x40
 [c0077cbefa20] [c02204d8] .bus_add_driver+0x90/0x228
 [c0077cbefac0] [c0221858] .driver_register+0x94/0xb0
 [c0077cbefb40] [c01bc430] .__pci_register_driver+0x6c/0xcc
 [c0077cbefbe0] [d0143428] .sym2_init+0x108/0x15b0 [sym53c8xx]
 [c0077cbefc80] [c008ce80] .sys_init_module+0x17c4/0x1958
 [c0077cbefe30] [c000872c] syscall_exit+0x0/0x40
 Instruction dump:
 6000 786b0420 38210070 7d635b78 e8010010 7c0803a6 4e800020 7c0802a6 
 f8010010 f821ff91 7c0004ac 8923 0c09 4c00012c 79290620 2f8900ff 
 I see no obvious lockup sites near the end of sym_hcb_attach().  Maybe it's
 being called lots of times from a higher level..  Do the traces all look
 the same?
 Hi Andrew,

 I see this call trace twice and both looks similar and on another reboot
 the following trace is seen twice in different cpu

 BUG: soft lockup detected on CPU#3!
 Call Trace:
 [C0003FEDEDA0] [C0010220] .show_stack+0x68/0x1b0 (unreliable)
 [C0003FEDEE40] [C00A061C] .softlockup_tick+0xf0/0x13c
 [C0003FEDEEF0] [C0072E2C] .run_local_timers+0x1c/0x30
 [C0003FEDEF70] [C0022FA0] .timer_interrupt+0xa8/0x488
 [C0003FEDF050] [C00034EC] decrementer_common+0xec/0x100
 --- Exception: 901 at .ioread8+0x14/0x60
 LR = .sym_hcb_attach+0x1194/0x1384 [sym53c8xx]
 [C0003FEDF340] [D02B3BC0] 0xd02b3bc0 (unreliable)
 [C0003FEDF3B0] [D029A3C0] .sym_hcb_attach+0x1194/0x1384 
 [sym53c8xx]
 [C0003FEDF480] [D0291D30] .sym2_probe+0x75c/0x9f8 [sym53c8xx]
 [C0003FEDF710] [C01B65A4] .pci_device_probe+0x13c/0x1dc
 [C0003FEDF7D0] [C0219A0C] .driver_probe_device+0xa0/0x15c
 [C0003FEDF870] [C0219C64] .__driver_attach+0xb4/0x138
 [C0003FEDF900] [C021913C] .bus_for_each_dev+0x7c/0xd4
 [C0003FEDF9C0] [C02198B0] .driver_attach+0x28/0x40
 [C0003FEDFA40] [C0218BA4] .bus_add_driver+0x98/0x18c
 [C0003FEDFAE0] [C021A064] .driver_register+0xa8/0xc4
 [C0003FEDFB60] [C01B68AC] .__pci_register_driver+0x5c/0xa4
 [C0003FEDFBF0] [D029C204] .sym2_init+0x104/0x1550 [sym53c8xx]
 [C0003FEDFC90] [C008D1F4] .sys_init_module+0x1764/0x1998
 [C0003FEDFE30] [C000869C] syscall_exit+0x0/0x40

 
 hm, odd.
 
 Can you look up sym_hcb_attach+0x1194/0x1384 in gdb?  Something like
 
Hi Andrew,

I tried with 2.6.24-rc3-git3 and got the following trace

BUG: soft lockup - CPU#2 stuck for 11s! [insmod:375]
NIP: c002f02c LR: d01414fc CTR: c002f018
REGS: c0077ca3b0b0 TRAP: 0901   Not tainted  (2.6.24-rc3-git3-autokern1)
MSR: 80009032 EE,ME,IR,DR  CR: 24022088  XER: 
TASK = c0077cc58000[375] 'insmod' THREAD: c0077ca38000 CPU: 2
GPR00: d01414fc c0077ca3b330 c052b880 d80080002014 
GPR04: d8008000202c  c0077c82eb00 d014ce54 
GPR08: c0077c82e63c  002a c002f018 
GPR12: d0143610 c0473f80 
NIP [c002f02c] .ioread8+0x14/0x60
LR [d01414fc] .sym_hcb_attach+0x1188/0x1378 [sym53c8xx]

Call Trace:
[c0077ca3b330] [c0077ca3b3c0] 0xc0077ca3b3c0 (unreliable)
[c0077ca3b3a0] [d01414fc] .sym_hcb_attach

Re: [BUG] 2.6.24-rc3-git2 softlockup detected

2007-11-27 Thread Kamalesh Babulal
Andrew Morton wrote:
 On Wed, 28 Nov 2007 11:59:00 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote:
 
 Hi,
 
 (cc linux-scsi, for sym53c8xx)
 
 Soft lockup is detected while bootup with 2.6.24-rc3-git2 on powerbox
 
 I assume this is a post-2.6.23 regression?
 
 BUG: soft lockup - CPU#1 stuck for 11s! [insmod:375]
 NIP: c002f02c LR: d01414fc CTR: c002f018
 REGS: c0077cbef0b0 TRAP: 0901   Not tainted  (2.6.24-rc3-git2-autotest)
 MSR: 80009032 EE,ME,IR,DR  CR: 24022088  XER: 
 TASK = c0077cbd8000[375] 'insmod' THREAD: c0077cbec000 CPU: 1
 GPR00: d01414fc c0077cbef330 c052b930 d80080002014 
 GPR04: d8008000202c  c0077ca1cb00 d014ce54 
 GPR08: c0077ca1c63c  002a c002f018 
 GPR12: d0143610 c0473d00 
 NIP [c002f02c] .ioread8+0x14/0x60
 LR [d01414fc] .sym_hcb_attach+0x1188/0x1378 [sym53c8xx]
 Call Trace:
 [c0077cbef330] [c0077cbef3c0] 0xc0077cbef3c0 (unreliable)
 [c0077cbef3a0] [d01414fc] .sym_hcb_attach+0x1188/0x1378 
 [sym53c8xx]
 [c0077cbef470] [d01395f8] .sym2_probe+0x700/0x99c [sym53c8xx]
 [c0077cbef710] [c01bc118] .pci_device_probe+0x124/0x1b0
 [c0077cbef7b0] [c0221138] .driver_probe_device+0x144/0x20c
 [c0077cbef850] [c0221450] .__driver_attach+0xcc/0x154
 [c0077cbef8e0] [c021ff94] .bus_for_each_dev+0x7c/0xd4
 [c0077cbef9a0] [c0220e9c] .driver_attach+0x28/0x40
 [c0077cbefa20] [c02204d8] .bus_add_driver+0x90/0x228
 [c0077cbefac0] [c0221858] .driver_register+0x94/0xb0
 [c0077cbefb40] [c01bc430] .__pci_register_driver+0x6c/0xcc
 [c0077cbefbe0] [d0143428] .sym2_init+0x108/0x15b0 [sym53c8xx]
 [c0077cbefc80] [c008ce80] .sys_init_module+0x17c4/0x1958
 [c0077cbefe30] [c000872c] syscall_exit+0x0/0x40
 Instruction dump:
 6000 786b0420 38210070 7d635b78 e8010010 7c0803a6 4e800020 7c0802a6 
 f8010010 f821ff91 7c0004ac 8923 0c09 4c00012c 79290620 2f8900ff 
 
 I see no obvious lockup sites near the end of sym_hcb_attach().  Maybe it's
 being called lots of times from a higher level..  Do the traces all look
 the same?

Hi Andrew,

I see this call trace twice and both looks similar and on another reboot
the following trace is seen twice in different cpu

BUG: soft lockup detected on CPU#3!
Call Trace:
[C0003FEDEDA0] [C0010220] .show_stack+0x68/0x1b0 (unreliable)
[C0003FEDEE40] [C00A061C] .softlockup_tick+0xf0/0x13c
[C0003FEDEEF0] [C0072E2C] .run_local_timers+0x1c/0x30
[C0003FEDEF70] [C0022FA0] .timer_interrupt+0xa8/0x488
[C0003FEDF050] [C00034EC] decrementer_common+0xec/0x100
--- Exception: 901 at .ioread8+0x14/0x60
LR = .sym_hcb_attach+0x1194/0x1384 [sym53c8xx]
[C0003FEDF340] [D02B3BC0] 0xd02b3bc0 (unreliable)
[C0003FEDF3B0] [D029A3C0] .sym_hcb_attach+0x1194/0x1384 [sym53c8xx]
[C0003FEDF480] [D0291D30] .sym2_probe+0x75c/0x9f8 [sym53c8xx]
[C0003FEDF710] [C01B65A4] .pci_device_probe+0x13c/0x1dc
[C0003FEDF7D0] [C0219A0C] .driver_probe_device+0xa0/0x15c
[C0003FEDF870] [C0219C64] .__driver_attach+0xb4/0x138
[C0003FEDF900] [C021913C] .bus_for_each_dev+0x7c/0xd4
[C0003FEDF9C0] [C02198B0] .driver_attach+0x28/0x40
[C0003FEDFA40] [C0218BA4] .bus_add_driver+0x98/0x18c
[C0003FEDFAE0] [C021A064] .driver_register+0xa8/0xc4
[C0003FEDFB60] [C01B68AC] .__pci_register_driver+0x5c/0xa4
[C0003FEDFBF0] [D029C204] .sym2_init+0x104/0x1550 [sym53c8xx]
[C0003FEDFC90] [C008D1F4] .sys_init_module+0x1764/0x1998
[C0003FEDFE30] [C000869C] syscall_exit+0x0/0x40


-- 
Thanks  Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html