RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device
Thanks Johannes for generously reviewing my patch. It indeed is going to
improve the thing a lot. I agree with all your comments so far, and will submit
a newer patch soon.
Since this is my first patch, I have couple of questions regarding submitting
the patch:
1. Is there a page/place where I can see the review comments rather neatly ?,
finding out all the comments and infact reading to entire code on text file is
cumbersome. If there is no way, then its fine,... I can live with it.
2. When I address the review comments and want to resubmit the patch, do I need
to submit the incremental patch or the entire code patch again ?
git-format-patch gives me incremental patch only.
Thanks
Maneesh
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Monday, January 25, 2016 2:56 PM
> To: Singhal, Maneesh
> Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org;
> jbottom...@odin.com; martin.peter...@oracle.com; linux-
> a...@vger.kernel.org
> Subject: Re: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client
> driver implementation for EMC-Symmetrix GuestOS emulated Cut-
> Through Device
>
> On Sat, Jan 23, 2016 at 05:51:50AM +, Singhal, Maneesh wrote:
> > Thanks for your time. My replies inlined...
> >
>
> [...]
>
> > > > + }
> > > > +
> > >
> > > You don't do any cleanup work at
> > > ctd_scsi_response_sanity_check_complete. You could just reutrn 0
> > > here as well.
> > [MS>] Just avoiding multiple exit points from the function
>
> Please have a look at Documentation/CodingStyle Chapter 7:
> Centralized exiting of functions. Especially this part:
>
>
> The goto statement comes in handy when a function exits from
> multiple locations and some common work such as cleanup has to be
> done. If there is no cleanup needed then just return directly.
>
>
> and the example below that section.
>
> > >
> > > > +
> > > > + ctd_dprintk_crit(
>
> [...]
>
> > > > + if (request && request->io_timeout < EMCCTD_MAX_RETRY) {
> > >
> > > The following block is a bit long and therefore it's hard to spot an
> > > eventual error of handling the io_mgmt_lock. Can't it be factored
> > > out in a helper function?
> > >
> > [MS>] I know its little longer, but actually fits logically together... Will
> see if it can be factored. Not sure though.
>
> Yes please. It's not uber important but short functions and paths are
> generally favoured when debugging and reviewing code.
>
>
> Thanks,
> Johannes
>
> --
> Johannes Thumshirn Storage
> jthumsh...@suse.de+49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG
> Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D
> 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device
Thanks a lot for detailed information. Appreciate it ! Regards Maneesh > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, January 25, 2016 3:39 PM > To: Singhal, Maneesh > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > jbottom...@odin.com; martin.peter...@oracle.com; linux- > a...@vger.kernel.org > Subject: Re: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client > driver implementation for EMC-Symmetrix GuestOS emulated Cut- > Through Device > > On Mon, Jan 25, 2016 at 09:30:47AM +, Singhal, Maneesh wrote: > > Thanks Johannes for generously reviewing my patch. It indeed is > going to improve the thing a lot. I agree with all your comments so far, > and will submit a newer patch soon. > > Since this is my first patch, I have couple of questions regarding > submitting the patch: > > > > 1. Is there a page/place where I can see the review comments > rather neatly ?, finding out all the comments and infact reading to > entire code on text file is cumbersome. If there is no way, then its > fine,... I can live with it. > > Nope unfortunately not. That's why it's nice when people trim their e- > mails > ;-) > > > 2. When I address the review comments and want to resubmit the > patch, do I need to submit the incremental patch or the entire code > patch again ? git-format-patch gives me incremental patch only. > > Ususally you change your code and do a git commit --amend. This > modifies your commit instead of creating a new one. If you already > have a new commit than you can use git rebase -i commit to amend> and squash the commit's into one (git gives you a > nice readme when doing rebase -i). Afterwards you do a git format- > patch -1 -v 2, this creates a v2-0001-your-patch-name.patch for git > send-email which has an updated [PATCH V2] in the subject. > > At least, the above is the way I do it (i.e. there are more than one ways > to do it). > > > -- > Johannes Thumshirn Storage > jthumsh...@suse.de+49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG > Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D > 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device
Hello Thumshirn. Thanks for taking out time to review the patch. I appreciate that. Please find my comments inlined. > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Tuesday, January 19, 2016 7:20 PM > To: Singhal, Maneesh > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > jbottom...@odin.com; martin.peter...@oracle.com; linux- > a...@vger.kernel.org > Subject: Re: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client > driver implementation for EMC-Symmetrix GuestOS emulated Cut- > Through Device > > On Tue, Jan 19, 2016 at 11:58:06AM +, Singhal, Maneesh wrote: > > Hello, > > Kindly review the following patch for the following driver to be > added in SCSI subsystem - > > > > Regards > > Maneesh > > > > Hi Maneesh, > > Fery first round of review. No real functionallity yet just a bit on > readablility. > > I'll do a more in depth review later. > > > > From f3c4b836d6f130b1d7ded618002c8164f8f4a06d Mon Sep 17 > 00:00:00 2001 > > From: "maneesh.singhal" <maneesh.sing...@emc.com> > > Date: Tue, 19 Jan 2016 06:39:35 -0500 > > Subject: [PATCH] [PATCH] drivers/scsi/emcctd: Client driver > implementation for > > EMC-Symmetrix GuestOS emulated Cut-Through Device. > > > > The patch is a driver implementation EMC-Symmetrix GuestOS > emulated Cut-Through > > Device. The Cut-Through Device PCI emulation is implemented for > GuestOS > > environments in the HyperMax OS. GuestOS environments allows > loading of > > any x86 compliant operating systems like Linux/FreeBSD etc. > > > > The client driver is a SCSI HBA implementation which interfaces with > SCSI > > midlayer in the north-bound interfaces and connects with the > emulated PCI device > > on the south side. > > > > The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > > > Signed-off-by: maneesh.singhal <maneesh.sing...@emc.com> > > --- > > Documentation/scsi/emcctd.txt | 57 + > > MAINTAINERS |9 + > > drivers/scsi/Kconfig|1 + > > drivers/scsi/Makefile |1 + > > drivers/scsi/emcctd/Kconfig |7 + > > drivers/scsi/emcctd/Makefile|1 + > > drivers/scsi/emcctd/README | 10 + > > drivers/scsi/emcctd/emc_ctd_interface.h | 386 + > > drivers/scsi/emcctd/emcctd.c| 2840 > +++ > > drivers/scsi/emcctd/emcctd.h| 232 +++ > > 10 files changed, 3544 insertions(+) > > create mode 100644 Documentation/scsi/emcctd.txt > > create mode 100644 drivers/scsi/emcctd/Kconfig > > create mode 100644 drivers/scsi/emcctd/Makefile > > create mode 100644 drivers/scsi/emcctd/README > > create mode 100644 drivers/scsi/emcctd/emc_ctd_interface.h > > create mode 100644 drivers/scsi/emcctd/emcctd.c > > create mode 100644 drivers/scsi/emcctd/emcctd.h > > > > diff --git a/Documentation/scsi/emcctd.txt > b/Documentation/scsi/emcctd.txt > > new file mode 100644 > > index 000..bcafc87 > > --- /dev/null > > +++ b/Documentation/scsi/emcctd.txt > > @@ -0,0 +1,56 @@ > > +This file contains brief information about the EMC Cut-Through > Driver (emcctd). > > +The driver is currently maintained by Singhal, Maneesh > (maneesh.sing...@emc.com) > > + > > +Last modified: Mon Jan 18 2016 by Maneesh Singhal > > + > > +BASICS > > + > > +Its a client driver implementation for EMC-Symmetrix GuestOS > emulated > > +Cut-Through Device. The Cut-Through Device PCI emulation is > implemented for > > +GuestOS environments in the HyperMax OS. GuestOS > environments allows loading of > > +any x86 compliant operating systems like Linux/FreeBSD etc. > > + > > +The client driver is a SCSI HBA implementation which interfaces with > SCSI > > +midlayer in the north-bound interfaces and connects with the > emulated PCI device > > +on the south side. > > + > > +The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > + > > +VERSIONING > > + > > +The Version of the driver is maintained as 2.0.0.X, where 2 refers to > the CTD > > +protocol in use, and X refers to the ongoing version of the driver. > > + > > + > > +SYSFS SUPPORT > > + > > +The driver creates the directory /sys/module/emcctd and > populates it with > > +ve
RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device
Hello Greg, Thanks for taking out time to review the patch. Please find my replies inlined... Will post the next patch for modifications soon. > -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Tuesday, January 19, 2016 11:42 PM > To: Singhal, Maneesh > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > jbottom...@odin.com; martin.peter...@oracle.com; linux- > a...@vger.kernel.org > Subject: Re: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client > driver implementation for EMC-Symmetrix GuestOS emulated Cut- > Through Device > > On Tue, Jan 19, 2016 at 11:58:06AM +, Singhal, Maneesh wrote: > > Hello, > > Kindly review the following patch for the following driver to be > added > > in SCSI subsystem - > > > > Regards > > Maneesh > > > > -- > > -- > > >From f3c4b836d6f130b1d7ded618002c8164f8f4a06d Mon Sep 17 > 00:00:00 > > >2001 > > From: "maneesh.singhal" <maneesh.sing...@emc.com> > > Date: Tue, 19 Jan 2016 06:39:35 -0500 > > Subject: [PATCH] [PATCH] drivers/scsi/emcctd: Client driver > > implementation for EMC-Symmetrix GuestOS emulated Cut- > Through Device. > > > > The patch is a driver implementation EMC-Symmetrix GuestOS > emulated > > Cut-Through Device. The Cut-Through Device PCI emulation is > > implemented for GuestOS environments in the HyperMax OS. > GuestOS > > environments allows loading of any x86 compliant operating systems > like Linux/FreeBSD etc. > > > > The client driver is a SCSI HBA implementation which interfaces with > > SCSI midlayer in the north-bound interfaces and connects with the > > emulated PCI device on the south side. > > > > The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > > > Signed-off-by: maneesh.singhal <maneesh.sing...@emc.com> > > --- > > Documentation/scsi/emcctd.txt | 57 + > > MAINTAINERS |9 + > > drivers/scsi/Kconfig|1 + > > drivers/scsi/Makefile |1 + > > drivers/scsi/emcctd/Kconfig |7 + > > drivers/scsi/emcctd/Makefile|1 + > > drivers/scsi/emcctd/README | 10 + > > drivers/scsi/emcctd/emc_ctd_interface.h | 386 + > > drivers/scsi/emcctd/emcctd.c| 2840 > +++ > > drivers/scsi/emcctd/emcctd.h| 232 +++ > > 10 files changed, 3544 insertions(+) > > create mode 100644 Documentation/scsi/emcctd.txt create mode > 100644 > > drivers/scsi/emcctd/Kconfig create mode 100644 > > drivers/scsi/emcctd/Makefile create mode 100644 > > drivers/scsi/emcctd/README create mode 100644 > > drivers/scsi/emcctd/emc_ctd_interface.h > > create mode 100644 drivers/scsi/emcctd/emcctd.c create mode > 100644 > > drivers/scsi/emcctd/emcctd.h > > > > diff --git a/Documentation/scsi/emcctd.txt > > b/Documentation/scsi/emcctd.txt new file mode 100644 index > > 000..bcafc87 > > --- /dev/null > > +++ b/Documentation/scsi/emcctd.txt > > @@ -0,0 +1,56 @@ > > +This file contains brief information about the EMC Cut-Through > Driver (emcctd). > > +The driver is currently maintained by Singhal, Maneesh > > +(maneesh.sing...@emc.com) > > + > > +Last modified: Mon Jan 18 2016 by Maneesh Singhal > > + > > +BASICS > > + > > +Its a client driver implementation for EMC-Symmetrix GuestOS > emulated > > +Cut-Through Device. The Cut-Through Device PCI emulation is > > +implemented for GuestOS environments in the HyperMax OS. > GuestOS > > +environments allows loading of any x86 compliant operating > systems like Linux/FreeBSD etc. > > + > > +The client driver is a SCSI HBA implementation which interfaces with > > +SCSI midlayer in the north-bound interfaces and connects with the > > +emulated PCI device on the south side. > > + > > +The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > + > > +VERSIONING > > + > > +The Version of the driver is maintained as 2.0.0.X, where 2 refers to > > +the CTD protocol in use, and X refers to the ongoing version of the > driver. > > + > > + > > +SYSFS SUPPORT > > + > > +The driver creates the directory /sys/module/emcctd and > populates it > > +with version file and a directory for various parameters as described > > +in MODULE PARAMETERS section. > > + &g
RE: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client driver implementation for EMC-Symmetrix GuestOS emulated Cut-Through Device
Thanks for your time. My replies inlined... > -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Tuesday, January 19, 2016 9:34 PM > To: Singhal, Maneesh > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; > jbottom...@odin.com; martin.peter...@oracle.com; linux- > a...@vger.kernel.org > Subject: Re: [PATCH] drivers/scsi/emcctd: drivers/scsi/emcctd: Client > driver implementation for EMC-Symmetrix GuestOS emulated Cut- > Through Device > > On Tue, Jan 19, 2016 at 11:58:06AM +, Singhal, Maneesh wrote: > > Hello, > > Kindly review the following patch for the following driver to be > added in SCSI subsystem - > > > > Regards > > Maneesh > > > > > > From f3c4b836d6f130b1d7ded618002c8164f8f4a06d Mon Sep 17 > 00:00:00 2001 > > From: "maneesh.singhal" <maneesh.sing...@emc.com> > > Date: Tue, 19 Jan 2016 06:39:35 -0500 > > Subject: [PATCH] [PATCH] drivers/scsi/emcctd: Client driver > implementation for > > EMC-Symmetrix GuestOS emulated Cut-Through Device. > > > > The patch is a driver implementation EMC-Symmetrix GuestOS > emulated Cut-Through > > Device. The Cut-Through Device PCI emulation is implemented for > GuestOS > > environments in the HyperMax OS. GuestOS environments allows > loading of > > any x86 compliant operating systems like Linux/FreeBSD etc. > > > > The client driver is a SCSI HBA implementation which interfaces with > SCSI > > midlayer in the north-bound interfaces and connects with the > emulated PCI device > > on the south side. > > > > The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > > > Signed-off-by: maneesh.singhal <maneesh.sing...@emc.com> > > --- > > Documentation/scsi/emcctd.txt | 57 + > > MAINTAINERS |9 + > > drivers/scsi/Kconfig|1 + > > drivers/scsi/Makefile |1 + > > drivers/scsi/emcctd/Kconfig |7 + > > drivers/scsi/emcctd/Makefile|1 + > > drivers/scsi/emcctd/README | 10 + > > drivers/scsi/emcctd/emc_ctd_interface.h | 386 + > > drivers/scsi/emcctd/emcctd.c| 2840 > +++ > > drivers/scsi/emcctd/emcctd.h| 232 +++ > > 10 files changed, 3544 insertions(+) > > create mode 100644 Documentation/scsi/emcctd.txt > > create mode 100644 drivers/scsi/emcctd/Kconfig > > create mode 100644 drivers/scsi/emcctd/Makefile > > create mode 100644 drivers/scsi/emcctd/README > > create mode 100644 drivers/scsi/emcctd/emc_ctd_interface.h > > create mode 100644 drivers/scsi/emcctd/emcctd.c > > create mode 100644 drivers/scsi/emcctd/emcctd.h > > > > diff --git a/Documentation/scsi/emcctd.txt > b/Documentation/scsi/emcctd.txt > > new file mode 100644 > > index 000..bcafc87 > > --- /dev/null > > +++ b/Documentation/scsi/emcctd.txt > > @@ -0,0 +1,56 @@ > > +This file contains brief information about the EMC Cut-Through > Driver (emcctd). > > +The driver is currently maintained by Singhal, Maneesh > (maneesh.sing...@emc.com) > > + > > +Last modified: Mon Jan 18 2016 by Maneesh Singhal > > + > > +BASICS > > + > > +Its a client driver implementation for EMC-Symmetrix GuestOS > emulated > > +Cut-Through Device. The Cut-Through Device PCI emulation is > implemented for > > +GuestOS environments in the HyperMax OS. GuestOS > environments allows loading of > > +any x86 compliant operating systems like Linux/FreeBSD etc. > > + > > +The client driver is a SCSI HBA implementation which interfaces with > SCSI > > +midlayer in the north-bound interfaces and connects with the > emulated PCI device > > +on the south side. > > + > > +The PCI vendor ID:product ID for emulated Cut-Through Device is > 0x1120:0x1B00. > > + > > +VERSIONING > > + > > +The Version of the driver is maintained as 2.0.0.X, where 2 refers to > the CTD > > +protocol in use, and X refers to the ongoing version of the driver. > > + > > + > > +SYSFS SUPPORT > > + > > +The driver creates the directory /sys/module/emcctd and > populates it with > > +version file and a directory for various parameters as described in > MODULE > > +PARAMETERS section. > > + > > +PROCFS SUPPORT > > + > > +The driver creates the directory /proc/emc and creates files > emcctd_sta
