[PATCH] scsi/isci/phy.c: Code tidiness, delete the redundant function call sci_change_state(iphy-sm, SCI_PHY_STOPPED) in sci_phy_link_layer_initialization()
The sci_phy_link_layer_initialization() was called only once in sci_phy_initialize() and it is called before a call of sci_change_state(iphy-sm, SCI_PHY_STOPPED). So the same call in the end of sci_phy_link_layer_initialization() is redundant. Signed-off-by: Xinghai Yu yuxing...@cn.fujitsu.com --- drivers/scsi/isci/phy.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index cb87b2e..82e8491 100644 --- a/drivers/scsi/isci/phy.c +++ b/drivers/scsi/isci/phy.c @@ -309,9 +309,6 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy, */ writel(0, llr-link_layer_hang_detection_timeout); - /* We can exit the initial state to the stopped state */ - sci_change_state(iphy-sm, SCI_PHY_STOPPED); - return SCI_SUCCESS; } -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] scsi/isci/port_config: Fix a infinite loop.
It seems the phy_index++; have been placed in wrong place, without it the while circle up will do a infinite loop. Signed-off-by: Xinghai Yu yuxing...@cn.fujitsu.com --- drivers/scsi/isci/port_config.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c index cd962da..85c77f6 100644 --- a/drivers/scsi/isci/port_config.c +++ b/drivers/scsi/isci/port_config.c @@ -311,9 +311,9 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost, ihost-phys[phy_index]); assigned_phy_mask |= (1 phy_index); + phy_index++; } - phy_index++; } return sci_port_configuration_agent_validate_ports(ihost, port_agent); -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
