Re: [PATCH] [SCSI] scsi_debug: Do not respond to INQUIRY commands with CHECK CONDITION when sense pending

2013-02-15 Thread Ewan Milne 
On Thu, 2013-02-14 at 16:46 -0500, Douglas Gilbert wrote:
> On 13-02-14 11:36 AM, Ewan D. Milne wrote:
> > From: "Ewan D. Milne" 
> >
> > According to SPC, INQUIRY commands are not supposed to respond
> > with a CHECK CONDITION due to a pending UNIT ATTENTION.  This
> > was causing failures when re-scanning a scsi_debug target.
> 
> Good pick up. Reference: sam5r12.pdf section 5.14 on
> Unit Attentions. And please add REPORT LUNS to your patch.

Will do, thanks.

-Ewan


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [SCSI] scsi_debug: Do not respond to INQUIRY commands with CHECK CONDITION when sense pending

2013-02-14 Thread Douglas Gilbert 

On 13-02-14 11:36 AM, Ewan D. Milne wrote:

From: "Ewan D. Milne" 

According to SPC, INQUIRY commands are not supposed to respond
with a CHECK CONDITION due to a pending UNIT ATTENTION.  This
was causing failures when re-scanning a scsi_debug target.


Good pick up. Reference: sam5r12.pdf section 5.14 on
Unit Attentions. And please add REPORT LUNS to your patch.

Doug Gilbert


Signed-off-by: Ewan D. Milne 
---
  drivers/scsi/scsi_debug.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 8a6bf31..68f13be 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -4060,7 +4060,7 @@ write:
errsts = check_condition_result;
break;
}
-   if (!errsts && devip->sense_pending) {
+   if (!errsts && devip->sense_pending && (*cmd != INQUIRY)) {
devip->sense_pending = 0;
errsts = check_condition_result;
}



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] [SCSI] scsi_debug: Do not respond to INQUIRY commands with CHECK CONDITION when sense pending

2013-02-14 Thread Ewan D. Milne 
From: "Ewan D. Milne" 

According to SPC, INQUIRY commands are not supposed to respond
with a CHECK CONDITION due to a pending UNIT ATTENTION.  This
was causing failures when re-scanning a scsi_debug target.

Signed-off-by: Ewan D. Milne 
---
 drivers/scsi/scsi_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 8a6bf31..68f13be 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -4060,7 +4060,7 @@ write:
errsts = check_condition_result;
break;
}
-   if (!errsts && devip->sense_pending) {
+   if (!errsts && devip->sense_pending && (*cmd != INQUIRY)) {
devip->sense_pending = 0;
errsts = check_condition_result;
}
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html